@cosmicdrift/kumiko-renderer 0.326.1 → 0.328.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.326.1",
+  "version": "0.328.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,9 +15,9 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.326.1",
-    "@cosmicdrift/kumiko-headless": "0.326.1",
-    "@cosmicdrift/kumiko-types": "0.326.1",
+    "@cosmicdrift/kumiko-framework": "0.328.0",
+    "@cosmicdrift/kumiko-headless": "0.328.0",
+    "@cosmicdrift/kumiko-types": "0.328.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"
@@ -28,7 +28,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "react-dom": "^19.2.6",
-    "@cosmicdrift/kumiko-locale-de": "0.326.1"
+    "@cosmicdrift/kumiko-locale-de": "0.328.0"
   },
   "repository": {
     "type": "git",

package/src/app/__tests__/entity-edit-fill-height.test.tsx

@@ -0,0 +1,118 @@
+// fw#3381: an entityEdit screen pins its action bar to the shell height by
+// default (Form fillHeight + stickyActions); `fillHeight: false` opts out.
+import { describe, expect, test } from "bun:test";
+import type {
+  EntityDefinition,
+  EntityEditScreenDefinition,
+} from "@cosmicdrift/kumiko-framework/ui-types";
+import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
+import { render } from "@testing-library/react";
+import type { ComponentType, ReactNode } from "react";
+import { DispatcherProvider } from "../../context/dispatcher-context";
+import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
+import { type CorePrimitives, type FormProps, PrimitivesProvider } from "../../primitives";
+import type { FeatureSchema } from "../feature-schema";
+import { KumikoScreen } from "../kumiko-screen";
+import { NavProvider } from "../nav";
+
+const noop = (): ReactNode => null;
+const passChildren = ({ children }: { readonly children?: ReactNode }): ReactNode => children;
+
+function stubDispatcher(): Dispatcher {
+  return {
+    write: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["write"],
+    query: (async () => ({ isSuccess: true, data: {} })) as unknown as Dispatcher["query"],
+    batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
+    statusStore: {
+      getState: () => "online",
+      subscribe: () => () => {},
+    } as unknown as Dispatcher["statusStore"],
+    async *stream() {},
+    pendingWrites: () => [],
+    pendingFiles: () => [],
+  };
+}
+
+function buildSchema(fillHeight?: boolean): FeatureSchema {
+  const entity: EntityDefinition = {
+    fields: {
+      name: { type: "text", maxLength: 200, required: false, searchable: false, sortable: false },
+    },
+  };
+  const screen: EntityEditScreenDefinition = {
+    id: "unit-edit",
+    type: "entityEdit",
+    entity: "unit",
+    layout: { sections: [{ columns: 1, fields: ["name"] }] },
+    ...(fillHeight !== undefined && { fillHeight }),
+  };
+  return {
+    featureName: "housing",
+    entities: { unit: entity },
+    screens: [screen],
+  } as FeatureSchema;
+}
+
+function captureFormProps(fillHeight?: boolean): FormProps {
+  let captured: FormProps | undefined;
+  const capturingForm: ComponentType<FormProps> = (props) => {
+    captured = props;
+    return null;
+  };
+  const primitives: CorePrimitives = {
+    Button: noop,
+    Banner: passChildren,
+    Field: passChildren,
+    Input: noop,
+    DataTable: noop,
+    Form: capturingForm,
+    Section: passChildren,
+    Card: passChildren,
+    Grid: passChildren,
+    GridCell: passChildren,
+    Text: passChildren,
+    Heading: noop,
+    Dialog: noop,
+    Modal: noop,
+    Lightbox: noop,
+    ConfigSourceBadge: noop,
+    ConfigCascadeView: noop,
+    Link: noop,
+  };
+  render(
+    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "de-DE" })}>
+      <DispatcherProvider dispatcher={stubDispatcher()}>
+        <NavProvider
+          value={{
+            route: { screenId: "housing:unit-edit" },
+            navigate: () => {},
+            replace: () => {},
+            hrefFor: () => "",
+            searchParams: {},
+            setSearchParams: () => {},
+          }}
+        >
+          <PrimitivesProvider value={primitives}>
+            <KumikoScreen schema={buildSchema(fillHeight)} qn="housing:screen:unit-edit" />
+          </PrimitivesProvider>
+        </NavProvider>
+      </DispatcherProvider>
+    </LocaleProvider>,
+  );
+  if (captured === undefined) throw new Error("Form was not rendered");
+  return captured;
+}
+
+describe("entityEdit fillHeight (fw#3381)", () => {
+  test("default: form fills the height with a pinned action bar", () => {
+    const props = captureFormProps();
+    expect(props.fillHeight).toBe(true);
+    expect(props.stickyActions).toBe(true);
+  });
+
+  test("fillHeight: false restores page scroll", () => {
+    const props = captureFormProps(false);
+    expect(props.fillHeight).toBeFalsy();
+    expect(props.stickyActions).toBeFalsy();
+  });
+});

package/src/app/__tests__/entity-list-screen-padding.test.tsx

@@ -39,7 +39,7 @@ function stubDispatcher(): Dispatcher {
   };
 }
 
-function buildSchema(): FeatureSchema {
+function buildSchema(fillHeight?: boolean): FeatureSchema {
   const entity: EntityDefinition = {
     fields: {
       name: { type: "text", maxLength: 200, required: false, searchable: false, sortable: false },
@@ -50,6 +50,7 @@ function buildSchema(): FeatureSchema {
     type: "entityList",
     entity: "org",
     columns: ["name"],
+    ...(fillHeight !== undefined && { fillHeight }),
   };
   return {
     featureName: "orgs",
@@ -58,54 +59,70 @@ function buildSchema(): FeatureSchema {
   } as FeatureSchema;
 }
 
+async function captureListProps(fillHeight?: boolean): Promise<DataTableProps> {
+  let captured: DataTableProps | undefined;
+  const capturingDataTable: ComponentType<DataTableProps> = (props) => {
+    captured = props;
+    return null;
+  };
+  const primitives: CorePrimitives = {
+    Button: noop,
+    Banner: passChildren,
+    Field: passChildren,
+    Input: noop,
+    DataTable: capturingDataTable,
+    Form: passChildren,
+    Section: passChildren,
+    Card: passChildren,
+    Grid: passChildren,
+    GridCell: passChildren,
+    Text: passChildren,
+    Heading: noop,
+    Dialog: noop,
+    Modal: noop,
+    Lightbox: noop,
+    ConfigSourceBadge: noop,
+    ConfigCascadeView: noop,
+    Link: noop,
+  };
+  render(
+    <LocaleProvider resolver={createStaticLocaleResolver({ locale: "de-DE" })}>
+      <DispatcherProvider dispatcher={stubDispatcher()}>
+        <NavProvider
+          value={{
+            route: { screenId: "orgs:org-list" },
+            navigate: () => {},
+            replace: () => {},
+            hrefFor: () => "",
+            searchParams: {},
+            setSearchParams: () => {},
+          }}
+        >
+          <PrimitivesProvider value={primitives}>
+            <KumikoScreen schema={buildSchema(fillHeight)} qn="orgs:screen:org-list" />
+          </PrimitivesProvider>
+        </NavProvider>
+      </DispatcherProvider>
+    </LocaleProvider>,
+  );
+
+  await waitFor(() => expect(captured).toBeDefined());
+  if (captured === undefined) throw new Error("DataTable was not rendered");
+  return captured;
+}
+
 describe("entityList screen padding (fw#2640)", () => {
   test("the list screen marks its table as the screen body", async () => {
-    let capturedScreenPadding: boolean | undefined;
-    const capturingDataTable: ComponentType<DataTableProps> = (props) => {
-      capturedScreenPadding = props.screenPadding;
-      return null;
-    };
-    const primitives: CorePrimitives = {
-      Button: noop,
-      Banner: passChildren,
-      Field: passChildren,
-      Input: noop,
-      DataTable: capturingDataTable,
-      Form: passChildren,
-      Section: passChildren,
-      Card: passChildren,
-      Grid: passChildren,
-      GridCell: passChildren,
-      Text: passChildren,
-      Heading: noop,
-      Dialog: noop,
-      Modal: noop,
-      Lightbox: noop,
-      ConfigSourceBadge: noop,
-      ConfigCascadeView: noop,
-      Link: noop,
-    };
-    render(
-      <LocaleProvider resolver={createStaticLocaleResolver({ locale: "de-DE" })}>
-        <DispatcherProvider dispatcher={stubDispatcher()}>
-          <NavProvider
-            value={{
-              route: { screenId: "orgs:org-list" },
-              navigate: () => {},
-              replace: () => {},
-              hrefFor: () => "",
-              searchParams: {},
-              setSearchParams: () => {},
-            }}
-          >
-            <PrimitivesProvider value={primitives}>
-              <KumikoScreen schema={buildSchema()} qn="orgs:screen:org-list" />
-            </PrimitivesProvider>
-          </NavProvider>
-        </DispatcherProvider>
-      </LocaleProvider>,
-    );
+    expect((await captureListProps()).screenPadding).toBe(true);
+  });
+});
+
+describe("entityList fillHeight (fw#3381)", () => {
+  test("fills the shell height by default (scrollBody)", async () => {
+    expect((await captureListProps()).scrollBody).toBe(true);
+  });
 
-    await waitFor(() => expect(capturedScreenPadding).toBe(true));
+  test("fillHeight: false restores page scroll (no scrollBody)", async () => {
+    expect((await captureListProps(false)).scrollBody).toBeUndefined();
   });
 });

package/src/app/action-form-shim.ts

@@ -53,6 +53,8 @@ export function synthesizeActionFormScreen(
     // Only ActionFormScreenDefinition carries slots/fieldLabels; `in` narrows
     // without a cast since SecretMintScreenDefinition has neither.
     ...("slots" in screen && screen.slots !== undefined && { slots: screen.slots }),
+    ...("fillHeight" in screen &&
+      screen.fillHeight !== undefined && { fillHeight: screen.fillHeight }),
     ...("fieldLabels" in screen &&
       screen.fieldLabels !== undefined && { fieldLabels: screen.fieldLabels }),
   };