@cosmicdrift/kumiko-renderer 0.325.1 → 0.325.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.325.1",
+  "version": "0.325.2",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,9 +15,9 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.325.1",
-    "@cosmicdrift/kumiko-headless": "0.325.1",
-    "@cosmicdrift/kumiko-types": "0.325.1",
+    "@cosmicdrift/kumiko-framework": "0.325.2",
+    "@cosmicdrift/kumiko-headless": "0.325.2",
+    "@cosmicdrift/kumiko-types": "0.325.2",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"
@@ -28,7 +28,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "react-dom": "^19.2.6",
-    "@cosmicdrift/kumiko-locale-de": "0.325.1"
+    "@cosmicdrift/kumiko-locale-de": "0.325.2"
   },
   "repository": {
     "type": "git",

package/src/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.325.2",
+    "type": "fix",
+    "title": "Server validation issues without a rendered field keep the error banner",
+    "detail": "RenderEdit suppressed the banner as soon as the server returned any field issue, even one\nthat no rendered field can display (`version`, `id`, a root-level refine, a condition-hidden\nfield), so the save failed silently. The banner now stays whenever at least one issue has no\nvisible field; tabs/wizard layouts still jump to the step holding the first matched field."
+  },
   {
     "version": "0.325.1",
     "type": "fix",

package/src/components/__tests__/render-edit-logic.test.ts

@@ -8,6 +8,7 @@ import type {
 import {
   filterEditSections,
   hasEditableSection,
+  hasIssueWithoutRenderedField,
   resolveExtensionEntityId,
   shouldNotifyCaller,
 } from "../render-edit-logic";
@@ -248,3 +249,66 @@ describe("filterEditSections", () => {
     expect(result).toEqual([extensionSection]);
   });
 });
+
+describe("hasIssueWithoutRenderedField", () => {
+  test("issue path matches a rendered field → false", () => {
+    expect(hasIssueWithoutRenderedField(["title"], [namedFieldsSection("title", "body")])).toBe(
+      false,
+    );
+  });
+
+  // Root-level refine issues (`version`/`id`/`changes`) never match a rendered
+  // field name — the banner is the only place that can show them.
+  test("root-level refine path (version) → true", () => {
+    expect(hasIssueWithoutRenderedField(["version"], [namedFieldsSection("title")])).toBe(true);
+  });
+
+  test("(root) path → true", () => {
+    expect(hasIssueWithoutRenderedField(["(root)"], [namedFieldsSection("title")])).toBe(true);
+  });
+
+  test("path matches a field hidden by its own condition → true", () => {
+    const section: EditSectionViewModel = {
+      kind: "fields",
+      columns: 1,
+      visible: true,
+      fields: [
+        {
+          field: "a",
+          label: "A",
+          type: "text",
+          value: "",
+          visible: true,
+          readOnly: false,
+          required: false,
+        },
+        {
+          field: "b",
+          label: "B",
+          type: "text",
+          value: "",
+          visible: false,
+          readOnly: false,
+          required: false,
+        },
+      ],
+    };
+    expect(hasIssueWithoutRenderedField(["b"], [section])).toBe(true);
+  });
+
+  test("dotted path (tasks.2.title) matches on its first segment → false", () => {
+    expect(hasIssueWithoutRenderedField(["tasks.2.title"], [namedFieldsSection("tasks")])).toBe(
+      false,
+    );
+  });
+
+  test("mixed: one matched, one unmatched → true", () => {
+    expect(hasIssueWithoutRenderedField(["title", "version"], [namedFieldsSection("title")])).toBe(
+      true,
+    );
+  });
+
+  test("empty issue list → true (single-section path always shows the banner then)", () => {
+    expect(hasIssueWithoutRenderedField([], [namedFieldsSection("title")])).toBe(true);
+  });
+});

package/src/components/render-edit-logic.ts

@@ -41,6 +41,22 @@ export function shouldNotifyCaller(
   return !(result.isSuccess && !extensionsPersisted);
 }
 
+// Matched on the first path segment (embedded-list rows are dotted, e.g. `tasks.2.title`).
+// No issues at all counts as unmatched, so the caller keeps the banner.
+export function hasIssueWithoutRenderedField(
+  issuePaths: readonly string[],
+  sections: readonly EditSectionViewModel[],
+): boolean {
+  if (issuePaths.length === 0) return true;
+  const renderedFields = new Set(
+    sections
+      .filter((s) => s.kind === "fields" && (s.visible || s.fields.length === 0))
+      .flatMap((s) => (s.kind === "fields" ? s.fields.filter((f) => f.visible) : []))
+      .map((f) => f.field),
+  );
+  return issuePaths.some((path) => !renderedFields.has(path.split(".")[0] ?? path));
+}
+
 // Extension, relatedList and writeForm sections skip the `fields` filter
 // (writeForm's fields belong to its own independent form, not the host's);
 // a `fields` section left with zero fields after filtering is dropped, not

package/src/components/render-edit.tsx

@@ -48,6 +48,7 @@ import { RelatedListSection } from "./related-list-section";
 import {
   filterEditSections,
   hasEditableSection,
+  hasIssueWithoutRenderedField,
   resolveExtensionEntityId,
   shouldNotifyCaller,
 } from "./render-edit-logic";
@@ -1029,29 +1030,21 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
         }
       } else {
         const fieldIssues = result.error.details?.fields ?? [];
+        const issuePaths = fieldIssues.map((i) => i.path);
         // A server field error on a step the form isn't currently showing is
         // otherwise invisible — jump to the first step that contains one of
         // the errored fields. For tabs this is what keeps the submit from
         // blocking in silence, the failure mode the boot-validator used to
-        // prevent by rejecting the layout outright (fw#3134). Single-section
-        // forms render every field at once, so the original
-        // suppress-when-field-issues-exist rule still applies there (the
-        // field itself already shows the error inline).
+        // prevent by rejecting the layout outright (fw#3134). An issue no
+        // rendered field can show (`version`, `id`, a root-level refine, a
+        // hidden field) keeps the banner, jump or not.
         if (isStepped) {
-          const step = findFirstErroringStep(fieldIssues.map((i) => i.path));
-          if (step !== undefined) {
-            setRawStep(step);
-            setFormError(null);
-          } else {
-            // No rendered step contains any of the errored fields (a
-            // root-level issue, or a field outside every step) — nothing
-            // will show this error inline, so the banner must not be
-            // suppressed.
-            setFormError(result.error);
-          }
-        } else {
-          setFormError(fieldIssues.length === 0 ? result.error : null);
+          const step = findFirstErroringStep(issuePaths);
+          if (step !== undefined) setRawStep(step);
         }
+        setFormError(
+          hasIssueWithoutRenderedField(issuePaths, filteredSections) ? result.error : null,
+        );
       }
       // skip: on entity-success-but-extension-failure the extension-error
       // banner is showing — don't notify (the caller navigates away on success