@cosmicdrift/kumiko-renderer 0.288.0 → 0.290.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.288.0",
+  "version": "0.290.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,9 +15,9 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.288.0",
-    "@cosmicdrift/kumiko-headless": "0.288.0",
-    "@cosmicdrift/kumiko-types": "0.288.0",
+    "@cosmicdrift/kumiko-framework": "0.290.0",
+    "@cosmicdrift/kumiko-headless": "0.290.0",
+    "@cosmicdrift/kumiko-types": "0.290.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"
@@ -28,7 +28,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "react-dom": "^19.2.6",
-    "@cosmicdrift/kumiko-locale-de": "0.288.0"
+    "@cosmicdrift/kumiko-locale-de": "0.290.0"
   },
   "repository": {
     "type": "git",

package/src/__tests__/merge-search-params-into-initial.test.ts

@@ -1,5 +1,7 @@
 import { describe, expect, spyOn, test } from "bun:test";
+import type { EntityEditScreenDefinition } from "@cosmicdrift/kumiko-framework/ui-types";
 import { mergeSearchParamsIntoInitial } from "../app/kumiko-screen";
+import { layoutFieldNames } from "../app/layout-fields";
 
 type FieldDef = {
   type?: string;
@@ -188,6 +190,22 @@ describe("mergeSearchParamsIntoInitial — coercion (every field URL-prefillable
     expect(result["ownerId"]).toBe("");
   });
 
+  test("renderableFields from a groups-only layout: searchParam on a group field is kept", () => {
+    const screen: EntityEditScreenDefinition = {
+      id: "s",
+      type: "entityEdit",
+      entity: "e",
+      layout: { sections: [{ fields: [], groups: [{ title: "g", fields: ["status"] }] }] },
+    };
+    const fields: Record<string, FieldDef> = { status: { type: "text", default: "draft" } };
+    const result = mergeWithAllFieldsUrlPrefillable(
+      fields,
+      { status: "approved" },
+      layoutFieldNames(screen),
+    );
+    expect(result["status"]).toBe("approved");
+  });
+
   test("no renderableFields set given (undefined): behaves as before, all fields eligible", () => {
     const fields: Record<string, FieldDef> = { ownerId: { type: "text" } };
     const result = mergeWithAllFieldsUrlPrefillable(fields, { ownerId: "user-123" });

package/src/app/__tests__/form-schema.test.ts

@@ -41,6 +41,21 @@ describe("buildFormSchema", () => {
     }
   });
 
+  test("required field inside a groups-only section → presence issue", () => {
+    const entity = entityWith({ name: { type: "text", required: true } });
+    const screen: EntityEditScreenDefinition = {
+      id: "s",
+      type: "entityEdit",
+      entity: "e",
+      layout: { sections: [{ fields: [], groups: [{ title: "g", fields: ["name"] }] }] },
+    };
+
+    const result = buildFormSchema(entity, screen).safeParse({ name: "" });
+    expect(result.success).toBe(false);
+    if (result.success) return;
+    expect(result.error.issues[0]?.path).toEqual(["name"]);
+  });
+
   test("required field missing → issue carries the required-field i18nKey override", () => {
     const entity = entityWith({ name: { type: "text", required: true } });
     const screen = screenWith(["name"]);

package/src/app/layout-fields.ts

@@ -2,7 +2,11 @@ import type {
   EditFieldSpec,
   EntityEditScreenDefinition,
 } from "@cosmicdrift/kumiko-framework/ui-types";
-import { isFieldsEditSection, normalizeEditField } from "@cosmicdrift/kumiko-framework/ui-types";
+import {
+  isFieldsEditSection,
+  normalizeEditField,
+  sectionFieldSpecs,
+} from "@cosmicdrift/kumiko-framework/ui-types";
 
 // Normalized field specs actually rendered by the screen's layout, extension
 // (and relatedList) sections skipped. Both this and `layoutFieldNames` key
@@ -15,7 +19,7 @@ export function layoutEditFields(
   const specs: Exclude<EditFieldSpec, string>[] = [];
   for (const section of screen.layout.sections) {
     if (!isFieldsEditSection(section)) continue;
-    for (const spec of section.fields) {
+    for (const spec of sectionFieldSpecs(section)) {
       specs.push(normalizeEditField(spec));
     }
   }

package/src/app/projection-detail-shim.ts

@@ -22,7 +22,6 @@
 
 import type {
   EditFieldSpec,
-  EditFieldsSection,
   EditLayout,
   EntityDefinition,
   EntityEditScreenDefinition,
@@ -32,18 +31,9 @@ import {
   isFieldsEditSection,
   normalizeEditField,
   PROJECTION_DETAIL_ENTITY as PROJECTION_DETAIL_PSEUDO_ENTITY,
+  sectionFieldSpecs,
 } from "@cosmicdrift/kumiko-framework/ui-types";
 
-// The boot-validator treats `fields`/`groups` as mutually exclusive per
-// section, but this reads both anyway: an extra name the current section
-// shape can never carry is harmless, while a name computeEditViewModel does
-// reference and this shim omitted throws downstream ("references unknown
-// field ... on entity"). Union is strictly safer than picking one branch.
-function allFieldSpecs(section: EditFieldsSection): readonly EditFieldSpec[] {
-  const grouped = section.groups?.flatMap((group) => group.fields) ?? [];
-  return [...section.fields, ...grouped];
-}
-
 /** Minimale EntityDefinition aus den Layout-Feldern: jedes Feld ein Text-
  *  Feld — computeEditViewModel liest nur `fields[<f>].type`, Text reicht für
  *  eine reine Anzeige (kein Select/Number-spezifisches Rendering nötig). */
@@ -52,7 +42,7 @@ export function synthesizeProjectionDetailEntity(layout: EditLayout): EntityDefi
   for (const section of layout.sections) {
     // relatedList and extension sections carry no `fields` to synthesize.
     if (!isFieldsEditSection(section)) continue;
-    for (const spec of allFieldSpecs(section)) {
+    for (const spec of sectionFieldSpecs(section)) {
       fields[normalizeEditField(spec).field] = { type: "text" };
     }
   }

package/src/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.290.0",
+    "type": "fix",
+    "title": "Layout field readers see groups[].fields",
+    "detail": "layoutEditFields flattens section.groups, so required fields inside a groups-only section are presence-validated by buildFormSchema and survive the renderableFields gate for search-param prefills."
+  },
   {
     "version": "0.283.0",
     "type": "fix",

package/src/components/__tests__/embedded-list-field.test.tsx

@@ -22,7 +22,18 @@ import { RenderField, type RenderFieldProps } from "../render-field";
 
 let captured: EmbeddedListInputProps | undefined;
 const captureEmbeddedListInput: ComponentType<EmbeddedListInputProps> = (props) => {
-  captured = props;
+  captured = {
+    ...props,
+    onCellChange: (...args) => act(() => props.onCellChange(...args)),
+    onAddRow: () => act(() => props.onAddRow()),
+    onRemoveRow: (rowIndex) => act(() => props.onRemoveRow(rowIndex)),
+    onDuplicateRow: (rowIndex) => act(() => props.onDuplicateRow(rowIndex)),
+    onMoveRow: (fromIndex, toIndex) => act(() => props.onMoveRow(fromIndex, toIndex)),
+    ...(props.onPasteCells !== undefined && {
+      onPasteCells: (...args: Parameters<NonNullable<EmbeddedListInputProps["onPasteCells"]>>) =>
+        act(() => props.onPasteCells?.(...args)),
+    }),
+  };
   return null;
 };
 const noop = (): ReactNode => null;
@@ -112,12 +123,12 @@ function invoiceLinesField(overrides: Partial<EditFieldViewModel> = {}): EditFie
   };
 }
 
-function renderEmbeddedListField(
+async function renderEmbeddedListField(
   field: EditFieldViewModel,
   onChange: (v: unknown) => void,
   allIssues: Readonly<Record<string, readonly FieldIssue[]>> = {},
   productRows: readonly ProductRow[] = [],
-): void {
+): Promise<void> {
   captured = undefined;
   render(
     <LocaleProvider
@@ -137,13 +148,14 @@ function renderEmbeddedListField(
       </DispatcherProvider>
     </LocaleProvider>,
   );
+  await act(async () => {});
 }
 
 describe("EmbeddedListField — cell change recomputes derived", () => {
-  test("changing quantity updates the cell and recomputes amount in the same row", () => {
+  test("changing quantity updates the cell and recomputes amount in the same row", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 2, unitPrice: 500, amount: 1000 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onCellChange(0, "quantity", 4);
@@ -152,10 +164,10 @@ describe("EmbeddedListField — cell change recomputes derived", () => {
     ]);
   });
 
-  test("a fractional product on the money-typed amount cell shows the rounded live preview, not the raw fraction", () => {
+  test("a fractional product on the money-typed amount cell shows the rounded live preview, not the raw fraction", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 2, unitPrice: 923, amount: 1846 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     // 2.5 * 923 = 2307.5 — a fractional minor-unit amount the money target
@@ -177,7 +189,7 @@ describe("EmbeddedListField — cell change recomputes derived", () => {
   // frozen `source` snapshot, same as the server. Two field configs with
   // "net"/"gross" declared in opposite key order must therefore produce the
   // identical, order-independent result.
-  test("chained derived cells (gross depends on net) recompute the same value regardless of the derived-map's key order", () => {
+  test("chained derived cells (gross depends on net) recompute the same value regardless of the derived-map's key order", async () => {
     const cells: EditFieldViewModel["embeddedListCells"] = [
       { field: "qty", label: "Qty", type: "number", required: true },
       { field: "price", label: "Price", type: "number", required: true },
@@ -194,7 +206,7 @@ describe("EmbeddedListField — cell change recomputes derived", () => {
     const expected = { qty: 4, price: 3, tax: 1, net: 12, gross: 7 };
 
     let netFirstResult: unknown;
-    renderEmbeddedListField(
+    await renderEmbeddedListField(
       {
         ...invoiceLinesField({ value: rows }),
         embeddedListCells: cells,
@@ -210,7 +222,7 @@ describe("EmbeddedListField — cell change recomputes derived", () => {
     captured?.onCellChange(0, "qty", 4);
 
     let grossFirstResult: unknown;
-    renderEmbeddedListField(
+    await renderEmbeddedListField(
       {
         ...invoiceLinesField({ value: rows }),
         embeddedListCells: cells,
@@ -236,45 +248,45 @@ describe("EmbeddedListField — row operations", () => {
     { product: "p2", unit: "hours", quantity: 2, unitPrice: 200, amount: 400 },
   ];
 
-  test("onAddRow appends an empty row with derived recomputed", () => {
+  test("onAddRow appends an empty row with derived recomputed", async () => {
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onAddRow();
     expect(lastValue).toEqual([...rows, { amount: undefined }]);
   });
 
-  test("onRemoveRow removes exactly the targeted row", () => {
+  test("onRemoveRow removes exactly the targeted row", async () => {
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onRemoveRow(0);
     expect(lastValue).toEqual([rows[1]]);
   });
 
-  test("onDuplicateRow inserts a copy right after the source row", () => {
+  test("onDuplicateRow inserts a copy right after the source row", async () => {
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onDuplicateRow(0);
     expect(lastValue).toEqual([rows[0], rows[0], rows[1]]);
   });
 
-  test("onDuplicateRow is a no-op for an out-of-range index", () => {
+  test("onDuplicateRow is a no-op for an out-of-range index", async () => {
     let called = false;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {
       called = true;
     });
     captured?.onDuplicateRow(99);
     expect(called).toBe(false);
   });
 
-  test("onMoveRow moves an element from one index to another, immutably", () => {
+  test("onMoveRow moves an element from one index to another, immutably", async () => {
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onMoveRow(1, 0);
@@ -286,9 +298,9 @@ describe("EmbeddedListField — row operations", () => {
     ]);
   });
 
-  test("onMoveRow is a no-op for an out-of-range target index", () => {
+  test("onMoveRow is a no-op for an out-of-range target index", async () => {
     let called = false;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {
       called = true;
     });
     captured?.onMoveRow(0, 5);
@@ -297,10 +309,10 @@ describe("EmbeddedListField — row operations", () => {
 });
 
 describe("EmbeddedListField — paste coercion", () => {
-  test("pastes number/money/select cells with correct coercion per column type", () => {
+  test("pastes number/money/select cells with correct coercion per column type", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     // Columns in order: product, unit, quantity, unitPrice, amount.
@@ -315,10 +327,10 @@ describe("EmbeddedListField — paste coercion", () => {
   // the typed-in path's currencyDecimals-based scaling for any non-2-decimal
   // currency — JPY (0 decimals) pasted "1234" would have landed on 123400
   // (100x too large) instead of 1234.
-  test("pastes a money cell for a zero-decimal currency (JPY) without the paste-path ×100 bug", () => {
+  test("pastes a money cell for a zero-decimal currency (JPY) without the paste-path ×100 bug", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 0, amount: 0 }];
     let lastValue: unknown;
-    renderEmbeddedListField(
+    await renderEmbeddedListField(
       invoiceLinesField({ value: rows, embeddedListCurrency: "JPY" }),
       (v) => {
         lastValue = v;
@@ -331,12 +343,15 @@ describe("EmbeddedListField — paste coercion", () => {
     expect(result[0]?.["unitPrice"]).toBe(1234);
   });
 
-  test("paste beyond the current rows appends new rows but never past maxItems", () => {
+  test("paste beyond the current rows appends new rows but never past maxItems", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows, embeddedListMaxItems: 2 }), (v) => {
-      lastValue = v;
-    });
+    await renderEmbeddedListField(
+      invoiceLinesField({ value: rows, embeddedListMaxItems: 2 }),
+      (v) => {
+        lastValue = v;
+      },
+    );
     captured?.onPasteCells?.(0, 2, [
       ["1", "100"],
       ["2", "200"],
@@ -348,7 +363,10 @@ describe("EmbeddedListField — paste coercion", () => {
 
   test("paste beyond maxItems surfaces a listIssue with the dropped-row count", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
-    renderEmbeddedListField(invoiceLinesField({ value: rows, embeddedListMaxItems: 2 }), () => {});
+    await renderEmbeddedListField(
+      invoiceLinesField({ value: rows, embeddedListMaxItems: 2 }),
+      () => {},
+    );
     act(() => {
       captured?.onPasteCells?.(0, 2, [
         ["1", "100"],
@@ -371,7 +389,7 @@ describe("EmbeddedListField — paste coercion", () => {
   test("a select paste value with no matching option leaves the cell unchanged and surfaces a listIssue", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     // Columns in order: product, unit, quantity, unitPrice, amount. Column
@@ -396,10 +414,10 @@ describe("EmbeddedListField — paste coercion", () => {
   // kumiko-framework#1838: a naive `replace(",", ".")` on a DE-locale paste
   // with a thousands separator turned "1.234,56" into "1.234.56" → NaN →
   // the cell silently cleared instead of keeping the pasted amount.
-  test("pastes a DE-locale money value with a thousands separator (1.234,56)", () => {
+  test("pastes a DE-locale money value with a thousands separator (1.234,56)", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     // Column index 3 = "unitPrice".
@@ -408,10 +426,10 @@ describe("EmbeddedListField — paste coercion", () => {
     expect(result[0]?.["unitPrice"]).toBe(123456);
   });
 
-  test("pastes an en-US-locale money value with a thousands separator (1,234.56)", () => {
+  test("pastes an en-US-locale money value with a thousands separator (1,234.56)", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     captured?.onPasteCells?.(0, 3, [["1,234.56"]]);
@@ -422,7 +440,7 @@ describe("EmbeddedListField — paste coercion", () => {
   test("an unparseable money paste leaves the cell unchanged and surfaces a listIssue instead of clearing it", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     let lastValue: unknown;
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
       lastValue = v;
     });
     act(() => {
@@ -445,7 +463,7 @@ describe("EmbeddedListField — paste coercion", () => {
 
 describe("EmbeddedListField — reference column populated via useQuery", () => {
   test("referenceOptions come from the product list query", async () => {
-    renderEmbeddedListField(invoiceLinesField({ value: [] }), () => {}, {}, [
+    await renderEmbeddedListField(invoiceLinesField({ value: [] }), () => {}, {}, [
       { id: "p1", name: "Widget A" },
     ]);
     await waitFor(() => {
@@ -456,10 +474,10 @@ describe("EmbeddedListField — reference column populated via useQuery", () =>
 });
 
 describe("EmbeddedListField — issue grouping wiring", () => {
-  test("a lines.0.amount issue is routed as a cellIssue at 0.amount", () => {
+  test("a lines.0.amount issue is routed as a cellIssue at 0.amount", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     const issue: FieldIssue = { path: "lines.0.amount", code: "custom", i18nKey: "Bad amount" };
-    renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {}, {
+    await renderEmbeddedListField(invoiceLinesField({ value: rows }), () => {}, {
       "lines.0.amount": [issue],
     });
     expect(captured?.cellIssues?.["0.amount"]).toEqual([issue]);
@@ -467,19 +485,19 @@ describe("EmbeddedListField — issue grouping wiring", () => {
     expect(captured?.listIssues ?? []).toEqual([]);
   });
 
-  test("a lines-level issue is routed as a listIssue", () => {
+  test("a lines-level issue is routed as a listIssue", async () => {
     const issue: FieldIssue = { path: "lines", code: "custom", i18nKey: "Too few lines" };
-    renderEmbeddedListField(invoiceLinesField({ value: [] }), () => {}, {
+    await renderEmbeddedListField(invoiceLinesField({ value: [] }), () => {}, {
       lines: [issue],
     });
     expect(captured?.listIssues).toEqual([issue]);
   });
 });
 
-function renderFieldWithEmbeddedList(
+async function renderFieldWithEmbeddedList(
   field: EditFieldViewModel,
   allIssues: RenderFieldProps["allIssues"],
-): void {
+): Promise<void> {
   captured = undefined;
   render(
     <LocaleProvider
@@ -498,13 +516,14 @@ function renderFieldWithEmbeddedList(
       </DispatcherProvider>
     </LocaleProvider>,
   );
+  await act(async () => {});
 }
 
 describe("RenderField — routes embedded-list fields to EmbeddedListField (plumbing)", () => {
-  test("field.embeddedListCells set → RenderField mounts EmbeddedListField, allIssues propagate", () => {
+  test("field.embeddedListCells set → RenderField mounts EmbeddedListField, allIssues propagate", async () => {
     const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
     const issue: FieldIssue = { path: "lines.0.amount", code: "custom", i18nKey: "Bad amount" };
-    renderFieldWithEmbeddedList(invoiceLinesField({ value: rows }), {
+    await renderFieldWithEmbeddedList(invoiceLinesField({ value: rows }), {
       "lines.0.amount": [issue],
     });
     expect(captured?.cellIssues?.["0.amount"]).toEqual([issue]);

package/src/i18n-defaults.ts

@@ -188,6 +188,7 @@ export const kumikoDefaultTranslations: TranslationsByLocale = {
     "errors.notFound": "Not found.",
     "errors.conflict": "Conflict — the operation could not be completed.",
     "errors.versionConflict": "The record was modified in the meantime. Reload and try again.",
+    "errors.preconditionFailed": "The record changed in the meantime. Reload and try again.",
     "errors.uniqueViolation": "This entry already exists.",
     "errors.unprocessable": "The request could not be processed.",
     "errors.unconfigured": "This feature isn't configured yet.",