@cosmicdrift/kumiko-renderer 0.247.0 → 0.249.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.247.0",
+  "version": "0.249.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.247.0",
-    "@cosmicdrift/kumiko-headless": "0.247.0",
+    "@cosmicdrift/kumiko-framework": "0.249.0",
+    "@cosmicdrift/kumiko-headless": "0.249.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"
@@ -27,7 +27,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "react-dom": "^19.2.6",
-    "@cosmicdrift/kumiko-locale-de": "0.247.0"
+    "@cosmicdrift/kumiko-locale-de": "0.249.0"
   },
   "repository": {
     "type": "git",

package/src/app/__tests__/entity-list-row-action-icon.test.tsx

@@ -3,8 +3,9 @@
 // renders the real entityList pipeline (KumikoScreen → EntityListBody) and
 // asserts on the resolved `icon` KumikoScreen attaches to each
 // DataTableRowAction — the id-derived default (ACTION_ICON_BY_ID in
-// kumiko-screen.tsx) for an action with no declared icon, and the declared
-// icon overriding that default for one that has it.
+// kumiko-screen.tsx) for an action with no declared icon, the declared icon
+// overriding that default for one that has it, and the full id / last
+// segment / first segment fallback order for compound ids (fw#2749).
 
 import { describe, expect, test } from "bun:test";
 import type {
@@ -101,6 +102,36 @@ function buildSchema(): FeatureSchema {
         screen: "widget-edit",
         icon: "archive",
       },
+      // Full id and last segment ("item") have no entry — falls through to
+      // the first segment ("add" -> plus).
+      {
+        id: "add-item",
+        label: "Add Item",
+        handler: "icon-fixture:write:widget:add-item",
+      },
+      // Same fallback, different verb ("open" -> eye).
+      {
+        kind: "navigate",
+        id: "open-lease",
+        label: "Open Lease",
+        screen: "widget-edit",
+      },
+      // Neither the full id nor either segment ("order", "ship") has an
+      // entry — the new stage must not invent an icon.
+      {
+        kind: "navigate",
+        id: "order-ship",
+        label: "Order Ship",
+        screen: "widget-edit",
+      },
+      // Last segment ("copy") and first segment ("send") both have entries —
+      // the last segment must keep priority over the new first-segment stage.
+      {
+        kind: "navigate",
+        id: "send-copy",
+        label: "Send Copy",
+        screen: "widget-edit",
+      },
     ],
   };
   return {
@@ -166,4 +197,52 @@ describe("entityList rowActions resolve an icon (fw-ui-defaults)", () => {
 
     expect(requireAction("edit").icon).toBe("archive");
   });
+
+  test("an id whose full form and last segment miss falls back to its first segment ('add-item' -> plus)", async () => {
+    capturedRowActions = undefined;
+
+    renderListScreen();
+
+    await waitFor(() => {
+      expect(capturedRowActions).toBeDefined();
+    });
+
+    expect(requireAction("add-item").icon).toBe("plus");
+  });
+
+  test("the first-segment fallback also applies to 'open-lease' -> eye", async () => {
+    capturedRowActions = undefined;
+
+    renderListScreen();
+
+    await waitFor(() => {
+      expect(capturedRowActions).toBeDefined();
+    });
+
+    expect(requireAction("open-lease").icon).toBe("eye");
+  });
+
+  test("an id with no matching segment stays without an icon ('order-ship')", async () => {
+    capturedRowActions = undefined;
+
+    renderListScreen();
+
+    await waitFor(() => {
+      expect(capturedRowActions).toBeDefined();
+    });
+
+    expect(requireAction("order-ship").icon).toBeUndefined();
+  });
+
+  test("the last segment keeps priority over the first ('send-copy' -> copy, not send)", async () => {
+    capturedRowActions = undefined;
+
+    renderListScreen();
+
+    await waitFor(() => {
+      expect(capturedRowActions).toBeDefined();
+    });
+
+    expect(requireAction("send-copy").icon).toBe("copy");
+  });
 });

package/src/app/row-actions.ts

@@ -57,19 +57,29 @@ const ACTION_ICON_BY_ID: Readonly<Partial<Record<string, IconKey>>> = {
   send: "send",
 };
 
-// Ids are kebab-case (RowAction.id doc) — a compound id whose full form has
-// no entry falls back to its last segment ("order-ship" -> "ship").
+// Ids are kebab-case (RowAction.id doc): aggregate-object-verb
+// ("order-ship") or verb-prefix ("add-item").
 function kebabLastSegment(id: string): string {
   const idx = id.lastIndexOf("-");
   return idx === -1 ? id : id.slice(idx + 1);
 }
 
+function kebabFirstSegment(id: string): string {
+  const idx = id.indexOf("-");
+  return idx === -1 ? id : id.slice(0, idx);
+}
+
 // Resolution order: author-declared `icon` wins, then the id-derived
-// default (full id, then its last kebab segment). `declared` is `undefined`
-// for ToolbarAction, which has no author-facing icon field.
+// default (full id, then its last kebab segment, then its first kebab
+// segment). `declared` is `undefined` for ToolbarAction, which has no
+// author-facing icon field.
 export function resolveActionIcon(id: string, declared?: IconKey): IconKey | undefined {
   if (declared !== undefined) return declared;
-  return ACTION_ICON_BY_ID[id] ?? ACTION_ICON_BY_ID[kebabLastSegment(id)];
+  return (
+    ACTION_ICON_BY_ID[id] ??
+    ACTION_ICON_BY_ID[kebabLastSegment(id)] ??
+    ACTION_ICON_BY_ID[kebabFirstSegment(id)]
+  );
 }
 
 // Row-action column mode for a resolved action set: a group where every