@cosmicdrift/kumiko-renderer 0.241.0 → 0.243.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.241.0",
+  "version": "0.243.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.241.0",
-    "@cosmicdrift/kumiko-headless": "0.241.0",
+    "@cosmicdrift/kumiko-framework": "0.243.0",
+    "@cosmicdrift/kumiko-headless": "0.243.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"
@@ -27,7 +27,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "react-dom": "^19.2.6",
-    "@cosmicdrift/kumiko-locale-de": "0.241.0"
+    "@cosmicdrift/kumiko-locale-de": "0.243.0"
   },
   "repository": {
     "type": "git",

package/src/app/kumiko-screen.tsx

@@ -25,7 +25,7 @@ import type {
 } from "@cosmicdrift/kumiko-headless";
 import { fieldLabelKey, fieldOptionLabelKey } from "@cosmicdrift/kumiko-headless";
 import { type ReactNode, useCallback, useEffect, useMemo, useRef, useState } from "react";
-import { extractCreatedId } from "../components/reference-create-dialog";
+import { extractCreatedId, extractIdField } from "../components/reference-create-dialog";
 import { RenderEdit, type RenderEditAction } from "../components/render-edit";
 import { RenderList, type ToolbarActionButton } from "../components/render-list";
 import { useDispatcher, useOptionalDispatcher } from "../context/dispatcher-context";
@@ -2425,6 +2425,12 @@ function ProjectionDetailBody({
 }
 // ---- actionForm (Tier 2.7d) ----
 
+function redirectScreenTarget(
+  redirect: NonNullable<ActionFormScreenDefinition["redirect"]>,
+): string {
+  return typeof redirect === "string" ? redirect : redirect.screen;
+}
+
 // Action-Form-Body — non-CRUD Write-Handler-driven Form. Re-uses
 // RenderEdit über synthetisierte EntityDefinition + EntityEditScreen-
 // Definition (siehe action-form-shim.ts für die Schulden-Doku). Die
@@ -2476,8 +2482,10 @@ function ActionFormBody({
       // Author entscheidet bewusst ob "stay on form" (default) oder
       // "back to list" (typisch bei Create-style Aktionen).
       if (screen.redirect !== undefined) {
-        const targetId = lastSegment(screen.redirect);
-        const targetFeatureName = featureNameFromQualifiedScreenId(screen.redirect);
+        const redirectScreen = redirectScreenTarget(screen.redirect);
+        const idField = typeof screen.redirect === "string" ? "id" : screen.redirect.idFrom;
+        const targetId = lastSegment(redirectScreen);
+        const targetFeatureName = featureNameFromQualifiedScreenId(redirectScreen);
         // A qualified redirect target may live in a different feature than
         // this screen's own schema (fw#2485) — resolve over all mounted
         // features (own schema first, cheap and provider-independent) same
@@ -2496,7 +2504,7 @@ function ActionFormBody({
               // pick by — fall back to the pre-fw#2485 best-effort match by
               // short id across all mounted features.
               appFeatures.flatMap((f) => f.screens).find((s) => lastSegment(s.id) === targetId));
-        const entityId = extractCreatedId(result.data);
+        const entityId = extractIdField(result.data, idField);
         const carriesId =
           target !== undefined &&
           (target.type === "entityEdit" || target.type === "projectionDetail");
@@ -2514,7 +2522,9 @@ function ActionFormBody({
   // (Single-Action-Screens, wo Cancel nur Submit-ohne-Senden wäre).
   const handleCancel = useMemo<(() => void) | undefined>(() => {
     if (onCancelOverride !== undefined) return onCancelOverride;
-    const target = screen.cancelTarget ?? screen.redirect;
+    const target =
+      screen.cancelTarget ??
+      (screen.redirect !== undefined ? redirectScreenTarget(screen.redirect) : undefined);
     if (target === undefined || target === false) return undefined;
     return () => nav.navigate({ screenId: lastSegment(target) });
   }, [nav, screen.redirect, screen.cancelTarget, onCancelOverride]);

package/src/components/__tests__/related-list-section.test.tsx

@@ -3,7 +3,7 @@ import type { RowAction } from "@cosmicdrift/kumiko-framework/ui-types";
 import type { Dispatcher, EditRelatedListSectionViewModel } from "@cosmicdrift/kumiko-headless";
 import { render, screen as rtlScreen, waitFor } from "@testing-library/react";
 import type { ComponentType, ReactNode } from "react";
-import { NavProvider } from "../../app/nav";
+import { type NavApi, NavProvider } from "../../app/nav";
 import { DispatcherProvider } from "../../context/dispatcher-context";
 import { createStaticLocaleResolver, LocaleProvider } from "../../i18n";
 import { kumikoDefaultTranslations } from "../../i18n-defaults";
@@ -26,22 +26,27 @@ const testSection: ComponentType<SectionProps> = ({ testId, children }) => (
 // wired straight to the action's onTrigger — enough to prove
 // RelatedListSection wires rowActions through to a real dispatch, without
 // needing the production DataTable's sorting/paging/kebab-menu chrome.
+// The isVisible filter mirrors the production DataTable's own row-action
+// filter (renderer-web primitives/index.tsx) so per-row gating is exercised
+// here rather than assumed.
 const testDataTable: ComponentType<DataTableProps> = ({ rows, rowActions }) => (
   <table>
     <tbody>
       {rows.map((row) => (
         <tr key={row.id} data-testid={`row-${row.id}`}>
           <td>
-            {(rowActions ?? []).map((action) => (
-              <button
-                key={action.id}
-                type="button"
-                data-testid={`action-${action.id}-${row.id}`}
-                onClick={() => void action.onTrigger(row)}
-              >
-                {action.label}
-              </button>
-            ))}
+            {(rowActions ?? [])
+              .filter((action) => action.isVisible === undefined || action.isVisible(row))
+              .map((action) => (
+                <button
+                  key={action.id}
+                  type="button"
+                  data-testid={`action-${action.id}-${row.id}`}
+                  onClick={() => void action.onTrigger(row)}
+                >
+                  {action.label}
+                </button>
+              ))}
           </td>
         </tr>
       ))}
@@ -74,7 +79,7 @@ function testPrimitives(): CorePrimitives {
   } as unknown as CorePrimitives;
 }
 
-function stubDispatcher(): {
+function stubDispatcher(rows: readonly Record<string, unknown>[] = [{ id: "r1", name: "Alice" }]): {
   dispatcher: Dispatcher;
   writes: Array<{ type: string; payload: unknown }>;
   queryCount: () => number;
@@ -88,10 +93,7 @@ function stubDispatcher(): {
     }) as Dispatcher["write"],
     query: (async () => {
       queryCalls += 1;
-      return {
-        isSuccess: true,
-        data: { rows: [{ id: "r1", name: "Alice" }], nextCursor: null },
-      };
+      return { isSuccess: true, data: { rows, nextCursor: null } };
     }) as Dispatcher["query"],
     batch: (async () => ({ isSuccess: true, results: [] })) as Dispatcher["batch"],
     statusStore: {
@@ -105,6 +107,28 @@ function stubDispatcher(): {
   return { dispatcher, writes, queryCount: () => queryCalls };
 }
 
+function stubNav(): {
+  nav: NavApi;
+  navigations: unknown[];
+  searchParams: Array<Record<string, string | null>>;
+} {
+  const navigations: unknown[] = [];
+  const searchParams: Array<Record<string, string | null>> = [];
+  const nav: NavApi = {
+    route: undefined,
+    navigate: (target: unknown) => {
+      navigations.push(target);
+    },
+    replace: noop,
+    hrefFor: () => "#",
+    searchParams: {},
+    setSearchParams: (params: Record<string, string | null>) => {
+      searchParams.push(params);
+    },
+  } as unknown as NavApi;
+  return { nav, navigations, searchParams };
+}
+
 const rowActions: readonly RowAction[] = [
   {
     id: "resend",
@@ -122,7 +146,11 @@ const historySection: EditRelatedListSectionViewModel = {
   rowActions,
 };
 
-function renderRelatedList(dispatcher: Dispatcher) {
+function renderRelatedList(
+  dispatcher: Dispatcher,
+  section: EditRelatedListSectionViewModel = historySection,
+  nav: NavApi = stubNav().nav,
+) {
   return render(
     <LocaleProvider
       resolver={createStaticLocaleResolver({ locale: "en-US" })}
@@ -130,17 +158,8 @@ function renderRelatedList(dispatcher: Dispatcher) {
     >
       <DispatcherProvider dispatcher={dispatcher}>
         <PrimitivesProvider value={testPrimitives()}>
-          <NavProvider
-            value={{
-              route: undefined,
-              navigate: noop,
-              replace: noop,
-              hrefFor: () => "#",
-              searchParams: {},
-              setSearchParams: noop,
-            }}
-          >
-            <RelatedListSection section={historySection} parentId="order-1" featureName="orders" />
+          <NavProvider value={nav}>
+            <RelatedListSection section={section} parentId="order-1" featureName="orders" />
           </NavProvider>
         </PrimitivesProvider>
       </DispatcherProvider>
@@ -160,4 +179,61 @@ describe("RelatedListSection — rowActions", () => {
     expect(writes[0]).toEqual({ type: "orders:write:resend", payload: { id: "r1" } });
     await waitFor(() => expect(queryCount()).toBe(2));
   });
+
+  test("a navigate row action targets its screen and carries the clicked row's own values as search params", async () => {
+    const { dispatcher } = stubDispatcher([{ id: "item-7", name: "Rent 2024", amount: 1200 }]);
+    const { nav, navigations, searchParams } = stubNav();
+    renderRelatedList(
+      dispatcher,
+      {
+        kind: "relatedList",
+        title: "Positions",
+        query: "lease:query:items:list",
+        columns: [{ field: "name" }],
+        rowActions: [
+          {
+            kind: "navigate",
+            id: "adjust-rent",
+            label: "actions.adjustRent",
+            screen: "adjust-rent-form",
+            params: { map: { itemId: "id", currentAmount: "amount" } },
+          },
+        ],
+      },
+      nav,
+    );
+
+    await waitFor(() => expect(rtlScreen.getByTestId("row-item-7")).toBeTruthy());
+    rtlScreen.getByTestId("action-adjust-rent-item-7").click();
+
+    await waitFor(() => expect(navigations).toHaveLength(1));
+    expect(navigations[0]).toEqual({ screenId: "adjust-rent-form" });
+    expect(searchParams).toEqual([{ itemId: "item-7", currentAmount: "1200" }]);
+  });
+
+  test("a row action with a visible condition renders only on the rows that satisfy it", async () => {
+    const { dispatcher } = stubDispatcher([
+      { id: "active-1", name: "Running", status: "active" },
+      { id: "ended-1", name: "Closed", status: "ended" },
+    ]);
+    renderRelatedList(dispatcher, {
+      kind: "relatedList",
+      title: "Positions",
+      query: "lease:query:items:list",
+      columns: [{ field: "name" }],
+      rowActions: [
+        {
+          id: "end-item",
+          label: "actions.endItem",
+          handler: "lease:write:end-item",
+          payload: { pick: ["id"] },
+          visible: { field: "status", eq: "active" },
+        },
+      ],
+    });
+
+    await waitFor(() => expect(rtlScreen.getByTestId("row-ended-1")).toBeTruthy());
+    expect(rtlScreen.getByTestId("action-end-item-active-1")).toBeTruthy();
+    expect(rtlScreen.queryByTestId("action-end-item-ended-1")).toBeNull();
+  });
 });

package/src/components/reference-create-dialog.tsx

@@ -23,10 +23,18 @@ function entityWriteCommand(featureName: string, entity: string): string {
 // The create handler's success payload is `{ kind: "save", id, ... }`
 // (see event-store-executor-write.ts) but RenderEdit's onSubmit only
 // types it as `unknown` — narrow defensively instead of casting through it.
-export function extractCreatedId(data: unknown): string | undefined {
+// `field` is author-declared (ActionFormRedirect.idFrom, fw#2670), never
+// user input; the own-property check keeps a prototype key like
+// "constructor" from resolving to anything.
+export function extractIdField(data: unknown, field: string): string | undefined {
   if (typeof data !== "object" || data === null) return undefined;
-  const id = (data as Record<string, unknown>)["id"];
-  return typeof id === "string" ? id : undefined;
+  if (!Object.hasOwn(data, field)) return undefined;
+  const value = (data as Record<string, unknown>)[field];
+  return typeof value === "string" ? value : undefined;
+}
+
+export function extractCreatedId(data: unknown): string | undefined {
+  return extractIdField(data, "id");
 }
 
 export type ReferenceCreateDialogProps = {

package/src/primitives.tsx

@@ -448,8 +448,9 @@ export type InputProps =
       readonly name: string;
       readonly value: string;
       readonly onChange: (v: string) => void;
-      /** Anzahl sichtbarer Zeilen. Default 4 in der Default-Primitive
-       *  — hinreichend für Notes, vertikal-scrollbar drüber. */
+      /** Visible rows. Acts as a minimum height — the field starts this tall
+       *  and still grows with its content. Omitted, the default primitive
+       *  falls back to its own floor (#2677). */
       readonly rows?: number;
       readonly disabled?: boolean;
       readonly required?: boolean;