@cosmicdrift/kumiko-renderer 0.205.0 → 0.206.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.205.0",
+  "version": "0.206.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.205.0",
-    "@cosmicdrift/kumiko-headless": "0.205.0",
+    "@cosmicdrift/kumiko-framework": "0.206.0",
+    "@cosmicdrift/kumiko-headless": "0.206.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"

package/src/app/__tests__/nav.test.ts

@@ -6,7 +6,7 @@
 import { describe, expect, test } from "bun:test";
 import type { ScreenDefinition } from "@cosmicdrift/kumiko-framework/ui-types";
 import type { FeatureSchema } from "../feature-schema";
-import { formatPath, parsePath, resolveTarget } from "../nav";
+import { formatPath, hasDetailScreen, parsePath, resolveTarget } from "../nav";
 
 describe("parsePath — ohne Workspaces", () => {
   test("/<screenId>", () => {
@@ -126,10 +126,14 @@ describe("resolveTarget", () => {
     expect(resolveTarget([], target)).toBe(target);
   });
 
+  // Short screenId, not the qualified "property:screen:lease-detail" —
+  // ScreenTarget.screenId round-trips through formatPath/parsePath as a
+  // short id; RoutedScreen re-qualifies it itself (fw#2164 fix, previously
+  // double-qualified and silently fell back to the app's default screen).
   test("ObjectTarget resolves via the matching custom detailFor screen", () => {
     const schema = schemaWith("property", [leaseDetailScreen]);
     expect(resolveTarget([schema], { entity: "lease", id: "l-1" })).toEqual({
-      screenId: "property:screen:lease-detail",
+      screenId: "lease-detail",
       entityId: "l-1",
     });
   });
@@ -146,7 +150,7 @@ describe("resolveTarget", () => {
       leaseDetailScreen,
     ]);
     expect(resolveTarget([schema], { entity: "lease", id: "l-1" })).toEqual({
-      screenId: "property:screen:lease-detail",
+      screenId: "lease-detail",
       entityId: "l-1",
     });
   });
@@ -156,7 +160,7 @@ describe("resolveTarget", () => {
     const resolved = resolveTarget([schema], { entity: "lease", id: "l-1", workspaceId: "admin" });
     expect(resolved).toEqual({
       workspaceId: "admin",
-      screenId: "property:screen:lease-detail",
+      screenId: "lease-detail",
       entityId: "l-1",
     });
   });
@@ -172,3 +176,23 @@ describe("resolveTarget", () => {
     expect(() => resolveTarget([schema], { entity: "boat", id: "b-1" })).toThrow(/"boat"/);
   });
 });
+
+// hasDetailScreen: non-throwing existence check create-app's row-click
+// default (fw#2164) uses to pick between a detailFor screen and its other
+// fallbacks — resolveTarget's throw isn't usable there since not resolving
+// is the expected, non-error case for most entities.
+describe("hasDetailScreen", () => {
+  test("true when a screen declares detailFor for the entity", () => {
+    const schema = schemaWith("property", [leaseDetailScreen]);
+    expect(hasDetailScreen([schema], "lease")).toBe(true);
+  });
+
+  test("false when no screen declares detailFor for the entity", () => {
+    const schema = schemaWith("property", [leaseListScreen, leaseEditScreen]);
+    expect(hasDetailScreen([schema], "lease")).toBe(false);
+  });
+
+  test("false for an empty feature list", () => {
+    expect(hasDetailScreen([], "lease")).toBe(false);
+  });
+});

package/src/app/nav.tsx

@@ -1,6 +1,5 @@
 import { createContext, type ReactNode, useContext } from "react";
 import type { FeatureSchema } from "./feature-schema";
-import { qualifyScreenId } from "./qualify-screen-id";
 
 // Navigation-Contract, plattform-neutral. Types + Context + Hook leben
 // hier; die konkrete Implementation (window.history im Web,
@@ -118,21 +117,45 @@ export function formatPath(target: ScreenTarget): string {
   return `/${segments.join("/")}`;
 }
 
+// Shared entity→detailFor-screen lookup — resolveTarget's ObjectTarget
+// branch and hasDetailScreen (create-app's row-click default, fw#2164) both
+// need "is there a detail screen for this entity", one to resolve it, the
+// other to just check before falling back to a different default.
+function findDetailForScreen(
+  features: readonly FeatureSchema[],
+  entity: string,
+): { readonly featureName: string; readonly screenId: string } | undefined {
+  for (const feature of features) {
+    for (const screen of feature.screens) {
+      if (screen.detailFor === entity)
+        return { featureName: feature.featureName, screenId: screen.id };
+    }
+  }
+  return undefined;
+}
+
+/** Non-throwing existence check for findDetailForScreen — lets a caller pick
+ *  a different default (fw#2164's row-click fallback) instead of resolving. */
+export function hasDetailScreen(features: readonly FeatureSchema[], entity: string): boolean {
+  return findDetailForScreen(features, entity) !== undefined;
+}
+
 // Resolves a NavTarget to the ScreenTarget form navigate/replace/hrefFor
 // operate on. Pure — no context, no I/O — so callers can use it outside
 // React too (see resolve-at-NavApi-build alternative in renderer-web).
 export function resolveTarget(features: readonly FeatureSchema[], target: NavTarget): ScreenTarget {
   if ("screenId" in target) return target;
 
-  for (const feature of features) {
-    for (const screen of feature.screens) {
-      if (screen.detailFor !== target.entity) continue;
-      return {
-        ...(target.workspaceId !== undefined && { workspaceId: target.workspaceId }),
-        screenId: qualifyScreenId(feature.featureName, screen.id),
-        entityId: target.id,
-      };
-    }
+  const found = findDetailForScreen(features, target.entity);
+  if (found !== undefined) {
+    // Short form (globally unique per validateScreenShortIdCollisions) —
+    // ScreenTarget.screenId round-trips through formatPath/parsePath as a
+    // short id; qualifying it here double-qualifies at RoutedScreen.
+    return {
+      ...(target.workspaceId !== undefined && { workspaceId: target.workspaceId }),
+      screenId: found.screenId,
+      entityId: target.id,
+    };
   }
 
   throw new Error(

package/src/index.ts

@@ -72,7 +72,14 @@ export type {
   ObjectTarget,
   ScreenTarget,
 } from "./app/nav";
-export { formatPath, NavProvider, parsePath, resolveTarget, useNav } from "./app/nav";
+export {
+  formatPath,
+  hasDetailScreen,
+  NavProvider,
+  parsePath,
+  resolveTarget,
+  useNav,
+} from "./app/nav";
 export { lastSegment } from "./app/qn";
 export type { VariableChipsProps } from "./app/variable-chips";
 export { VariableChips } from "./app/variable-chips";