@cosmicdrift/kumiko-renderer 0.201.0 → 0.203.0

package/src/app/projection-list-shim.ts

@@ -24,14 +24,19 @@ import { normalizeListColumn } from "@cosmicdrift/kumiko-framework/ui-types";
 
 const PROJECTION_PSEUDO_ENTITY = "__projection__";
 
-/** Minimale EntityDefinition aus den Column-Feldern: jedes Feld ein Text-Feld,
- *  nicht sortierbar (eine Projection-Query hat keinen garantierten Server-Sort).
- *  computeListViewModel liest nur `fields[<col>].type` → Text reicht; die
- *  Präsentation kommt aus dem Column-Renderer + explizitem Label. */
-export function synthesizeProjectionEntity(columns: readonly ListColumnSpec[]): EntityDefinition {
-  const fields: Record<string, { type: "text"; sortable: false }> = {};
+/** Minimal EntityDefinition from the column list: every field is a text
+ *  field. `sortable` applies uniformly to all columns — buildAppSchema
+ *  derives it from the query's Zod schema (`screen.sortable`, fw#2165); the
+ *  query itself has no per-field server-sort guarantee.
+ *  computeListViewModel only reads `fields[<col>].type` — text is enough,
+ *  presentation comes from the column renderer + explicit label. */
+export function synthesizeProjectionEntity(
+  columns: readonly ListColumnSpec[],
+  sortable: boolean,
+): EntityDefinition {
+  const fields: Record<string, { type: "text"; sortable: boolean }> = {};
   for (const col of columns) {
-    fields[normalizeListColumn(col).field] = { type: "text", sortable: false };
+    fields[normalizeListColumn(col).field] = { type: "text", sortable };
   }
   return { fields } as unknown as EntityDefinition;
 }

package/src/app/qualify-screen-id.ts

@@ -0,0 +1,6 @@
+// Dependency-free: kumiko-screen.tsx already imports useNav from nav.tsx, so
+// this can't live in either without a cycle. Form must match the registry's
+// qualification rule (packages/framework/src/engine/qualified-name.ts).
+export function qualifyScreenId(featureName: string, screenId: string): string {
+  return `${featureName}:screen:${screenId}`;
+}

package/src/components/render-edit.tsx

@@ -136,6 +136,12 @@ export type RenderEditProps<TValues extends FormValues, TCtx = unknown> = {
    *  platform-neutrale Package darf kein `navigator`/`window` anfassen,
    *  siehe guard-renderer-boundaries). undefined = kein Button. */
   readonly onCopyLink?: () => Promise<void> | void;
+  /** Header action buttons, rendered before the built-in copy-link/
+   *  delete/cancel/save controls. Each callback is already fully
+   *  bound (screen-type/nav/dispatcher resolution happens in the caller,
+   *  same split as `onCopyLink`) — RenderEdit only wires the button, its
+   *  busy state and its confirm dialog. */
+  readonly actions?: readonly RenderEditAction[];
   /** i18n-key für den Submit-Button. Default: "kumiko.actions.save".
    *  Action-Forms (Tier 2.7d) übergeben hier ihren screen.submitLabel,
    *  damit "Speichern" durch domain-spezifischere Strings ersetzt
@@ -205,6 +211,15 @@ export type RenderEditProps<TValues extends FormValues, TCtx = unknown> = {
   readonly hideActions?: boolean;
 };
 
+export type RenderEditAction = {
+  readonly id: string;
+  readonly label: string;
+  readonly onPress: () => void | Promise<void>;
+  readonly style?: "primary" | "secondary" | "danger";
+  readonly confirm?: string;
+  readonly confirmLabel?: string;
+};
+
 export type RenderEditChangeState<TValues extends FormValues> = {
   readonly values: TValues;
   readonly changes: Partial<TValues>;
@@ -314,6 +329,72 @@ function ExtensionSectionMount({
   );
 }
 
+// One header action + its own busy/confirm state — same pattern as
+// render-list.tsx's ToolbarActionView (each RenderEditAction is
+// independently bound by the caller, there is no shared trigger pipeline
+// to hook into like the built-in onDelete/onSubmit paths have).
+function RenderEditActionButton({
+  action,
+  Button,
+  Dialog,
+  onError,
+}: {
+  readonly action: RenderEditAction;
+  readonly Button: ReturnType<typeof usePrimitives>["Button"];
+  readonly Dialog: ReturnType<typeof usePrimitives>["Dialog"];
+  readonly onError: (text: string | null) => void;
+}): ReactNode {
+  const [busy, setBusy] = useState(false);
+  const [confirmOpen, setConfirmOpen] = useState(false);
+
+  const trigger = async (): Promise<void> => {
+    setBusy(true);
+    onError(null);
+    try {
+      await action.onPress();
+    } catch (e) {
+      onError(e instanceof Error ? e.message : String(e));
+    } finally {
+      setBusy(false);
+    }
+  };
+
+  const variant = action.style ?? "secondary";
+  // Same rule as RowActionWriteHandler: "danger" forces a confirm even
+  // without an explicit confirm key.
+  const needsConfirm = action.confirm !== undefined || action.style === "danger";
+
+  return (
+    <>
+      <Button
+        type="button"
+        variant={variant}
+        loading={busy}
+        onClick={() => {
+          if (needsConfirm) {
+            setConfirmOpen(true);
+          } else {
+            void trigger();
+          }
+        }}
+        testId={`render-edit-action-${action.id}`}
+      >
+        {action.label}
+      </Button>
+      <Dialog
+        open={confirmOpen}
+        onOpenChange={setConfirmOpen}
+        title={action.label}
+        {...(action.confirm !== undefined && { description: action.confirm })}
+        confirmLabel={action.confirmLabel ?? action.label}
+        {...(action.style === "danger" && { variant: "danger" as const })}
+        onConfirm={trigger}
+        testId={`render-edit-action-${action.id}-dialog`}
+      />
+    </>
+  );
+}
+
 export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
   props: RenderEditProps<TValues, TCtx>,
 ): ReactNode {
@@ -333,6 +414,7 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
     onCancel,
     onReload,
     onCopyLink,
+    actions,
     submitLabel,
     labelAppendix,
     fieldAppendix,
@@ -362,6 +444,12 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
   const [linkCopied, setLinkCopied] = useState(false);
   const [isSubmitting, setIsSubmitting] = useState(false);
   const [formError, setFormError] = useState<DispatcherError | null>(null);
+  // One state for all header actions (actions?), not per-button — only one
+  // action can be in flight at a time, and this keeps the error surfaced in
+  // the shared formError-adjacent banner region instead of inside the
+  // button row (fw#2166 review: a full-width Banner there breaks the
+  // flex justify-end action bar).
+  const [actionError, setActionError] = useState<string | null>(null);
   const [rawStep, setRawStep] = useState(0);
   // Create-mode draftId (issue #1913) — resumed from `sessionStorage` (web)
   // on mount so a same-tab reload finds the right one of several parallel
@@ -985,6 +1073,15 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
   // gegen Fehlklicks. Save bleibt rechts (primary affordance).
   const formActions = (
     <>
+      {actions?.map((action) => (
+        <RenderEditActionButton
+          key={action.id}
+          action={action}
+          Button={Button}
+          Dialog={Dialog}
+          onError={setActionError}
+        />
+      ))}
       {onCopyLink !== undefined && (
         <Button
           type="button"
@@ -1282,6 +1379,11 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
             <Text testId="render-edit-extension-error-key">{translate(extensionErrorKey)}</Text>
           </Banner>
         )}
+        {actionError !== null && (
+          <Banner variant="error" testId="render-edit-action-error">
+            {actionError}
+          </Banner>
+        )}
         {onDelete !== undefined && (
           <Dialog
             open={confirmDeleteOpen}

package/src/index.ts

@@ -64,13 +64,21 @@ export type {
 export { isAppSchema, toAppSchema } from "./app/feature-schema";
 export type { KumikoScreenProps } from "./app/kumiko-screen";
 export { KumikoScreen, qualifyNavId, qualifyScreenId } from "./app/kumiko-screen";
-export type { NavApi, NavProviderProps, NavRoute, NavTarget } from "./app/nav";
-export { formatPath, NavProvider, parsePath, useNav } from "./app/nav";
+export type {
+  NavApi,
+  NavProviderProps,
+  NavRoute,
+  NavTarget,
+  ObjectTarget,
+  ScreenTarget,
+} from "./app/nav";
+export { formatPath, NavProvider, parsePath, resolveTarget, useNav } from "./app/nav";
 export { lastSegment } from "./app/qn";
 export type { VariableChipsProps } from "./app/variable-chips";
 export { VariableChips } from "./app/variable-chips";
 export { dispatcherErrorText, WriteFailedError } from "./app/write-failed-error";
 export type {
+  RenderEditAction,
   RenderEditChangeState,
   RenderEditControls,
   RenderEditProps,