@cosmicdrift/kumiko-renderer 0.197.1 → 0.199.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.197.1",
+  "version": "0.199.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.197.1",
-    "@cosmicdrift/kumiko-headless": "0.197.1",
+    "@cosmicdrift/kumiko-framework": "0.199.0",
+    "@cosmicdrift/kumiko-headless": "0.199.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2",
     "zod": "^4.4.3"

package/src/app/kumiko-screen.tsx

@@ -198,7 +198,7 @@ export function KumikoScreen({
     case "configEdit":
       return <ConfigEditBody schema={schema} screen={screen} translate={translate} />;
     case "custom":
-      return <CustomScreenBody screenId={screen.id} />;
+      return <CustomScreenBody screenId={screen.id} featureName={schema.featureName} />;
   }
 }
 
@@ -228,16 +228,27 @@ function DashboardScreenBody({
 // Lookup-Body für custom-screens: schaut die Component aus dem
 // CustomScreens-Context (gefüttert von clientFeatures.components in
 // createKumikoApp). Wenn weder Provider gemounted noch screenId
-// registriert ist, fällt es auf einen Banner zurück — Apps die das
-// sehen wissen sofort: "Component fehlt im clientFeatures.components".
-function CustomScreenBody({ screenId }: { readonly screenId: string }): ReactNode {
+// registriert ist, fällt es auf einen error-Banner zurück statt leer zu
+// rendern — der Screen ist per URL erreichbar sobald das Server-Feature
+// gemountet ist, unabhängig davon ob ein Client-Plugin existiert
+// (kumiko-framework#2025).
+function CustomScreenBody({
+  screenId,
+  featureName,
+}: {
+  readonly screenId: string;
+  readonly featureName: string;
+}): ReactNode {
   const { Banner, Text } = usePrimitives();
   const Component = useCustomScreenComponent(screenId);
   if (Component === undefined) {
     return (
-      <Banner padded variant="info" testId="kumiko-screen-custom-placeholder">
-        Custom screen <Text variant="code">{screenId}</Text> hat keine Component im{" "}
-        <Text variant="code">clientFeatures.components</Text>.
+      <Banner padded variant="error" testId="kumiko-screen-custom-placeholder">
+        Custom screen <Text variant="code">{screenId}</Text> (Feature{" "}
+        <Text variant="code">{featureName}</Text>) hat keine Component in{" "}
+        <Text variant="code">clientFeatures.components</Text> — das Web-Client-Plugin des Features
+        (siehe <Text variant="code">{featureName}/web/client-plugin.tsx</Text>) fehlt in{" "}
+        <Text variant="code">clientFeatures</Text>.
       </Banner>
     );
   }
@@ -438,11 +449,20 @@ function EntityEditCreateBody({
   screen,
   entity,
   translate,
+  onSaved,
 }: {
   readonly schema: FeatureSchema;
   readonly screen: EntityEditScreenDefinition;
   readonly entity: EntityDefinition;
   readonly translate?: Translate;
+  // Singleton screens (kumiko-screen#1944) run without a wrapping
+  // entityList screen, so `navigateToList` below is a silent no-op there —
+  // without this callback, a successful create left the form stuck showing
+  // the just-submitted values, and a second submit created a duplicate
+  // record. Wired by EntityEditSingletonBody to re-run its list(limit:1)
+  // query, which flips the branch to EntityEditUpdateBody once it sees the
+  // new row.
+  readonly onSaved?: () => void;
 }): ReactNode {
   const nav = useNav();
   const initial = useMemo(
@@ -470,8 +490,9 @@ function EntityEditCreateBody({
         return;
       }
       navigateToList();
+      onSaved?.();
     },
-    [nav, screen.redirect, navigateToList],
+    [nav, screen.redirect, navigateToList, onSaved],
   );
   return (
     <RenderEdit
@@ -500,6 +521,8 @@ function EntityEditUpdateBody({
   entityId,
   translate,
   onCopyLink,
+  autoReloadOnSave,
+  onDeleted,
 }: {
   readonly schema: FeatureSchema;
   readonly screen: EntityEditScreenDefinition;
@@ -507,6 +530,18 @@ function EntityEditUpdateBody({
   readonly entityId: string;
   readonly translate?: Translate;
   readonly onCopyLink?: () => Promise<void> | void;
+  // Singleton screens (kumiko-screen#1944): `navigateToList` below is a
+  // no-op there (no wrapping entityList screen), so a successful update
+  // left the form holding the now-stale `recordVersion` it captured at
+  // mount — the next submit hit a version conflict. Set by
+  // EntityEditSingletonBody to re-fetch this body's own detail query after
+  // a successful save, remounting the form (via the version-keyed `key`
+  // below) with the fresh version.
+  readonly autoReloadOnSave?: boolean;
+  // Wired by EntityEditSingletonBody to re-run its list(limit:1) query
+  // after a successful delete, so the branch flips back to the create form
+  // instead of the update form continuing to display the deleted record.
+  readonly onDeleted?: () => void;
 }): ReactNode {
   const { Banner, Text } = usePrimitives();
   const t = useTranslation();
@@ -554,6 +589,8 @@ function EntityEditUpdateBody({
       onReload={detailQuery.refetch}
       {...(translate !== undefined && { translate })}
       {...(onCopyLink !== undefined && { onCopyLink })}
+      {...(autoReloadOnSave === true && { onSaved: () => void detailQuery.refetch() })}
+      {...(onDeleted !== undefined && { onDeleted })}
     />
   );
 }
@@ -567,6 +604,8 @@ function EntityEditUpdateForm({
   onReload,
   translate,
   onCopyLink,
+  onSaved,
+  onDeleted,
 }: {
   readonly schema: FeatureSchema;
   readonly screen: EntityEditScreenDefinition;
@@ -576,6 +615,10 @@ function EntityEditUpdateForm({
   readonly onReload: () => Promise<void> | void;
   readonly translate?: Translate;
   readonly onCopyLink?: () => Promise<void> | void;
+  // See EntityEditUpdateBody's autoReloadOnSave/onDeleted docs — both are
+  // no-ops unless the caller (singleton screens) wires them.
+  readonly onSaved?: () => void;
+  readonly onDeleted?: () => void;
 }): ReactNode {
   // Seed the form with the server values for the entity's declared
   // fields; anything else (id, tenant_id, created_at…) stays out of
@@ -628,13 +671,17 @@ function EntityEditUpdateForm({
         return;
       }
       navigateToList();
+      onSaved?.();
     },
-    [nav, screen.redirect, navigateToList],
+    [nav, screen.redirect, navigateToList, onSaved],
   );
   const handleDelete = useCallback(async () => {
     const res = await dispatcher.write(deleteCommand, { id: entityId });
-    if (res.isSuccess) navigateToList();
-  }, [dispatcher, deleteCommand, entityId, navigateToList]);
+    if (res.isSuccess) {
+      navigateToList();
+      onDeleted?.();
+    }
+  }, [dispatcher, deleteCommand, entityId, navigateToList, onDeleted]);
 
   return (
     <RenderEdit
@@ -715,6 +762,8 @@ function EntityEditSingletonBody({
         entityId={existingId}
         {...(translate !== undefined && { translate })}
         {...(onCopyLink !== undefined && { onCopyLink })}
+        autoReloadOnSave
+        onDeleted={() => void listQuery.refetch()}
       />
     );
   }
@@ -724,6 +773,7 @@ function EntityEditSingletonBody({
       screen={screen}
       entity={entity}
       {...(translate !== undefined && { translate })}
+      onSaved={() => void listQuery.refetch()}
     />
   );
 }
@@ -737,11 +787,13 @@ function EntityEditCreateOrDisabled({
   screen,
   entity,
   translate,
+  onSaved,
 }: {
   readonly schema: FeatureSchema;
   readonly screen: EntityEditScreenDefinition;
   readonly entity: EntityDefinition;
   readonly translate?: Translate;
+  readonly onSaved?: () => void;
 }): ReactNode {
   const { Banner, Text } = usePrimitives();
   if (screen.allowCreate === false) {
@@ -758,6 +810,7 @@ function EntityEditCreateOrDisabled({
       screen={screen}
       entity={entity}
       {...(translate !== undefined && { translate })}
+      {...(onSaved !== undefined && { onSaved })}
     />
   );
 }
@@ -1229,12 +1282,16 @@ function EntityListBody({
       ? (row: ListRowViewModel) => onRowClick(row, screen.entity)
       : undefined;
 
-  // Searchable-Default: explizite Author-Wahl gewinnt, sonst auto-on
-  // wenn die Entity searchable Felder hat (sonst wäre die Toolbar-Bar
-  // ein toter Slot — Server-Search-Index hat eh nichts zum Filtern).
+  // Searchable default: explicit author choice wins, otherwise auto-on when
+  // the entity has searchable fields (dead toolbar slot otherwise — the
+  // server search index has nothing to filter). Gated on
+  // schema.searchAdapterMissing !== true regardless of source (explicit or
+  // auto) — a search bar the server can't serve would 422 at request-time
+  // (#2032); matches the boot-time check in api/server.ts (#2051).
   const searchable =
-    screen.searchable ??
-    Object.values(entity.fields).some((f) => "searchable" in f && f.searchable === true);
+    schema.searchAdapterMissing !== true &&
+    (screen.searchable ??
+      Object.values(entity.fields).some((f) => "searchable" in f && f.searchable === true));
 
   // Pager-Props nur bei pagination="pages" zusammenstellen. Server-
   // total kommt async — bis es da ist, rendert RenderList die Tabelle

package/src/components/__tests__/embedded-list-field.test.tsx

@@ -392,6 +392,55 @@ describe("EmbeddedListField — paste coercion", () => {
       ]);
     });
   });
+
+  // kumiko-framework#1838: a naive `replace(",", ".")` on a DE-locale paste
+  // with a thousands separator turned "1.234,56" into "1.234.56" → NaN →
+  // the cell silently cleared instead of keeping the pasted amount.
+  test("pastes a DE-locale money value with a thousands separator (1.234,56)", () => {
+    const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
+    let lastValue: unknown;
+    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+      lastValue = v;
+    });
+    // Column index 3 = "unitPrice".
+    captured?.onPasteCells?.(0, 3, [["1.234,56"]]);
+    const result = lastValue as readonly Record<string, unknown>[];
+    expect(result[0]?.["unitPrice"]).toBe(123456);
+  });
+
+  test("pastes an en-US-locale money value with a thousands separator (1,234.56)", () => {
+    const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
+    let lastValue: unknown;
+    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+      lastValue = v;
+    });
+    captured?.onPasteCells?.(0, 3, [["1,234.56"]]);
+    const result = lastValue as readonly Record<string, unknown>[];
+    expect(result[0]?.["unitPrice"]).toBe(123456);
+  });
+
+  test("an unparseable money paste leaves the cell unchanged and surfaces a listIssue instead of clearing it", async () => {
+    const rows = [{ product: "p1", unit: "pcs", quantity: 1, unitPrice: 100, amount: 100 }];
+    let lastValue: unknown;
+    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+      lastValue = v;
+    });
+    act(() => {
+      captured?.onPasteCells?.(0, 3, [["not-a-number"]]);
+    });
+    const result = lastValue as readonly Record<string, unknown>[];
+    expect(result[0]?.["unitPrice"]).toBe(100);
+    await waitFor(() => {
+      expect(captured?.listIssues).toEqual([
+        {
+          path: "lines",
+          code: "paste-cells-unmatched",
+          i18nKey: "kumiko.field.embedded-list.paste-cells-unmatched",
+          params: { count: 1 },
+        },
+      ]);
+    });
+  });
 });
 
 describe("EmbeddedListField — reference column populated via useQuery", () => {

package/src/components/embedded-list-field.tsx

@@ -55,6 +55,30 @@ function withRecomputedDerived(
   return result;
 }
 
+// Locale-aware decimal parse for pasted text: strips space/NBSP thousands
+// separators outright, then treats whichever of "," or "." appears LAST in
+// the string as the decimal separator and strips the other one — handles
+// both "1.234,56" (de) and "1,234.56" (en-US) pastes. Returns undefined for
+// anything that still doesn't parse as a finite number.
+function parseLocaleAwareDecimal(raw: string): number | undefined {
+  const stripped = raw.replace(/[\s ]/g, "");
+  if (stripped === "") return undefined;
+  const lastComma = stripped.lastIndexOf(",");
+  const lastDot = stripped.lastIndexOf(".");
+  const decimalIndex = Math.max(lastComma, lastDot);
+  if (decimalIndex === -1) {
+    const n = Number(stripped);
+    return Number.isFinite(n) ? n : undefined;
+  }
+  const integerPart = stripped.slice(0, decimalIndex).replace(/[.,]/g, "");
+  const fractionPart = stripped.slice(decimalIndex + 1);
+  if (!/^\d*$/.test(integerPart) || !/^\d*$/.test(fractionPart)) return undefined;
+  const n = Number(
+    `${integerPart === "" ? "0" : integerPart}.${fractionPart === "" ? "0" : fractionPart}`,
+  );
+  return Number.isFinite(n) ? n : undefined;
+}
+
 function coerceCellValue(column: EmbeddedListColumn, text: string, currency: string): unknown {
   switch (column.type) {
     case "text":
@@ -73,9 +97,13 @@ function coerceCellValue(column: EmbeddedListColumn, text: string, currency: str
       // currencyDecimals) — a hardcoded ×100 here diverged for zero-/three-
       // decimal currencies (JPY, BHD, ...), landing a pasted value 100x off
       // from the same value typed by hand (kumiko-framework#1972).
+      // parseLocaleAwareDecimal handles both "1.234,56" (de) and
+      // "1,234.56" (en-US) thousands/decimal conventions — a naive
+      // `replace(",", ".")` mangled DE-locale pastes with thousands
+      // separators into NaN (kumiko-framework#1838).
       if (text.trim() === "") return undefined;
-      const n = Number(text.replace(",", "."));
-      return Number.isFinite(n) ? Math.round(n * 10 ** currencyDecimals(currency)) : undefined;
+      const n = parseLocaleAwareDecimal(text);
+      return n === undefined ? undefined : Math.round(n * 10 ** currencyDecimals(currency));
     }
     case "boolean":
       return ["true", "1", "yes", "y", "ja"].includes(text.trim().toLowerCase());
@@ -263,11 +291,14 @@ export function EmbeddedListField({
         const column = columns[columnIndex + gridColOffset];
         if (column === undefined) return;
         const coerced = coerceCellValue(column, text, field.embeddedListCurrency ?? "EUR");
-        const isUnmatchedChoice =
-          (column.type === "select" || column.type === "reference") &&
+        // Also covers an unparseable money paste (e.g. mangled thousands
+        // separators) — the cell must stay unchanged instead of silently
+        // clearing to undefined (kumiko-framework#1838).
+        const isUnmatchedOrUnparseable =
+          (column.type === "select" || column.type === "reference" || column.type === "money") &&
           coerced === undefined &&
           text.trim() !== "";
-        if (isUnmatchedChoice) {
+        if (isUnmatchedOrUnparseable) {
           unmatchedCells += 1;
           return;
         }

package/src/components/render-edit.tsx

@@ -415,11 +415,15 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
   // freezes it on first render) — safe because a section's field-name set is
   // value-independent, so it matches filterEditSections(vm.sections, fieldsFilter).
   // undefined = unscoped, since scoping would silently drop root-level .refine() issues.
-  const scopeFieldNames = useMemo(
-    () =>
-      fieldsFilter === undefined ? undefined : fieldsFilter.filter((f) => Object.hasOwn(fields, f)),
-    [fieldsFilter, fields],
-  );
+  // A `fieldsFilter` that matches nothing in `fields` (typo, renamed field)
+  // must fall back to unscoped too — an empty scope array would filter out
+  // ALL validation issues (kumiko-framework#1907), letting submit() through
+  // unvalidated on a form that also renders no sections.
+  const scopeFieldNames = useMemo(() => {
+    if (fieldsFilter === undefined) return undefined;
+    const matched = fieldsFilter.filter((f) => Object.hasOwn(fields, f));
+    return matched.length === 0 ? undefined : matched;
+  }, [fieldsFilter, fields]);
 
   // Submit-Config nur wenn der Caller einen writeCommand mitgibt; bei
   // customSubmit-Pfad kommt der Form-Controller ohne Submit-Wiring,
@@ -1097,7 +1101,13 @@ export function RenderEdit<TValues extends FormValues, TCtx = unknown>(
               </Button>,
             ]}
           >
-            <Text>{translate("kumiko.form.draft.resume-multiple")}</Text>
+            <Text>
+              {translate(
+                draftCandidates.length === 1
+                  ? "kumiko.form.draft.resume-single"
+                  : "kumiko.form.draft.resume-multiple",
+              )}
+            </Text>
           </Banner>
         )}
         {isWizard && (

package/src/i18n-defaults.ts

@@ -162,6 +162,9 @@ export const kumikoDefaultTranslations: TranslationsByLocale = {
     "kumiko.form.extension.save-failed": "Ein Zusatzfeld konnte nicht gespeichert werden.",
     "kumiko.form.draft.resume-multiple":
       "Mehrere offene Entwürfe für dieses Formular gefunden. Welchen möchtest du fortsetzen?",
+    "kumiko.form.draft.resume-single":
+      "Ein offener Entwurf für dieses Formular gefunden. Möchtest du ihn fortsetzen?",
+    "kumiko.form.draft.start-new": "Neu beginnen",
 
     // Validation — Default-Reason-Codes aus dem Framework. App-Code
     // kann eigene Codes via Validation-Hooks reinwerfen; die hier sind
@@ -343,6 +346,9 @@ export const kumikoDefaultTranslations: TranslationsByLocale = {
     "kumiko.form.extension.save-failed": "A custom field could not be saved.",
     "kumiko.form.draft.resume-multiple":
       "Found multiple open drafts for this form. Which one do you want to resume?",
+    "kumiko.form.draft.resume-single":
+      "Found an open draft for this form. Do you want to resume it?",
+    "kumiko.form.draft.start-new": "Start new",
 
     "kumiko.validation.required": "Required.",
     "kumiko.validation.invalid": "Invalid value.",

package/src/index.ts

@@ -9,6 +9,7 @@
 // eigenen Bootstrap schreiben will. Normale Samples gehen über
 // @cosmicdrift/kumiko-renderer-web/createKumikoApp, das alle Provider verdrahtet.
 
+export { synthesizeActionFormEntity, synthesizeActionFormScreen } from "./app/action-form-shim";
 export type { AppFeaturesProviderProps } from "./app/app-features-context";
 export { AppFeaturesProvider, useAppFeatures } from "./app/app-features-context";
 export type {