@cosmicdrift/kumiko-renderer 0.186.2 → 0.187.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer",
-  "version": "0.186.2",
+  "version": "0.187.0",
   "description": "Platform-agnostic React renderer for Kumiko screens. Contains the shared logic — primitives-contract, hooks, KumikoScreen, navigation & SSE abstractions — that any platform-specific renderer (web, native) composes. No DOM, no EventSource, no react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -15,8 +15,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.186.2",
-    "@cosmicdrift/kumiko-headless": "0.186.2",
+    "@cosmicdrift/kumiko-framework": "0.187.0",
+    "@cosmicdrift/kumiko-headless": "0.187.0",
     "react": "^19.2.6",
     "temporal-polyfill": "^0.3.2"
   },

package/src/app/column-renderers.tsx

@@ -24,6 +24,10 @@ export type ColumnRendererProps = {
   readonly column: {
     readonly field: string;
   };
+  /** Set only when the caller (DataTable's `onCellChange`) wired an
+   *  editable path for this cell — undefined means read-only. A renderer
+   *  can branch its own markup (input vs. plain text) on presence alone. */
+  readonly onChange?: (value: unknown) => void;
 };
 
 export type ColumnRendererComponent = ComponentType<ColumnRendererProps>;

package/src/components/__tests__/embedded-list-field.test.tsx

@@ -151,6 +151,21 @@ describe("EmbeddedListField — cell change recomputes derived", () => {
       { product: "p1", unit: "pcs", quantity: 4, unitPrice: 500, amount: 2000 },
     ]);
   });
+
+  test("a fractional product on the money-typed amount cell shows the rounded live preview, not the raw fraction", () => {
+    const rows = [{ product: "p1", unit: "pcs", quantity: 2, unitPrice: 923, amount: 1846 }];
+    let lastValue: unknown;
+    renderEmbeddedListField(invoiceLinesField({ value: rows }), (v) => {
+      lastValue = v;
+    });
+    // 2.5 * 923 = 2307.5 — a fractional minor-unit amount the money target
+    // can't store as-is. The live preview must show the rounded value
+    // (2308), matching what the server would compute and persist.
+    captured?.onCellChange(0, "quantity", 2.5);
+    expect(lastValue).toEqual([
+      { product: "p1", unit: "pcs", quantity: 2.5, unitPrice: 923, amount: 2308 },
+    ]);
+  });
 });
 
 describe("EmbeddedListField — row operations", () => {

package/src/components/embedded-list-field.tsx

@@ -1,7 +1,12 @@
-import type { EditFieldViewModel, FieldIssue } from "@cosmicdrift/kumiko-headless";
+import type {
+  EditFieldViewModel,
+  EmbeddedListCellViewModel,
+  FieldIssue,
+} from "@cosmicdrift/kumiko-headless";
 import {
   computeDerivedCellValue,
   groupEmbeddedListIssues,
+  roundDerivedCellValue,
   sumEmbeddedListColumn,
 } from "@cosmicdrift/kumiko-headless";
 import type { ReactNode } from "react";
@@ -25,6 +30,7 @@ type EmbeddedRow = Readonly<Record<string, unknown>>;
 function withRecomputedDerived(
   row: EmbeddedRow,
   derived: EditFieldViewModel["embeddedListDerived"],
+  cells: readonly EmbeddedListCellViewModel[],
 ): EmbeddedRow {
   if (derived === undefined) return row;
   const result: Record<string, unknown> = { ...row };
@@ -33,7 +39,12 @@ function withRecomputedDerived(
       const v = result[src];
       return typeof v === "number" ? v : undefined;
     });
-    result[derivedField] = computeDerivedCellValue(def.op, values);
+    const computed = computeDerivedCellValue(def.op, values);
+    const target = cells.find((c) => c.field === derivedField);
+    result[derivedField] =
+      computed !== undefined && target !== undefined
+        ? roundDerivedCellValue(computed, target)
+        : computed;
   }
   return result;
 }
@@ -154,11 +165,13 @@ export function EmbeddedListField({
   }
 
   function handleCellChange(rowIndex: number, cellField: string, value: unknown): void {
-    replaceRow(rowIndex, (row) => withRecomputedDerived({ ...row, [cellField]: value }, derived));
+    replaceRow(rowIndex, (row) =>
+      withRecomputedDerived({ ...row, [cellField]: value }, derived, cells),
+    );
   }
 
   function handleAddRow(): void {
-    onChange([...rows, withRecomputedDerived({}, derived)]);
+    onChange([...rows, withRecomputedDerived({}, derived, cells)]);
   }
 
   function handleRemoveRow(rowIndex: number): void {
@@ -210,7 +223,7 @@ export function EmbeddedListField({
     });
 
     const recomputed = nextRows.map((row, i) =>
-      touchedIndices.has(i) ? withRecomputedDerived(row, derived) : row,
+      touchedIndices.has(i) ? withRecomputedDerived(row, derived, cells) : row,
     );
     onChange(recomputed);
   }

package/src/i18n-defaults.ts

@@ -31,6 +31,9 @@ export const kumikoDefaultTranslations: TranslationsByLocale = {
 
     // Field — aria-Labels der Date/Timestamp-Primitives.
     "kumiko.field.open-calendar": "Kalender öffnen",
+    "kumiko.field.dateField.placeholderYear": "J",
+    "kumiko.field.dateField.placeholderMonth": "M",
+    "kumiko.field.dateField.placeholderDay": "T",
     "kumiko.field.time": "Uhrzeit",
     "kumiko.field.timezone": "Zeitzone",
     "kumiko.field.locatedTzHint": "Zeit lokal am angegebenen Ort",
@@ -195,6 +198,9 @@ export const kumikoDefaultTranslations: TranslationsByLocale = {
     "kumiko.toast.learn-more": "Learn more",
 
     "kumiko.field.open-calendar": "Open calendar",
+    "kumiko.field.dateField.placeholderYear": "Y",
+    "kumiko.field.dateField.placeholderMonth": "M",
+    "kumiko.field.dateField.placeholderDay": "D",
     "kumiko.field.time": "Time",
     "kumiko.field.timezone": "Time zone",
     "kumiko.field.locatedTzHint": "Time local to the given location",

package/src/primitives.tsx

@@ -548,6 +548,18 @@ export type DataTableProps = {
    *  "Ende der Liste"-Hinweis statt des Sentinels. Default true. */
   readonly hasMore?: boolean;
   readonly testId?: string;
+  /** Wires an edit path into a component column-renderer: `DataTableCell`
+   *  passes this down as `ColumnRendererProps.onChange` for that cell,
+   *  bound to `(rowId, column.field)`. Renderers without a component
+   *  renderer (format-spec, type-default) ignore it — read-only stays
+   *  read-only unless the column has a custom renderer that reads
+   *  `onChange`. */
+  readonly onCellChange?: (rowId: string, field: string, value: unknown) => void;
+  /** Overrides the row `data-testid` (default `row-${row.id}`) — for a
+   *  screen that already has its own DOM-test/e2e naming scheme. */
+  readonly getRowTestId?: (row: ListRowViewModel) => string;
+  /** Overrides the cell `data-testid` (default `cell-${row.id}-${field}`). */
+  readonly getCellTestId?: (row: ListRowViewModel, field: string) => string;
 };
 
 // ---- EmbeddedListInput (createEmbeddedListField widget) ----