@cosmicdrift/kumiko-renderer-web 0.241.0 → 0.243.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer-web",
-  "version": "0.241.0",
+  "version": "0.243.0",
   "description": "Web-platform bindings for @cosmicdrift/kumiko-renderer. HTML default-primitives, browser history-based navigation, EventSource-backed live events, and a one-call createKumikoApp that mounts the whole stack via react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -16,9 +16,9 @@
     "./styles.css": "./src/styles.css"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.241.0",
-    "@cosmicdrift/kumiko-headless": "0.241.0",
-    "@cosmicdrift/kumiko-renderer": "0.241.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.243.0",
+    "@cosmicdrift/kumiko-headless": "0.243.0",
+    "@cosmicdrift/kumiko-renderer": "0.243.0",
     "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.16",
     "@radix-ui/react-label": "^2.1.8",
@@ -39,10 +39,10 @@
     "react-resizable-panels": "^4.12.2",
     "tailwind-merge": "^3.6.0",
     "temporal-polyfill": "^0.3.2",
-    "@tiptap/core": "^3.29.2",
-    "@tiptap/pm": "^3.29.2",
-    "@tiptap/react": "^3.29.2",
-    "@tiptap/starter-kit": "^3.29.2"
+    "@tiptap/core": "^3.30.5",
+    "@tiptap/pm": "^3.30.5",
+    "@tiptap/react": "^3.30.5",
+    "@tiptap/starter-kit": "^3.30.5"
   },
   "peerDependencies": {
     "@tailwindcss/cli": "^4.3.0",
@@ -64,7 +64,7 @@
     "@types/react-dom": "^19.2.3",
     "jsdom": "^29.1.1",
     "tailwindcss": "^4.3.0",
-    "@cosmicdrift/kumiko-locale-de": "0.241.0"
+    "@cosmicdrift/kumiko-locale-de": "0.243.0"
   },
   "repository": {
     "type": "git",

package/src/__tests__/kumiko-screen.test.tsx

@@ -1889,6 +1889,114 @@ describe("KumikoScreen", () => {
     expect(navigateCalls[0]).toEqual({ screenId: "task-edit", entityId: "x" });
   });
 
+  // #2670: a handler that writes a child record reports the child's id, but
+  // the redirect target is the parent's detail screen — `idFrom` names the
+  // payload field the navigation id comes from, so the handler keeps
+  // reporting what it actually wrote.
+  test("actionForm mit redirect-Objekt + idFrom: navigiert mit der Eltern-ID statt data.id (#2670)", async () => {
+    const navigateCalls: NavTarget[] = [];
+    const dispatcher = makeDispatcher({
+      write: (async () => ({
+        isSuccess: true,
+        data: { id: "child", leaseId: "parent" },
+      })) as unknown as Dispatcher["write"],
+    });
+    const memoryNav = {
+      route: { screenId: "quick-add" },
+      navigate: (target: NavTarget) => {
+        if ("screenId" in target) navigateCalls.push(target);
+      },
+      replace: () => undefined,
+      hrefFor: (t: NavTarget) => ("screenId" in t ? `/${t.screenId}` : ""),
+      searchParams: {},
+      setSearchParams: () => undefined,
+    };
+    const editScreen: EntityEditScreenDefinition = {
+      id: "task-edit",
+      type: "entityEdit",
+      entity: "task",
+      layout: { sections: [{ title: "x", fields: ["title"] }] },
+    };
+    const actionScreen: ActionFormScreenDefinition = {
+      id: "quick-add",
+      type: "actionForm",
+      handler: "tasks:write:task:quick-add",
+      fields: { title: { type: "text", required: true } },
+      layout: { sections: [{ title: "x", fields: ["title"] }] },
+      redirect: { screen: "task-edit", idFrom: "leaseId" },
+    };
+
+    const { NavProvider } = await import("@cosmicdrift/kumiko-renderer");
+    render(
+      <NavProvider value={memoryNav}>
+        <DispatcherProvider dispatcher={dispatcher}>
+          <KumikoScreen
+            schema={{ ...schema, screens: [actionScreen, editScreen, listScreen] }}
+            qn="tasks:screen:quick-add"
+          />
+        </DispatcherProvider>
+      </NavProvider>,
+    );
+
+    const titleInput = screen.getByTestId("field-title").querySelector("input") as HTMLInputElement;
+    fireEvent.change(titleInput, { target: { value: "go" } });
+    await clickSubmitOnceEnabled();
+    await waitFor(() => expect(navigateCalls.length).toBe(1));
+    expect(navigateCalls[0]).toEqual({ screenId: "task-edit", entityId: "parent" });
+  });
+
+  test("actionForm mit blankem String-redirect: navigiert weiter mit data.id, nicht mit einem anderen Payload-Feld (#2670)", async () => {
+    const navigateCalls: NavTarget[] = [];
+    const dispatcher = makeDispatcher({
+      write: (async () => ({
+        isSuccess: true,
+        data: { id: "child", leaseId: "parent" },
+      })) as unknown as Dispatcher["write"],
+    });
+    const memoryNav = {
+      route: { screenId: "quick-add" },
+      navigate: (target: NavTarget) => {
+        if ("screenId" in target) navigateCalls.push(target);
+      },
+      replace: () => undefined,
+      hrefFor: (t: NavTarget) => ("screenId" in t ? `/${t.screenId}` : ""),
+      searchParams: {},
+      setSearchParams: () => undefined,
+    };
+    const editScreen: EntityEditScreenDefinition = {
+      id: "task-edit",
+      type: "entityEdit",
+      entity: "task",
+      layout: { sections: [{ title: "x", fields: ["title"] }] },
+    };
+    const actionScreen: ActionFormScreenDefinition = {
+      id: "quick-add",
+      type: "actionForm",
+      handler: "tasks:write:task:quick-add",
+      fields: { title: { type: "text", required: true } },
+      layout: { sections: [{ title: "x", fields: ["title"] }] },
+      redirect: "task-edit",
+    };
+
+    const { NavProvider } = await import("@cosmicdrift/kumiko-renderer");
+    render(
+      <NavProvider value={memoryNav}>
+        <DispatcherProvider dispatcher={dispatcher}>
+          <KumikoScreen
+            schema={{ ...schema, screens: [actionScreen, editScreen, listScreen] }}
+            qn="tasks:screen:quick-add"
+          />
+        </DispatcherProvider>
+      </NavProvider>,
+    );
+
+    const titleInput = screen.getByTestId("field-title").querySelector("input") as HTMLInputElement;
+    fireEvent.change(titleInput, { target: { value: "go" } });
+    await clickSubmitOnceEnabled();
+    await waitFor(() => expect(navigateCalls.length).toBe(1));
+    expect(navigateCalls[0]).toEqual({ screenId: "task-edit", entityId: "child" });
+  });
+
   // #2416: entityEdit-create passes the newly created record's id through to
   // the post-submit navigate as `entityId` (extractCreatedId); actionForm's
   // redirect did the same navigate but never extracted the id. The with-id

package/src/primitives/__tests__/textarea-rows.test.tsx

@@ -0,0 +1,58 @@
+// #2677 — `field-sizing: content` on the vendored shadcn Textarea makes the
+// `rows` attribute inert, so a declared row count has to reach the rendered
+// height as a min-height floor. Asserting the attribute alone would pass even
+// with the bug present.
+import { describe, expect, test } from "bun:test";
+import { render } from "@testing-library/react";
+import { defaultPrimitives } from "../index";
+
+const { Input } = defaultPrimitives;
+const noop = () => {};
+
+function renderTextarea(rows?: number): HTMLTextAreaElement {
+  const { container } = render(
+    <Input
+      kind="textarea"
+      id="notes"
+      name="notes"
+      value=""
+      onChange={noop}
+      {...(rows !== undefined && { rows })}
+    />,
+  );
+  const textarea = container.querySelector("textarea");
+  if (textarea === null) throw new Error("no textarea rendered");
+  return textarea;
+}
+
+function rowFactor(minHeight: string): number {
+  const match = /calc\((\d+(?:\.\d+)?) \* 1lh/.exec(minHeight);
+  if (match?.[1] === undefined) throw new Error(`min-height not row-derived: "${minHeight}"`);
+  return Number(match[1]);
+}
+
+describe("textarea rows → min-height (#2677)", () => {
+  test("declared rows drive the min-height, not just the attribute", () => {
+    const textarea = renderTextarea(16);
+    expect(textarea.getAttribute("rows")).toBe("16");
+    expect(rowFactor(textarea.style.minHeight)).toBe(16);
+  });
+
+  test("min-height scales with the declared row count", () => {
+    const small = rowFactor(renderTextarea(4).style.minHeight);
+    const large = rowFactor(renderTextarea(16).style.minHeight);
+    expect(large).toBeGreaterThan(small);
+  });
+
+  test("without rows no min-height is imposed — the Tailwind floor stays", () => {
+    expect(renderTextarea().style.minHeight).toBe("");
+  });
+
+  test("a row count that is not a positive integer falls back to the default", () => {
+    for (const rows of [0, -3, 2.5]) {
+      const textarea = renderTextarea(rows);
+      expect(textarea.style.minHeight).toBe("");
+      expect(textarea.getAttribute("rows")).toBe("4");
+    }
+  });
+});

package/src/primitives/index.tsx

@@ -528,6 +528,22 @@ function SegmentedSelect({
   );
 }
 
+// The row count reaches the textarea through an untyped view-model hint, so a
+// sloppy schema can hand over a fraction or a zero — neither renders a sane
+// attribute nor a sane min-height, so both fall back to the default instead.
+function normalizedTextareaRows(rows: number | undefined): number | undefined {
+  return rows !== undefined && Number.isInteger(rows) && rows >= 1 ? rows : undefined;
+}
+
+// The vendored shadcn Textarea carries `field-sizing: content`, which derives
+// the box height from the content and makes the `rows` attribute inert (#2677).
+// A declared row count therefore only survives as a min-height floor: the field
+// starts at `rows` lines tall and still grows with its content. The addend is
+// the textarea frame — py-2 top+bottom plus the 1px borders.
+function textareaMinHeight(rows: number): CSSProperties {
+  return { minHeight: `calc(${rows} * 1lh + 1rem + 2px)` };
+}
+
 function DefaultInput(props: InputProps): ReactNode {
   // Vendored ui/input + ui/checkbox stylen Fehler über `aria-invalid`
   // selbst — kein manuelles border-destructive mehr nötig.
@@ -783,17 +799,20 @@ function DefaultInput(props: InputProps): ReactNode {
           {...(props.hasError !== undefined && { hasError: props.hasError })}
         />
       );
-    case "textarea":
+    case "textarea": {
+      const rows = normalizedTextareaRows(props.rows);
       return (
         <Textarea
           {...common}
           readOnly={props.readOnly}
           value={props.value}
           onChange={(e: ChangeEvent<HTMLTextAreaElement>) => props.onChange(e.target.value)}
-          rows={props.rows ?? 4}
+          rows={rows ?? 4}
           className="resize-y"
+          {...(rows !== undefined && { style: textareaMinHeight(rows) })}
         />
       );
+    }
     case "tz":
       return (
         <TzInput