@cosmicdrift/kumiko-renderer-web 0.232.0 → 0.234.0

package/src/layout/workspace-shell.tsx

@@ -80,7 +80,8 @@ export type WorkspaceShellProps = {
   /** Runtime badge slot per nav leaf (bare nav id), same as DefaultAppShell. */
   readonly navBadges?: ReadonlyMap<string, ReactNode>;
   /** Viewport-fit shell. true → fixed viewport height (`h-svh`), content
-   *  scrolls INSIDE instead of the whole page. Default false (page scroll). */
+   *  scrolls INSIDE instead of the whole page. Default true — set
+   *  `fill={false}` to opt back into page scroll. */
   readonly fill?: boolean;
   /** Screen content. */
   readonly children: ReactNode;
@@ -94,7 +95,7 @@ export function WorkspaceShell({
   initialWorkspaceId,
   sidebarFooter,
   navBadges,
-  fill,
+  fill = true,
   children,
 }: WorkspaceShellProps): ReactNode {
   const app = useMemo(() => toAppSchema(schema), [schema]);

package/src/primitives/__tests__/button.test.tsx

@@ -25,3 +25,40 @@ describe("DefaultButton className/ref (fw#1831)", () => {
     expect(ref.current).toBe(screen.getByTestId("btn"));
   });
 });
+
+describe("DefaultButton icon (fw-ui-defaults)", () => {
+  test("icon prop renders the resolved icon left of the text", () => {
+    render(
+      <Button icon="trash" testId="btn">
+        Delete
+      </Button>,
+    );
+    const btn = screen.getByTestId("btn");
+    expect(btn.querySelector("svg")).not.toBeNull();
+    expect(btn.textContent).toBe("Delete");
+  });
+
+  test("size='icon' + a resolved icon still renders icon, children and aria-label", () => {
+    render(
+      <Button icon="trash" size="icon" ariaLabel="Delete" testId="btn">
+        Delete
+      </Button>,
+    );
+    const btn = screen.getByTestId("btn");
+    expect(btn.textContent).toBe("Delete");
+    expect(btn.querySelector("svg")).not.toBeNull();
+    expect(btn.getAttribute("aria-label")).toBe("Delete");
+  });
+
+  test("unknown icon key: no crash, falls back to rendering children only", () => {
+    render(
+      // @ts-expect-error — exercising the runtime fallback for a schema-supplied key outside the closed IconKey union
+      <Button icon="not-a-real-icon" testId="btn">
+        Delete
+      </Button>,
+    );
+    const btn = screen.getByTestId("btn");
+    expect(btn.querySelector("svg")).toBeNull();
+    expect(btn.textContent).toBe("Delete");
+  });
+});

package/src/primitives/__tests__/data-table-logic.test.ts

@@ -216,6 +216,39 @@ describe("defaultCellRender", () => {
     expect(defaultCellRender("hallo", "text")).toBe("hallo");
   });
 
+  test("text-Spalte mit vollem ISO-8601-Zeitstempel warnt einmal pro Spalte, Wert bleibt unverändert (fw#2569)", () => {
+    const prevNodeEnv = process.env.NODE_ENV;
+    process.env.NODE_ENV = "development";
+    const warn = spyOn(console, "warn").mockImplementation(() => {});
+    try {
+      const iso = "2026-09-04T12:30:00.000Z";
+      expect(defaultCellRender(iso, "text", undefined, undefined, "createdAt")).toBe(iso);
+      expect(warn).toHaveBeenCalledTimes(1);
+      expect(warn.mock.calls[0]?.[0]).toContain("createdAt");
+      // Same column, second row with a different ISO value → no second warning.
+      expect(
+        defaultCellRender("2026-09-05T08:00:00Z", "text", undefined, undefined, "createdAt"),
+      ).toBe("2026-09-05T08:00:00Z");
+      expect(warn).toHaveBeenCalledTimes(1);
+      // A different column still gets its own warning.
+      expect(defaultCellRender(iso, "text", undefined, undefined, "expiresAt")).toBe(iso);
+      expect(warn).toHaveBeenCalledTimes(2);
+      // Plain text and date-only strings never trigger the warning.
+      expect(defaultCellRender("hallo", "text", undefined, undefined, "name")).toBe("hallo");
+      expect(defaultCellRender("2026-09-04", "text", undefined, undefined, "day")).toBe(
+        "2026-09-04",
+      );
+      expect(warn).toHaveBeenCalledTimes(2);
+    } finally {
+      warn.mockRestore();
+      if (prevNodeEnv === undefined) {
+        delete process.env.NODE_ENV;
+      } else {
+        process.env.NODE_ENV = prevNodeEnv;
+      }
+    }
+  });
+
   test("number/decimal → locale-formatiert, kein roher Dezimalpunkt (fw#2160)", () => {
     expect(defaultCellRender(42, "number")).toBe(new Intl.NumberFormat(undefined).format(42));
     expect(defaultCellRender(245.5, "decimal")).toBe(

package/src/primitives/__tests__/select-segmented.test.tsx

@@ -0,0 +1,84 @@
+// Segment control for `kind: "select"` with a small closed option set
+// (edit-existing screenshot feedback): a Status field with 3 short values
+// no longer stretches into a full-width dropdown. Threshold: ≤4 options,
+// each label ≤14 chars — otherwise the unchanged ComboboxInput dropdown.
+
+import { describe, expect, test } from "bun:test";
+import { fireEvent } from "@testing-library/react";
+import { render, screen } from "../../__tests__/test-utils";
+import { defaultPrimitives } from "../index";
+
+const { Field, Input } = defaultPrimitives;
+
+function renderSelect(
+  options: readonly string[],
+  overrides: { readonly value?: string; readonly disabled?: boolean } = {},
+): string[] {
+  const changes: string[] = [];
+  render(
+    <Field id="status" label="Status" testId="field-status">
+      <Input
+        kind="select"
+        id="status"
+        name="status"
+        value={overrides.value ?? options[0] ?? ""}
+        onChange={(v) => changes.push(v)}
+        options={options}
+        {...(overrides.disabled !== undefined && { disabled: overrides.disabled })}
+      />
+    </Field>,
+  );
+  return changes;
+}
+
+describe("DefaultInput select → segmented control (edit-existing feedback)", () => {
+  test("≤4 short options render the segmented control, not the dropdown", () => {
+    renderSelect(["Draft", "Review", "Published"]);
+    expect(screen.queryByTestId("combobox-status")).toBeNull();
+    expect(screen.getByRole("radiogroup")).toBeTruthy();
+    expect(screen.getAllByRole("radio")).toHaveLength(3);
+  });
+
+  test("4 options render the segmented control", () => {
+    renderSelect(["Draft", "Review", "Published", "Archived"]);
+    expect(screen.queryByTestId("combobox-status")).toBeNull();
+    expect(screen.getByRole("radiogroup")).toBeTruthy();
+    expect(screen.getAllByRole("radio")).toHaveLength(4);
+  });
+
+  test("5 options keep the dropdown", () => {
+    renderSelect(["Draft", "Review", "Published", "Archived", "Deleted"]);
+    expect(screen.queryByRole("radiogroup")).toBeNull();
+    expect(screen.getByTestId("combobox-status")).toBeTruthy();
+  });
+
+  test("3 options with one long label (>14 chars) keep the dropdown", () => {
+    renderSelect(["Draft", "Review", "Published Status"]);
+    expect(screen.queryByRole("radiogroup")).toBeNull();
+    expect(screen.getByTestId("combobox-status")).toBeTruthy();
+  });
+
+  test("clicking a segment reports the same value the dropdown's onChange would give", () => {
+    const changes = renderSelect(["Draft", "Review", "Published"], { value: "Draft" });
+    fireEvent.click(screen.getByRole("radio", { name: "Review" }));
+    expect(changes).toEqual(["Review"]);
+  });
+
+  test("group has an accessible name and the selected segment is aria-checked", () => {
+    renderSelect(["Draft", "Review", "Published"], { value: "Review" });
+    expect(screen.getByRole("radiogroup", { name: "Status" })).toBeTruthy();
+    expect(screen.getByRole("radio", { name: "Review" }).getAttribute("aria-checked")).toBe("true");
+    expect(screen.getByRole("radio", { name: "Draft" }).getAttribute("aria-checked")).toBe("false");
+  });
+
+  test("disabled prevents selection", () => {
+    const changes = renderSelect(["Draft", "Review", "Published"], {
+      value: "Draft",
+      disabled: true,
+    });
+    const review = screen.getByRole("radio", { name: "Review" });
+    expect((review as HTMLButtonElement).disabled).toBe(true);
+    fireEvent.click(review);
+    expect(changes).toEqual([]);
+  });
+});