@cosmicdrift/kumiko-renderer-web 0.205.0 → 0.206.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer-web",
-  "version": "0.205.0",
+  "version": "0.206.0",
   "description": "Web-platform bindings for @cosmicdrift/kumiko-renderer. HTML default-primitives, browser history-based navigation, EventSource-backed live events, and a one-call createKumikoApp that mounts the whole stack via react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -16,9 +16,9 @@
     "./styles.css": "./src/styles.css"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.205.0",
-    "@cosmicdrift/kumiko-headless": "0.205.0",
-    "@cosmicdrift/kumiko-renderer": "0.205.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.206.0",
+    "@cosmicdrift/kumiko-headless": "0.206.0",
+    "@cosmicdrift/kumiko-renderer": "0.206.0",
     "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.16",
     "@radix-ui/react-label": "^2.1.8",

package/src/__tests__/create-app.test.tsx

@@ -4,6 +4,7 @@ import type {
   EntityDefinition,
   EntityEditScreenDefinition,
   EntityListScreenDefinition,
+  ScreenDefinition,
 } from "@cosmicdrift/kumiko-framework/ui-types";
 import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
 import type {
@@ -14,7 +15,7 @@ import type {
   NavApi,
 } from "@cosmicdrift/kumiko-renderer";
 import { createStaticLocaleResolver, useContentEditor } from "@cosmicdrift/kumiko-renderer";
-import { act, screen, waitFor } from "@testing-library/react";
+import { act, fireEvent, screen, waitFor } from "@testing-library/react";
 import type { ReactNode } from "react";
 import type { ClientFeatureDefinition } from "../app/client-plugin";
 import { type CreateKumikoAppOptions, createKumikoApp } from "../app/create-app";
@@ -594,4 +595,92 @@ describe("createKumikoApp", () => {
     // Und definitiv NICHT der Edit-Screen (der wäre die Default-Landing).
     expect(screen.queryByTestId("render-edit-form")).toBeNull();
   });
+
+  // fw#2164: default row-click target. A screen declaring `detailFor` for the
+  // entity is the "Akte" — the click should land there without anyone
+  // wiring rowActions/onRowClick, and it should win over both of the old
+  // defaults (entityEdit-search, app-wide onRowClick).
+  describe("default row click (fw#2164)", () => {
+    const taskDetailScreen: ScreenDefinition = {
+      id: "task-detail",
+      type: "custom",
+      detailFor: "task",
+      renderer: { react: { __component: "TaskDetail" } },
+    };
+
+    function TaskDetailStub(): ReactNode {
+      return <span data-testid="task-detail-mounted" />;
+    }
+
+    function makeRowDispatcher(): Dispatcher {
+      return createMockDispatcher({
+        query: (async () => ({
+          isSuccess: true,
+          data: { rows: [{ id: "r1", title: "Alpha" }], nextCursor: null },
+        })) as unknown as Dispatcher["query"],
+      });
+    }
+
+    test("declared detailFor screen wins over the entityEdit-search fallback", async () => {
+      window.history.replaceState(null, "", "/task-list");
+      mountRoot();
+      const schema: FeatureSchema = {
+        featureName: "tasks",
+        entities: { task: taskEntity },
+        screens: [editScreen, listScreen, taskDetailScreen],
+      };
+      await mountApp({
+        schema,
+        dispatcher: makeRowDispatcher(),
+        screenQn: "tasks:screen:task-list",
+        clientFeatures: [{ name: "tasks", components: { "task-detail": TaskDetailStub } }],
+      });
+      await waitFor(() => expect(screen.getByTestId("row-r1")).toBeTruthy());
+
+      fireEvent.click(screen.getByTestId("row-r1"));
+
+      await waitFor(() => expect(window.location.pathname).toBe("/task-detail/r1"));
+      expect(await screen.findByTestId("task-detail-mounted")).toBeTruthy();
+    });
+
+    test("no detailFor screen → unchanged fallback to the entity's entityEdit screen", async () => {
+      window.history.replaceState(null, "", "/task-list");
+      mountRoot();
+      await mountApp({
+        schema: baseSchema,
+        dispatcher: makeRowDispatcher(),
+        screenQn: "tasks:screen:task-list",
+      });
+      await waitFor(() => expect(screen.getByTestId("row-r1")).toBeTruthy());
+
+      fireEvent.click(screen.getByTestId("row-r1"));
+
+      await waitFor(() => expect(window.location.pathname).toBe("/task-edit/r1"));
+    });
+
+    test("declared detailFor screen wins even over an app-wide onRowClick option", async () => {
+      window.history.replaceState(null, "", "/task-list");
+      mountRoot();
+      const schema: FeatureSchema = {
+        featureName: "tasks",
+        entities: { task: taskEntity },
+        screens: [listScreen, taskDetailScreen],
+      };
+      const onRowClick = () => {
+        throw new Error("onRowClick must not fire when a detailFor screen resolves");
+      };
+      await mountApp({
+        schema,
+        dispatcher: makeRowDispatcher(),
+        screenQn: "tasks:screen:task-list",
+        onRowClick,
+        clientFeatures: [{ name: "tasks", components: { "task-detail": TaskDetailStub } }],
+      });
+      await waitFor(() => expect(screen.getByTestId("row-r1")).toBeTruthy());
+
+      fireEvent.click(screen.getByTestId("row-r1"));
+
+      await waitFor(() => expect(window.location.pathname).toBe("/task-detail/r1"));
+    });
+  });
 });

package/src/app/create-app.tsx

@@ -19,6 +19,7 @@ import {
   DraftStorageProvider,
   ExtensionSectionsProvider,
   type FeatureSchema,
+  hasDetailScreen,
   KumikoScreen,
   kumikoDefaultTranslations,
   LiveEventsProvider,
@@ -143,6 +144,8 @@ export type CreateKumikoAppOptions = {
   readonly draftStorage?: DraftStorage;
   readonly screenQn?: string;
   readonly translate?: Translate;
+  /** Row-click fallback for entities with no declared `detailFor` screen
+   *  (fw#2164) — a `detailFor` screen always wins over this option. */
   readonly onRowClick?: (row: ListRowViewModel, entityName: string) => void;
   /** App-Shell. Bekommt das resolved `schema` als Prop — so können
    *  AppShell-Komponenten an WorkspaceShell/DefaultAppShell durchreichen
@@ -568,19 +571,31 @@ function RoutedScreen({
   const effectiveOnRowClick = useMemo<
     ((row: ListRowViewModel, entityName: string) => void) | undefined
   >(() => {
-    if (onRowClick !== undefined) return onRowClick;
     return (row, entityName) => {
-      // Search for the edit screen for the entity across all features —
-      // in a single-feature setup that's the same feature as the active
-      // one, in multi-feature the edit could theoretically live in a
-      // different feature (one that shares the entity).
+      // Precedence (fw#2164): detailFor screen, then onRowClick, then the
+      // entityEdit-search fallback below. An explicit rowActions
+      // rowClick:true already wins over all of this — kumiko-screen.tsx
+      // handles it before onRowClick is ever called.
+      if (hasDetailScreen(app.features, entityName)) {
+        nav.navigate({ entity: entityName, id: row.id });
+        return;
+      }
+      if (onRowClick !== undefined) {
+        onRowClick(row, entityName);
+        return;
+      }
+      // No declared detail screen and no app-wide onRowClick — search for
+      // the edit screen for the entity across all features — in a
+      // single-feature setup that's the same feature as the active one, in
+      // multi-feature the edit could theoretically live in a different
+      // feature (one that shares the entity).
       for (const f of app.features) {
         const editScreen = f.screens.find(
           (s) => s.type === "entityEdit" && s.entity === entityName,
         );
         if (editScreen) {
-          // editScreen.id is QN form (registry-stamped); nav.navigate
-          // expects the short form. Otherwise the URL gets double-qualified.
+          // editScreen.id is already short form; lastSegment is a no-op
+          // safety net here, kept for symmetry with the other call sites.
           nav.navigate({ screenId: lastSegment(editScreen.id), entityId: row.id });
           return;
         }