@cosmicdrift/kumiko-renderer-web 0.173.0 → 0.174.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer-web",
-  "version": "0.173.0",
+  "version": "0.174.0",
   "description": "Web-platform bindings for @cosmicdrift/kumiko-renderer. HTML default-primitives, browser history-based navigation, EventSource-backed live events, and a one-call createKumikoApp that mounts the whole stack via react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -16,9 +16,9 @@
     "./styles.css": "./src/styles.css"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.173.0",
-    "@cosmicdrift/kumiko-headless": "0.173.0",
-    "@cosmicdrift/kumiko-renderer": "0.173.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.174.0",
+    "@cosmicdrift/kumiko-headless": "0.174.0",
+    "@cosmicdrift/kumiko-renderer": "0.174.0",
     "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.16",
     "@radix-ui/react-label": "^2.1.8",

package/src/__tests__/primitives.test.tsx

@@ -9,7 +9,7 @@
 
 import { describe, expect, mock, test } from "bun:test";
 import userEvent from "@testing-library/user-event";
-import { defaultPrimitives } from "../primitives";
+import { defaultPrimitives, END_LABEL_MIN_ROWS } from "../primitives";
 import { PageSection, Stack } from "../primitives/layout";
 import { fireEvent, render, screen } from "./test-utils";
 
@@ -483,6 +483,8 @@ describe("DataTable", () => {
       id: `r${i}`,
       values: { name: `A${i}` },
     }));
+    const rowsOfCount = (n: number) =>
+      Array.from({ length: n }, (_, i) => ({ id: `r${i}`, values: { name: `A${i}` } }));
 
     test("ohne onReachEnd: kein Sentinel im DOM", () => {
       render(<DataTable columns={cols} rows={oneRow} testId="dt" />);
@@ -551,6 +553,34 @@ describe("DataTable", () => {
       expect(screen.getByTestId("dt-sentinel").textContent).toBe("");
     });
 
+    test(`hasMore=false + ${END_LABEL_MIN_ROWS - 1} Zeilen: kein End-Marker (Grenzfall unter Threshold)`, () => {
+      render(
+        <DataTable
+          columns={cols}
+          rows={rowsOfCount(END_LABEL_MIN_ROWS - 1)}
+          testId="dt"
+          onReachEnd={mock()}
+          loadingMore={false}
+          hasMore={false}
+        />,
+      );
+      expect(screen.queryByTestId("dt-sentinel-end")).toBeNull();
+    });
+
+    test(`hasMore=false + ${END_LABEL_MIN_ROWS} Zeilen: End-Marker (Grenzfall auf Threshold)`, () => {
+      render(
+        <DataTable
+          columns={cols}
+          rows={rowsOfCount(END_LABEL_MIN_ROWS)}
+          testId="dt"
+          onReachEnd={mock()}
+          loadingMore={false}
+          hasMore={false}
+        />,
+      );
+      expect(screen.getByTestId("dt-sentinel-end")).not.toBeNull();
+    });
+
     test("hasMore=false + de-Locale: Marker kommt aus i18n statt hartcodiert", async () => {
       const { LocaleProvider, createStaticLocaleResolver, kumikoDefaultTranslations } =
         await import("@cosmicdrift/kumiko-renderer");

package/src/__tests__/reference-create.test.tsx

@@ -178,4 +178,71 @@ describe("Reference-field create-in-place (#1681)", () => {
     expect(dispatcher.writes).toHaveLength(0);
     expect(screen.getByTestId("combobox-kumiko-edit-assignee").textContent).not.toContain("widget");
   });
+
+  // The three negative gates that decide whether the "+ Create" footer
+  // renders at all (render-field.tsx ReferenceInput.canCreate). A regression
+  // here silently shows a create button the server would reject.
+  describe("create-footer gates: no combobox-*-create in the DOM", () => {
+    test("allowCreate: false on the target screen", async () => {
+      const noCreateSchema: FeatureSchema = {
+        ...catalogSchema,
+        screens: [{ ...widgetCreateScreen, allowCreate: false }],
+      };
+      render(
+        <AppFeaturesProvider features={[tasksSchema, noCreateSchema]}>
+          <DispatcherProvider dispatcher={makeDispatcher()}>
+            <KumikoScreen schema={tasksSchema} qn="tasks:screen:task-edit" />
+          </DispatcherProvider>
+        </AppFeaturesProvider>,
+      );
+      await waitFor(() => screen.getByTestId("render-edit-form"));
+      await userEvent.setup().click(screen.getByTestId("combobox-kumiko-edit-assignee"));
+      expect(screen.queryByTestId("combobox-kumiko-edit-assignee-create")).toBeNull();
+    });
+
+    test("target screen gated by a role the user doesn't have (no UserRolesProvider mounted)", async () => {
+      const roleGatedSchema: FeatureSchema = {
+        ...catalogSchema,
+        screens: [{ ...widgetCreateScreen, access: { roles: ["Admin"] } }],
+      };
+      render(
+        <AppFeaturesProvider features={[tasksSchema, roleGatedSchema]}>
+          <DispatcherProvider dispatcher={makeDispatcher()}>
+            <KumikoScreen schema={tasksSchema} qn="tasks:screen:task-edit" />
+          </DispatcherProvider>
+        </AppFeaturesProvider>,
+      );
+      await waitFor(() => screen.getByTestId("render-edit-form"));
+      await userEvent.setup().click(screen.getByTestId("combobox-kumiko-edit-assignee"));
+      expect(screen.queryByTestId("combobox-kumiko-edit-assignee-create")).toBeNull();
+    });
+
+    test("field.readOnly on the reference field itself", async () => {
+      const readOnlySchema: FeatureSchema = {
+        ...tasksSchema,
+        screens: [
+          {
+            ...taskEditScreen,
+            layout: {
+              sections: [
+                {
+                  title: "Basics",
+                  fields: ["title", { field: "assignee", readOnly: true }, "tags"],
+                },
+              ],
+            },
+          },
+        ],
+      };
+      render(
+        <AppFeaturesProvider features={[readOnlySchema, catalogSchema]}>
+          <DispatcherProvider dispatcher={makeDispatcher()}>
+            <KumikoScreen schema={readOnlySchema} qn="tasks:screen:task-edit" />
+          </DispatcherProvider>
+        </AppFeaturesProvider>,
+      );
+      await waitFor(() => screen.getByTestId("render-edit-form"));
+      expect(screen.queryByTestId("combobox-kumiko-edit-assignee-create")).toBeNull();
+    });
+  });
 });

package/src/__tests__/workspace-shell.test.tsx

@@ -443,6 +443,23 @@ describe("WorkspaceShell", () => {
     expect(innerMain?.classList.contains("flex-1")).toBe(true);
     expect(innerMain?.classList.contains("overflow-auto")).toBe(true);
   });
+
+  // #1692: default (no fill) must not force viewport-lock classes
+  test("without fill does not apply h-svh or min-h-0", () => {
+    renderShell(
+      <WorkspaceShell
+        brand={<div>Brand</div>}
+        schema={schema}
+        user={{ id: "u1", roles: ["admin"] }}
+      >
+        <div>content</div>
+      </WorkspaceShell>,
+    );
+    const root = document.querySelector('[data-slot="sidebar-wrapper"]');
+    expect(root?.classList.contains("h-svh")).toBe(false);
+    const inset = document.querySelector('[data-slot="sidebar-inset"]');
+    expect(inset?.classList.contains("min-h-0")).toBe(false);
+  });
 });
 
 // ---------------------------------------------------------------------------

package/src/primitives/__tests__/date-parse.test.ts

@@ -36,6 +36,17 @@ describe("parseIso", () => {
     expect(parseIso("0026-04-25")).toBeUndefined();
     expect(parseIso("26-04-25")).toBeUndefined();
   });
+
+  test("year above 9999 → undefined (Temporal.toString() would switch to signed extended ISO)", () => {
+    expect(parseIso("10000-04-25")).toBeUndefined();
+    expect(parseIso("999999-04-25")).toBeUndefined();
+  });
+
+  test("year 9999 is still accepted (upper boundary)", () => {
+    const d = parseIso("9999-04-25");
+    expect(d).toBeDefined();
+    expect(toIso(d as Temporal.PlainDate)).toBe("9999-04-25");
+  });
 });
 
 describe("toIso", () => {
@@ -80,6 +91,10 @@ describe("parseTypedDate", () => {
     if (d !== undefined) expect(toIso(d)).toBe("2026-04-25");
   });
 
+  test("six-digit year → undefined, not a signed extended-ISO wire value", () => {
+    expect(parseTypedDate("25.04.999999", "de-DE")).toBeUndefined();
+  });
+
   test("partial/invalid input → undefined", () => {
     expect(parseTypedDate("", "de-DE")).toBeUndefined();
     expect(parseTypedDate("25.04", "de-DE")).toBeUndefined();
@@ -108,4 +123,15 @@ describe("formatDateForInput", () => {
     expect(roundtrip).toBeDefined();
     if (roundtrip !== undefined) expect(toIso(roundtrip)).toBe("2026-04-25");
   });
+
+  // #1659: y/m/d locale branch of localeDateOrder (ISO-like)
+  test("ja-JP locale (y/m/d order), re-parseable", () => {
+    const formatted = formatDateForInput(
+      Temporal.PlainDate.from({ year: 2026, month: 4, day: 25 }),
+      "ja-JP",
+    );
+    const roundtrip = parseTypedDate(formatted, "ja-JP");
+    expect(roundtrip).toBeDefined();
+    if (roundtrip !== undefined) expect(toIso(roundtrip)).toBe("2026-04-25");
+  });
 });

package/src/primitives/date-parse.ts

@@ -37,7 +37,11 @@ export function parseIso(v: string): Temporal.PlainDate | undefined {
     Number.isNaN(d) ||
     // Reject 2-digit years — matches the pre-PlainDate behavior where
     // `new Date`'s 1900+y quirk made a round-trip check fail on them.
-    y < 100
+    y < 100 ||
+    // Reject years outside 0000-9999 — Temporal.toString() switches to the
+    // signed extended ISO format above that range (e.g. "+010000-04-25"),
+    // breaking the "unchanged ISO string" wire contract (toIso below).
+    y > 9999
   ) {
     return undefined;
   }
@@ -106,6 +110,7 @@ export function parseTypedDate(input: string, locale: string): Temporal.PlainDat
     else d = val;
   });
   if (y < 100) y += 2000;
+  if (y > 9999) return undefined;
 
   return makePlainDate(y, m, d);
 }

package/src/primitives/index.tsx

@@ -1020,7 +1020,7 @@ function RowActionsKebab({
 // Server-Side-Render, kein observer wenn hasMore=false — dann zeigt
 // der Sentinel nur den End-of-list-Hinweis.
 // ponytail: Short lists do not need an end marker.
-const END_LABEL_MIN_ROWS = 20;
+export const END_LABEL_MIN_ROWS = 20;
 
 function InfiniteSentinel({
   onReachEnd,