@cosmicdrift/kumiko-renderer-web 0.156.0 → 0.156.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer-web",
-  "version": "0.156.0",
+  "version": "0.156.1",
   "description": "Web-platform bindings for @cosmicdrift/kumiko-renderer. HTML default-primitives, browser history-based navigation, EventSource-backed live events, and a one-call createKumikoApp that mounts the whole stack via react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -16,9 +16,9 @@
     "./styles.css": "./src/styles.css"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.156.0",
-    "@cosmicdrift/kumiko-headless": "0.156.0",
-    "@cosmicdrift/kumiko-renderer": "0.156.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.156.1",
+    "@cosmicdrift/kumiko-headless": "0.156.1",
+    "@cosmicdrift/kumiko-renderer": "0.156.1",
     "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.16",
     "@radix-ui/react-label": "^2.1.8",

package/src/__tests__/create-app.test.tsx

@@ -6,7 +6,12 @@ import type {
   EntityListScreenDefinition,
 } from "@cosmicdrift/kumiko-framework/ui-types";
 import type { Dispatcher } from "@cosmicdrift/kumiko-headless";
-import type { ColumnRendererProps, FeatureSchema, NavApi } from "@cosmicdrift/kumiko-renderer";
+import type {
+  AppSchema,
+  ColumnRendererProps,
+  FeatureSchema,
+  NavApi,
+} from "@cosmicdrift/kumiko-renderer";
 import { createStaticLocaleResolver } from "@cosmicdrift/kumiko-renderer";
 import { act, screen, waitFor } from "@testing-library/react";
 import type { ReactNode } from "react";
@@ -150,6 +155,54 @@ describe("createKumikoApp", () => {
     );
   });
 
+  test("fallback screen skips access-restricted screens across features (#1176)", async () => {
+    mountRoot();
+    const restrictedFeature: FeatureSchema = {
+      featureName: "user",
+      entities: { task: taskEntity },
+      screens: [{ ...listScreen, id: "user-list", access: { roles: ["SystemAdmin"] } }],
+    };
+    const openFeature: FeatureSchema = { ...baseSchema, featureName: "tasks" };
+    const schema: AppSchema = { features: [restrictedFeature, openFeature] };
+    await mountApp({ schema, dispatcher: makeDispatcher() });
+    // Landing on user-list (SystemAdmin-only) would show an access-denied
+    // banner instead — the tasks:task-edit form must win instead.
+    await waitFor(() => expect(screen.getByTestId("render-edit-form")).toBeTruthy());
+  });
+
+  test("fallback screen: an openToAll screen counts as accessible", async () => {
+    mountRoot();
+    const restrictedFeature: FeatureSchema = {
+      featureName: "user",
+      entities: { task: taskEntity },
+      screens: [{ ...editScreen, id: "user-edit", access: { roles: ["SystemAdmin"] } }],
+    };
+    const openFeature: FeatureSchema = {
+      featureName: "tasks",
+      entities: { task: taskEntity },
+      screens: [{ ...listScreen, access: { openToAll: true } }],
+    };
+    const schema: AppSchema = { features: [restrictedFeature, openFeature] };
+    await mountApp({ schema, dispatcher: makeDispatcher() });
+    expect(await screen.findByTestId("render-list-table-empty")).toBeTruthy();
+  });
+
+  test("all screens access-restricted → throws (no accessible fallback)", () => {
+    mountRoot();
+    const restrictedOnly: AppSchema = {
+      features: [
+        {
+          featureName: "user",
+          entities: { task: taskEntity },
+          screens: [{ ...editScreen, access: { roles: ["SystemAdmin"] } }],
+        },
+      ],
+    };
+    expect(() => createKumikoApp({ schema: restrictedOnly, dispatcher: makeDispatcher() })).toThrow(
+      /no screens/,
+    );
+  });
+
   test("clientFeatures.columnRenderers → bei Key-Kollision warnt + last-wins gewinnt", async () => {
     // Zwei Features liefern denselben Renderer-Key — der Merge in
     // create-app warnt und behält den späteren Eintrag (Last-Wins).

package/src/app/create-app.tsx

@@ -129,6 +129,22 @@ function readInjectedSchema(): AppSchema | FeatureSchema | undefined {
   return w.__KUMIKO_SCHEMA__;
 }
 
+// Erstes Screen über alle Features in deklarierter Reihenfolge, dessen
+// `access` niemanden ausschließt (undefined oder openToAll). Die Landing-
+// Route wird VOR Auth-Resolution gewählt, kennt also keine User-Rollen —
+// ein role-restricted Screen (z.B. bundled user/tenant, SystemAdmin-only)
+// darf hier nie gewinnen, sonst landet jeder Nicht-Admin auf einem
+// Access-Denied-Screen (#1176).
+function firstOpenScreenQn(features: readonly FeatureSchema[]): string | undefined {
+  for (const feature of features) {
+    const openScreen = feature.screens.find(
+      (s) => s.access === undefined || "openToAll" in s.access,
+    );
+    if (openScreen !== undefined) return qualifyScreenId(feature.featureName, openScreen.id);
+  }
+  return undefined;
+}
+
 export function createKumikoApp(options: CreateKumikoAppOptions = {}): { readonly root: Root } {
   const rootId = options.rootId ?? "root";
   const container = document.getElementById(rootId);
@@ -154,19 +170,11 @@ export function createKumikoApp(options: CreateKumikoAppOptions = {}): { readonl
   }
   const app = toAppSchema(rawSchema);
 
-  // Fallback-Screen: erstes Screen über alle Features in deklarierter
-  // Reihenfolge. War vorher schema.screens[0], jetzt search the first
-  // feature with screens.
-  const firstFeatureWithScreens = app.features.find((f) => f.screens.length > 0);
-  const firstScreen = firstFeatureWithScreens?.screens[0];
-  const fallbackQn =
-    options.screenQn ??
-    (firstScreen !== undefined && firstFeatureWithScreens !== undefined
-      ? qualifyScreenId(firstFeatureWithScreens.featureName, firstScreen.id)
-      : undefined);
+  // Fallback-Screen falls kein explizites screenQn übergeben wurde.
+  const fallbackQn = options.screenQn ?? firstOpenScreenQn(app.features);
   if (!fallbackQn) {
     throw new Error(
-      "createKumikoApp: schema contains no screens. Add at least one entry to `schema.screens` or pass `screenQn` explicitly.",
+      "createKumikoApp: schema contains no screens accessible without a role restriction. Add at least one entry to `schema.screens` without `access.roles`, or pass `screenQn` explicitly.",
     );
   }