@cosmicdrift/kumiko-renderer-web 0.155.0 → 0.156.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-renderer-web",
-  "version": "0.155.0",
+  "version": "0.156.0",
   "description": "Web-platform bindings for @cosmicdrift/kumiko-renderer. HTML default-primitives, browser history-based navigation, EventSource-backed live events, and a one-call createKumikoApp that mounts the whole stack via react-dom.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -16,9 +16,9 @@
     "./styles.css": "./src/styles.css"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.155.0",
-    "@cosmicdrift/kumiko-headless": "0.155.0",
-    "@cosmicdrift/kumiko-renderer": "0.155.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.156.0",
+    "@cosmicdrift/kumiko-headless": "0.156.0",
+    "@cosmicdrift/kumiko-renderer": "0.156.0",
     "@radix-ui/react-dialog": "^1.1.15",
     "@radix-ui/react-dropdown-menu": "^2.1.16",
     "@radix-ui/react-label": "^2.1.8",

package/src/__tests__/kumiko-screen.test.tsx

@@ -314,6 +314,68 @@ describe("KumikoScreen", () => {
     expect(screen.queryByTestId("render-edit-delete")).toBeNull();
   });
 
+  // Issue #912 — Copy-Link-Action. KumikoScreen threads an already-bound
+  // onCopyLink callback down to RenderEdit (the actual URL-build/clipboard
+  // impl lives in renderer-web's RoutedScreen, outside this test — here we
+  // only verify the wiring: button renders in update-mode, fires the
+  // callback, and shows the "copied" label afterwards).
+  test("entityEdit update-mode: Copy-Link-Button feuert onCopyLink + zeigt 'copied'-Label", async () => {
+    const user = userEvent.setup();
+    const onCopyLink = mock(() => Promise.resolve());
+    const dispatcher = makeDispatcher({
+      query: (async () => ({
+        isSuccess: true,
+        data: { id: "task-1", version: 1, title: "loaded", count: 3, done: false },
+      })) as unknown as Dispatcher["query"],
+    });
+    render(
+      <DispatcherProvider dispatcher={dispatcher}>
+        <KumikoScreen
+          schema={schema}
+          qn="tasks:screen:task-edit"
+          entityId="task-1"
+          onCopyLink={onCopyLink}
+        />
+      </DispatcherProvider>,
+    );
+    await waitFor(() => expect(screen.queryByTestId("kumiko-screen-loading")).toBeNull());
+
+    const button = screen.getByTestId("render-edit-copy-link");
+    expect(button.textContent).toBe("Copy link");
+    await user.click(button);
+    expect(onCopyLink).toHaveBeenCalledTimes(1);
+    await waitFor(() => expect(button.textContent).toBe("Copied!"));
+  });
+
+  test("entityEdit create-mode: kein Copy-Link-Button (keine entity-id → kein Permalink)", () => {
+    render(
+      <DispatcherProvider dispatcher={makeDispatcher()}>
+        <KumikoScreen
+          schema={schema}
+          qn="tasks:screen:task-edit"
+          onCopyLink={() => Promise.resolve()}
+        />
+      </DispatcherProvider>,
+    );
+    expect(screen.queryByTestId("render-edit-copy-link")).toBeNull();
+  });
+
+  test("entityEdit update-mode ohne onCopyLink-Prop: kein Copy-Link-Button", async () => {
+    const dispatcher = makeDispatcher({
+      query: (async () => ({
+        isSuccess: true,
+        data: { id: "task-1", version: 1, title: "loaded", count: 3, done: false },
+      })) as unknown as Dispatcher["query"],
+    });
+    render(
+      <DispatcherProvider dispatcher={dispatcher}>
+        <KumikoScreen schema={schema} qn="tasks:screen:task-edit" entityId="task-1" />
+      </DispatcherProvider>,
+    );
+    await waitFor(() => expect(screen.queryByTestId("kumiko-screen-loading")).toBeNull());
+    expect(screen.queryByTestId("render-edit-copy-link")).toBeNull();
+  });
+
   test("entityEdit update-mode: version_conflict → Banner + 'Neu laden' triggert detail-refetch", async () => {
     let detailCalls = 0;
     const dispatcher = makeDispatcher({

package/src/app/browser-locale.ts

@@ -67,7 +67,7 @@ export function createBrowserLocaleResolver(
     timeZone: () => timeZone,
     subscribe: store.subscribe,
     setLocale: (next) => {
-      // Early-Return so we don't write localStorage on a no-op. Store's
+      // skip: locale unchanged, avoid redundant localStorage write
       // own Object.is-Gate would already block listener notification,
       // but the persistence side-effect lives outside the store.
       if (next === store.getSnapshot()) return;

package/src/app/create-app.tsx

@@ -455,6 +455,25 @@ function RoutedScreen({
     };
   }, [onRowClick, app.features, nav]);
 
+  // Copy-Link-Action (Issue #912) für entityEdit-Update-Screens. Baut die
+  // absolute Permalink-URL aus der aktuellen Route + kopiert sie —
+  // `navigator`/`window` sind hier erlaubt (renderer-web, kein
+  // platform-neutrales Package). Kein Button ohne entityId (create-mode).
+  // Silent-catch bei Clipboard-Fehler (non-secure context) mirrort das
+  // bestehende Muster in pat-tokens-screen.tsx.
+  const effectiveOnCopyLink = useMemo<(() => Promise<void> | void) | undefined>(() => {
+    const route = nav.route;
+    if (route?.entityId === undefined) return undefined;
+    return async () => {
+      const url = `${window.location.origin}${nav.hrefFor(route)}`;
+      try {
+        await navigator.clipboard.writeText(url);
+      } catch {
+        // clipboard blocked (non-secure context) — no fallback UI needed here
+      }
+    };
+  }, [nav]);
+
   // KumikoScreen will nach wie vor ein single-feature schema. Wir
   // füttern es mit dem owning Feature — es enthält Entity-Defs +
   // Screen-Defs für den aktiven Render-Pfad. Kein Owner gefunden → wir
@@ -474,6 +493,7 @@ function RoutedScreen({
       {...(translate !== undefined && { translate })}
       {...(entityId !== undefined && { entityId })}
       onRowClick={effectiveOnRowClick}
+      {...(effectiveOnCopyLink !== undefined && { onCopyLink: effectiveOnCopyLink })}
     />
   );
 }

package/src/layout/__tests__/nav-registry.test.ts

@@ -128,6 +128,25 @@ describe("buildNavRegistrySliceForApp", () => {
     expect(slice.topLevel[0]?.access).toEqual({ roles: ["Admin", "Editor"] });
   });
 
+  test("nav ohne eigene access bleibt ohne access, wenn der Ziel-Screen offen ist (kein Verstecken eines openToAll-Screens)", () => {
+    const app: AppSchema = {
+      features: [
+        featureWithScreens(
+          [{ id: "pub", label: "Pub", screen: "pub" }],
+          [
+            {
+              id: "pub",
+              type: "custom",
+              renderer: { react: { __component: "Pub" } },
+            },
+          ],
+        ),
+      ],
+    };
+    const slice = buildNavRegistrySliceForApp(app);
+    expect(slice.topLevel[0]?.access).toBeUndefined();
+  });
+
   test("nav ohne screen bleibt ohne access (nichts zum Erben da)", () => {
     const app: AppSchema = {
       features: [feature([{ id: "group", label: "Group" }])],

package/src/sse/live-events.ts

@@ -41,7 +41,7 @@ export function createEventSourceLiveEvents(
     try {
       parsed = JSON.parse(raw) as LiveEvent["data"];
     } catch {
-      // Malformed payload — drop it. Besser als einen fangenden Listener
+      // skip: malformed SSE payload, drop it rather than crash all subscribers
       // zu crashen und alle anderen subscribers mitzureißen.
       return;
     }
@@ -52,12 +52,15 @@ export function createEventSourceLiveEvents(
   };
 
   const ensureConnected = (): void => {
+    // skip: EventSource already connected
     if (source !== undefined) return;
+    // skip: no window/EventSource available (SSR/non-browser), nothing to connect
     if (typeof window === "undefined" || typeof EventSource === "undefined") return;
     source = new EventSource(url);
   };
 
   const ensureListenersForEntity = (entityName: string): void => {
+    // skip: not connected yet, listeners get wired once ensureConnected runs
     if (source === undefined) return;
     for (const verb of VERBS) {
       const type = `${entityName}.${verb}`;
@@ -70,7 +73,9 @@ export function createEventSourceLiveEvents(
   };
 
   const closeIfEmpty = (): void => {
+    // skip: subscribers remain, connection still needed
     if (subscribers.size > 0) return;
+    // skip: already closed, nothing to close
     if (source === undefined) return;
     source.close();
     source = undefined;

package/src/tokens.ts

@@ -55,6 +55,7 @@ function persistMode(mode: ThemeMode): void {
  *  in der Host-HTML (siehe Header-Kommentar) macht dasselbe synchron
  *  vor dem ersten Paint. */
 export function applyStoredThemeMode(): void {
+  // skip: no document (SSR/non-DOM context), nothing to apply
   if (typeof document === "undefined") return;
   let stored: string | null = null;
   try {
@@ -63,6 +64,7 @@ export function applyStoredThemeMode(): void {
     // skip: localStorage kann werfen (Private-Mode) — ohne gespeicherte
     // Wahl bleibt der Server-/HTML-Default stehen.
   }
+  // skip: no valid persisted mode stored, keep server/HTML default
   if (stored !== "dark" && stored !== "light") return;
   document.documentElement.classList.toggle("dark", stored === "dark");
   notifyThemeChange();
@@ -99,12 +101,14 @@ export function useBrowserTokensApi(): TokensApi {
     tokens: cssVarTokens,
     mode,
     setMode: (next) => {
+      // skip: no document (SSR/non-DOM context), nothing to toggle
       if (typeof document === "undefined") return;
       document.documentElement.classList.toggle("dark", next === "dark");
       persistMode(next);
       notifyThemeChange();
     },
     toggleMode: () => {
+      // skip: no document (SSR/non-DOM context), nothing to toggle
       if (typeof document === "undefined") return;
       const nowDark = document.documentElement.classList.toggle("dark");
       persistMode(nowDark ? "dark" : "light");