npm - @cosmicdrift/kumiko-headless - Versions diffs - 0.146.4 → 0.147.0 - Mend

@cosmicdrift/kumiko-headless 0.146.4 → 0.147.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

package/package.json +2 -2
package/src/apex/__tests__/lightbox.test.ts +1 -1
package/src/apex/__tests__/render.test.ts +30 -0
package/src/apex/index.ts +17 -11
package/src/apex/lightbox.ts +2 -8
package/src/locale-routing/__tests__/locale-routing.test.ts +24 -0
package/src/locale-routing/index.ts +11 -1

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-headless",
-  "version": "0.146.4",
+  "version": "0.147.0",
   "description": "Headless UI logic for Kumiko — Dispatcher contract, Form-Controller, View-Model, Nav-Resolver. Plattform- und React-frei; jeder Renderer (renderer, renderer-web, renderer-native, …) komponiert darauf.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -36,7 +36,7 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.146.4",
+    "@cosmicdrift/kumiko-framework": "0.147.0",
     "zod": "^4.4.3"
   },
   "publishConfig": {

package/src/apex/__tests__/lightbox.test.ts CHANGED Viewed

@@ -1,6 +1,6 @@
 import { describe, expect, test } from "bun:test";
 import { createHash } from "node:crypto";
-import { APEX_LIGHTBOX_SCRIPT, APEX_LIGHTBOX_SCRIPT_CSP_HASH } from "../lightbox";
+import { APEX_LIGHTBOX_SCRIPT, APEX_LIGHTBOX_SCRIPT_CSP_HASH } from "../index";
 function scriptBody(html: string): string {
   const match = html.match(/^<script>(?<body>[\s\S]*)<\/script>$/);

package/src/apex/__tests__/render.test.ts CHANGED Viewed

@@ -122,6 +122,8 @@ describe("renderApexPage", () => {
     expect(html.indexOf("price-cap")).toBeLessThan(html.indexOf("b1"));
     // featured tier without explicit cta variant → primary button
     expect(html).toContain('class="btn btn-primary" href="/s"');
+    expect(html).not.toContain("btn-link");
   });
   test("cta variant link renders a plain anchor, default renders a button", () => {
@@ -140,6 +142,29 @@ describe("renderApexPage", () => {
     expect(html).toContain('<a class="btn btn-primary" href="/signup">Start</a>');
   });
+  test("pricing-tier cta variant link renders a plain anchor via renderCta, not a btn-link class", () => {
+    const html = renderApexPage(
+      page({
+        sections: [
+          {
+            kind: "pricing-grid",
+            heading: "Preise",
+            tiers: [
+              {
+                name: "Free",
+                amount: "0 €",
+                benefits: ["b1"],
+                cta: { label: "Los", href: "/free", variant: "link" },
+              },
+            ],
+          },
+        ],
+      }),
+    );
+    expect(html).toContain('<a href="/free">Los</a>');
+    expect(html).not.toContain("btn-link");
+  });
   test("footer --footer-cols reflects column count and survives without columns", () => {
     const twoCols = renderApexPage(
       page({
@@ -193,6 +218,11 @@ describe("renderApexPage", () => {
     );
     expect(withRobots).toContain('<meta name="robots" content="noindex, nofollow" />');
   });
+  test("omits both description meta tags when description is empty", () => {
+    const html = renderApexPage(page({ head: { lang: "de", title: "T", description: "" } }));
+    expect(html).not.toContain('<meta name="description"');
+    expect(html).not.toContain('<meta property="og:description"');
+  });
   test("renders og:site_name and og:locale", () => {
     const html = renderApexPage(

package/src/apex/index.ts CHANGED Viewed

@@ -300,21 +300,23 @@ function renderPricingCard(t: ApexPricingTier): string {
   const benefits = t.benefits.map((b) => `<li>${escapeHtml(b)}</li>`);
   const items = [...cap, ...benefits].join("\n            ");
   const per = t.priceSuffix !== undefined ? `<span>${escapeHtml(t.priceSuffix)}</span>` : "";
-  const cls =
-    t.cta.variant !== undefined
-      ? `btn btn-${t.cta.variant}`
-      : featured
-        ? "btn btn-primary"
-        : "btn btn-secondary";
   const tagline =
     t.tagline !== undefined ? `<p class="price-tagline">${escapeHtml(t.tagline)}</p>` : "";
+  // Delegates to renderCta so a `variant: "link"` tier CTA gets the same
+  // class-free anchor as everywhere else instead of re-deriving the class
+  // string here (a prior inline duplicate had no "link" case, always
+  // emitting `.btn-link`, which the structural CSS never defines).
+  const cta =
+    t.cta.variant === undefined
+      ? renderCta({ ...t.cta, variant: featured ? "primary" : "secondary" })
+      : renderCta(t.cta);
   return `<article class="price-card${featured ? " price-card--featured" : ""}">
           ${badge}<h3>${escapeHtml(t.name)}</h3>
           ${tagline}<div class="price-amount">${escapeHtml(t.amount)}${per}</div>
           <ul class="price-list">
             ${items}
           </ul>
-          <a class="${cls}" href="${escapeHtml(t.cta.href)}">${escapeHtml(t.cta.label)}</a>
+          ${cta}
         </article>`;
 }
@@ -509,10 +511,14 @@ export function renderApexHeadTags(head: ApexHead): string {
     head.schemaJson !== undefined
       ? `\n    <script type="application/ld+json">${scriptSafeJsonHtml(head.schemaJson)}</script>`
       : "";
-  return `<title>${escapeHtml(head.title)}</title>
-    <meta name="description" content="${escapeHtml(head.description)}" />
-    <meta property="og:title" content="${escapeHtml(head.title)}" />
-    <meta property="og:description" content="${escapeHtml(head.description)}" />
+  const metaDescription = head.description
+    ? `\n    <meta name="description" content="${escapeHtml(head.description)}" />`
+    : "";
+  const ogDescription = head.description
+    ? `\n    <meta property="og:description" content="${escapeHtml(head.description)}" />`
+    : "";
+  return `<title>${escapeHtml(head.title)}</title>${metaDescription}
+    <meta property="og:title" content="${escapeHtml(head.title)}" />${ogDescription}
     <meta property="og:type" content="website" />${ogUrl}${ogImage}${siteName}${locale}${twitterCard}${twitterSite}${favicon}${canonical}${alternates}${robots}${preconnects}${schema}`;
 }

package/src/apex/lightbox.ts CHANGED Viewed

@@ -45,12 +45,6 @@ const APEX_LIGHTBOX_SCRIPT_BODY = `
 /** ponytail: one delegated listener; no-op when no .shot-frame on the page. */
 export const APEX_LIGHTBOX_SCRIPT = `<script>${APEX_LIGHTBOX_SCRIPT_BODY}</script>`;
-// Apps that enforce `script-src 'self'` without `'unsafe-inline'`/nonce (the
-// apex renderer has no per-request nonce hook — its output is often
-// pre-rendered to static HTML at build time, where a nonce can't work
-// anyway) need a hash-source instead. Add this to your CSP's script-src,
-// e.g. `script-src 'self' 'sha256-...'` (value = this constant).
-// lightbox.test.ts asserts this matches APEX_LIGHTBOX_SCRIPT_BODY byte-for-
-// byte, so an edit to the script that doesn't update the hash fails CI
-// instead of silently breaking every strict-CSP consumer's lightbox.
+// CSP hash-source for the inline script above; apex output is often
+// pre-rendered, so a per-request nonce can't work. Guarded by lightbox.test.ts.
 export const APEX_LIGHTBOX_SCRIPT_CSP_HASH = "sha256-f+hHLpDuQsjmtFZCjdM13D9NaMTCyOKaawAhfLf/X9o=";

package/src/locale-routing/__tests__/locale-routing.test.ts CHANGED Viewed

@@ -92,3 +92,27 @@ describe("createLocaleRouter inverted default (website-style)", () => {
     expect(router.altLocalePath("/de")).toBe("/");
   });
 });
+describe("createLocaleRouter homePage validation", () => {
+  test("throws at construction when homePage has no routes entry", () => {
+    expect(() =>
+      createLocaleRouter({
+        defaultLocale: "de",
+        prefixedLocales: ["en"],
+        routes: { features: { de: "/funktionen", en: "/en/features" } },
+      }),
+    ).toThrow(/homePage/);
+  });
+  test("publicPath throws instead of crashing when page is missing from routes", () => {
+    const router = createLocaleRouter<"home" | "features">({
+      defaultLocale: "de",
+      prefixedLocales: ["en"],
+      routes: { home: { de: "/", en: "/en" } } as unknown as Record<
+        "home" | "features",
+        Record<string, string>
+      >,
+    });
+    expect(() => router.publicPath("features", "de")).toThrow(/no path for page/);
+  });
+});

package/src/locale-routing/index.ts CHANGED Viewed

@@ -53,6 +53,11 @@ export function createLocaleRouter<TPage extends string>(
     homePage = "home" as TPage,
   } = config;
+  if (routes[homePage] === undefined) {
+    throw new Error(
+      `locale-routing: homePage "${String(homePage)}" has no entry in routes — altLocalePath's fallback would throw at request time`,
+    );
+  }
   const pathIndex = new Map<string, { page: TPage; locale: string }>();
   for (const [page, localePaths] of Object.entries(routes) as [TPage, Record<string, string>][]) {
@@ -102,13 +107,18 @@ export function createLocaleRouter<TPage extends string>(
   }
   function publicPath(page: TPage, locale: string): string {
-    const routePath = routes[page][locale];
+    const localePaths = routes[page];
+    const routePath = localePaths?.[locale];
     if (routePath === undefined) {
       throw new Error(`locale-routing: no path for page "${String(page)}" locale "${locale}"`);
     }
     return routePath;
   }
+  // Binary toggle (defaultLocale <-> prefixedLocales[0]) — altLocalePath has
+  // no way to target a specific alt locale beyond the first prefixed one.
+  // Fine for the current bilingual (de/en) setup; a third prefixed locale
+  // needs altLocalePath to take an explicit targetLocale param instead.
   function otherLocale(currentLocale: string): string {
     if (currentLocale === defaultLocale) {
       return prefixedLocales[0] ?? defaultLocale;