@cosmicdrift/kumiko-framework 0.48.0 → 0.48.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.48.0",
+  "version": "0.48.1",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",

package/src/engine/__tests__/feature-manifest.test.ts

@@ -0,0 +1,45 @@
+import { describe, expect, test } from "bun:test";
+import { ConfigScopes } from "../constants";
+import { buildManifestFromRegistry, createRegistry, defineFeature } from "../index";
+
+const boolKey = {
+  type: "boolean",
+  scope: ConfigScopes.system,
+  access: { read: ["anonymous"], write: ["anonymous"] },
+} as const;
+
+describe("buildManifestFromRegistry — deterministic codepoint sort (#330)", () => {
+  // `bZeta` vs `balpha`: localeCompare orders these case-insensitively
+  // (balpha < bZeta), but a codepoint sort puts uppercase 'Z' (U+005A) ahead of
+  // lowercase 'a' (U+0061) — the two comparators DISAGREE. The manifest is
+  // serialized to byte-exact JSON and must not depend on the runner's ICU
+  // locale (macOS-dev vs Linux-CI). This assertion fails the instant anyone
+  // reverts buildManifestFromRegistry to localeCompare. (Feature names skip the
+  // kebab normalization that config/secret short-names go through, so they are
+  // the one place a case-based disagreement survives into the sorted output.)
+  test("features are ordered by codepoint name, not locale", () => {
+    const registry = createRegistry([
+      defineFeature("bZeta", () => {}),
+      defineFeature("balpha", () => {}),
+    ]);
+
+    const manifest = buildManifestFromRegistry(registry, { source: "test" });
+
+    expect(manifest.features.map((f) => f.name)).toEqual(["bZeta", "balpha"]);
+  });
+
+  test("config keys within a feature come out sorted by qualified name", () => {
+    const feature = defineFeature("demo", (r) => {
+      r.config({ keys: { "z-flag": boolKey, "a-flag": boolKey } });
+    });
+    const registry = createRegistry([feature]);
+
+    const manifest = buildManifestFromRegistry(registry, { source: "test" });
+    const demo = manifest.features.find((f) => f.name === "demo");
+
+    expect(demo?.configKeys.map((k) => k.qualifiedName)).toEqual([
+      "demo:config:a-flag",
+      "demo:config:z-flag",
+    ]);
+  });
+});

package/src/engine/feature-manifest.ts

@@ -59,6 +59,13 @@ export type FeatureManifest = {
 
 const CONFIG_SEGMENT = ":config:";
 
+// Codepoint order, not localeCompare: the manifest is serialized to byte-exact
+// JSON, and localeCompare's ordering depends on the runner's ICU locale → drift
+// between macOS-dev and Linux-CI (#330).
+function compareByCodepoint(a: string, b: string): number {
+  return a < b ? -1 : a > b ? 1 : 0;
+}
+
 export type BuildManifestOptions = {
   /** Herkunfts-Beschreibung fürs Manifest (landet 1:1 im JSON). */
   readonly source: string;
@@ -111,8 +118,8 @@ export function buildManifestFromRegistry(
       });
     }
 
-    configKeys.sort((a, b) => a.qualifiedName.localeCompare(b.qualifiedName));
-    secrets.sort((a, b) => a.qualifiedName.localeCompare(b.qualifiedName));
+    configKeys.sort((a, b) => compareByCodepoint(a.qualifiedName, b.qualifiedName));
+    secrets.sort((a, b) => compareByCodepoint(a.qualifiedName, b.qualifiedName));
 
     manifestFeatures.push({
       name: feature.name,
@@ -133,7 +140,7 @@ export function buildManifestFromRegistry(
     });
   }
 
-  manifestFeatures.sort((a, b) => a.name.localeCompare(b.name));
+  manifestFeatures.sort((a, b) => compareByCodepoint(a.name, b.name));
 
   return {
     source: options.source,