@cosmicdrift/kumiko-framework 0.389.0 → 0.390.1

package/src/scripts/codemod/remove-engine-payload-casts.ts

@@ -1,318 +0,0 @@
-#!/usr/bin/env bun
-// remove-engine-payload-casts — executor.detail()/list() now return the entity's own row type
-// (EntityRow<E>), so casts that used to narrow the untyped Record are redundant. This removes
-// `row as T` / `row["f"] as T` / `(await x.detail(...)) as unknown as T` (and the
-// `@cast-boundary` marker of that cast) where the operand derives from an executor read AND
-// the checker says its type is assignable to T. Casts the row type does not satisfy stay and
-// are listed as manual. A file whose rewrite would add type errors is left untouched.
-//
-// Usage:
-//   bun scripts/codemod/remove-engine-payload-casts.ts <targetDir...> [--check | --dry-run | --write] [--no-format]
-//
-// Needs a tsconfig.json at or above the target: the assignability check runs on the real
-// program, so the framework version the app compiles against decides the row type.
-
-import { dirname, resolve } from "node:path";
-import { type AsExpression, Node, Project, type SourceFile, SyntaxKind, ts } from "ts-morph";
-import { type CodemodResult, runCodemodCli } from "./codemod-support.ts";
-
-const CAST_MARKER = "@cast-boundary";
-const EXECUTOR_TYPES_FILE = "/event-store-executor-types.ts";
-const READ_VERBS: ReadonlySet<string> = new Set(["detail", "list"]);
-const READ_CALL_PREFILTER = /\.(detail|list)\(/;
-const CAST_PREFILTER = /\bas\s/;
-const MAX_DERIVATION_DEPTH = 8;
-const MAX_TYPE_TEXT_LENGTH = 120;
-
-const SKIPPED_PATH_SUFFIXES: readonly string[] = [
-  "packages/framework/src/scripts/codemod/remove-engine-payload-casts.ts",
-  "packages/framework/src/__tests__/remove-engine-payload-casts-codemod.test.ts",
-];
-
-interface Edit {
-  readonly start: number;
-  readonly end: number;
-  readonly text: string;
-}
-
-function stripWrappers(node: Node): Node {
-  let current = node;
-  for (;;) {
-    if (Node.isParenthesizedExpression(current) || Node.isNonNullExpression(current)) {
-      current = current.getExpression();
-    } else if (Node.isAwaitExpression(current)) {
-      current = current.getExpression();
-    } else {
-      return current;
-    }
-  }
-}
-
-function isCastTo(node: Node, keyword: SyntaxKind): boolean {
-  return Node.isAsExpression(node) && node.getTypeNode()?.getKind() === keyword;
-}
-
-function isExecutorReadCall(node: Node): boolean {
-  if (!Node.isCallExpression(node)) return false;
-  const callee = node.getExpression();
-  if (!Node.isPropertyAccessExpression(callee) || !READ_VERBS.has(callee.getName())) return false;
-  const declarations = callee.getNameNode().getSymbol()?.getDeclarations() ?? [];
-  return declarations.some((declaration) =>
-    declaration.getSourceFile().getFilePath().endsWith(EXECUTOR_TYPES_FILE),
-  );
-}
-
-// Follows property/element access, `??` / `||` and single-assignment variables back to an
-// executor read. Anything else (parameters, callbacks, reassigned lets) is not recognised.
-function derivesFromExecutorRead(node: Node, depth = 0): boolean {
-  if (depth > MAX_DERIVATION_DEPTH) return false;
-  const current = stripWrappers(node);
-  if (Node.isCallExpression(current)) return isExecutorReadCall(current);
-  if (Node.isPropertyAccessExpression(current) || Node.isElementAccessExpression(current)) {
-    return derivesFromExecutorRead(current.getExpression(), depth + 1);
-  }
-  if (Node.isBinaryExpression(current)) {
-    const operator = current.getOperatorToken().getKind();
-    return (
-      (operator === SyntaxKind.QuestionQuestionToken || operator === SyntaxKind.BarBarToken) &&
-      derivesFromExecutorRead(current.getLeft(), depth + 1)
-    );
-  }
-  if (Node.isIdentifier(current)) {
-    const declarations = current.getDefinitionNodes();
-    const declaration = declarations.length === 1 ? declarations[0] : undefined;
-    if (declaration === undefined || !Node.isVariableDeclaration(declaration)) return false;
-    const initializer = declaration.getInitializer();
-    return initializer !== undefined && derivesFromExecutorRead(initializer, depth + 1);
-  }
-  return false;
-}
-
-function innermostOperand(cast: AsExpression): Node {
-  let operand = cast.getExpression();
-  while (isCastTo(stripParenthesesOnly(operand), SyntaxKind.UnknownKeyword)) {
-    const inner = stripParenthesesOnly(operand);
-    if (!Node.isAsExpression(inner)) break;
-    operand = inner.getExpression();
-  }
-  return operand;
-}
-
-function stripParenthesesOnly(node: Node): Node {
-  let current = node;
-  while (Node.isParenthesizedExpression(current)) current = current.getExpression();
-  return current;
-}
-
-function enclosingStatement(node: Node): Node | undefined {
-  return node.getFirstAncestor((ancestor) => {
-    const parent = ancestor.getParent();
-    return (
-      parent !== undefined &&
-      (Node.isBlock(parent) ||
-        Node.isSourceFile(parent) ||
-        Node.isModuleBlock(parent) ||
-        Node.isCaseClause(parent) ||
-        Node.isDefaultClause(parent))
-    );
-  });
-}
-
-function isRemovableCastKind(cast: AsExpression): boolean {
-  return !isCastTo(cast, SyntaxKind.ConstKeyword);
-}
-
-function remainingCasts(statement: Node, removed: ReadonlySet<Node>): number {
-  return statement
-    .getDescendantsOfKind(SyntaxKind.AsExpression)
-    .filter((candidate) => isRemovableCastKind(candidate) && !removed.has(candidate)).length;
-}
-
-function lineEnd(text: string, from: number): number {
-  const newline = text.indexOf("\n", from);
-  return newline === -1 ? text.length : newline;
-}
-
-// The marker sits as trailing line comment of the cast's line or of the statement's last line,
-// or as its own comment line(s) directly above the statement.
-function markerEdits(source: string, statement: Node, cast: AsExpression): Edit[] {
-  const edits: Edit[] = [];
-  for (const from of new Set([cast.getEnd(), statement.getEnd()])) {
-    const end = lineEnd(source, from);
-    const rest = source.slice(from, end);
-    const commentStart = rest.indexOf("//");
-    if (commentStart === -1 || !rest.slice(commentStart).includes(CAST_MARKER)) continue;
-    const start = from + commentStart;
-    const spaces = /[ \t]*$/.exec(source.slice(0, start))?.[0].length ?? 0;
-    edits.push({ start: start - spaces, end, text: "" });
-  }
-  for (const range of statement.getLeadingCommentRanges()) {
-    if (!range.getText().includes(CAST_MARKER)) continue;
-    const start = source.lastIndexOf("\n", range.getPos() - 1) + 1;
-    const end = source[range.getEnd()] === "\n" ? range.getEnd() + 1 : range.getEnd();
-    edits.push({ start, end, text: "" });
-  }
-  return edits;
-}
-
-function shortTypeText(text: string): string {
-  const oneLine = text.replace(/\s+/g, " ");
-  return oneLine.length <= MAX_TYPE_TEXT_LENGTH
-    ? oneLine
-    : `${oneLine.slice(0, MAX_TYPE_TEXT_LENGTH)}...`;
-}
-
-function applyEdits(source: string, edits: readonly Edit[]): string {
-  const unique = new Map<number, Edit>();
-  for (const edit of edits) unique.set(edit.start, edit);
-  let output = source;
-  for (const edit of [...unique.values()].sort((a, b) => b.start - a.start)) {
-    output = output.slice(0, edit.start) + edit.text + output.slice(edit.end);
-  }
-  return output;
-}
-
-function diagnosticCount(sourceFile: SourceFile): number {
-  return sourceFile.getProject().getProgram().getSemanticDiagnostics(sourceFile).length;
-}
-
-function addsTypeErrors(sourceFile: SourceFile, source: string, output: string): boolean {
-  const errorsBefore = diagnosticCount(sourceFile);
-  sourceFile.replaceWithText(output);
-  const errorsAfter = diagnosticCount(sourceFile);
-  sourceFile.replaceWithText(source);
-  return errorsAfter > errorsBefore;
-}
-
-function markerEditsForTouched(
-  source: string,
-  touchedStatements: ReadonlyMap<Node, readonly AsExpression[]>,
-  removed: ReadonlySet<Node>,
-): Edit[] {
-  const edits: Edit[] = [];
-  for (const [statement, casts] of touchedStatements) {
-    const [first] = casts;
-    if (first !== undefined && remainingCasts(statement, removed) === 0) {
-      edits.push(...markerEdits(source, statement, first));
-    }
-  }
-  return edits;
-}
-
-function skippedForTypeErrors(
-  source: string,
-  rewrites: CodemodResult["rewrites"],
-  manual: CodemodResult["rewrites"],
-): CodemodResult {
-  return {
-    output: source,
-    rewrites: [],
-    manual: [
-      ...manual,
-      ...rewrites.map((site) => ({
-        ...site,
-        description: `${site.description} — skipped: removing it adds type errors in this file`,
-      })),
-    ],
-  };
-}
-
-export function transformEnginePayloadCastsFile(
-  sourceFile: SourceFile,
-  filePath: string,
-): CodemodResult {
-  const source = sourceFile.getFullText();
-  const result: CodemodResult = { output: source, rewrites: [], manual: [] };
-  const rewrites = [...result.rewrites];
-  const manual = [...result.manual];
-  const edits: Edit[] = [];
-  const removed = new Set<Node>();
-  const touchedStatements = new Map<Node, AsExpression[]>();
-
-  for (const cast of sourceFile.getDescendantsOfKind(SyntaxKind.AsExpression)) {
-    const typeNode = cast.getTypeNode();
-    if (typeNode === undefined || !isRemovableCastKind(cast)) continue;
-    if (isCastTo(cast, SyntaxKind.UnknownKeyword)) continue;
-    const operand = innermostOperand(cast);
-    if (!derivesFromExecutorRead(operand)) continue;
-    const line = cast.getStartLineNumber();
-    const operandType = operand.getType();
-    if (!operandType.isAssignableTo(typeNode.getType())) {
-      manual.push({
-        file: filePath,
-        line,
-        description: `cast to ${shortTypeText(typeNode.getText())} kept: ${shortTypeText(operandType.getText(cast))} is not assignable to it`,
-      });
-      continue;
-    }
-    edits.push({ start: cast.getStart(), end: cast.getEnd(), text: operand.getText() });
-    removed.add(cast);
-    // The inner `as unknown` of a double cast disappears with the outer cast.
-    for (const inner of cast.getDescendantsOfKind(SyntaxKind.AsExpression)) removed.add(inner);
-    const statement = enclosingStatement(cast);
-    if (statement !== undefined) {
-      touchedStatements.set(statement, [...(touchedStatements.get(statement) ?? []), cast]);
-    }
-    rewrites.push({
-      file: filePath,
-      line,
-      description: `removed cast to ${shortTypeText(typeNode.getText())}, the executor row type already satisfies it`,
-    });
-  }
-
-  edits.push(...markerEditsForTouched(source, touchedStatements, removed));
-
-  if (edits.length === 0) return { output: source, rewrites, manual };
-
-  const output = applyEdits(source, edits);
-  if (addsTypeErrors(sourceFile, source, output)) {
-    return skippedForTypeErrors(source, rewrites, manual);
-  }
-  return { output, rewrites, manual };
-}
-
-const projectsByTsconfig = new Map<string, Project>();
-
-function projectFor(filePath: string): Project | undefined {
-  const tsconfig = ts.findConfigFile(dirname(resolve(filePath)), ts.sys.fileExists);
-  if (tsconfig === undefined) return undefined;
-  const cached = projectsByTsconfig.get(tsconfig);
-  if (cached !== undefined) return cached;
-  const project = new Project({ tsConfigFilePath: tsconfig, skipAddingFilesFromTsConfig: true });
-  projectsByTsconfig.set(tsconfig, project);
-  return project;
-}
-
-// `project` decides which program answers the assignability question; without one the tsconfig
-// next to the file is used. A file without any tsconfig is reported as manual, not guessed at.
-export function transformEnginePayloadCastsSource(
-  source: string,
-  filePath = "source.ts",
-  project?: Project,
-): CodemodResult {
-  const unchanged: CodemodResult = { output: source, rewrites: [], manual: [] };
-  if (!READ_CALL_PREFILTER.test(source) || !CAST_PREFILTER.test(source)) return unchanged;
-  const absolutePath = resolve(filePath);
-  const program = project ?? projectFor(absolutePath);
-  if (program === undefined) {
-    return {
-      ...unchanged,
-      manual: [
-        { file: filePath, line: 1, description: "no tsconfig.json found, cannot type-check" },
-      ],
-    };
-  }
-  const sourceFile = program.createSourceFile(absolutePath, source, { overwrite: true });
-  return transformEnginePayloadCastsFile(sourceFile, filePath);
-}
-
-if (import.meta.main) {
-  await runCodemodCli(
-    {
-      name: "remove-engine-payload-casts",
-      transform: (source, filePath) => transformEnginePayloadCastsSource(source, filePath),
-      isSkippedPath: (file) => SKIPPED_PATH_SUFFIXES.some((suffix) => file.endsWith(suffix)),
-    },
-    process.argv.slice(2),
-  );
-}

package/src/scripts/codemod/s3-imports.ts

@@ -1,236 +0,0 @@
-#!/usr/bin/env bun
-// s3-imports — the S3 file providers merged into one `file-provider-s3` subpath:
-//   .../files-provider-s3                                -> .../file-provider-s3/lib
-//   fileProviderS3EnvFeature (.../file-provider-s3-env)  -> createFileProviderS3Feature({ fromEnv: true })
-// `fileProviderS3Feature` -> `createFileProviderS3Feature()` is feature-factory.ts's job; the two
-// codemods leave the same result in either order.
-//
-// Usage:
-//   bun scripts/codemod/s3-imports.ts <targetDir...> [--check | --dry-run | --write] [--no-format]
-// Without a mode flag it writes (kumiko-upgrade --apply calls it that way). --check exits 1
-// while any rewritable or manual site is left; --dry-run only reports.
-
-import { type ImportDeclaration, Node, Project, type SourceFile } from "ts-morph";
-import {
-  applyEdits,
-  type CodemodResult,
-  type CodemodSite,
-  ensureNamedImport,
-  hasImportBinding,
-  moduleSpecifierLiterals,
-  relativeSpecifier,
-  removeNamedImport,
-  runCodemodCli,
-  type SiteLists,
-  sourceRelativeModule,
-  type TextEdit,
-} from "./codemod-support.ts";
-
-const BUNDLED_PACKAGE = "@cosmicdrift/kumiko-bundled-features";
-const BUNDLED_SRC_MARKER = "/packages/bundled-features/src/";
-const OLD_LIB_FOLDER = "files-provider-s3";
-const NEW_LIB_MODULE = "file-provider-s3/lib";
-const ENV_FOLDER = "file-provider-s3-env";
-const MERGED_FOLDER = "file-provider-s3";
-const ENV_CONSTANT = "fileProviderS3EnvFeature";
-const MERGED_FACTORY = "createFileProviderS3Feature";
-const ENV_CALL = `${MERGED_FACTORY}({ fromEnv: true })`;
-
-const CHEAP_PREFILTER = /files-provider-s3|fileProviderS3EnvFeature/;
-const SKIPPED_PATH_SUFFIXES: readonly string[] = [
-  "packages/bundled-features/src/files-provider-s3/index.ts",
-  "packages/bundled-features/src/file-provider-s3-env/index.ts",
-  "packages/framework/src/scripts/codemod/s3-imports.ts",
-  "packages/framework/src/__tests__/s3-imports-codemod.test.ts",
-];
-
-function newLibSpecifier(specifier: string, filePath: string): string | undefined {
-  if (specifier === `${BUNDLED_PACKAGE}/${OLD_LIB_FOLDER}`) {
-    return `${BUNDLED_PACKAGE}/${NEW_LIB_MODULE}`;
-  }
-  const relativeModule = sourceRelativeModule(specifier, filePath, BUNDLED_SRC_MARKER);
-  if (relativeModule === undefined) return undefined;
-  const { root, module, extension } = relativeModule;
-  if (module !== OLD_LIB_FOLDER && !module.startsWith(`${OLD_LIB_FOLDER}/`)) return undefined;
-  return relativeSpecifier(
-    filePath,
-    root,
-    `${NEW_LIB_MODULE}${module.slice(OLD_LIB_FOLDER.length)}`,
-    extension,
-  );
-}
-
-function envModuleReplacement(specifier: string, filePath: string): string | undefined {
-  if (specifier === `${BUNDLED_PACKAGE}/${ENV_FOLDER}`) {
-    return `${BUNDLED_PACKAGE}/${MERGED_FOLDER}`;
-  }
-  const relativeModule = sourceRelativeModule(specifier, filePath, BUNDLED_SRC_MARKER);
-  if (relativeModule === undefined) return undefined;
-  const { root, module, extension } = relativeModule;
-  if (module !== ENV_FOLDER && !/^file-provider-s3-env\/(index|feature)$/.test(module)) {
-    return undefined;
-  }
-  return relativeSpecifier(
-    filePath,
-    root,
-    `${MERGED_FOLDER}${module.slice(ENV_FOLDER.length)}`,
-    extension,
-  );
-}
-
-function site(file: string, node: Node, description: string): CodemodSite {
-  return { file, line: node.getStartLineNumber(), description };
-}
-
-function rewriteLibSpecifiers(
-  sourceFile: SourceFile,
-  source: string,
-  filePath: string,
-  result: SiteLists,
-): string {
-  const edits: TextEdit[] = [];
-  for (const literal of moduleSpecifierLiterals(sourceFile)) {
-    if (!Node.isStringLiteral(literal)) continue;
-    const current = literal.getLiteralValue();
-    const next = newLibSpecifier(current, filePath);
-    if (next === undefined) continue;
-    result.rewrites.push(site(filePath, literal, `${current} -> ${next}`));
-    edits.push({ start: literal.getStart(), end: literal.getEnd(), text: JSON.stringify(next) });
-  }
-  return applyEdits(source, edits);
-}
-
-function envFactoryEdit(reference: Node): TextEdit | "manual-type" | "manual-export" {
-  const parent = reference.getParent();
-  if (Node.isTypeQuery(parent)) return "manual-type";
-  if (Node.isExportSpecifier(parent)) return "manual-export";
-  const text = Node.isShorthandPropertyAssignment(parent)
-    ? `${ENV_CONSTANT}: ${ENV_CALL}`
-    : ENV_CALL;
-  return { start: reference.getStart(), end: reference.getEnd(), text };
-}
-
-interface EnvImportTarget {
-  readonly specifier: string;
-  readonly isTypeOnly: boolean;
-}
-
-// Collects the call-site edits of one import declaration. Returns false when a site can only be
-// fixed by hand, so the import is left untouched too.
-function planEnvDeclaration(
-  declaration: ImportDeclaration,
-  filePath: string,
-  edits: TextEdit[],
-  result: SiteLists,
-): boolean {
-  const named = declaration.getNamedImports().find((n) => n.getName() === ENV_CONSTANT);
-  if (named === undefined) return false;
-  const nameNode = named.getNameNode();
-  if (named.getAliasNode() !== undefined || !Node.isIdentifier(nameNode)) {
-    result.manual.push(
-      site(filePath, named, `${ENV_CONSTANT} imported under an alias: call ${ENV_CALL} by hand`),
-    );
-    return false;
-  }
-  const references = nameNode
-    .findReferencesAsNodes()
-    .filter((reference) => reference.getFirstAncestor((a) => a === declaration) === undefined);
-  const planned = references.map((reference) => ({ reference, edit: envFactoryEdit(reference) }));
-  const blocked = planned.filter(({ edit }) => typeof edit === "string");
-  for (const { reference, edit } of blocked) {
-    result.manual.push(
-      site(
-        filePath,
-        reference,
-        edit === "manual-type"
-          ? `typeof ${ENV_CONSTANT}: use the return type of ${MERGED_FACTORY} by hand`
-          : `${ENV_CONSTANT} is exported from this module: export ${MERGED_FACTORY} as well`,
-      ),
-    );
-  }
-  if (blocked.length > 0) return false;
-  for (const { reference, edit } of planned) {
-    if (typeof edit === "string") continue;
-    edits.push(edit);
-    result.rewrites.push(site(filePath, reference, `${ENV_CONSTANT} -> ${ENV_CALL}`));
-  }
-  return true;
-}
-
-function rewriteEnvFeature(source: string, filePath: string, result: SiteLists): string {
-  const project = new Project({
-    useInMemoryFileSystem: true,
-    skipAddingFilesFromTsConfig: true,
-    skipFileDependencyResolution: true,
-  });
-  const sourceFile = project.createSourceFile(filePath, source);
-  const edits: TextEdit[] = [];
-  const targetSpecifiers: EnvImportTarget[] = [];
-  for (const declaration of sourceFile.getImportDeclarations()) {
-    const replacement = envModuleReplacement(declaration.getModuleSpecifierValue(), filePath);
-    if (replacement === undefined) continue;
-    if (!planEnvDeclaration(declaration, filePath, edits, result)) continue;
-    targetSpecifiers.push({ specifier: replacement, isTypeOnly: declaration.isTypeOnly() });
-  }
-  if (targetSpecifiers.length === 0) return source;
-
-  const next = project.createSourceFile(`${filePath}.rewritten.ts`, applyEdits(source, edits));
-  for (const { specifier, isTypeOnly } of targetSpecifiers) {
-    const declaration = next
-      .getImportDeclarations()
-      .find((d) => d.getNamedImports().some((n) => n.getName() === ENV_CONSTANT));
-    const named = declaration?.getNamedImports().find((n) => n.getName() === ENV_CONSTANT);
-    if (declaration === undefined || named === undefined) continue;
-    result.rewrites.push(
-      site(filePath, named, `import ${ENV_CONSTANT} -> ${MERGED_FACTORY} from ${specifier}`),
-    );
-    removeNamedImport(next, declaration, named);
-    if (!hasImportBinding(next, MERGED_FACTORY)) {
-      ensureNamedImport(next, specifier, MERGED_FACTORY, isTypeOnly);
-    }
-  }
-  return next.getFullText();
-}
-
-function reportEnvReexports(sourceFile: SourceFile, filePath: string, result: SiteLists): void {
-  for (const declaration of sourceFile.getExportDeclarations()) {
-    const specifier = declaration.getModuleSpecifierValue();
-    if (specifier === undefined || envModuleReplacement(specifier, filePath) === undefined)
-      continue;
-    if (declaration.getNamedExports().some((e) => e.getName() === ENV_CONSTANT)) {
-      result.manual.push(
-        site(
-          filePath,
-          declaration,
-          `${ENV_CONSTANT} re-exported from ${specifier}: re-export ${MERGED_FACTORY}`,
-        ),
-      );
-    }
-  }
-}
-
-export function transformS3ImportsSource(source: string, filePath = "source.ts"): CodemodResult {
-  const result: SiteLists = { rewrites: [], manual: [] };
-  if (!CHEAP_PREFILTER.test(source)) return { output: source, ...result };
-  const project = new Project({
-    useInMemoryFileSystem: true,
-    skipAddingFilesFromTsConfig: true,
-    skipFileDependencyResolution: true,
-  });
-  const sourceFile = project.createSourceFile(filePath, source);
-  reportEnvReexports(sourceFile, filePath, result);
-  const libRewritten = rewriteLibSpecifiers(sourceFile, source, filePath, result);
-  const output = rewriteEnvFeature(libRewritten, filePath, result);
-  return { output, ...result };
-}
-
-function isSkippedPath(file: string): boolean {
-  return SKIPPED_PATH_SUFFIXES.some((suffix) => file.endsWith(suffix));
-}
-
-if (import.meta.main) {
-  await runCodemodCli(
-    { name: "s3-imports", transform: transformS3ImportsSource, isSkippedPath },
-    process.argv.slice(2),
-  );
-}