@cosmicdrift/kumiko-framework 0.336.1 → 0.338.0

package/src/scripts/codemod/migrate-open-to-all.ts

@@ -6,8 +6,7 @@
 // Usage:
 //   bun scripts/codemod/migrate-open-to-all.ts [--dry-run] [--test-reason "<text>"] <path...>
 
-import { readdirSync, readFileSync, statSync, writeFileSync } from "node:fs";
-import { join, resolve } from "node:path";
+import { readFileSync, writeFileSync } from "node:fs";
 import {
   Node,
   type ObjectLiteralExpression,
@@ -15,6 +14,7 @@ import {
   type PropertyAssignment,
   SyntaxKind,
 } from "ts-morph";
+import { collectSourceFiles } from "./collect-source-files.js";
 
 const DEFAULT_TEST_REASON = "test handler callable by any signed-in test user";
 
@@ -164,28 +164,8 @@ function isMigratableFile(name: string): boolean {
   return /\.(ts|tsx)$/.test(name);
 }
 
-function walkDir(dir: string, out: string[]): void {
-  for (const name of readdirSync(dir)) {
-    if (name === "node_modules") continue;
-    const full = join(dir, name);
-    const stat = statSync(full);
-    if (stat.isDirectory()) {
-      walkDir(full, out);
-      continue;
-    }
-    if (isMigratableFile(name)) out.push(full);
-  }
-}
-
-function collectFiles(paths: string[]): string[] {
-  const files: string[] = [];
-  for (const p of paths) {
-    const abs = resolve(p);
-    const stat = statSync(abs);
-    if (stat.isDirectory()) walkDir(abs, files);
-    else if (isMigratableFile(abs)) files.push(abs);
-  }
-  return files;
+export function collectFiles(paths: string[]): string[] {
+  return collectSourceFiles(paths, { isMigratableFile });
 }
 
 // Remaining manual sites still fail boot validation, so upgrade-cli must not

package/src/scripts/codemod/unprocessable-error-details-reason.ts

@@ -51,14 +51,20 @@ function findTargetFiles(rootDir: string): string[] {
   return files.sort();
 }
 
+const NAMESPACE_IMPORT = "*";
+
 type ImportedBinding = { readonly importedName: string; readonly moduleSpecifier: string };
 
-/** Local-name -> where it's imported from, for every named value import in the file. */
+/** Local-name -> where it's imported from, for every named or namespace value import in the file. */
 function collectImportedNames(sourceFile: SourceFile): Map<string, ImportedBinding> {
   const bindings = new Map<string, ImportedBinding>();
   for (const imp of sourceFile.getImportDeclarations()) {
     if (imp.isTypeOnly()) continue;
     const moduleSpecifier = imp.getModuleSpecifierValue();
+    const namespaceImport = imp.getNamespaceImport();
+    if (namespaceImport) {
+      bindings.set(namespaceImport.getText(), { importedName: NAMESPACE_IMPORT, moduleSpecifier });
+    }
     for (const spec of imp.getNamedImports()) {
       if (spec.isTypeOnly()) continue;
       const importedName = spec.getName();
@@ -264,6 +270,17 @@ const FAIL_UNPROCESSABLE_CALL: MigratableCall = {
   process: processFailUnprocessableCall,
 };
 
+function isKumikoNamespaceReceiver(
+  receiver: Node,
+  importedNames: ReadonlyMap<string, ImportedBinding>,
+): boolean {
+  if (!Node.isIdentifier(receiver)) return false;
+  const binding = importedNames.get(receiver.getText());
+  return (
+    binding?.importedName === NAMESPACE_IMPORT && KUMIKO_MODULE_RE.test(binding.moduleSpecifier)
+  );
+}
+
 function migrateCallSite(
   sourceFile: SourceFile,
   importedNames: ReadonlyMap<string, ImportedBinding>,
@@ -272,11 +289,28 @@ function migrateCallSite(
   skips: SkipEntry[],
 ): boolean {
   const callee = site.getExpression();
-  if (!Node.isIdentifier(callee)) return false;
-  const localName = callee.getText();
   const line = site.getStartLineNumber();
   const file = sourceFile.getFilePath();
 
+  if (!Node.isIdentifier(callee)) {
+    const unresolvedCallee = callee.getText();
+    const resolvedViaNamespace =
+      Node.isPropertyAccessExpression(callee) &&
+      callee.getName() === target.exportName &&
+      isKumikoNamespaceReceiver(callee.getExpression(), importedNames);
+    if (resolvedViaNamespace) return processCall(site, target, skips, file, line);
+    if (unresolvedCallee.endsWith(target.exportName)) {
+      skips.push({
+        file,
+        line,
+        note: `${target.exportName} is called through "${unresolvedCallee}", which is not a @cosmicdrift/kumiko-* namespace import this codemod can resolve`,
+        kind: "manual",
+      });
+    }
+    return false;
+  }
+  const localName = callee.getText();
+
   const binding = importedNames.get(localName);
   if (binding?.importedName !== target.exportName) {
     if (localName !== target.exportName) return false;
@@ -296,6 +330,16 @@ function migrateCallSite(
     return false;
   }
 
+  return processCall(site, target, skips, file, line);
+}
+
+function processCall(
+  site: Node & { getArguments(): Node[] },
+  target: MigratableCall,
+  skips: SkipEntry[],
+  file: string,
+  line: number,
+): boolean {
   const outcome = target.process(site.getArguments(), (note, kind) =>
     skips.push({ file, line, note, kind }),
   );