@cosmicdrift/kumiko-framework 0.309.0 → 0.310.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.309.0",
+  "version": "0.310.0",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -198,8 +198,8 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-http": "0.309.0",
-    "@cosmicdrift/kumiko-types": "0.309.0",
+    "@cosmicdrift/kumiko-http": "0.310.0",
+    "@cosmicdrift/kumiko-types": "0.310.0",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -215,7 +215,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.309.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.310.0",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.310.0",
+    "type": "improvement",
+    "title": "Boot validator checks the target tab of navigate actions",
+    "detail": "A navigate action with `tab` fails boot when its target is not a\nprojectionDetail with layout.mode \"tabs\" or has no section with that id.\nThe check covers list rowActions, relatedList rowActions, screen actions,\nsection actions and relatedList emptyState actions."
+  },
   {
     "version": "0.309.0",
     "type": "fix",

package/src/engine/__tests__/row-action-navigate-tab.test.ts

@@ -0,0 +1,107 @@
+import { describe, expect, test } from "bun:test";
+import * as z from "zod";
+import { withBootValidatorFixture } from "../../testing/boot-validator-fixture";
+import { validateBoot as validateBootRaw } from "../boot-validator";
+import { defineFeature } from "../define-feature";
+import { createEntity, createTextField } from "../factories";
+
+function validateBoot(features: Parameters<typeof validateBootRaw>[0]): void {
+  validateBootRaw(withBootValidatorFixture(features));
+}
+
+function buildFeature(options: {
+  readonly detailTabs: boolean;
+  readonly tab: string;
+  readonly via: "entityEditSection" | "entityListRowAction";
+}) {
+  return defineFeature("app", (r) => {
+    r.entity(
+      "vehicle",
+      createEntity({
+        fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+      }),
+    );
+    r.queryHandler("vehicle:detail", z.object({}), async () => ({ name: "x" }), {
+      access: { openToAll: { reason: "test handler callable by any signed-in test user" } },
+    });
+    r.screen({
+      id: "vehicle-detail",
+      type: "projectionDetail",
+      query: "app:query:vehicle:detail",
+      layout: options.detailTabs
+        ? {
+            mode: "tabs",
+            sections: [
+              { id: "overview", title: "Overview", fields: ["name"] },
+              { id: "channels", title: "Channels", fields: ["name"] },
+            ],
+          }
+        : { sections: [{ title: "Overview", fields: ["name"] }] },
+    });
+    const navigateAction = {
+      kind: "navigate" as const,
+      id: "view-channels",
+      label: "app.actions.viewChannels",
+      screen: "vehicle-detail",
+      tab: options.tab,
+    };
+    if (options.via === "entityEditSection") {
+      r.screen({
+        id: "vehicle-edit",
+        type: "entityEdit",
+        entity: "vehicle",
+        layout: {
+          sections: [
+            {
+              id: "main",
+              title: "Main",
+              columns: 1,
+              fields: ["name"],
+              actions: [{ ...navigateAction, entityId: "vehicleId" }],
+            },
+          ],
+        },
+      });
+    } else {
+      r.screen({
+        id: "vehicle-list",
+        type: "entityList",
+        entity: "vehicle",
+        columns: ["name"],
+        rowActions: [navigateAction],
+      });
+    }
+  });
+}
+
+describe("validateBoot — RowActionNavigate.tab", () => {
+  test("entityEdit section action navigates to a known tab boots cleanly", () => {
+    const feature = buildFeature({ detailTabs: true, tab: "channels", via: "entityEditSection" });
+    expect(() => validateBoot([feature])).not.toThrow();
+  });
+
+  test("entityEdit section action navigates to an unknown tab throws", () => {
+    const feature = buildFeature({ detailTabs: true, tab: "unknown", via: "entityEditSection" });
+    expect(() => validateBoot([feature])).toThrow(
+      /navigates to tab "unknown", which is not a section id on target screen/,
+    );
+  });
+
+  test("entityEdit section action navigating to a non-tabs projectionDetail throws", () => {
+    const feature = buildFeature({ detailTabs: false, tab: "overview", via: "entityEditSection" });
+    expect(() => validateBoot([feature])).toThrow(
+      /is not a projectionDetail with layout.mode "tabs"/,
+    );
+  });
+
+  test("entityList rowAction navigating to an unknown tab throws (central resolution path)", () => {
+    const feature = buildFeature({
+      detailTabs: true,
+      tab: "unknown",
+      via: "entityListRowAction",
+    });
+    expect(() => validateBoot([feature])).toThrow(
+      /navigates to tab "unknown", which is not a section id on target screen/,
+    );
+  });
+});

package/src/engine/boot-validator/screens.ts

@@ -542,11 +542,48 @@ type RowActionNavigateRuntime = RowActionNavigateBase & {
   readonly entity?: string;
 };
 
+// The target can be any screen, so this checks the resolved target's
+// sections, not the host's.
+function validateRowActionNavigateTab(
+  featureName: string,
+  screenId: string,
+  screenType: "entityList" | "projectionList" | "projectionDetail" | "entityEdit",
+  actionLabel: string,
+  action: RowActionNavigateRuntime,
+  target: { readonly featureName: string; readonly screen: ScreenDefinition } | undefined,
+): void {
+  // skip: no tab declared — nothing to check against the target's sections
+  if (action.tab === undefined) return;
+  if (target === undefined) {
+    throw new Error(
+      `[Feature ${featureName}] Screen "${screenId}" (${screenType}) ${actionLabel} "${action.id}" ` +
+        `sets tab "${action.tab}", but its navigate-target could not be resolved to a screen.`,
+    );
+  }
+  if (target.screen.type !== "projectionDetail" || target.screen.layout.mode !== "tabs") {
+    throw new Error(
+      `[Feature ${featureName}] Screen "${screenId}" (${screenType}) ${actionLabel} "${action.id}" ` +
+        `sets tab "${action.tab}", but navigate-target screen "${target.screen.id}" is not a ` +
+        `projectionDetail with layout.mode "tabs" — only those read the tab param.`,
+    );
+  }
+  const sectionIds = target.screen.layout.sections
+    .map((section) => section.id)
+    .filter((id): id is string => id !== undefined);
+  if (!sectionIds.includes(action.tab)) {
+    throw new Error(
+      `[Feature ${featureName}] Screen "${screenId}" (${screenType}) ${actionLabel} "${action.id}" ` +
+        `navigates to tab "${action.tab}", which is not a section id on target screen ` +
+        `"${target.screen.id}". Available: ${sectionIds.join(", ") || "(none)"}.`,
+    );
+  }
+}
+
 function resolveRowActionNavigateTarget(
   featureName: string,
   screenId: string,
   screenType: "entityList" | "projectionList" | "projectionDetail" | "entityEdit",
-  actionLabel: "rowAction" | "action",
+  actionLabel: string,
   action: RowActionNavigateRuntime,
   allScreenQns: ReadonlySet<string>,
   navTargetShortIds: ReadonlySet<string>,
@@ -586,6 +623,7 @@ function resolveRowActionNavigateTarget(
           `detailFor: "${action.entity}".`,
       );
     }
+    validateRowActionNavigateTab(featureName, screenId, screenType, actionLabel, action, detail);
     return detail;
   }
   if (action.screen === undefined) {
@@ -601,7 +639,9 @@ function resolveRowActionNavigateTarget(
         `navigate-target "${action.screen}" does not resolve to a registered screen in any feature.`,
     );
   }
-  return screensByShortId.get(action.screen)?.[0];
+  const target = screensByShortId.get(action.screen)?.[0];
+  validateRowActionNavigateTab(featureName, screenId, screenType, actionLabel, action, target);
+  return target;
 }
 
 // Shared by the mint step's own handler (screen.handler) and its optional
@@ -1225,6 +1265,19 @@ export function validateScreens(
               `section "${sectionLabel}" action`,
               action,
             );
+            if (action.kind === "navigate" && action.tab !== undefined) {
+              resolveRowActionNavigateTarget(
+                feature.name,
+                screenId,
+                "projectionDetail",
+                `section "${sectionLabel}" action`,
+                action,
+                allScreenQns,
+                navTargetShortIds,
+                screensByShortId,
+                detailForScreens,
+              );
+            }
           }
         }
         if (section.kind === "relatedList" && section.emptyState?.action !== undefined) {
@@ -1235,6 +1288,22 @@ export function validateScreens(
             `section "${sectionLabel}" emptyState action`,
             section.emptyState.action,
           );
+          if (
+            section.emptyState.action.kind === "navigate" &&
+            section.emptyState.action.tab !== undefined
+          ) {
+            resolveRowActionNavigateTarget(
+              feature.name,
+              screenId,
+              "projectionDetail",
+              `section "${sectionLabel}" emptyState action`,
+              section.emptyState.action,
+              allScreenQns,
+              navTargetShortIds,
+              screensByShortId,
+              detailForScreens,
+            );
+          }
         }
         if (isExtensionEditSection(section)) {
           // projectionDetail is read-only (no composed form submit) — an
@@ -1983,6 +2052,19 @@ export function validateScreens(
               `section "${sectionLabel}" action`,
               action,
             );
+            if (action.kind === "navigate" && action.tab !== undefined) {
+              resolveRowActionNavigateTarget(
+                feature.name,
+                screenId,
+                "entityEdit",
+                `section "${sectionLabel}" action`,
+                action,
+                allScreenQns,
+                navTargetShortIds,
+                screensByShortId,
+                detailForScreens,
+              );
+            }
           }
         }
         if (isExtensionEditSection(section)) {