@cosmicdrift/kumiko-framework 0.284.0 → 0.285.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.284.0",
+  "version": "0.285.1",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -198,8 +198,8 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-http": "0.284.0",
-    "@cosmicdrift/kumiko-types": "0.284.0",
+    "@cosmicdrift/kumiko-http": "0.285.1",
+    "@cosmicdrift/kumiko-types": "0.285.1",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -215,7 +215,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.284.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.285.1",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/changes.json

@@ -1,4 +1,10 @@
 [
+  {
+    "version": "0.285.0",
+    "type": "improvement",
+    "title": "Add a `tooling` repo kind, scoped out of guards by default",
+    "detail": "`kumiko-repo-manifest`'s `repoKindSchema` gains a `\"tooling\"` value for a repo with no product code (infra, Pulumi, build tooling). `kumiko-guards`' `scanRoots` treats an omitted `ScanSpec.kinds` as \"every root except tooling\" instead of \"every root\" — only 7 of ~60 guards declare `kinds` today, so without this a tooling repo would have been silently pulled into every product-oriented guard; a guard now has to name `\"tooling\"` in `kinds` explicitly to scan one. Separately, `kumiko-framework`'s boot-validator now includes the implicit parent-id field in a form screen's `urlPrefillFields` when it's reached via a relatedList toolbarAction that declares no `params` of its own — the renderer already sends that field (`parentFilter.field`, else `parentParam`, else `\"id\"`), the boot-validator just wasn't allowlisting it."
+  },
   {
     "version": "0.283.0",
     "type": "improvement",

package/src/engine/__tests__/build-app-schema-url-prefill.test.ts

@@ -93,6 +93,21 @@ const leasesFeature = defineFeature("leases", (r) => {
             },
           ],
         },
+        {
+          kind: "relatedList",
+          title: "Custom-key items",
+          query: "leases:query:lease:items",
+          columns: ["name"],
+          parentParam: "customParentId",
+          toolbarActions: [
+            {
+              kind: "navigate",
+              id: "silent-add-custom",
+              label: "Silent add",
+              screen: "item-toolbar-custom-parent",
+            },
+          ],
+        },
       ],
     },
     metrics: [
@@ -121,6 +136,12 @@ const leasesFeature = defineFeature("leases", (r) => {
     entity: "item",
     layout: { sections: [{ title: "x", fields: ["leaseId", "note"] }] },
   });
+  r.screen({
+    id: "item-toolbar-custom-parent",
+    type: "entityEdit",
+    entity: "item",
+    layout: { sections: [{ title: "x", fields: ["leaseId", "note"] }] },
+  });
   r.screen({
     id: "record-payment",
     type: "actionForm",
@@ -191,7 +212,11 @@ describe("buildAppSchema — urlPrefillFields derived from navigate params", ()
     expect(urlPrefillFieldsOf("leases", "item-toolbar-note")).toEqual(["leaseId"]);
   });
 
-  test("a relatedList toolbarAction without params contributes no fields — the allowlist stays an allowlist", () => {
-    expect(urlPrefillFieldsOf("leases", "item-toolbar-silent")).toEqual([]);
+  test("a relatedList toolbarAction without params still contributes the implicit parent-id field", () => {
+    expect(urlPrefillFieldsOf("leases", "item-toolbar-silent")).toEqual(["id"]);
+  });
+
+  test("a relatedList toolbarAction without params uses the section's own parentParam key", () => {
+    expect(urlPrefillFieldsOf("leases", "item-toolbar-custom-parent")).toEqual(["customParentId"]);
   });
 });

package/src/engine/boot-validator/url-prefill-fields.ts

@@ -1,6 +1,7 @@
 import { qualifyEntityName } from "../qualified-name";
 import type { FeatureDefinition } from "../types";
 import type {
+  EditRelatedListSection,
   ProjectionDetailScreenDefinition,
   RowFieldExtractor,
   ScreenDefinition,
@@ -26,23 +27,29 @@ type NavigateActionLike = {
   readonly entityId?: string;
   readonly params?: RowFieldExtractor;
 };
-type NavigateActionWithParams = NavigateActionLike & { readonly params: RowFieldExtractor };
 type ScopedNavigateAction = {
   readonly action: NavigateActionLike;
   readonly sourceScreenEntity: string | undefined;
+  /** Used when the action itself declares no `params` — the field a
+   *  relatedList toolbarAction's parent id lands under at runtime
+   *  (RelatedListSection's `navigatePrefill`, related-list-section.tsx). */
+  readonly implicitParams?: RowFieldExtractor;
 };
 
 function isNavigateKind(action: NavigateActionLike): boolean {
   return action.kind === undefined || action.kind === "navigate";
 }
-function isNavigateWithParams(action: NavigateActionLike): action is NavigateActionWithParams {
-  return isNavigateKind(action) && action.params !== undefined;
-}
 function scopeActions(
   actions: readonly NavigateActionLike[] | undefined,
   sourceScreenEntity: string | undefined,
+  implicitParams?: RowFieldExtractor,
 ): ScopedNavigateAction[] {
-  return (actions ?? []).map((action) => ({ action, sourceScreenEntity }));
+  return (actions ?? []).map((action) => ({ action, sourceScreenEntity, implicitParams }));
+}
+// Same key the renderer falls back to when a relatedList toolbarAction has no
+// `params` of its own: `parentFilter.field`, else `parentParam`, else "id".
+function relatedListParentParamField(section: EditRelatedListSection): string {
+  return section.parentFilter?.field ?? section.parentParam ?? "id";
 }
 function projectionDetailNavigateActions(
   screen: ProjectionDetailScreenDefinition,
@@ -53,7 +60,11 @@ function projectionDetailNavigateActions(
       section.kind === "relatedList" ? scopeActions(section.rowActions, undefined) : [],
     ),
     ...screen.layout.sections.flatMap((section) =>
-      section.kind === "relatedList" ? scopeActions(section.toolbarActions, undefined) : [],
+      section.kind === "relatedList"
+        ? scopeActions(section.toolbarActions, undefined, {
+            pick: [relatedListParentParamField(section)],
+          })
+        : [],
     ),
     ...(screen.metrics ?? []).flatMap((metric) =>
       typeof metric === "string" || metric.navigate === undefined
@@ -77,25 +88,30 @@ function navigateActionsOf(screen: ScreenDefinition): ScopedNavigateAction[] {
   }
 }
 function toNavigateParamsSource(
-  action: NavigateActionWithParams,
+  action: NavigateActionLike,
+  params: RowFieldExtractor,
   sourceScreenEntity: string | undefined,
 ): NavigateParamsSource {
   return {
     ...(action.screen !== undefined && { screen: action.screen }),
     ...(action.entity !== undefined && { entity: action.entity }),
     ...(action.entityId !== undefined && { entityId: action.entityId }),
-    params: action.params,
+    params,
     sourceScreenEntity,
   };
 }
 
-// Every declarative navigate that writes `params` into the target's URL —
+// Every declarative navigate that writes params into the target's URL —
 // the same sources validateScreens pairs with validateRowActionNavigateParams,
-// plus projectionDetail metrics (runMetricNavigate), which reuse that shape.
+// plus projectionDetail metrics (runMetricNavigate), which reuse that shape —
+// plus a relatedList toolbarAction with no `params` of its own, which still
+// writes its implicit parent-id param at runtime (see `implicitParams`).
 function navigateParamsSources(screen: ScreenDefinition): NavigateParamsSource[] {
-  return navigateActionsOf(screen).flatMap(({ action, sourceScreenEntity }) =>
-    isNavigateWithParams(action) ? [toNavigateParamsSource(action, sourceScreenEntity)] : [],
-  );
+  return navigateActionsOf(screen).flatMap(({ action, sourceScreenEntity, implicitParams }) => {
+    if (!isNavigateKind(action)) return [];
+    const params = action.params ?? implicitParams;
+    return params === undefined ? [] : [toNavigateParamsSource(action, params, sourceScreenEntity)];
+  });
 }
 
 // Per target screen QN, the union of field names any navigate `params` may