@cosmicdrift/kumiko-framework 0.259.0 → 0.260.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.259.0",
+  "version": "0.260.0",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -198,7 +198,7 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-types": "0.259.0",
+    "@cosmicdrift/kumiko-types": "0.260.0",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -214,7 +214,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.259.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.260.0",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/engine/__tests__/boot-validator.test.ts

@@ -3167,7 +3167,10 @@ describe("boot-validator", () => {
   // Post-save navigation target, same validation as actionForm's redirect:
   // short screen-ID, same feature, must resolve to a registered screen.
   describe("entityEdit redirect", () => {
-    function makeFeature(redirect?: string, extraScreens: readonly string[] = []) {
+    function makeFeature(
+      redirect?: string | { readonly screen: string; readonly idFrom: string },
+      extraScreens: readonly string[] = [],
+    ) {
       return defineFeature("shop", (r) => {
         r.entity(
           "product",
@@ -3224,6 +3227,27 @@ describe("boot-validator", () => {
         /redirect "statements:screen:ghost-screen" does not resolve to a registered screen/,
       );
     });
+
+    // --- redirect object form with idFrom (same rule as actionForm's) ---
+    test("redirect object → existing screen-id → kein Throw", () => {
+      expect(() =>
+        validateBoot([
+          makeFeature({ screen: "product-list", idFrom: "parentId" }, ["product-list"]),
+        ]),
+      ).not.toThrow();
+    });
+
+    test("redirect object → unknown screen-id → Throw", () => {
+      expect(() =>
+        validateBoot([makeFeature({ screen: "ghost-screen", idFrom: "parentId" })]),
+      ).toThrow(/redirect "ghost-screen" does not resolve to a registered screen/);
+    });
+
+    test("redirect object mit leerem idFrom → Throw", () => {
+      expect(() =>
+        validateBoot([makeFeature({ screen: "product-list", idFrom: "  " }, ["product-list"])]),
+      ).toThrow(/redirect\.idFrom is empty/);
+    });
   });
 
   // --- no-widget field types + required (#1925) ---

package/src/engine/__tests__/projection-detail-tabs.test.ts

@@ -168,6 +168,49 @@ describe("validateBoot — projectionDetail tabs (fw record-layout)", () => {
     );
   });
 
+  test("metric navigate.tab with no screen/entity — unknown section id throws", () => {
+    const feature = defineFeature("app", (r) => {
+      r.screen({
+        id: "rent-detail",
+        type: "projectionDetail",
+        query: "app:query:rent:detail",
+        metrics: [{ field: "balance", label: "rent.balance", navigate: { tab: "unknown" } }],
+        layout: {
+          mode: "tabs",
+          sections: [
+            { id: "overview", title: "Overview", fields: ["description"] },
+            { id: "history", title: "History", fields: ["notes"] },
+          ],
+        },
+      });
+    });
+    expect(() => validateBoot([feature])).toThrow(
+      /navigates to tab "unknown", which is not a section id on this screen/,
+    );
+  });
+
+  test("metric navigate.tab with no screen/entity — a known section id boots cleanly", () => {
+    const feature = defineFeature("app", (r) => {
+      r.queryHandler("rent:detail", z.object({}), async () => ({ description: "x" }), {
+        access: { openToAll: true },
+      });
+      r.screen({
+        id: "rent-detail",
+        type: "projectionDetail",
+        query: "app:query:rent:detail",
+        metrics: [{ field: "balance", label: "rent.balance", navigate: { tab: "history" } }],
+        layout: {
+          mode: "tabs",
+          sections: [
+            { id: "overview", title: "Overview", fields: ["description"] },
+            { id: "history", title: "History", fields: ["notes"] },
+          ],
+        },
+      });
+    });
+    expect(() => validateBoot([feature])).not.toThrow();
+  });
+
   test("valid tabs + header + metrics declaration boots cleanly", () => {
     const feature = defineFeature("app", (r) => {
       r.queryHandler("rent:detail", z.object({}), async () => ({ description: "x" }), {

package/src/engine/__tests__/screen.test.ts

@@ -1469,6 +1469,26 @@ describe("validateBoot — screen validation", () => {
     expect(() => validateBoot([feature])).not.toThrow();
   });
 
+  test("wizard entityEdit with slots.footer passes boot", () => {
+    const feature = defineFeature("shop", (r) => {
+      r.entity("product", productEntity());
+      r.screen({
+        id: "edit-wizard",
+        type: "entityEdit",
+        entity: "product",
+        layout: {
+          mode: "wizard",
+          sections: [
+            { title: "shop:section.basics", fields: ["name"] },
+            { title: "shop:section.details", fields: ["sku"] },
+          ],
+        },
+        slots: { footer: { react: { __component: "f" } } },
+      });
+    });
+    expect(() => validateBoot([feature])).not.toThrow();
+  });
+
   test("entityList with empty columns fails boot", () => {
     // Blank columns list renders as a blank table — almost always an author
     // oversight. Locked down at boot rather than silently producing an empty

package/src/engine/boot-validator/screens.ts

@@ -18,6 +18,7 @@ import {
 import type { EntityDefinition, FeatureDefinition, FieldDefinition } from "../types";
 import { metricField } from "../types";
 import type {
+  ActionFormRedirect,
   ActionFormScreenDefinition,
   DashboardCustomPanel,
   DashboardFilterDefinition,
@@ -631,6 +632,42 @@ function validateFormLayoutSections(
   }
 }
 
+// redirect is either a short screen id (same-feature, e.g. "item-list") or
+// a fully-qualified cross-feature QN (`<feature>:screen:<id>`) — the
+// renderer strips the latter to the short id (lastSegment) when
+// navigating, which the nav-router resolves app-wide (#1946). The object
+// form (fw#2670) carries the same target under `screen` plus the payload
+// field `idFrom`. Shared by actionForm/secretMint (validateInlineFormNavTargets)
+// and entityEdit — same rule, same error message, one place to keep them in sync.
+function validateRedirectTarget(
+  feature: FeatureDefinition,
+  screenId: string,
+  screenKind: "actionForm" | "secretMint" | "entityEdit",
+  redirect: string | ActionFormRedirect,
+  allScreenQns: ReadonlySet<string>,
+): void {
+  const redirectTarget = typeof redirect === "string" ? redirect : redirect.screen;
+  if (
+    typeof redirect !== "string" &&
+    (typeof redirect.idFrom !== "string" || redirect.idFrom.trim() === "")
+  ) {
+    throw new Error(
+      `[Feature ${feature.name}] Screen "${screenId}" (${screenKind}) redirect.idFrom is empty or not a string — ` +
+        `name the success-payload field carrying the navigation id, or use the plain string ` +
+        `redirect form to navigate with the handler's own "id".`,
+    );
+  }
+  validateScreenNavTarget(
+    feature.name,
+    screenId,
+    screenKind,
+    "redirect",
+    redirectTarget,
+    allScreenQns,
+    feature.screens,
+  );
+}
+
 function validateInlineFormNavTargets(
   feature: FeatureDefinition,
   screenId: string,
@@ -639,33 +676,7 @@ function validateInlineFormNavTargets(
   allScreenQns: ReadonlySet<string>,
 ): void {
   if (screen.redirect !== undefined) {
-    // redirect is either a short screen id (same-feature, e.g. "item-list")
-    // or a fully-qualified cross-feature QN (`<feature>:screen:<id>`) — the
-    // renderer strips the latter to the short id (lastSegment) when
-    // navigating, which the nav-router resolves app-wide (#1946). The object
-    // form (fw#2670, actionForm only) carries the same target under `screen`
-    // plus the payload field `idFrom`.
-    const redirectTarget =
-      typeof screen.redirect === "string" ? screen.redirect : screen.redirect.screen;
-    if (
-      typeof screen.redirect !== "string" &&
-      (typeof screen.redirect.idFrom !== "string" || screen.redirect.idFrom.trim() === "")
-    ) {
-      throw new Error(
-        `[Feature ${feature.name}] Screen "${screenId}" (${kind}) redirect.idFrom is empty or not a string — ` +
-          `name the success-payload field carrying the navigation id, or use the plain string ` +
-          `redirect form to navigate with the handler's own "id".`,
-      );
-    }
-    validateScreenNavTarget(
-      feature.name,
-      screenId,
-      kind,
-      "redirect",
-      redirectTarget,
-      allScreenQns,
-      feature.screens,
-    );
+    validateRedirectTarget(feature, screenId, kind, screen.redirect, allScreenQns);
   }
   if (typeof screen.cancelTarget === "string") {
     // Same rule as redirect — `false` (no Cancel button) needs no validation.
@@ -986,6 +997,20 @@ export function validateScreens(
                 `there is no fallback to the raw column name.`,
             );
           }
+          const navigate = typeof metric === "string" ? undefined : metric.navigate;
+          // Cross-screen navigate+tab isn't checked here — the target screen
+          // validates its own section ids when the loop reaches it.
+          if (
+            navigate?.tab !== undefined &&
+            navigate.screen === undefined &&
+            navigate.entity === undefined &&
+            !screen.layout.sections.some((section) => section.id === navigate.tab)
+          ) {
+            throw new Error(
+              `[Feature ${feature.name}] Screen "${screenId}" (projectionDetail) metric "${field}" ` +
+                `navigates to tab "${navigate.tab}", which is not a section id on this screen.`,
+            );
+          }
         }
       }
       for (const section of screen.layout.sections) {
@@ -1785,17 +1810,7 @@ export function validateScreens(
         }
       }
       if (screen.redirect !== undefined) {
-        // Same rule as actionForm's redirect: short screen-ID (same-feature)
-        // or a fully-qualified cross-feature QN (#1946).
-        validateScreenNavTarget(
-          feature.name,
-          screenId,
-          "entityEdit",
-          "redirect",
-          screen.redirect,
-          allScreenQns,
-          feature.screens,
-        );
+        validateRedirectTarget(feature, screenId, "entityEdit", screen.redirect, allScreenQns);
       }
     }
   }