@cosmicdrift/kumiko-framework 0.258.0 → 0.259.0

package/src/engine/__tests__/boot-validator-dashboard.test.ts

@@ -3,7 +3,7 @@ import { z } from "zod";
 import { requiredKeysFromScreen } from "../../i18n/required-surface-keys";
 import { validateBoot } from "../boot-validator";
 import { defineFeature } from "../define-feature";
-import type { DashboardScreenDefinition } from "../types/screen";
+import type { DashboardScreenDefinition, DashboardScreenPanel } from "../types/screen";
 
 const STAT_PANEL = {
   kind: "stat",
@@ -242,3 +242,140 @@ describe("validateBoot — dashboard screens", () => {
     expect(keys).not.toContain("custom-panel");
   });
 });
+
+const catalogFeature = defineFeature("catalog", (r) => {
+  r.queryHandler("items:list", z.object({}), async () => ({ rows: [], nextCursor: null }), {
+    access: { openToAll: true },
+  });
+  r.queryHandler("items:status", z.object({}), async () => ({ enabled: true }), {
+    access: { openToAll: true },
+  });
+  r.screen({
+    id: "items",
+    type: "projectionList",
+    query: "catalog:query:items:list",
+    columns: ["name"],
+  });
+  r.screen({
+    id: "items-overview",
+    type: "dashboard",
+    panels: [STAT_PANEL],
+  });
+  r.translations({
+    keys: {
+      "screen:items.title": { de: "Artikel", en: "Items" },
+      "screen:items-overview.title": { de: "Übersicht", en: "Overview" },
+      "demo:dashboard:panel:open-incidents": { de: "Offene Vorfälle", en: "Open incidents" },
+    },
+  });
+});
+
+function screenPanelFeature(panel: DashboardScreenPanel) {
+  return dashboardFeature([STAT_PANEL, panel]);
+}
+
+describe("validateBoot — dashboard screen panels (fw#2841)", () => {
+  test("accepts a cross-feature projectionList target with a registered visibleWhen query", () => {
+    const feature = screenPanelFeature({
+      kind: "screen",
+      id: "items",
+      screen: "catalog:screen:items",
+      label: "demo:dashboard:panel:latest",
+      visibleWhen: { query: "catalog:query:items:status", field: "enabled", eq: true },
+    });
+    expect(() => validateBoot([feature, catalogFeature])).not.toThrow();
+  });
+
+  test("accepts a same-feature short id", () => {
+    const feature = defineFeature("demo", (r) => {
+      r.queryHandler("items:list", z.object({}), async () => ({ rows: [], nextCursor: null }), {
+        access: { openToAll: true },
+      });
+      r.screen({
+        id: "items",
+        type: "projectionList",
+        query: "demo:query:items:list",
+        columns: ["name"],
+      });
+      r.screen({
+        id: "overview",
+        type: "dashboard",
+        panels: [{ kind: "screen", id: "items", screen: "items" }],
+      });
+      r.translations({
+        keys: {
+          "screen:items.title": { de: "Artikel", en: "Items" },
+          "screen:overview.title": { de: "Übersicht", en: "Overview" },
+        },
+      });
+    });
+    expect(() => validateBoot([feature])).not.toThrow();
+  });
+
+  test("rejects a target that resolves to no registered screen", () => {
+    const feature = screenPanelFeature({
+      kind: "screen",
+      id: "items",
+      screen: "catalog:screen:ghost",
+    });
+    expect(() => validateBoot([feature, catalogFeature])).toThrow(
+      /screen-panel "items" screen "catalog:screen:ghost" does not resolve/,
+    );
+  });
+
+  test("rejects a short id that only exists in another feature", () => {
+    const feature = screenPanelFeature({ kind: "screen", id: "items", screen: "items" });
+    expect(() => validateBoot([feature, catalogFeature])).toThrow(/checked "demo:screen:items"/);
+  });
+
+  test("rejects embedding a dashboard (no nesting)", () => {
+    const feature = screenPanelFeature({
+      kind: "screen",
+      id: "nested",
+      screen: "catalog:screen:items-overview",
+    });
+    expect(() => validateBoot([feature, catalogFeature])).toThrow(
+      /of type "dashboard", which can't be embedded/,
+    );
+  });
+
+  test("rejects a visibleWhen query that is not registered", () => {
+    const feature = screenPanelFeature({
+      kind: "screen",
+      id: "items",
+      screen: "catalog:screen:items",
+      visibleWhen: { query: "catalog:query:items:ghost", field: "enabled", eq: true },
+    });
+    expect(() => validateBoot([feature, catalogFeature])).toThrow(
+      /screen-panel "items" visibleWhen query "catalog:query:items:ghost" is not a registered query-handler/,
+    );
+  });
+
+  test("rejects a visibleWhen with an empty field", () => {
+    const feature = screenPanelFeature({
+      kind: "screen",
+      id: "items",
+      screen: "catalog:screen:items",
+      visibleWhen: { query: "catalog:query:items:status", field: "", eq: true },
+    });
+    expect(() => validateBoot([feature, catalogFeature])).toThrow(
+      /visibleWhen needs a non-empty query and field/,
+    );
+  });
+
+  test("requiredKeysFromScreen sammelt ein gesetztes Screen-Panel-Label", () => {
+    const screen: DashboardScreenDefinition = {
+      id: "overview",
+      type: "dashboard",
+      panels: [
+        {
+          kind: "screen",
+          id: "items",
+          screen: "catalog:screen:items",
+          label: "demo:dashboard:panel:latest",
+        },
+      ],
+    };
+    expect(requiredKeysFromScreen("demo", screen)).toContain("demo:dashboard:panel:latest");
+  });
+});

package/src/engine/__tests__/boot-validator-detail-for.test.ts

@@ -6,7 +6,13 @@ import { createEntity, createTextField } from "../factories";
 describe("validateBoot — detailFor screens (fw#2163)", () => {
   test("two screens with the same detailFor fail boot, naming both screen ids", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("item", createEntity({ table: "Items", fields: { name: createTextField() } }));
+      r.entity(
+        "item",
+        createEntity({
+          table: "Items",
+          fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.screen({
         id: "item-detail-a",
         type: "custom",
@@ -34,7 +40,13 @@ describe("validateBoot — detailFor screens (fw#2163)", () => {
 
   test("detailFor on an unknown entity fails boot", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("item", createEntity({ table: "Items", fields: { name: createTextField() } }));
+      r.entity(
+        "item",
+        createEntity({
+          table: "Items",
+          fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.screen({
         id: "item-detail",
         type: "custom",
@@ -53,7 +65,13 @@ describe("validateBoot — detailFor screens (fw#2163)", () => {
 
   test("a valid detailFor on a custom screen passes boot", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("item", createEntity({ table: "Items", fields: { name: createTextField() } }));
+      r.entity(
+        "item",
+        createEntity({
+          table: "Items",
+          fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.screen({
         id: "item-detail",
         type: "custom",
@@ -72,7 +90,13 @@ describe("validateBoot — detailFor screens (fw#2163)", () => {
 
   test("an entity without any detail screen passes boot", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("item", createEntity({ table: "Items", fields: { name: createTextField() } }));
+      r.entity(
+        "item",
+        createEntity({
+          table: "Items",
+          fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.translations({
         keys: { "demo:entity:item:field:name": { de: "Name", en: "Name" } },
       });

package/src/engine/__tests__/boot-validator-entity-list.test.ts

@@ -10,7 +10,9 @@ describe("validateBoot — entityList screens", () => {
         "item",
         createEntity({
           table: "Items",
-          fields: { name: createTextField({ sortable: true }) },
+          fields: {
+            name: createTextField({ sortable: true, personal: false, reason: "test_fixture" }),
+          },
         }),
       );
       r.screen({
@@ -31,7 +33,13 @@ describe("validateBoot — entityList screens", () => {
 
   test("rejects searchable:false on operator lists not on whitelist", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("item", createEntity({ table: "Items", fields: { name: createTextField() } }));
+      r.entity(
+        "item",
+        createEntity({
+          table: "Items",
+          fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.screen({
         id: "item-list",
         type: "entityList",
@@ -51,7 +59,13 @@ describe("validateBoot — entityList screens", () => {
 
   test("allows searchable:false on download-attempt-list whitelist", () => {
     const feature = defineFeature("demo", (r) => {
-      r.entity("attempt", createEntity({ table: "Attempts", fields: { id: createTextField() } }));
+      r.entity(
+        "attempt",
+        createEntity({
+          table: "Attempts",
+          fields: { id: createTextField({ personal: false, reason: "test_fixture" }) },
+        }),
+      );
       r.screen({
         id: "download-attempt-list",
         type: "entityList",
@@ -75,7 +89,9 @@ describe("validateBoot — entityList screens", () => {
         "item",
         createEntity({
           table: "Items",
-          fields: { name: createTextField({ sortable: true }) },
+          fields: {
+            name: createTextField({ sortable: true, personal: false, reason: "test_fixture" }),
+          },
         }),
       );
       r.screen({

package/src/engine/__tests__/boot-validator-i18n-keys.test.ts

@@ -10,7 +10,9 @@ describe("validateBoot — i18n surface keys", () => {
         "item",
         createEntity({
           table: "Items",
-          fields: { name: createTextField({ sortable: true }) },
+          fields: {
+            name: createTextField({ sortable: true, personal: false, reason: "test_fixture" }),
+          },
         }),
       );
       r.screen({
@@ -36,7 +38,9 @@ describe("validateBoot — i18n surface keys", () => {
         "item",
         createEntity({
           table: "Items",
-          fields: { name: createTextField({ sortable: true }) },
+          fields: {
+            name: createTextField({ sortable: true, personal: false, reason: "test_fixture" }),
+          },
         }),
       );
       r.screen({
@@ -63,7 +67,9 @@ describe("validateBoot — i18n surface keys", () => {
         "item",
         createEntity({
           table: "Items",
-          fields: { name: createTextField({ sortable: true }) },
+          fields: {
+            name: createTextField({ sortable: true, personal: false, reason: "test_fixture" }),
+          },
         }),
       );
       r.screen({