@cosmicdrift/kumiko-framework 0.226.0 → 0.228.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.226.0",
+  "version": "0.228.0",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -198,7 +198,7 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-types": "0.226.0",
+    "@cosmicdrift/kumiko-types": "0.228.0",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -214,7 +214,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.226.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.228.0",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/engine/__tests__/screen.test.ts

@@ -149,7 +149,31 @@ describe("r.screen() — registration", () => {
     expect(() => validateBoot(features)).toThrow(/zero fields/i);
   });
 
-  test("validateBoot rejects a projectionDetail with an extension section (no entity to persist against)", () => {
+  test("validateBoot rejects a projectionDetail extension section with contributesToFormSubmit: true (read-only screen, solon#264)", () => {
+    const features = [
+      defineFeature("app", (r) => {
+        r.screen({
+          id: "x",
+          type: "projectionDetail",
+          query: "app:query:foo:detail",
+          layout: {
+            sections: [
+              {
+                kind: "extension",
+                title: "s",
+                component: { react: { __component: "c" } },
+                entityName: "lease",
+                contributesToFormSubmit: true,
+              },
+            ],
+          },
+        });
+      }),
+    ];
+    expect(() => validateBoot(features)).toThrow(/no form submit to contribute to/i);
+  });
+
+  test("validateBoot rejects a projectionDetail extension section without entityName", () => {
     const features = [
       defineFeature("app", (r) => {
         r.screen({
@@ -164,7 +188,49 @@ describe("r.screen() — registration", () => {
         });
       }),
     ];
-    expect(() => validateBoot(features)).toThrow(/extension section/i);
+    expect(() => validateBoot(features)).toThrow(/has no entityName/i);
+  });
+
+  test("validateBoot rejects a projectionDetail extension section with no component", () => {
+    const features = [
+      defineFeature("app", (r) => {
+        r.screen({
+          id: "x",
+          type: "projectionDetail",
+          query: "app:query:foo:detail",
+          layout: {
+            sections: [{ kind: "extension", title: "s", component: {}, entityName: "lease" }],
+          },
+        });
+      }),
+    ];
+    expect(() => validateBoot(features)).toThrow(/has no component/i);
+  });
+
+  test("validateBoot boots a projectionDetail extension section without contributesToFormSubmit (self-persisting, solon#264)", () => {
+    const features = [
+      defineFeature("app", (r) => {
+        r.queryHandler("foo:detail", z.object({}), async () => ({}), {
+          access: { openToAll: true },
+        });
+        r.screen({
+          id: "x",
+          type: "projectionDetail",
+          query: "app:query:foo:detail",
+          layout: {
+            sections: [
+              {
+                kind: "extension",
+                title: "s",
+                component: { react: { __component: "c" } },
+                entityName: "lease",
+              },
+            ],
+          },
+        });
+      }),
+    ];
+    expect(() => validateBoot(features)).not.toThrow();
   });
 
   test("validateBoot rejects a projectionDetail relatedList section with an empty query (fw#2166)", () => {

package/src/engine/boot-validator/screens.ts

@@ -663,11 +663,37 @@ export function validateScreens(
       }
       for (const section of screen.layout.sections) {
         if (isExtensionEditSection(section)) {
-          throw new Error(
-            `[Feature ${feature.name}] Screen "${screenId}" (projectionDetail) extension section ` +
-              `"${section.title}" is not supported — projectionDetail has no entity for an extension ` +
-              `section to persist against.`,
-          );
+          // projectionDetail is read-only (no composed form submit) — an
+          // extension that persists through the host's Save button has
+          // nothing to save against. Extensions that persist themselves
+          // (e.g. notes-history NotesSection, via their own dispatcher
+          // writes) are fine (solon#264).
+          if (section.contributesToFormSubmit === true) {
+            throw new Error(
+              `[Feature ${feature.name}] Screen "${screenId}" (projectionDetail) extension section ` +
+                `"${section.title}" sets contributesToFormSubmit: true, but projectionDetail has no ` +
+                `form submit to contribute to (read-only screen). Omit contributesToFormSubmit and ` +
+                `persist through the extension's own dispatcher writes instead.`,
+            );
+          }
+          if (section.component?.react === undefined && section.component?.native === undefined) {
+            throw new Error(
+              `[Feature ${feature.name}] Screen "${screenId}" (projectionDetail) extension section ` +
+                `"${section.title}" has no component — declare a react/native component marker.`,
+            );
+          }
+          // The host-derived entity name on projectionDetail is an internal
+          // placeholder (no real entity backs this screen) — a self-
+          // persisting extension needs the real domain entity name declared
+          // explicitly, or it silently reads/writes against the wrong type.
+          if (section.entityName === undefined || section.entityName.trim().length === 0) {
+            throw new Error(
+              `[Feature ${feature.name}] Screen "${screenId}" (projectionDetail) extension section ` +
+                `"${section.title}" has no entityName — projectionDetail has no real entity, so the ` +
+                `extension must declare entityName explicitly (the domain entity it persists against).`,
+            );
+          }
+          continue;
         }
         if (section.kind === "relatedList") {
           if (!section.query || typeof section.query !== "string") {

package/src/i18n/required-surface-keys.ts

@@ -226,7 +226,10 @@ export function requiredKeysFromScreen(
     case "projectionDetail": {
       const detail = screen as ProjectionDetailScreenDefinition;
       for (const section of detail.layout.sections) {
-        if (isExtensionEditSection(section)) continue; // rejected at boot, unreachable here
+        if (isExtensionEditSection(section)) {
+          pushKey(out, section.title);
+          continue;
+        }
         if (section.kind === "relatedList") {
           pushKey(out, section.title);
           for (const col of section.columns) {