@cosmicdrift/kumiko-framework 0.220.0 → 0.220.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.220.0",
+  "version": "0.220.1",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -194,7 +194,7 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-types": "0.220.0",
+    "@cosmicdrift/kumiko-types": "0.220.1",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -210,7 +210,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.220.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.220.1",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/api/__tests__/request-locale.integration.test.ts

@@ -85,7 +85,7 @@ describe("ctx.locale falls back to the app's boot-configured defaultLocale", ()
   beforeAll(async () => {
     stack = await setupTestStack({
       features: [localeProbe],
-      extraContext: { defaultLocale: "ja" },
+      defaultLocale: "ja",
     });
   });
 
@@ -108,7 +108,7 @@ describe("ctx.locale falls back to SessionUser.locale ahead of the boot default"
   beforeAll(async () => {
     stack = await setupTestStack({
       features: [localeProbe],
-      extraContext: { defaultLocale: "ja" },
+      defaultLocale: "ja",
     });
   });
 

package/src/pipeline/__tests__/event-dispatcher-pg-listen.integration.test.ts

@@ -38,7 +38,7 @@ const executor = createEventStoreExecutor(sharedWidgetTable, sharedWidgetEntity,
   entityName: "widget",
 });
 
-const deliveryTimes: number[] = [];
+let deliveryCount = 0;
 
 const listenFeature = defineFeature("listen", (r) => {
   r.entity("widget", sharedWidgetEntity);
@@ -47,7 +47,7 @@ const listenFeature = defineFeature("listen", (r) => {
     name: "latency-probe",
     apply: {
       "widget.created": async () => {
-        deliveryTimes.push(Date.now());
+        deliveryCount += 1;
       },
     },
   });
@@ -79,17 +79,17 @@ afterAll(async () => {
 
 describe("E.4 — PG NOTIFY/LISTEN wake-up", () => {
   test("NOTIFY on commit triggers runOnce without waiting for the poll timer", async () => {
-    deliveryTimes.length = 0;
+    deliveryCount = 0;
 
     await stack.eventDispatcher?.start();
     try {
       await executor.create({ name: "latency-test" }, admin, tdb);
 
       const deadline = Date.now() + 5000;
-      while (Date.now() < deadline && deliveryTimes.length === 0) {
+      while (Date.now() < deadline && deliveryCount === 0) {
         await new Promise((r) => setTimeout(r, 5));
       }
-      expect(deliveryTimes).toHaveLength(1);
+      expect(deliveryCount).toBe(1);
     } finally {
       await stack.eventDispatcher?.stop();
     }
@@ -105,16 +105,16 @@ describe("E.4 — PG NOTIFY/LISTEN wake-up", () => {
       await stack.eventDispatcher?.stop();
     }
 
-    deliveryTimes.length = 0;
+    deliveryCount = 0;
     await stack.eventDispatcher?.start();
     try {
       await executor.create({ name: "restart-probe" }, admin, tdb);
 
       const deadline = Date.now() + 5000;
-      while (Date.now() < deadline && deliveryTimes.length === 0) {
+      while (Date.now() < deadline && deliveryCount === 0) {
         await new Promise((r) => setTimeout(r, 5));
       }
-      expect(deliveryTimes).toHaveLength(1);
+      expect(deliveryCount).toBe(1);
     } finally {
       await stack.eventDispatcher?.stop();
     }

package/src/pipeline/__tests__/load-aggregate-query.integration.test.ts

@@ -190,10 +190,12 @@ describe("ctx.loadAggregate via queryHandler — Marten AggregateStreamAsync equ
       { customer: "TimeTraveler", status: "draft" },
       admin,
     );
-    // Capture the event timestamp from the events-table for a precise cutoff.
-    // A too-small offset risks clock granularity flakes — we rely on the
-    // millisecond-precision timestamp column.
-    const preApprove = new Date();
+    // Cutoff must come from the event row's created_at (Postgres now()), not
+    // host wall-clock — Docker clock skew made Date()-based cutoffs exclude
+    // the create event (fw#2425).
+    const beforeApprove = await loadAggregateRaw(stack.db, created.id, admin.tenantId);
+    expect(beforeApprove).toHaveLength(1);
+    const preApprove = beforeApprove[0]!.createdAt;
     // Make sure the next event's createdAt is strictly after the cutoff.
     await new Promise((r) => setTimeout(r, 10));
     await stack.http.writeOk(
@@ -210,10 +212,10 @@ describe("ctx.loadAggregate via queryHandler — Marten AggregateStreamAsync equ
     );
     expect(now.approved).toBe(true);
 
-    // asOf preApprove: the approval is in the future, not yet visible.
+    // asOf create.createdAt: the approval is in the future, not yet visible.
     const past = await stack.http.queryOk<{ approved: boolean; status: string }>(
       "asoftest:query:invoice:state",
-      { id: created.id, asOf: preApprove.toISOString() },
+      { id: created.id, asOf: preApprove.toString() },
       admin,
     );
     expect(past.approved).toBe(false);

package/src/scripts/codemod/pii-personal-migration.ts

@@ -204,15 +204,22 @@ function processObjectLiteral(obj: ObjectLiteralExpression, factoryName: string)
   }
 
   if (subjectProps.length > 1) {
-    report(
-      subjectProps[0]!.prop,
-      `multiple subject annotations on one field (${subjectProps.map((s) => s.name).join(", ")}) — needs a human decision on which subject is correct`,
-    );
+    const first = subjectProps[0];
+    if (first) {
+      report(
+        first.prop,
+        `multiple subject annotations on one field (${subjectProps.map((s) => s.name).join(", ")}) — needs a human decision on which subject is correct`,
+      );
+    }
     // skip: reported above — multiple subject annotations need a human call on which one wins
     return;
   }
 
-  const subject = subjectProps[0]!;
+  const subject = subjectProps[0];
+  if (!subject) {
+    // skip: length===0 and length>1 already returned — empty [0] is unreachable
+    return;
+  }
 
   if (NO_PERSONAL_FACTORIES.has(factoryName)) {
     report(
@@ -276,12 +283,13 @@ function processObjectLiteral(obj: ObjectLiteralExpression, factoryName: string)
       return;
     }
     const ownerFieldProp = findProp(init, "ownerField");
-    if (!ownerFieldProp?.getInitializer()) {
+    const ownerFieldInit = ownerFieldProp?.getInitializer();
+    if (!ownerFieldInit) {
       report(subject.prop, 'userOwned is missing an "ownerField" property');
       // skip: reported above — userOwned is missing its ownerField property
       return;
     }
-    personalInit = `{ of: ${ownerFieldProp.getInitializer()!.getText()} }`;
+    personalInit = `{ of: ${ownerFieldInit.getText()} }`;
   }
 
   const subjectIsRefOrPlaintext =
@@ -331,9 +339,9 @@ function processObjectLiteral(obj: ObjectLiteralExpression, factoryName: string)
   const hasSearchable = !!searchableProp;
   const hasSensitive = !!sensitiveProp;
 
-  if (hasSensitive && (hasLookupable || hasSearchable)) {
+  if (sensitiveProp && (hasLookupable || hasSearchable)) {
     report(
-      sensitiveProp!,
+      sensitiveProp,
       'sensitive combined with lookupable/searchable — two find values ("secret" vs "exact"/"fuzzy"), needs a human decision',
     );
     // skip: reported above — sensitive plus lookupable/searchable is an ambiguous find value
@@ -348,10 +356,13 @@ function processObjectLiteral(obj: ObjectLiteralExpression, factoryName: string)
   else find = "none";
 
   if (isLongTextFind && (find === "exact" || find === "fuzzy")) {
-    report(
-      (lookupableProp ?? searchableProp)!,
-      'lookupable/searchable on createLongTextField — only "none"/"secret" are valid find values on longText',
-    );
+    const findSite = lookupableProp ?? searchableProp;
+    if (findSite) {
+      report(
+        findSite,
+        'lookupable/searchable on createLongTextField — only "none"/"secret" are valid find values on longText',
+      );
+    }
     // skip: reported above — exact/fuzzy find isn't valid on createLongTextField
     return;
   }
@@ -381,7 +392,12 @@ function applyTransform(
   next: { personal: string; reason: string | undefined; find: string | undefined },
 ): void {
   const properties = obj.getProperties();
-  const anchor = removedProps[0]!;
+  // Call sites always pass at least subject.prop; without an anchor there is nowhere to insert.
+  const anchor = removedProps[0];
+  if (!anchor) {
+    // skip: no removed prop to anchor inserts on — nothing to transform
+    return;
+  }
   const anchorIndex = properties.indexOf(anchor);
   const removedSet = new Set<PropertyAssignment>(removedProps);
   let insertIndex = 0;

package/src/stack/test-stack.ts

@@ -72,6 +72,8 @@ export type TestStackOptions = {
   jwtSecret?: string;
   /** Extra fields merged into the AppContext (e.g. _notifyFactory, configResolver).
    *  Can be a function receiving (registry, db, sseBroker) for late binding. */
+  /** Boot default locale (BCP-47) merged into AppContext before extraContext. */
+  defaultLocale?: string;
   extraContext?:
     | Record<string, unknown>
     | ((deps: {
@@ -294,6 +296,7 @@ export async function setupTestStack(options: TestStackOptions): Promise<TestSta
     registry,
     ...(options.masterKeyProvider ? { masterKeyProvider: options.masterKeyProvider } : {}),
     ...(fileProviderResolver ? { _fileProviderResolver: fileProviderResolver } : {}),
+    ...(options.defaultLocale !== undefined && { defaultLocale: options.defaultLocale }),
     ...(typeof options.extraContext === "function"
       ? options.extraContext({ registry, db: testDb.db, sseBroker, redis: testRedis.redis })
       : options.extraContext),

package/src/upgrade-cli.ts

@@ -325,9 +325,11 @@ async function applyCodemods(
     return 0;
   }
 
+  const firstPending = pending[0];
+  if (!firstPending) return 0;
   const latestVersion = pending.reduce(
     (max, e) => (compareVersions(e.version, max) > 0 ? e.version : max),
-    pending[0]!.version,
+    firstPending.version,
   );
   writeUpgradeMarker(targetDir, {
     version: latestVersion,