@cosmicdrift/kumiko-framework 0.205.0 → 0.206.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.205.0",
+  "version": "0.206.0",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -190,7 +190,7 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-types": "0.205.0",
+    "@cosmicdrift/kumiko-types": "0.206.0",
     "bullmq": "^5.76.7",
     "bun-types": "^1.3.13",
     "hono": "^4.13.1",
@@ -206,7 +206,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.205.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.206.0",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/db/index.ts

@@ -108,6 +108,7 @@ export {
   isUniqueViolation,
   type PgErrorInfo,
 } from "./pg-error";
+export { acquireNamespacedAdvisoryLock } from "./queries/advisory-lock";
 export type { SelectOptions, WhereObject, WhereValue } from "./query-api";
 export {
   asRawClient,

package/src/db/queries/advisory-lock.ts

@@ -0,0 +1,11 @@
+import type { AnyDb } from "../query";
+import { asRawClient } from "../query";
+
+/** pg_advisory_xact_lock keyed on namespace+key hash — xact-scoped, auto-released at commit/rollback. */
+export async function acquireNamespacedAdvisoryLock(
+  db: AnyDb,
+  namespace: number,
+  key: string,
+): Promise<void> {
+  await asRawClient(db).unsafe(`SELECT pg_advisory_xact_lock($1, hashtext($2))`, [namespace, key]);
+}

package/src/engine/__tests__/boot-validator-projection-list.test.ts

@@ -188,4 +188,54 @@ describe("validateBoot — projectionList screens", () => {
     });
     expect(() => validateBoot([feature])).toThrow(/paginated is derived/);
   });
+
+  // fw#2164 Nebenbefund: the "at most one rowClick:true" cap (already
+  // enforced for entityList) didn't run for projectionList — a boot-time
+  // gap, not a rendering one (the renderer only wires the first match, see
+  // ProjectionListBody), but two conflicting rowClick actions on the same
+  // screen should still fail loud instead of silently picking one.
+  describe("projectionList rowAction rowClick", () => {
+    function makeFeature(rowClickCount: number) {
+      return defineFeature("ledger", (r) => {
+        r.queryHandler(
+          "schedule:list",
+          z.object({}),
+          async () => ({ rows: [], nextCursor: null }),
+          {
+            access: { openToAll: true },
+          },
+        );
+        r.screen({ id: "schedule-detail", type: "custom", renderer: { react: "stub" } });
+        r.screen({
+          id: "schedule-list",
+          type: "projectionList",
+          query: "ledger:query:schedule:list",
+          columns: ["description"],
+          rowActions: Array.from({ length: rowClickCount }, (_, i) => ({
+            kind: "navigate" as const,
+            id: `open-${i}`,
+            label: "actions.open",
+            screen: "schedule-detail",
+            rowClick: true,
+          })),
+        });
+        r.translations({
+          keys: {
+            "screen:schedule-list.title": { de: "Liste", en: "List" },
+            "screen:schedule-detail.title": { de: "Detail", en: "Detail" },
+          },
+        });
+      });
+    }
+
+    test("one rowClick navigate action passes boot", () => {
+      expect(() => validateBoot([makeFeature(1)])).not.toThrow();
+    });
+
+    test("more than one rowClick action per list is rejected", () => {
+      expect(() => validateBoot([makeFeature(2)])).toThrow(
+        /at most one may fire on a row-body click/i,
+      );
+    });
+  });
 });

package/src/engine/boot-validator/screens.ts

@@ -25,6 +25,24 @@ import type {
   ToolbarAction,
 } from "../types/screen";
 
+// entityList and projectionList both allow a rowAction to double as the
+// row-body click target (rowClick: true, fw#1708/#2164) — at most one per
+// screen, or the renderer can't tell which one should fire.
+function validateAtMostOneRowClick(
+  featureName: string,
+  screenId: string,
+  screenType: "entityList" | "projectionList",
+  rowActions: readonly RowAction[],
+): void {
+  const rowClickActions = rowActions.filter((a) => a.kind === "navigate" && a.rowClick === true);
+  if (rowClickActions.length > 1) {
+    throw new Error(
+      `[Feature ${featureName}] Screen "${screenId}" (${screenType}) has ${rowClickActions.length} ` +
+        "rowActions marked rowClick:true — at most one may fire on a row-body click.",
+    );
+  }
+}
+
 // A field type in NO_WIDGET_FIELD_TYPES renders read-only on the auto-wired
 // entityEdit path (#1925) — a required field the user can never fill would
 // block every save. Only the statically-resolvable case is caught here: a
@@ -354,6 +372,7 @@ export function validateScreens(
             );
           }
         }
+        validateAtMostOneRowClick(feature.name, screenId, "projectionList", screen.rowActions);
       }
       continue;
     }
@@ -889,15 +908,7 @@ export function validateScreens(
             rowMeta,
           );
         }
-        const rowClickActions = screen.rowActions.filter(
-          (a) => a.kind === "navigate" && a.rowClick === true,
-        );
-        if (rowClickActions.length > 1) {
-          throw new Error(
-            `[Feature ${feature.name}] Screen "${screenId}" (entityList) has ${rowClickActions.length} ` +
-              "rowActions marked rowClick:true — at most one may fire on a row-body click.",
-          );
-        }
+        validateAtMostOneRowClick(feature.name, screenId, "entityList", screen.rowActions);
       }
       // Tier 2.7e-2: toolbarActions — analog zu rowActions, aber bisher
       // ohne Validator. Typo'd navigate-targets und unregistrierte