@cosmicdrift/kumiko-framework 0.147.2 → 0.148.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.147.2",
+  "version": "0.148.0",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -193,7 +193,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.147.2",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.148.0",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/engine/__tests__/build-app-schema.test.ts

@@ -47,6 +47,38 @@ describe("buildAppSchema", () => {
     expect(fleet?.entities["vehicle"]).toBeDefined();
   });
 
+  // #1059: r.translations({keys}) must flow into FeatureSchema.translations
+  // BYTE-IDENTICAL — nav/screen labels resolve these keys verbatim via
+  // t(label) client-side, so any re-prefixing (like the registry's internal
+  // mergedTranslations does for features whose keys already carry a colon)
+  // would break the lookup. Mirrors cap-counter's real shape exactly: nav
+  // label references its own already-qualified translation key.
+  test("r.translations landet verbatim in FeatureSchema.translations, ohne Re-Prefixing", () => {
+    const capCounterLikeFeature = defineFeature("cap-counter", (r) => {
+      r.nav({ id: "cap-list", label: "cap-counter:nav.cap-list" });
+      r.translations({
+        keys: {
+          "cap-counter:nav.cap-list": { de: "Limits", en: "Caps" },
+        },
+      });
+    });
+
+    const app = buildAppSchema(createRegistry([capCounterLikeFeature]));
+    const feature = app.features.find((f) => f.featureName === "cap-counter");
+
+    expect(feature?.translations).toEqual({
+      "cap-counter:nav.cap-list": { de: "Limits", en: "Caps" },
+    });
+  });
+
+  test("Feature ohne r.translations lässt das Feld weg (omit-undefined-Pattern)", () => {
+    const f = defineFeature("bare", (r) => {
+      r.nav({ id: "x", label: "X" });
+    });
+    const app = buildAppSchema(createRegistry([f]));
+    expect(app.features[0]?.translations).toBeUndefined();
+  });
+
   test("Workspaces — definition + aufgelöste navMembers landen auf AppSchema-Ebene", () => {
     const ordersFeature = defineFeature("orders", (r) => {
       r.nav({ id: "list", label: "List" });

package/src/engine/build-app-schema.ts

@@ -17,6 +17,8 @@
 //              sind plain literals)
 //   Nav:       verbatim (NavDefinition ist nur strings + literals)
 //   Workspace: verbatim definition + getWorkspaceNavs() von der Registry
+//   Translations: verbatim feature.translations (raw r.translations keys,
+//                 unfiltered — see FeatureSchema.translations doc)
 //
 // Feature-Toggles: BISHER NICHT GEFILTERT. Wenn ein Feature über die
 // feature-toggles-bundled-feature global deaktiviert ist, erscheint es
@@ -49,6 +51,12 @@ export function buildAppSchema(registry: Registry, options: BuildAppSchemaOption
       entities: projectEntities(feature.entities ?? {}),
       screens: Object.values(feature.screens),
       ...(navs.length > 0 && { navs }),
+      // #1059: verbatim r.translations({keys}) — see FeatureSchema.translations
+      // doc for why this must NOT go through registry.getAllTranslations()
+      // (double-prefixes features that already qualify their own keys).
+      ...(Object.keys(feature.translations ?? {}).length > 0 && {
+        translations: feature.translations,
+      }),
     };
     features.push(featureSchema);
   }

package/src/ui-types/app-schema.ts

@@ -7,6 +7,7 @@
 // web), Runtime-Helpers (toAppSchema, isAppSchema) bleiben renderer-side
 // weil das die Layer ist die mit den AppSchemas zur Laufzeit arbeitet.
 
+import type { TranslationKeys } from "../engine/types/config";
 import type { EntityDefinition } from "../engine/types/fields";
 import type { NavDefinition } from "../engine/types/nav";
 import type { ScreenDefinition } from "../engine/types/screen";
@@ -19,6 +20,17 @@ export type FeatureSchema = {
   // Flat list; resolveNavigation builds the tree at render-time from
   // the registry's indexes. Omitted when the app has no top-level nav.
   readonly navs?: readonly NavDefinition[];
+  // Server-authored `r.translations({ keys })`, projected verbatim — byte-
+  // identical keys, NOT re-prefixed with featureName (unlike the registry's
+  // internal mergedTranslations, which double-prefixes features that
+  // already qualify their own keys — see registry-ingest.ts populate
+  // Translations). Nav/screen labels resolve these keys directly via
+  // `t(label)`, so shipping anything other than the raw authored string
+  // would break the lookup. Omitted when a feature declares none. #1059:
+  // without this, nav labels only resolved when an app ALSO duplicated the
+  // key in `web/i18n.ts` — most bundled features never did, so labels
+  // rendered as raw i18n keys in the shell.
+  readonly translations?: TranslationKeys;
   // Workspaces — Legacy-Slot für single-feature-Apps. Bevorzugt liegt
   // workspaces auf der AppSchema-Ebene weil ihre navMembers regelmäßig
   // Cross-Feature-Navs referenzieren (siehe AppSchema-Doc). Hier als