@cosmicdrift/kumiko-framework 0.121.1 → 0.122.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-framework",
-  "version": "0.121.1",
+  "version": "0.122.1",
   "description": "Framework core — engine, pipeline, API, DB, and every other bit that makes Kumiko go.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -135,6 +135,10 @@
       "types": "./src/crypto/index.ts",
       "default": "./src/crypto/index.ts"
     },
+    "./logging": {
+      "types": "./src/logging/index.ts",
+      "default": "./src/logging/index.ts"
+    },
     "./schema-cli": {
       "types": "./src/schema-cli.ts",
       "default": "./src/schema-cli.ts"
@@ -185,7 +189,7 @@
     "zod": "^4.4.3"
   },
   "devDependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.121.1",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.122.1",
     "bun-types": "^1.3.13",
     "pino-pretty": "^13.1.3"
   },

package/src/db/__tests__/rebuild-marker.test.ts

@@ -28,14 +28,16 @@ function tmpDir(): string {
 }
 
 describe("rebuildTablesFromDiff", () => {
-  test("managed: new + changed tables included, dropped excluded, sorted + unique", () => {
+  test("managed: new table rebuilt, additive-only change NOT rebuilt, dropped excluded", () => {
+    // read_a: nur eine nullable Spalte dazu → in-place ALTER, kein Rebuild.
+    // read_b: neue Tabelle → Rebuild. read_c gedroppt → nie im Marker.
     const prev = snapshotFromMetas([meta("read_a"), meta("read_c")]);
     const next = snapshotFromMetas([
       meta("read_a", { name: "title", pgType: "text", notNull: false }),
       meta("read_b"),
     ]);
     const diff = diffSnapshots(prev, next);
-    expect(rebuildTablesFromDiff(diff)).toEqual(["read_a", "read_b"]);
+    expect(rebuildTablesFromDiff(diff)).toEqual(["read_b"]);
   });
 
   test("no schema change → empty", () => {
@@ -51,11 +53,19 @@ describe("rebuildTablesFromDiff", () => {
     expect(rebuildTablesFromDiff(diffSnapshots(prev, next))).toEqual([]);
   });
 
-  test("managed new nullable column → rebuild (Backfill aus Events nötig)", () => {
+  test("managed new NULLABLE column → NO rebuild (in-place ADD COLUMN reicht; Rebuild würde die Spalte wischen, #835)", () => {
     const prev = snapshotFromMetas([meta("read_a")]);
     const next = snapshotFromMetas([
       meta("read_a", { name: "title", pgType: "text", notNull: false }),
     ]);
+    expect(rebuildTablesFromDiff(diffSnapshots(prev, next))).toEqual([]);
+  });
+
+  test("managed new NOT-NULL column ohne Default → rebuild (recreate, kann nicht in-place)", () => {
+    const prev = snapshotFromMetas([meta("read_a")]);
+    const next = snapshotFromMetas([
+      meta("read_a", { name: "title", pgType: "text", notNull: true }),
+    ]);
     expect(rebuildTablesFromDiff(diffSnapshots(prev, next))).toEqual(["read_a"]);
   });
 

package/src/db/queries/projection-rebuild.ts

@@ -23,12 +23,19 @@ export async function selectEventsForProjectionRebuildBatch(
   afterId: bigint,
   limit: number,
 ): Promise<ReadonlyArray<Record<string, unknown>>> {
+  // Archived streams don't replay (Marten-aligned): their aggregates are
+  // frozen ops-tombstones — replaying them would resurrect rows (or, for
+  // stranded duplicate-aggregates like fw#832, collide on unique indexes).
   return (await asRawClient(db).unsafe(
-    `SELECT * FROM "kumiko_events"
-     WHERE "aggregate_type" = ANY($1::text[])
-       AND "type" = ANY($2::text[])
-       AND "id" > $3
-     ORDER BY "id" ASC
+    `SELECT * FROM "kumiko_events" e
+     WHERE e."aggregate_type" = ANY($1::text[])
+       AND e."type" = ANY($2::text[])
+       AND e."id" > $3
+       AND NOT EXISTS (
+         SELECT 1 FROM "kumiko_archived_streams" a
+          WHERE a."tenant_id" = e."tenant_id" AND a."aggregate_id" = e."aggregate_id"
+       )
+     ORDER BY e."id" ASC
      LIMIT $4`,
     [aggregateTypes, eventTypes, afterId, limit],
   )) as ReadonlyArray<Record<string, unknown>>;
@@ -43,10 +50,17 @@ export async function countSubscribedEvents(
   aggregateTypes: readonly string[],
   eventTypes: readonly string[],
 ): Promise<bigint> {
+  // Same archived-streams exclusion as the batch query — the #443 recompute
+  // compares this count against applied events; a filter mismatch would make
+  // every rebuild with an archived stream loop the full-re-replay forever.
   const rows = (await asRawClient(db).unsafe(
-    `SELECT count(*)::bigint AS n FROM "kumiko_events"
-     WHERE "aggregate_type" = ANY($1::text[])
-       AND "type" = ANY($2::text[])`,
+    `SELECT count(*)::bigint AS n FROM "kumiko_events" e
+     WHERE e."aggregate_type" = ANY($1::text[])
+       AND e."type" = ANY($2::text[])
+       AND NOT EXISTS (
+         SELECT 1 FROM "kumiko_archived_streams" a
+          WHERE a."tenant_id" = e."tenant_id" AND a."aggregate_id" = e."aggregate_id"
+       )`,
     [aggregateTypes, eventTypes],
   )) as ReadonlyArray<{ n: bigint | string | number | null }>;
   const raw = rows[0]?.n;

package/src/db/rebuild-marker.ts

@@ -32,12 +32,28 @@ function markerPathFor(migrationsDir: string, migrationId: string): string {
   return join(migrationsDir, `${migrationId}.rebuild.json`);
 }
 
-// Only managed tables (event-stream derivatives) get rebuild markers — unmanaged carry real data, never rebuilt from events; sorted+deduped for stable PR diff.
+// Only managed tables (event-stream derivatives) get rebuild markers — unmanaged
+// carry real data, never rebuilt from events; sorted+deduped for stable PR diff.
+//
+// A changed table needs a rebuild ONLY when the generated SQL RECREATES it
+// (managedChangeRequiresRecreate: drop/NOT-NULL-w/o-default/unique-index/type-
+// or nullability-change) — then the table is emptied and must be re-derived from
+// events. A pure additive nullable column is an in-place `ADD COLUMN` ALTER that
+// already brings the table to the target state (same logic #181 applied to
+// index-/default-only changes). Rebuilding it anyway is wasted replay AND — the
+// bug this closes — a co-triggered rebuild can drop the fresh column (rebuild
+// runs from the rebuilding process's registry meta; on a rolling deploy an older
+// pod's meta lacks the column → shadow-swap wipes it → phantom migration + boot-
+// drift crash; see 0008_add_pending_deletion_request_id / #494 / #835).
+//
+// If a NEW additive column genuinely needs value-backfill from historical events
+// (a column DERIVED from existing event fields), opt in explicitly by hand-adding
+// a `NNNN_<name>.rebuild.json` next to the migration (readRebuildMarker reads it).
 export function rebuildTablesFromDiff(diff: SchemaDiff): readonly string[] {
   const names = new Set<string>();
   for (const t of diff.changedTables) {
     if (t.nextMeta.source !== "managed") continue;
-    if (t.newColumns.length > 0 || managedChangeRequiresRecreate(t)) names.add(t.tableName);
+    if (managedChangeRequiresRecreate(t)) names.add(t.tableName);
   }
   for (const t of diff.newTables) {
     if (t.source === "managed") names.add(t.tableName);

package/src/pipeline/__tests__/projection-rebuild.integration.test.ts

@@ -26,7 +26,7 @@ import {
   defineFeature,
 } from "../../engine";
 import type { ProjectionDefinition } from "../../engine/types";
-import { createEventsTable } from "../../event-store";
+import { archiveStream, createEventsTable } from "../../event-store";
 import {
   createProjectionStateTable,
   getAllProjectionProgress,
@@ -116,7 +116,7 @@ afterAll(async () => {
 
 beforeEach(async () => {
   await asRawClient(testDb.db).unsafe(
-    `TRUNCATE kumiko_events, read_rebuild_items, read_rebuild_items_per_group, kumiko_projections RESTART IDENTITY CASCADE`,
+    `TRUNCATE kumiko_events, read_rebuild_items, read_rebuild_items_per_group, kumiko_projections, kumiko_archived_streams RESTART IDENTITY CASCADE`,
   );
 });
 
@@ -210,6 +210,36 @@ describe("rebuildProjection — happy path", () => {
     expect(result.eventsProcessed).toBe(0);
     expect(result.lastProcessedEventId).toBe(0n);
   });
+
+  test("archived streams don't replay (fw#832) — stranded aggregate heals via archiveStream", async () => {
+    // Heilungs-Muster fuer eventlose Read-Side-Deletes im Bestand: ein
+    // Aggregat, dessen Live-Row (vor dem fw#832-Fix) read-side entfernt
+    // wurde, hinterlaesst ein created-Event ohne deleted — jeder Rebuild
+    // wuerde die Row resurrecten (bzw. an unique-Indexen kollidieren).
+    // archiveStream friert den Stream ein UND nimmt ihn aus dem Replay.
+    const group = "00000000-0000-4000-8000-000000000020";
+    const stranded = await executor.create({ groupId: group, name: "stranded" }, admin, tdb);
+    if (!stranded.isSuccess) throw new Error("create failed");
+    await appendCreatedEvent(group, "survivor");
+
+    await archiveStream(testDb.db, {
+      tenantId: admin.tenantId,
+      aggregateId: String(stranded.data.id),
+      aggregateType: "rebuild-item",
+      archivedBy: "fw832-heal-test",
+    });
+
+    const result = await rebuildProjection(qualifiedProjectionName, {
+      db: testDb.db,
+      registry,
+    });
+
+    // Nur das survivor-Event replayed; das archivierte Aggregat traegt
+    // nicht mehr bei — auch nicht im #443-ground-truth-count (sonst
+    // wuerde der Recompute-Pfad endlos nachziehen).
+    expect(result.eventsProcessed).toBe(1);
+    expect(await getCount(group)).toBe(1);
+  });
 });
 
 describe("rebuildProjection — state table lifecycle", () => {