@cosmicdrift/kumiko-feature-ast 0.390.1 → 0.391.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-feature-ast",
-  "version": "0.390.1",
+  "version": "0.391.1",
   "description": "Feature-file AST for Kumiko: parse, patch and render feature definitions, the pattern library, and the codemods kumiko-upgrade runs.",
   "license": "MIT",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -22,8 +22,8 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.390.1",
-    "@cosmicdrift/kumiko-types": "0.390.1",
+    "@cosmicdrift/kumiko-framework": "0.391.1",
+    "@cosmicdrift/kumiko-types": "0.391.1",
     "ts-morph": "^28.0.0",
     "zod": "^4.6.7"
   },

package/src/changes.json

@@ -1,4 +1,16 @@
 [
+  {
+    "version": "0.391.1",
+    "type": "fix",
+    "title": "Type-aware codemods no longer exhaust memory when the app pins another zod",
+    "detail": "ctx-namespaces and remove-engine-payload-casts build their ts-morph project with a resolution host that resolves zod and its subpaths from the app root, so the program holds one zod copy even when bun nests a second version under each framework package. Without zod at the app root, resolution is unchanged. A small app with zod 4.6.6 next to framework packages on 4.6.7 went from 17 GB and 36 s to 1.1 GB and 3 s for ctx-namespaces, with the same rewrites."
+  },
+  {
+    "version": "0.391.0",
+    "type": "fix",
+    "title": "Codemods no longer fail when git is not installed",
+    "detail": "collectSourceFiles asks git check-ignore which files the repository's .gitignore excludes. Without a git executable Bun.spawnSync threw ENOENT and kumiko-upgrade --apply aborted at the first codemod, for example ctx-namespaces in the customer-app builder image. A missing git is now treated like a directory outside a repository: no file is filtered."
+  },
   {
     "version": "0.390.1",
     "type": "fix",

package/src/scripts/codemod/collect-source-files.ts

@@ -1,5 +1,6 @@
 import { lstatSync, readdirSync, statSync } from "node:fs";
 import { dirname, join, resolve } from "node:path";
+import { errorCodeOf } from "@cosmicdrift/kumiko-types/type-guards";
 
 export const BUILD_AND_VENDOR_DIR_NAMES: readonly string[] = [
   "node_modules",
@@ -68,15 +69,26 @@ export function envWithoutGitRepositoryOverrides(): Record<string, string> {
 // a codemod must not rewrite them.
 function withoutGitIgnored(cwd: string, files: readonly string[]): readonly string[] {
   if (files.length === 0) return files;
-  const result = Bun.spawnSync({
-    cmd: ["git", "check-ignore", "--stdin", "-z"],
-    cwd,
-    env: envWithoutGitRepositoryOverrides(),
-    stdin: Buffer.from(`${files.join("\0")}\0`),
-    stdout: "pipe",
-    stderr: "pipe",
-  });
-  if (result.exitCode !== GIT_CHECK_IGNORE_SOME_IGNORED) return files;
+  const result = runGitCheckIgnore(cwd, files);
+  if (result === undefined || result.exitCode !== GIT_CHECK_IGNORE_SOME_IGNORED) return files;
   const ignored = new Set(result.stdout.toString().split("\0"));
   return files.filter((file) => !ignored.has(file));
 }
+
+function runGitCheckIgnore(cwd: string, files: readonly string[]) {
+  try {
+    return Bun.spawnSync({
+      cmd: ["git", "check-ignore", "--stdin", "-z"],
+      cwd,
+      env: envWithoutGitRepositoryOverrides(),
+      stdin: Buffer.from(`${files.join("\0")}\0`),
+      stdout: "pipe",
+      stderr: "pipe",
+    });
+  } catch (error) {
+    // Build images such as the customer-app builder ship without git; like outside a repository,
+    // there is no .gitignore to honour then.
+    if (errorCodeOf(error) === "ENOENT") return undefined;
+    throw error;
+  }
+}

package/src/scripts/codemod/ctx-namespaces.ts

@@ -1,9 +1,9 @@
 import { existsSync, readFileSync, writeFileSync } from "node:fs";
 import { dirname, join, relative, resolve } from "node:path";
-import { Project } from "ts-morph";
 import { type CodemodSite, formatWithBiome } from "./codemod-support.ts";
 import { collectSourceFiles } from "./collect-source-files.ts";
 import { transformCtxNamespaces } from "./ctx-namespaces-transform.ts";
+import { createTypeAwareProject } from "./type-aware-project.ts";
 
 const NAME = "ctx-namespaces";
 
@@ -101,10 +101,7 @@ function runGroup(
   mode: Mode,
   totals: RunTotals,
 ): void {
-  const project = new Project({
-    ...(tsconfig === undefined ? {} : { tsConfigFilePath: tsconfig }),
-    skipAddingFilesFromTsConfig: true,
-  });
+  const project = createTypeAwareProject(tsconfig);
   totals.projects += 1;
   // Receivers are found through references: a structural helper is only recognised as taking a
   // handler context when its callers in other files are already part of the project.

package/src/scripts/codemod/remove-engine-payload-casts.ts

@@ -13,8 +13,9 @@
 // program, so the framework version the app compiles against decides the row type.
 
 import { dirname, resolve } from "node:path";
-import { type AsExpression, Node, Project, type SourceFile, SyntaxKind, ts } from "ts-morph";
+import { type AsExpression, Node, type Project, type SourceFile, SyntaxKind, ts } from "ts-morph";
 import { type CodemodResult, runCodemodCli } from "./codemod-support.ts";
+import { createTypeAwareProject } from "./type-aware-project.ts";
 
 const CAST_MARKER = "@cast-boundary";
 const EXECUTOR_TYPES_FILE = "/event-store-executor-types.ts";
@@ -278,7 +279,7 @@ function projectFor(filePath: string): Project | undefined {
   if (tsconfig === undefined) return undefined;
   const cached = projectsByTsconfig.get(tsconfig);
   if (cached !== undefined) return cached;
-  const project = new Project({ tsConfigFilePath: tsconfig, skipAddingFilesFromTsConfig: true });
+  const project = createTypeAwareProject(tsconfig);
   projectsByTsconfig.set(tsconfig, project);
   return project;
 }

package/src/scripts/codemod/type-aware-project.ts

@@ -0,0 +1,47 @@
+import { dirname, join, resolve } from "node:path";
+import { Project, type ResolutionHostFactory, ts } from "ts-morph";
+
+function isZodSpecifier(moduleName: string): boolean {
+  return moduleName === "zod" || moduleName.startsWith("zod/");
+}
+
+// A second zod nested under a package makes the checker compare schemas structurally across both
+// copies at every framework call, which exhausts memory; one copy keeps them nominal.
+function appRootZodResolution(appRoot: string): ResolutionHostFactory {
+  const appRootAnchor = join(appRoot, "codemod-resolution-anchor.ts");
+  return (moduleResolutionHost, getCompilerOptions) => {
+    const cache = ts.createModuleResolutionCache(
+      appRoot,
+      (fileName) => fileName,
+      getCompilerOptions(),
+    );
+    const resolveFrom = (moduleName: string, containingFile: string, options: ts.CompilerOptions) =>
+      ts.resolveModuleName(moduleName, containingFile, options, moduleResolutionHost, cache)
+        .resolvedModule;
+    return {
+      resolveModuleNames: (
+        moduleNames,
+        containingFile,
+        _reusedNames,
+        _redirectedReference,
+        options,
+      ) =>
+        moduleNames.map(
+          (moduleName) =>
+            (isZodSpecifier(moduleName)
+              ? resolveFrom(moduleName, appRootAnchor, options)
+              : undefined) ?? resolveFrom(moduleName, containingFile, options),
+        ),
+    };
+  };
+}
+
+export function createTypeAwareProject(tsconfig: string | undefined): Project {
+  if (tsconfig === undefined) return new Project({ skipAddingFilesFromTsConfig: true });
+  const tsConfigFilePath = resolve(tsconfig);
+  return new Project({
+    tsConfigFilePath,
+    skipAddingFilesFromTsConfig: true,
+    resolutionHost: appRootZodResolution(dirname(tsConfigFilePath)),
+  });
+}