@cosmicdrift/kumiko-feature-ast 0.390.0 → 0.391.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-feature-ast",
-  "version": "0.390.0",
+  "version": "0.391.0",
   "description": "Feature-file AST for Kumiko: parse, patch and render feature definitions, the pattern library, and the codemods kumiko-upgrade runs.",
   "license": "MIT",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -22,10 +22,10 @@
     }
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-framework": "0.390.0",
-    "@cosmicdrift/kumiko-types": "0.390.0",
+    "@cosmicdrift/kumiko-framework": "0.391.0",
+    "@cosmicdrift/kumiko-types": "0.391.0",
     "ts-morph": "^28.0.0",
-    "zod": "^4.4.3"
+    "zod": "^4.6.7"
   },
   "repository": {
     "type": "git",

package/src/changes.json

@@ -1,4 +1,16 @@
 [
+  {
+    "version": "0.391.0",
+    "type": "fix",
+    "title": "Codemods no longer fail when git is not installed",
+    "detail": "collectSourceFiles asks git check-ignore which files the repository's .gitignore excludes. Without a git executable Bun.spawnSync threw ENOENT and kumiko-upgrade --apply aborted at the first codemod, for example ctx-namespaces in the customer-app builder image. A missing git is now treated like a directory outside a repository: no file is filtered."
+  },
+  {
+    "version": "0.390.1",
+    "type": "fix",
+    "title": "Codemods skip gitignored files, ctx-namespaces finds structural helpers across files",
+    "detail": "collectSourceFiles, used by the codemods, leaves out files the repository's .gitignore excludes, such as generated output and local worktrees. The ctx-namespaces codemod loads all files of a tsconfig project before rewriting, so a helper with a structural `{ query }` context type is migrated even when its handler caller sits in a file processed later."
+  },
   {
     "version": "0.390.0",
     "type": "fix",

package/src/scripts/codemod/collect-source-files.ts

@@ -1,5 +1,6 @@
 import { lstatSync, readdirSync, statSync } from "node:fs";
-import { join, resolve } from "node:path";
+import { dirname, join, resolve } from "node:path";
+import { errorCodeOf } from "@cosmicdrift/kumiko-types/type-guards";
 
 export const BUILD_AND_VENDOR_DIR_NAMES: readonly string[] = [
   "node_modules",
@@ -41,8 +42,53 @@ export function collectSourceFiles(
   const files: string[] = [];
   for (const p of paths) {
     const abs = resolve(p);
-    if (statSync(abs).isDirectory()) walkDir(abs, files);
-    else if (options.isMigratableFile(abs)) files.push(abs);
+    const found: string[] = [];
+    const isDirectory = statSync(abs).isDirectory();
+    if (isDirectory) walkDir(abs, found);
+    else if (options.isMigratableFile(abs)) found.push(abs);
+    files.push(...withoutGitIgnored(isDirectory ? abs : dirname(abs), found));
   }
   return files;
 }
+
+// git check-ignore exits 0 when it printed ignored paths, 1 when none is ignored and 128 outside a
+// repository; only 0 filters anything.
+const GIT_CHECK_IGNORE_SOME_IGNORED = 0;
+
+// A git hook exports GIT_DIR and friends, and git prefers them over cwd: inherited, check-ignore
+// would ask the hook's repository about paths outside it.
+export function envWithoutGitRepositoryOverrides(): Record<string, string> {
+  return Object.fromEntries(
+    Object.entries(process.env).filter(
+      (entry): entry is [string, string] => !entry[0].startsWith("GIT_") && entry[1] !== undefined,
+    ),
+  );
+}
+
+// Generated output, worktrees and local scratch dirs are usually only excluded through .gitignore;
+// a codemod must not rewrite them.
+function withoutGitIgnored(cwd: string, files: readonly string[]): readonly string[] {
+  if (files.length === 0) return files;
+  const result = runGitCheckIgnore(cwd, files);
+  if (result === undefined || result.exitCode !== GIT_CHECK_IGNORE_SOME_IGNORED) return files;
+  const ignored = new Set(result.stdout.toString().split("\0"));
+  return files.filter((file) => !ignored.has(file));
+}
+
+function runGitCheckIgnore(cwd: string, files: readonly string[]) {
+  try {
+    return Bun.spawnSync({
+      cmd: ["git", "check-ignore", "--stdin", "-z"],
+      cwd,
+      env: envWithoutGitRepositoryOverrides(),
+      stdin: Buffer.from(`${files.join("\0")}\0`),
+      stdout: "pipe",
+      stderr: "pipe",
+    });
+  } catch (error) {
+    // Build images such as the customer-app builder ship without git; like outside a repository,
+    // there is no .gitignore to honour then.
+    if (errorCodeOf(error) === "ENOENT") return undefined;
+    throw error;
+  }
+}

package/src/scripts/codemod/ctx-namespaces.ts

@@ -106,8 +106,10 @@ function runGroup(
     skipAddingFilesFromTsConfig: true,
   });
   totals.projects += 1;
-  for (const file of files) {
-    const sourceFile = project.addSourceFileAtPath(file);
+  // Receivers are found through references: a structural helper is only recognised as taking a
+  // handler context when its callers in other files are already part of the project.
+  const staged = files.map((file) => ({ file, sourceFile: project.addSourceFileAtPath(file) }));
+  for (const { file, sourceFile } of staged) {
     const before = readFileSync(file, "utf8");
     const result = transformCtxNamespaces(sourceFile);
     reportSites(result.rewrites, "rewritten");