@cosmicdrift/kumiko-dev-server 0.81.0 → 0.82.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-dev-server",
-  "version": "0.81.0",
+  "version": "0.82.0",
   "description": "Development server bootstrap for Kumiko apps. Bundles the client, mints dev-JWTs, injects the resolved AppSchema, and seeds an admin. Not for production.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -50,8 +50,8 @@
     "kumiko-schema-check": "./bin/kumiko-schema-check.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.81.0",
-    "@cosmicdrift/kumiko-framework": "0.81.0",
+    "@cosmicdrift/kumiko-bundled-features": "0.82.0",
+    "@cosmicdrift/kumiko-framework": "0.82.0",
     "ts-morph": "^28.0.0"
   },
   "publishConfig": {

package/src/__tests__/config-resolver-default.integration.test.ts

@@ -94,4 +94,38 @@ describe("runDevApp configResolver-default — ENV→app-override bridge", () =>
     }) as ExtraObj;
     expect(extra.configResolver).toBe(custom);
   });
+
+  // Regression: the GDPR export download threw errors.internal in prod because
+  // boot only wired `configResolver`, never `_configAccessorFactory` — so the
+  // dispatcher left ctx.config undefined and createFileProviderForTenant threw
+  // "ctx.config is missing". The boot now mints the factory.
+  test("boot wiring mints _configAccessorFactory so handlers get ctx.config", () => {
+    const extra = mergeConfigResolverDefault(undefined, stack.registry, {}) as ExtraObj & {
+      readonly _configAccessorFactory?: unknown;
+    };
+    expect(typeof extra._configAccessorFactory).toBe("function");
+  });
+
+  test("_configAccessorFactory uses the EFFECTIVE resolver (caller override wins over env-bridge)", async () => {
+    // money-horse pins `file-foundation:config:provider` = "s3-env" via an
+    // appOverride on its own configResolver; ctx.config MUST read that override,
+    // not the boot default — else the download resolves no provider.
+    const override = createConfigResolver({ appOverrides: new Map([[PAGE_SIZE, "99"]]) });
+    const extra = mergeConfigResolverDefault({ configResolver: override }, stack.registry, {
+      DEVCFG_PAGE_SIZE: "25", // env-bridge default would be 25 — the override must win
+    }) as ExtraObj & {
+      readonly _configAccessorFactory: (deps: {
+        readonly user: { readonly id: string; readonly tenantId: string };
+        readonly db: typeof stack.db;
+      }) => (key: string) => Promise<unknown>;
+    };
+    const accessor = extra._configAccessorFactory({
+      user: { id: TestUsers.systemAdmin.id, tenantId: TestUsers.systemAdmin.tenantId },
+      db: stack.db,
+    });
+    // appOverride values come through raw (string) — what matters is it's the
+    // override's "99", NOT the env-bridge default ("25"): proves the factory
+    // was built from the caller's resolver, exactly like money-horse's "s3-env".
+    expect(await accessor(PAGE_SIZE)).toBe("99");
+  });
 });

package/src/run-dev-app.ts

@@ -69,6 +69,7 @@ import type {
   PasswordResetSetup,
   SignupSetup,
 } from "./run-prod-app";
+import { addConfigAccessorFactory } from "./run-prod-app";
 
 export type RunDevAppAuthOptions = {
   /** Admin user to seed at boot. Idempotent — re-runs in persistent-DB
@@ -451,9 +452,13 @@ export function mergeConfigResolverDefault(
       appOverrides: buildEnvConfigOverrides(registry, envSource),
     }),
   };
-  if (ctx === undefined) return defaults;
+  // ctx.config wird per-Request aus _configAccessorFactory geminted (siehe
+  // addConfigAccessorFactory) — sonst bleibt ctx.config undefined und Handler
+  // die es lesen (createFileProviderForTenant) werfen. Aus dem EFFEKTIVEN
+  // Resolver (Caller-Override gewinnt) gebaut, symmetrisch zu runProdApp.
+  if (ctx === undefined) return addConfigAccessorFactory(defaults, registry);
   if (typeof ctx === "function") {
-    return (deps) => ({ ...defaults, ...ctx(deps) });
+    return (deps) => addConfigAccessorFactory({ ...defaults, ...ctx(deps) }, registry);
   }
-  return { ...defaults, ...ctx };
+  return addConfigAccessorFactory({ ...defaults, ...ctx }, registry);
 }

package/src/run-prod-app.ts

@@ -38,6 +38,7 @@ import {
 } from "@cosmicdrift/kumiko-bundled-features/auth-email-password/seeding";
 import {
   buildEnvConfigOverrides,
+  createConfigAccessorFactory,
   createConfigResolver,
 } from "@cosmicdrift/kumiko-bundled-features/config";
 import { createSessionCallbacks } from "@cosmicdrift/kumiko-bundled-features/sessions";
@@ -47,11 +48,13 @@ import { createSseBroker, type SseBroker } from "@cosmicdrift/kumiko-framework/a
 import { createDbConnection, type DbRunner } from "@cosmicdrift/kumiko-framework/db";
 import {
   buildAppSchema,
+  type ConfigResolver,
   collectWriteHandlerQns,
   createRegistry,
   type EffectiveFeaturesResolver,
   type FeatureDefinition,
   findTierResolverUsage,
+  type Registry,
   type TenantId,
   type TierResolverPlugin,
   validateAppCustomScreenWriteQns,
@@ -517,6 +520,25 @@ export type ProdAppHandle = {
   readonly stop: () => Promise<void>;
 };
 
+// Mint `ctx.config` per request: the dispatcher only builds a per-user
+// ConfigAccessor when `_configAccessorFactory` is on the AppContext
+// (pipeline/dispatcher.ts). Without it `ctx.config` stays undefined and any
+// handler reading it — e.g. createFileProviderForTenant for the GDPR export
+// download — throws "ctx.config is missing". Built from the EFFECTIVE resolver
+// so an app-supplied configResolver override (its appOverrides) is the one
+// ctx.config reads. Shared with runDevApp (mergeConfigResolverDefault) for
+// dev/prod parity.
+export function addConfigAccessorFactory<T extends { readonly configResolver?: ConfigResolver }>(
+  resolved: T,
+  registry: Registry,
+): T {
+  if (!resolved.configResolver) return resolved;
+  return {
+    ...resolved,
+    _configAccessorFactory: createConfigAccessorFactory(registry, resolved.configResolver),
+  };
+}
+
 export async function runProdApp(options: RunProdAppOptions): Promise<ProdAppHandle> {
   // 0. Env-Schema validation + dry-run modes. Runs FIRST so:
   //    - operators can introspect env-requirements without a real boot
@@ -688,14 +710,17 @@ export async function runProdApp(options: RunProdAppOptions): Promise<ProdAppHan
     typeof options.extraContext === "function"
       ? options.extraContext(deps)
       : (options.extraContext ?? {});
-  const extraContext = options.auth
-    ? {
-        configResolver: createConfigResolver({
-          appOverrides: buildEnvConfigOverrides(registry, envSource),
-        }),
-        ...resolvedExtraContext,
-      }
-    : resolvedExtraContext;
+  const extraContext = addConfigAccessorFactory(
+    options.auth
+      ? {
+          configResolver: createConfigResolver({
+            appOverrides: buildEnvConfigOverrides(registry, envSource),
+          }),
+          ...resolvedExtraContext,
+        }
+      : resolvedExtraContext,
+    registry,
+  );
   const resolvedAnonymousAccess =
     typeof options.anonymousAccess === "function"
       ? options.anonymousAccess(deps)