@cosmicdrift/kumiko-dev-server 0.79.2 → 0.80.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-dev-server",
-  "version": "0.79.2",
+  "version": "0.80.0",
   "description": "Development server bootstrap for Kumiko apps. Bundles the client, mints dev-JWTs, injects the resolved AppSchema, and seeds an admin. Not for production.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -50,8 +50,8 @@
     "kumiko-schema-check": "./bin/kumiko-schema-check.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.79.2",
-    "@cosmicdrift/kumiko-framework": "0.79.2",
+    "@cosmicdrift/kumiko-bundled-features": "0.80.0",
+    "@cosmicdrift/kumiko-framework": "0.80.0",
     "ts-morph": "^28.0.0"
   },
   "publishConfig": {

package/src/__tests__/scaffold-app.test.ts

@@ -27,6 +27,7 @@ describe("scaffoldApp", () => {
       "src/run-config.ts",
       "bin/main.ts",
       "bin/dev.ts",
+      "src/client.tsx",
       ".env.example",
       "README.md",
     ]);
@@ -48,11 +49,12 @@ describe("scaffoldApp", () => {
     expect(pkg.dependencies["@cosmicdrift/kumiko-bundled-features"]).toBe("^0.13.0");
     expect(pkg.dependencies["@cosmicdrift/kumiko-dev-server"]).toBe("^0.13.0");
     expect(pkg.dependencies["@cosmicdrift/kumiko-framework"]).toBe("^0.13.0");
+    expect(pkg.dependencies["@cosmicdrift/kumiko-renderer-web"]).toBe("^0.13.0");
     expect(pkg.scripts["boot"]).toContain("KUMIKO_DRY_RUN_ENV=boot");
     expect(pkg.scripts["dev"]).toBe("bun --watch bin/dev.ts");
   });
 
-  test("bin/dev.ts contains runDevApp + welcomeBanner + admin login", () => {
+  test("bin/dev.ts contains runDevApp + welcomeBanner + admin login + clientEntry", () => {
     const dest = join(tmp, "my-shop");
     scaffoldApp({ name: "my-shop", destination: dest });
 
@@ -61,6 +63,25 @@ describe("scaffoldApp", () => {
     expect(dev).toContain("welcomeBanner: true");
     expect(dev).toContain("admin@my-shop.local");
     expect(dev).toContain(`password: "changeme"`);
+    // Without clientEntry the default HTML still <script src="/client.js">'s,
+    // and the dev-server 404s on it — every fresh scaffold rendered blank.
+    expect(dev).toContain(`clientEntry: "./src/client.tsx"`);
+  });
+
+  test("src/client.tsx bundles createKumikoApp + emailPasswordClient + DefaultAppShell", () => {
+    const dest = join(tmp, "my-shop");
+    scaffoldApp({ name: "my-shop", destination: dest });
+
+    const client = readFileSync(join(dest, "src/client.tsx"), "utf-8");
+    expect(client).toContain("createKumikoApp");
+    expect(client).toContain("emailPasswordClient");
+    // Without shell:DefaultAppShell post-login renders only the active
+    // screen (no sidebar / topbar) — the e2e hero-demo proved this dead-
+    // ends on "Screen not found" because routing has no layout chrome.
+    expect(client).toContain("DefaultAppShell");
+    expect(client).toContain("shell: DefaultAppShell");
+    expect(client).toContain('from "@cosmicdrift/kumiko-renderer-web"');
+    expect(client).toContain('from "@cosmicdrift/kumiko-bundled-features/auth-email-password/web"');
   });
 
   test(".env.example carries KUMIKO_DEV_DB_NAME default so reboots are persistent", () => {
@@ -71,6 +92,18 @@ describe("scaffoldApp", () => {
     expect(env).toContain("KUMIKO_DEV_DB_NAME=my_shop_dev");
   });
 
+  test(".env.example lists both TEST_DATABASE_URL (bun dev) + DATABASE_URL (prod)", () => {
+    const dest = join(tmp, "my-shop");
+    scaffoldApp({ name: "my-shop", destination: dest });
+
+    const env = readFileSync(join(dest, ".env.example"), "utf-8");
+    // runDevApp → setupTestStack needs TEST_DATABASE_URL; previously the
+    // template only listed DATABASE_URL, so every fresh `bun dev` crashed
+    // with "Missing required env var: TEST_DATABASE_URL".
+    expect(env).toContain("TEST_DATABASE_URL=");
+    expect(env).toContain("DATABASE_URL=");
+  });
+
   test("README lists the mounted features dynamically", () => {
     const dest = join(tmp, "my-shop");
     scaffoldApp({
@@ -173,25 +206,25 @@ describe("scaffoldApp", () => {
       name: "custom-features",
       destination: dest,
       features: [
-        {
-          name: "tenant",
-          importPath: "@cosmicdrift/kumiko-bundled-features/tenant",
-          exportName: "createTenantFeature",
-          callExpression: "createTenantFeature()",
-        },
         {
           name: "billing-foundation",
           importPath: "@cosmicdrift/kumiko-bundled-features/billing-foundation",
           exportName: "billingFoundationFeature",
           callExpression: "billingFoundationFeature",
         },
+        {
+          name: "delivery",
+          importPath: "@cosmicdrift/kumiko-bundled-features/delivery",
+          exportName: "createDeliveryFeature",
+          callExpression: "createDeliveryFeature()",
+        },
       ],
     });
     const cfg = readFileSync(join(dest, "src/run-config.ts"), "utf-8");
-    expect(cfg).toContain('from "@cosmicdrift/kumiko-bundled-features/tenant"');
     expect(cfg).toContain('from "@cosmicdrift/kumiko-bundled-features/billing-foundation"');
-    expect(cfg).toContain("createTenantFeature()");
+    expect(cfg).toContain('from "@cosmicdrift/kumiko-bundled-features/delivery"');
     expect(cfg).toContain("billingFoundationFeature");
+    expect(cfg).toContain("createDeliveryFeature()");
     expect(cfg).not.toContain("createSecretsFeature");
     expect(cfg).not.toContain("createSessionsFeature");
   });
@@ -204,6 +237,55 @@ describe("scaffoldApp", () => {
     expect(cfg).toContain("createSessionsFeature()");
   });
 
+  test("features-param: composeFeatures auto-mounted (config/user/tenant/auth-email-password) are filtered out — no boot-time dedupe-warn spam", () => {
+    const dest = join(tmp, "filtered");
+    scaffoldApp({
+      name: "filtered",
+      destination: dest,
+      features: [
+        // Picker's recommended set includes the 4 auto-mounted bundled
+        // features; without the filter they'd land in APP_FEATURES and
+        // composeFeatures would log 4 dedupe warnings on every boot.
+        {
+          name: "config",
+          importPath: "@cosmicdrift/kumiko-bundled-features/config",
+          exportName: "createConfigFeature",
+          callExpression: "createConfigFeature()",
+        },
+        {
+          name: "user",
+          importPath: "@cosmicdrift/kumiko-bundled-features/user",
+          exportName: "createUserFeature",
+          callExpression: "createUserFeature()",
+        },
+        {
+          name: "tenant",
+          importPath: "@cosmicdrift/kumiko-bundled-features/tenant",
+          exportName: "createTenantFeature",
+          callExpression: "createTenantFeature()",
+        },
+        {
+          name: "auth-email-password",
+          importPath: "@cosmicdrift/kumiko-bundled-features/auth-email-password",
+          exportName: "createAuthEmailPasswordFeature",
+          callExpression: "createAuthEmailPasswordFeature()",
+        },
+        {
+          name: "delivery",
+          importPath: "@cosmicdrift/kumiko-bundled-features/delivery",
+          exportName: "createDeliveryFeature",
+          callExpression: "createDeliveryFeature()",
+        },
+      ],
+    });
+    const cfg = readFileSync(join(dest, "src/run-config.ts"), "utf-8");
+    expect(cfg).not.toContain("createConfigFeature");
+    expect(cfg).not.toContain("createUserFeature");
+    expect(cfg).not.toContain("createTenantFeature");
+    expect(cfg).not.toContain("createAuthEmailPasswordFeature");
+    expect(cfg).toContain("createDeliveryFeature()");
+  });
+
   test("deterministic tenantId for same name (reproducible boots)", () => {
     const a = join(tmp, "a");
     const b = join(tmp, "b");

package/src/__tests__/walkthrough.integration.test.ts

@@ -40,6 +40,7 @@ describe("walkthrough — DX-3.1 snapshot", () => {
       "src/run-config.ts",
       "bin/main.ts",
       "bin/dev.ts",
+      "src/client.tsx",
       ".env.example",
       "README.md",
     ]);

package/src/scaffold-app.ts

@@ -83,6 +83,9 @@ export function scaffoldApp(options: ScaffoldAppOptions): ScaffoldAppResult {
   write(join(destination, "bin", "dev.ts"), renderDev(options.name));
   files.push("bin/dev.ts");
 
+  write(join(destination, "src", "client.tsx"), renderClient());
+  files.push("src/client.tsx");
+
   write(join(destination, ".env.example"), renderEnvExample(options.name));
   files.push(".env.example");
 
@@ -113,6 +116,7 @@ function renderPackageJson(name: string, version: string): string {
         "@cosmicdrift/kumiko-bundled-features": version,
         "@cosmicdrift/kumiko-dev-server": version,
         "@cosmicdrift/kumiko-framework": version,
+        "@cosmicdrift/kumiko-renderer-web": version,
         zod: "^4.4.3",
       },
     },
@@ -168,11 +172,20 @@ const FOUNDATION_FEATURES: ReadonlyArray<ScaffoldFeatureEntry> = [
   },
 ];
 
+// composeFeatures({ includeBundled: true }) auto-mountet diese 4 Foundation-
+// Features. Sie hier nochmal in APP_FEATURES zu schreiben löste den dedupe-
+// warn-Spam im scaffolded `bun dev` aus (PR #599 hat den createRegistry-
+// Crash gefangen, der Spam blieb bis hier). Filter wirkt defensiv: auch wenn
+// jemand scaffoldApp() direkt mit allen Bundled-Feature-Entries aufruft
+// rutschen die 4 nicht in run-config.ts.
+const COMPOSE_AUTO_MOUNTED_NAMES = new Set(["config", "user", "tenant", "auth-email-password"]);
+
 function renderRunConfig(features?: ReadonlyArray<ScaffoldFeatureEntry>): string {
   const project = newTsProject();
   const sf = project.createSourceFile("run-config.ts", "");
 
-  const effective = features && features.length > 0 ? features : FOUNDATION_FEATURES;
+  const filtered = (features ?? []).filter((f) => !COMPOSE_AUTO_MOUNTED_NAMES.has(f.name));
+  const effective = filtered.length > 0 ? filtered : FOUNDATION_FEATURES;
   const grouped = new Map<string, string[]>();
   for (const entry of effective) {
     const existing = grouped.get(entry.importPath) ?? [];
@@ -352,6 +365,7 @@ function renderDev(appName: string): string {
       .inlineBlock(() => {
         writer.writeLine("features: APP_FEATURES,");
         writer.writeLine("welcomeBanner: true,");
+        writer.writeLine(`clientEntry: "./src/client.tsx",`);
         writer.write("auth: ").inlineBlock(() => {
           writer.write("admin: ").inlineBlock(() => {
             writer.writeLine(`email: "admin@${appName}.local",`);
@@ -391,8 +405,39 @@ function renderDev(appName: string): string {
   return sf.getFullText();
 }
 
+function renderClient(): string {
+  return [
+    "// Browser-Entry. runDevApp's clientEntry-Option bundlet diese Datei zu",
+    "// /client.js und das Default-HTML lädt sie. createKumikoApp liest das",
+    "// Schema aus dem window-globalen (das injectSchema im dev-server setzt)",
+    "// und mountet die Routen.",
+    "//",
+    "// DefaultAppShell liefert die Sidebar + Topbar — ohne `shell` rendert",
+    "// createKumikoApp das aktive Screen ohne Layout-Wrapper (= nach Login",
+    "// nur ein nackter Banner statt der App). emailPasswordClient() bringt",
+    "// Login-Screen + Session-Provider — ohne ihn bliebe /login leer.",
+    "//",
+    "// Neue Client-Plugins (z.B. notificationsClient()) hier in clientFeatures",
+    "// hinzu — symmetrisch zu APP_FEATURES auf der Server-Seite.",
+    "",
+    'import { emailPasswordClient } from "@cosmicdrift/kumiko-bundled-features/auth-email-password/web";',
+    'import { createKumikoApp, DefaultAppShell } from "@cosmicdrift/kumiko-renderer-web";',
+    "",
+    "createKumikoApp({",
+    "  shell: DefaultAppShell,",
+    "  clientFeatures: [emailPasswordClient()],",
+    "});",
+    "",
+  ].join("\n");
+}
+
 function renderEnvExample(appName: string): string {
-  return `# Required env-vars für boot-mode + dev. Production: über Pulumi/k8s-Secrets.
+  const devDb = `${appName.replace(/-/g, "_")}_dev`;
+  return `# bun dev (runDevApp → setupTestStack) braucht TEST_DATABASE_URL.
+# Production (bun bin/main.ts → runProdApp) braucht DATABASE_URL.
+# Beide zeigen im Default auf denselben lokalen Postgres — runDevApp legt
+# darunter eine eigene "<KUMIKO_DEV_DB_NAME>"-Datenbank an.
+TEST_DATABASE_URL=postgres://postgres:postgres@127.0.0.1:5432/postgres
 DATABASE_URL=postgres://postgres:postgres@127.0.0.1:5432/app
 REDIS_URL=redis://127.0.0.1:6379
 
@@ -406,7 +451,7 @@ KUMIKO_SECRETS_MASTER_KEY_V1=
 # Dev-only: persistente DB für \`bun dev\`. Ohne diesen Var startet jeder Reboot
 # eine frische kumiko_test_<random>-DB → Admin-Login + Daten weg bei jedem Edit.
 # Mit Var bleibt die DB zwischen Reboots erhalten (Schema-Pushes sind idempotent).
-KUMIKO_DEV_DB_NAME=${appName.replace(/-/g, "_")}_dev
+KUMIKO_DEV_DB_NAME=${devDb}
 `;
 }