@cosmicdrift/kumiko-dev-server 0.328.1 → 0.330.0

package/src/__tests__/resolve-stylesheet.test.ts

@@ -1,132 +0,0 @@
-// Unit-Tests für resolveStylesheet — die Verzweigungen aus
-// createKumikoServer's CSS-Setup. Läuft unter vitest auf Node, also
-// ohne Bun.serve und ohne Bun.resolveSync; der Default-Resolution-
-// Pfad (Bun-only) ist hier explizit als "skip silent" abgedeckt.
-//
-// Warum als eigener File statt im create-kumiko-server.integration.ts:
-// die anderen Tests dort booten ein TestStack (DB + Redis), das brauchen
-// wir für reine Resolver-Logik nicht.
-
-import { describe, expect, test } from "bun:test";
-import { mkdirSync, mkdtempSync, realpathSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import {
-  resolveStylesheet,
-  resolveStylesheetWatch,
-  STYLESHEET_WATCH_ENV,
-} from "../create-kumiko-server";
-
-describe("resolveStylesheet", () => {
-  test("string → resolved absolute path", () => {
-    // Relativ zum CWD aufgelöst — das ist Node's path.resolve-Default.
-    const out = resolveStylesheet({
-      features: [],
-      stylesheet: "./some/stylesheet.css",
-    });
-    expect(out).toMatch(/\/some\/stylesheet\.css$/);
-    expect(out?.startsWith("/")).toBe(true);
-  });
-
-  test("absolute string bleibt unverändert (path.resolve idempotent)", () => {
-    const out = resolveStylesheet({
-      features: [],
-      stylesheet: "/abs/path/styles.css",
-    });
-    expect(out).toBe("/abs/path/styles.css");
-  });
-
-  test("false → undefined (Pipeline explizit aus)", () => {
-    const out = resolveStylesheet({
-      features: [],
-      stylesheet: false,
-      clientEntry: "./entry.tsx",
-    });
-    expect(out).toBeUndefined();
-  });
-
-  test("undefined ohne clientEntry → undefined (kein Browser-Bundle, keine CSS)", () => {
-    const out = resolveStylesheet({
-      features: [],
-    });
-    expect(out).toBeUndefined();
-  });
-
-  test("undefined + clientEntry: undefined (silent skip)", () => {
-    // Bun resolveSync findet packages/renderer-web/src/styles.css im
-    // Repo. Das ist der prod-Pfad — unter Bun (real oder CI) ist der
-    // Wert ein absoluter path; unter Node (von wo der Test portiert
-    // wurde) wäre es undefined. Wir akzeptieren beides.
-    const out = resolveStylesheet({
-      features: [],
-      clientEntry: "./entry.tsx",
-    });
-    if (typeof Bun === "undefined") {
-      expect(out).toBeUndefined();
-    } else {
-      expect(out).toMatch(/renderer-web\/src\/styles\.css$/);
-    }
-  });
-
-  test("Bun.resolveSync failure → undefined (catch path, no throw)", () => {
-    const tmpDir = realpathSync(mkdtempSync(join(tmpdir(), "kumiko-resolve-catch-")));
-    const cwdBefore = process.cwd();
-    process.chdir(tmpDir);
-    try {
-      const out = resolveStylesheet({
-        features: [],
-        clientEntry: "./entry.tsx",
-      });
-      expect(out).toBeUndefined();
-    } finally {
-      process.chdir(cwdBefore);
-      rmSync(tmpDir, { recursive: true, force: true });
-    }
-  });
-
-  test("undefined + clientEntry + src/styles.css existiert → returns App-Theme-Override", () => {
-    // Auto-Detection greift VOR dem renderer-web-Fallback: Wenn die App
-    // ein eigenes src/styles.css hat (App-Theme-Pattern), wird das
-    // automatisch als Tailwind-Entry genommen — symmetrisch zum prod-
-    // Build (kumiko-build:resolveStylesheetEntry). Ohne diesen Check
-    // müsste jede App `stylesheet:` explizit setzen.
-    // realpath aufgelöst, weil macOS' /var → /private/var Symlink sonst
-    // einen anderen Pfad rauswirft als process.cwd() nach chdir.
-    const tmpDir = realpathSync(mkdtempSync(join(tmpdir(), "kumiko-resolve-styles-")));
-    const srcDir = join(tmpDir, "src");
-    mkdirSync(srcDir);
-    const stylesheet = join(srcDir, "styles.css");
-    writeFileSync(stylesheet, "/* app theme */");
-
-    const cwdBefore = process.cwd();
-    process.chdir(tmpDir);
-    try {
-      const out = resolveStylesheet({
-        features: [],
-        clientEntry: "./entry.tsx",
-      });
-      expect(out).toBe(stylesheet);
-    } finally {
-      process.chdir(cwdBefore);
-      rmSync(tmpDir, { recursive: true, force: true });
-    }
-  });
-});
-
-describe("resolveStylesheetWatch", () => {
-  test("an explicit option wins over the env", () => {
-    expect(resolveStylesheetWatch({ stylesheetWatch: false }, {})).toBe(false);
-    expect(resolveStylesheetWatch({ stylesheetWatch: true }, { [STYLESHEET_WATCH_ENV]: "0" })).toBe(
-      true,
-    );
-  });
-
-  test("no option, env=0 → false", () => {
-    expect(resolveStylesheetWatch({}, { [STYLESHEET_WATCH_ENV]: "0" })).toBe(false);
-  });
-
-  test("no option, no or other env value → true", () => {
-    expect(resolveStylesheetWatch({}, {})).toBe(true);
-    expect(resolveStylesheetWatch({}, { [STYLESHEET_WATCH_ENV]: "1" })).toBe(true);
-  });
-});

package/src/__tests__/run-dev-app-boot-validation.test.ts

@@ -1,38 +0,0 @@
-// runDevApp muss denselben Boot-Validator wie runProdApp ausführen (#359):
-// eine ganze Fehlerklasse (unqualifizierte nav-/handler-QNs, unauflösbare
-// navigate-Targets, screen-access) passierte früher den Dev-Server still und
-// crashte erst den Prod-Pod im CrashLoopBackOff. Hier: ein Feature mit einem
-// rowAction-navigate auf einen nie registrierten Screen — runDevApp muss
-// SYNCHRON beim Boot werfen, bevor ein Port gebunden oder der codegen-Watcher
-// gestartet wird (validateBoot läuft vor watchAndRegenerate).
-
-import { describe, expect, test } from "bun:test";
-import { createEntity, createTextField, defineFeature } from "@cosmicdrift/kumiko-framework/engine";
-import { runDevApp } from "../run-dev-app";
-
-function unresolvableNavFeature() {
-  return defineFeature("shop", (r) => {
-    r.entity(
-      "product",
-      createEntity({
-        fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
-      }),
-    );
-    r.screen({
-      id: "product-list",
-      type: "entityList",
-      entity: "product",
-      columns: ["name"],
-      // "ghost-screen" wird nie via r.screen registriert → validateBoot wirft.
-      rowActions: [{ kind: "navigate", id: "edit", label: "actions.edit", screen: "ghost-screen" }],
-    });
-  });
-}
-
-describe("runDevApp boot-validation (#359)", () => {
-  test("unresolvable navigate-target throws at boot — dev/prod parity, no port bound", async () => {
-    await expect(runDevApp({ features: [unresolvableNavFeature()] })).rejects.toThrow(
-      /navigate-target "ghost-screen" does not resolve/,
-    );
-  });
-});

package/src/__tests__/run-dev-app.integration.test.ts

@@ -1,290 +0,0 @@
-// The origin-guard config (allowedOrigins / unsafeSkipOriginCheck) is forwarded
-// from runDevApp's auth options through to the server exactly like runProdApp
-// (#399/1). The guard fires during server build — AFTER the ephemeral test DB is
-// up — so this is an integration test (needs TEST_DATABASE_URL), mirroring the
-// run-prod-app forwarding pair. Without it a typo or wrong spread-key on the dev
-// path would silently drop the fail-closed guard and dev/prod would diverge.
-
-import { afterEach, beforeEach, describe, expect, spyOn, test } from "bun:test";
-import { authFoundationFeature } from "@cosmicdrift/kumiko-bundled-features/auth-foundation";
-import { createPersonalAccessTokensFeature } from "@cosmicdrift/kumiko-bundled-features/personal-access-tokens";
-import { createSessionsFeature } from "@cosmicdrift/kumiko-bundled-features/sessions";
-import {
-  requireTemplateResolver,
-  TEXT_BLOCK_KIND,
-  type TemplateResolverApi,
-} from "@cosmicdrift/kumiko-bundled-features/template-resolver";
-import type { AnonymousExtraRoute } from "@cosmicdrift/kumiko-framework/api";
-import {
-  createEntity,
-  createTextField,
-  defineFeature,
-  defineQueryHandler,
-  type TenantId,
-} from "@cosmicdrift/kumiko-framework/engine";
-import { TestUsers } from "@cosmicdrift/kumiko-framework/stack";
-import * as jose from "jose";
-import * as z from "zod";
-import type { KumikoServerHandle } from "../create-kumiko-server";
-import { runDevApp } from "../run-dev-app";
-
-function validFeature() {
-  return defineFeature("shop", (r) => {
-    r.entity(
-      "product",
-      createEntity({
-        fields: { name: createTextField({ personal: false, reason: "test_fixture" }) },
-      }),
-    );
-  });
-}
-
-const ADMIN = {
-  email: "origin-guard@example.eu",
-  password: "test-pw-strong-1234",
-  displayName: "Admin",
-  memberships: [],
-};
-
-let handle: KumikoServerHandle | undefined;
-const savedJwtSecret = process.env["JWT_SECRET"];
-
-beforeEach(() => {
-  process.env["JWT_SECRET"] = "test-rundev-secret-32-chars-min!!!!";
-});
-
-afterEach(async () => {
-  await handle?.stop();
-  handle = undefined;
-  if (savedJwtSecret === undefined) delete process.env["JWT_SECRET"];
-  else process.env["JWT_SECRET"] = savedJwtSecret;
-});
-
-describe("runDevApp — auth.mail fail-fast on missing JWT_SECRET", () => {
-  test("options.auth set but JWT_SECRET missing → throws, no dev-fallback", async () => {
-    // beforeEach sets JWT_SECRET unconditionally for every OTHER test in this
-    // file — none of them ever exercise the missing-secret path, so it's
-    // unclear whether the fail-closed guard (requireEnv, not the old dev-
-    // fallback) actually fires or was silently dropped. Pass a custom
-    // envSource without JWT_SECRET instead of touching process.env.
-    const { JWT_SECRET: _drop, ...envWithoutJwtSecret } = process.env;
-    await expect(
-      runDevApp({
-        features: [validFeature()],
-        auth: { admin: ADMIN, cookieDomain: "example.eu", allowedOrigins: ["https://example.eu"] },
-        envSource: envWithoutJwtSecret,
-      }),
-    ).rejects.toThrow(/JWT_SECRET/);
-  });
-});
-
-describe("runDevApp — auth allowedOrigins forwarding (#399/1)", () => {
-  test("cookieDomain without allowedOrigins fails closed — guard is wired through runDevApp", async () => {
-    await expect(
-      runDevApp({
-        features: [validFeature()],
-        auth: { admin: ADMIN, cookieDomain: "example.eu" },
-      }),
-    ).rejects.toThrow(/allowedOrigins is empty/);
-  });
-
-  test("cookieDomain + allowedOrigins clears the guard — allowlist reaches the server", async () => {
-    // Without the forwarding fix this would ALSO throw /allowedOrigins is empty/.
-    handle = await runDevApp({
-      features: [validFeature()],
-      // Port 0 → OS-assigned ephemeral port, no fixed-port collision in CI.
-      port: 0,
-      auth: {
-        admin: ADMIN,
-        cookieDomain: "example.eu",
-        allowedOrigins: ["https://app.example.eu"],
-      },
-    });
-    // A booted handle that did not throw on the origin guard IS the forwarding
-    // proof — the allowlist reached the server build.
-    expect(handle).toBeDefined();
-  });
-
-  test("cookieDomain + unsafeSkipOriginCheck clears the guard without an allowlist", async () => {
-    // The escape hatch must also forward: cookieDomain alone fails closed
-    // (first test), but unsafeSkipOriginCheck=true bypasses it. A dropped/
-    // mis-spread key would let the guard fire → /allowedOrigins is empty/.
-    handle = await runDevApp({
-      features: [validFeature()],
-      port: 0,
-      auth: {
-        admin: ADMIN,
-        cookieDomain: "example.eu",
-        unsafeSkipOriginCheck: true,
-      },
-    });
-    expect(handle).toBeDefined();
-  });
-});
-
-describe("runDevApp — trustedProxyHops env fallback (KUMIKO_TRUSTED_PROXY_HOPS)", () => {
-  const clientIpRoute: AnonymousExtraRoute = {
-    method: "GET",
-    path: "/client-ip-probe",
-    entry: "anonymous",
-    handler: async (c, deps) => c.json({ clientIp: deps.clientIp }),
-  };
-
-  test("no trustedProxyHops option, env var set → env value reaches the server's client-ip resolver", async () => {
-    handle = await runDevApp({
-      features: [validFeature()],
-      port: 0,
-      extraRoutes: [clientIpRoute],
-      envSource: { ...process.env, KUMIKO_TRUSTED_PROXY_HOPS: "1" },
-    });
-    const res = await handle.fetch(
-      new Request("http://test/client-ip-probe", {
-        headers: { "x-forwarded-for": "203.0.113.10" },
-      }),
-    );
-    expect(await res.json()).toEqual({ clientIp: "203.0.113.10" });
-  });
-
-  test("explicit trustedProxyHops option wins over the env var", async () => {
-    handle = await runDevApp({
-      features: [validFeature()],
-      port: 0,
-      trustedProxyHops: 0,
-      extraRoutes: [clientIpRoute],
-      envSource: { ...process.env, KUMIKO_TRUSTED_PROXY_HOPS: "1" },
-    });
-    const res = await handle.fetch(
-      new Request("http://test/client-ip-probe", {
-        headers: { "x-forwarded-for": "203.0.113.10" },
-      }),
-    );
-    expect(await res.json()).toEqual({ clientIp: "unknown" });
-  });
-});
-
-describe("runDevApp — extraContext merge order: app values win over boot defaults (707/1)", () => {
-  test("a caller-supplied extraContext.templateResolver wins over the auto-wired boot default", async () => {
-    // runDevApp's extraContext factory does `{ ...boot, ...base }` — boot's
-    // auto-wired templateResolver must lose to a caller-supplied override, exactly
-    // the "app values win" parity claim this PR made against runProdApp. Every
-    // OTHER test in this file only checks that runDevApp boots without
-    // throwing; none dispatch a request that actually reads the merged value.
-    const sentinel: TemplateResolverApi = {
-      findExact: async () => ({
-        id: "sentinel",
-        version: 1,
-        tenantId: TestUsers.systemAdmin.tenantId,
-        slug: "sentinel",
-        kind: TEXT_BLOCK_KIND,
-        locale: "en",
-        title: "from caller extraContext",
-        folder: null,
-        content: "",
-        contentFormat: "markdown",
-        variableSchema: {},
-        linkedResources: {},
-        scope: "system",
-        parentTemplateId: null,
-        status: "active",
-        updatedAt: new Date(0),
-      }),
-      resolveTemplate: async () => {
-        throw new Error("not used in this test");
-      },
-    };
-    const readBlockQuery = defineQueryHandler({
-      name: "read-block",
-      schema: z.object({}),
-      access: { openToAll: { reason: "test handler callable by any signed-in test user" } },
-      handler: async (_query, ctx) => {
-        const api = requireTemplateResolver(ctx, "textcheck:query:read-block");
-        return api.findExact({
-          tenantId: TestUsers.systemAdmin.tenantId,
-          slug: "x",
-          kind: TEXT_BLOCK_KIND,
-          locale: "en",
-        });
-      },
-    });
-    const textcheckFeature = defineFeature("textcheck", (r) => {
-      r.queryHandler(readBlockQuery);
-    });
-
-    handle = await runDevApp({
-      features: [validFeature(), textcheckFeature],
-      port: 0,
-      extraContext: { templateResolver: sentinel },
-    });
-
-    const res = await handle.stack.http.queryOk<{ title: string } | null>(
-      "textcheck:query:read-block",
-      {},
-      TestUsers.systemAdmin,
-    );
-
-    expect(res?.title).toBe("from caller extraContext");
-  });
-});
-
-// runDevApp had no equivalent of runProdApp's session boot gate (#1262/#1275):
-// a forgotten sessions mount left session-list silently empty instead of
-// saying anything (#2027). Unlike prod, dev warns rather than aborts —
-// mirrors assertPiiBootInvariants' dev/prod split.
-describe("runDevApp — session boot gate (#2027)", () => {
-  const ADMIN = {
-    email: "session-gate-dev@example.eu",
-    password: "test-pw-strong-1234",
-    displayName: "Admin",
-    emailVerified: true,
-    memberships: [
-      {
-        tenantId: "00000000-0000-4000-8000-000000000002" as TenantId,
-        tenantKey: "session-gate-dev",
-        tenantName: "Session Gate Dev",
-        roles: ["Admin"],
-      },
-    ],
-  };
-
-  test("auth mounted, sessions feature missing → warns but still boots (dev doesn't abort)", async () => {
-    const warnSpy = spyOn(console, "warn").mockImplementation(() => {});
-    try {
-      handle = await runDevApp({
-        features: [validFeature()],
-        port: 0,
-        auth: { admin: ADMIN },
-      });
-      expect(handle).toBeDefined();
-      expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining("sessionStore"));
-      expect(warnSpy).toHaveBeenCalledWith(expect.stringContaining("[runDevApp]"));
-    } finally {
-      warnSpy.mockRestore();
-    }
-  });
-
-  test("auth mounted, sessions feature mounted → login actually creates a session (sid on the JWT)", async () => {
-    // The bug this issue reports: a mounted sessions feature whose sessionCreator
-    // never reached the auth config, so login never got a `sid` and
-    // store_user_sessions never got a row — session-list stayed empty with no
-    // error anywhere. A boot that doesn't throw proves nothing about that; only
-    // a real login + decoded JWT does.
-    handle = await runDevApp({
-      features: [
-        authFoundationFeature,
-        createPersonalAccessTokensFeature({ scopes: {} }),
-        createSessionsFeature(),
-      ],
-      port: 0,
-      auth: { admin: ADMIN },
-    });
-
-    const login = await handle.stack.http.raw("POST", "/api/auth/login", {
-      email: ADMIN.email,
-      password: ADMIN.password,
-    });
-    expect(login.status).toBe(200);
-    const body = (await login.json()) as { token?: string };
-    expect(body.token).toBeTypeOf("string");
-    expect(typeof jose.decodeJwt(body.token!).jti).toBe("string");
-  });
-});

package/src/__tests__/runtime-classification.test.ts

@@ -1,26 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { readFileSync } from "node:fs";
-import { fileURLToPath } from "node:url";
-
-// Mirrors infra/guards/runtime-isolation-classify.ts `classifyByDirective`
-// as of kumiko-framework#2337 (first 600 bytes, first 8 lines,
-// `// @runtime <kind>`) — guards against a reformat of compose-stacks.ts
-// pushing the directive out of that window. Doesn't catch infra changing
-// the window/regex itself; that lives in the infra repo's own tests.
-const ALL_RUNTIMES = new Set(["runtime", "client", "dev", "tooling", "test"]);
-
-function classifyByDirective(filePath: string): string | null {
-  const head = readFileSync(filePath, "utf8").slice(0, 600);
-  for (const line of head.split("\n").slice(0, 8)) {
-    const match = line.match(/\/\/\s*@runtime\s+(\w+)/);
-    if (match && ALL_RUNTIMES.has(match[1] ?? "")) return match[1] ?? null;
-  }
-  return null;
-}
-
-describe("compose-stacks.ts runtime directive", () => {
-  it("carries a @runtime runtime directive the guard's classifyByDirective will find", () => {
-    const composeStacksPath = fileURLToPath(new URL("../compose-stacks.ts", import.meta.url));
-    expect(classifyByDirective(composeStacksPath)).toBe("runtime");
-  });
-});