@cosmicdrift/kumiko-dev-server 0.156.2 → 0.157.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-dev-server",
-  "version": "0.156.2",
+  "version": "0.157.0",
   "description": "Dev-tooling for Kumiko apps: local dev-server bootstrap (runDevApp), scaffolding, codegen. Not shipped into production node_modules — see @cosmicdrift/kumiko-server-runtime for the prod boot path.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -54,9 +54,9 @@
     "kumiko-schema-check": "./bin/kumiko-schema-check.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-bundled-features": "0.156.2",
-    "@cosmicdrift/kumiko-framework": "0.156.2",
-    "@cosmicdrift/kumiko-server-runtime": "0.156.2",
+    "@cosmicdrift/kumiko-bundled-features": "0.157.0",
+    "@cosmicdrift/kumiko-framework": "0.157.0",
+    "@cosmicdrift/kumiko-server-runtime": "0.157.0",
     "ts-morph": "^28.0.0"
   },
   "publishConfig": {

package/src/__tests__/build-server-bundle.test.ts

@@ -55,10 +55,44 @@ describe("buildServerBundle (multi-entry + splitting)", () => {
       expect(pkg.scripts.start).toBe("bun run server.js");
       expect(Object.keys(pkg.dependencies)).not.toContain("drizzle-kit");
       expect(Object.keys(pkg.dependencies)).not.toContain("drizzle-orm");
+      // Positive counterpart to the negative checks above — a runtime
+      // external accidentally dropped from RUNTIME_EXTERNALS (into
+      // BUILD_ONLY_EXTERNALS instead) would slip through silently. This
+      // is the exact regression class behind the money-horse prod crash
+      // ("Cannot find package 'meilisearch'").
+      expect(Object.keys(pkg.dependencies)).toContain("meilisearch");
 
       expect(result.totalBytes).toBeGreaterThan(0);
     } finally {
       rmSync(dir, { recursive: true, force: true });
     }
   });
+
+  test("pins runtime-deps from node_modules/@cosmicdrift/* for consumer apps without a packages/ dir", async () => {
+    // Reproduziert #1217: findRepoRoot liefert für eine Consumer-App die
+    // App-Wurzel selbst (kein packages/-Ordner) — die Version muss aus den
+    // installierten node_modules/@cosmicdrift/*-Packages kommen, nicht "*".
+    const dir = makeFixture();
+    try {
+      const frameworkPkgDir = join(dir, "node_modules/@cosmicdrift/kumiko-framework");
+      mkdirSync(frameworkPkgDir, { recursive: true });
+      writeFileSync(
+        join(frameworkPkgDir, "package.json"),
+        `${JSON.stringify({ name: "@cosmicdrift/kumiko-framework", dependencies: { meilisearch: "^0.58.0" } })}\n`,
+      );
+      const bundledFeaturesPkgDir = join(dir, "node_modules/@cosmicdrift/kumiko-bundled-features");
+      mkdirSync(bundledFeaturesPkgDir, { recursive: true });
+      writeFileSync(
+        join(bundledFeaturesPkgDir, "package.json"),
+        `${JSON.stringify({ name: "@cosmicdrift/kumiko-bundled-features", dependencies: { ioredis: "^5.4.1" } })}\n`,
+      );
+
+      const result = await buildServerBundle({ cwd: dir, outDir: join(dir, "dist-server") });
+
+      expect(result.runtimeDeps["meilisearch"]).toBe("^0.58.0");
+      expect(result.runtimeDeps["ioredis"]).toBe("^5.4.1");
+    } finally {
+      rmSync(dir, { recursive: true, force: true });
+    }
+  });
 });

package/src/build-server-bundle.ts

@@ -185,7 +185,7 @@ export async function buildServerBundle(
   entries.sort((a, b) => a.file.localeCompare(b.file));
   const totalBytes = [...entries, ...chunks].reduce((sum, e) => sum + e.sizeBytes, 0);
 
-  const runtimeDeps = await resolveRuntimeDepsVersions(repoRoot, [
+  const runtimeDeps = await resolveRuntimeDepsVersions(cwd, repoRoot, [
     ...RUNTIME_EXTERNALS,
     ...(options.extraRuntimeExternals ?? []),
   ]);
@@ -224,23 +224,27 @@ function findRepoRoot(start: string): string | undefined {
   return undefined;
 }
 
-// Versionen für RUNTIME_EXTERNALS auflösen: erst aus framework + bundled-
-// features package.json (Workspace-pinning), Fallback auf "*" wenn nichts
-// gefunden. Ein Repo-Root muss existieren — sonst kann eh kein CLI-Bundle
-// gemacht werden, also wird die Funktion gar nicht erst gerufen.
+// Versionen für RUNTIME_EXTERNALS auflösen: erst aus den installierten
+// node_modules/@cosmicdrift/*-Packages (relativ zu cwd — funktioniert für
+// jede Consumer-App), dann als Zusatz aus packages/framework + bundled-
+// features (Workspace-Checkout des Frameworks selbst). Fallback auf "*"
+// wenn keine Quelle den Namen kennt.
 async function resolveRuntimeDepsVersions(
+  cwd: string,
   repoRoot: string | undefined,
   packages: readonly string[],
 ): Promise<Record<string, string>> {
   const out: Record<string, string> = {};
-  if (!repoRoot) {
-    for (const pkg of packages) out[pkg] = "*";
-    return out;
-  }
 
   const pinSources = [
-    join(repoRoot, "packages/framework/package.json"),
-    join(repoRoot, "packages/bundled-features/package.json"),
+    join(cwd, "node_modules/@cosmicdrift/kumiko-framework/package.json"),
+    join(cwd, "node_modules/@cosmicdrift/kumiko-bundled-features/package.json"),
+    ...(repoRoot
+      ? [
+          join(repoRoot, "packages/framework/package.json"),
+          join(repoRoot, "packages/bundled-features/package.json"),
+        ]
+      : []),
   ];
   const allDeps: Record<string, string> = {};
   for (const path of pinSources) {