@cosmicdrift/kumiko-bundled-features 0.79.0 → 0.79.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.79.0",
+  "version": "0.79.2",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -84,11 +84,11 @@
     "./step-dispatcher": "./src/step-dispatcher/index.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.79.0",
-    "@cosmicdrift/kumiko-framework": "0.79.0",
-    "@cosmicdrift/kumiko-headless": "0.79.0",
-    "@cosmicdrift/kumiko-renderer": "0.79.0",
-    "@cosmicdrift/kumiko-renderer-web": "0.79.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.79.2",
+    "@cosmicdrift/kumiko-framework": "0.79.2",
+    "@cosmicdrift/kumiko-headless": "0.79.2",
+    "@cosmicdrift/kumiko-renderer": "0.79.2",
+    "@cosmicdrift/kumiko-renderer-web": "0.79.2",
     "@mollie/api-client": "^4.5.0",
     "@node-rs/argon2": "^2.0.2",
     "@types/nodemailer": "^8.0.0",

package/src/user-data-rights/__tests__/run-export-jobs-cron-context.integration.test.ts

@@ -0,0 +1,148 @@
+// Treibt den ECHTEN registrierten Export-Cron-Job (r.job "run-export-jobs")
+// über seinen Job-Kontext — so wie der Job-Runner ihn in prod aufruft:
+// `ctx.configResolver` gesetzt (App-Override provider=inmemory), aber KEIN
+// per-request `ctx.config` (das baut nur der HTTP-Dispatcher).
+//
+// Der bestehende run-export-jobs-Test reicht `buildStorageProvider` MANUELL —
+// und übersprang damit genau diesen Pfad: der Wrapper baut providerCtx aus dem
+// Job-Kontext. Ohne den configResolver→ConfigAccessor-Bau wirft
+// createFileProviderForTenant "ctx.config is missing" (genau der prod-Bug, der
+// jeden Export auf "failed" setzte).
+
+import { afterAll, beforeAll, beforeEach, describe, expect, test } from "bun:test";
+import { asRawClient, insertOne, selectMany } from "@cosmicdrift/kumiko-framework/bun-db";
+import { SYSTEM_USER_ID } from "@cosmicdrift/kumiko-framework/engine";
+import { createEventsTable } from "@cosmicdrift/kumiko-framework/event-store";
+import {
+  setupTestStack,
+  type TestStack,
+  unsafeCreateEntityTable,
+  unsafePushTables,
+} from "@cosmicdrift/kumiko-framework/stack";
+import { getTemporal } from "@cosmicdrift/kumiko-framework/time";
+import {
+  createComplianceProfilesFeature,
+  tenantComplianceProfileEntity,
+} from "../../compliance-profiles";
+import { configValuesTable, createConfigFeature, createConfigResolver } from "../../config";
+import { createDataRetentionFeature } from "../../data-retention";
+import { fileFoundationFeature } from "../../file-foundation";
+import { fileProviderInMemoryFeature } from "../../file-provider-inmemory";
+import { createSessionsFeature } from "../../sessions";
+import { createUserFeature, USER_STATUS, userEntity, userTable } from "../../user";
+import { createUserDataRightsFeature } from "../feature";
+import { exportDownloadTokenEntity } from "../schema/download-token";
+import { EXPORT_JOB_STATUS, exportJobEntity, exportJobsTable } from "../schema/export-job";
+
+const TENANT = "00000000-0000-4000-8000-0000000009a1";
+const USER_ID = "00000000-0000-4000-8000-0000000009b1";
+const JOB_QN = "user-data-rights:job:run-export-jobs";
+
+// App-weiter Override wie money-horse's cashColtConfigResolver — provider=inmemory
+// ohne per-Tenant-config-Row. Der Job-Kontext trägt DIESEN resolver, kein config.
+const configResolver = createConfigResolver({
+  appOverrides: new Map([["file-foundation:config:provider", "inmemory"]]),
+});
+
+let stack: TestStack;
+
+beforeAll(async () => {
+  stack = await setupTestStack({
+    features: [
+      createConfigFeature(),
+      createUserFeature(),
+      createDataRetentionFeature(),
+      createComplianceProfilesFeature(),
+      fileFoundationFeature,
+      fileProviderInMemoryFeature,
+      createSessionsFeature(),
+      createUserDataRightsFeature(),
+    ],
+  });
+  await createEventsTable(stack.db);
+  await unsafePushTables(stack.db, { configValuesTable });
+  await unsafeCreateEntityTable(stack.db, exportJobEntity);
+  await unsafeCreateEntityTable(stack.db, exportDownloadTokenEntity);
+  await unsafeCreateEntityTable(stack.db, tenantComplianceProfileEntity);
+  await unsafeCreateEntityTable(stack.db, userEntity);
+  await asRawClient(stack.db).unsafe(`
+    CREATE TABLE IF NOT EXISTS read_tenant_memberships (
+      id UUID PRIMARY KEY DEFAULT gen_random_uuid(),
+      tenant_id UUID NOT NULL,
+      user_id TEXT NOT NULL,
+      version INTEGER NOT NULL DEFAULT 0,
+      inserted_at TIMESTAMPTZ NOT NULL DEFAULT now(),
+      modified_at TIMESTAMPTZ NOT NULL DEFAULT now(),
+      inserted_by_id TEXT,
+      modified_by_id TEXT,
+      is_deleted BOOLEAN NOT NULL DEFAULT false,
+      deleted_at TIMESTAMPTZ,
+      deleted_by_id TEXT,
+      roles TEXT NOT NULL DEFAULT '[]',
+      UNIQUE(user_id, tenant_id)
+    )
+  `);
+});
+
+afterAll(async () => {
+  await stack.cleanup();
+});
+
+beforeEach(async () => {
+  const raw = asRawClient(stack.db);
+  await raw.unsafe("DELETE FROM read_export_jobs");
+  await raw.unsafe("DELETE FROM read_users");
+  await raw.unsafe("DELETE FROM read_tenant_memberships");
+  await insertOne(stack.db, userTable, {
+    id: USER_ID,
+    tenantId: TENANT,
+    email: "export-cron@example.test",
+    passwordHash: "hashed",
+    displayName: "Cron Export",
+    locale: "de",
+    emailVerified: true,
+    roles: '["Member"]',
+    status: USER_STATUS.Active,
+  });
+  await raw.unsafe(
+    `INSERT INTO read_tenant_memberships (tenant_id, user_id, roles) VALUES ('${TENANT}', '${USER_ID}', '["Member"]')`,
+  );
+});
+
+// Seedet einen pending Export-Job über den echten request-export-Handler.
+async function seedPendingJob(): Promise<string> {
+  const res = await stack.http.writeOk<{ jobId: string }>(
+    "user-data-rights:write:request-export",
+    {},
+    { id: USER_ID, tenantId: TENANT, roles: ["Member"] },
+  );
+  return res.jobId;
+}
+
+describe("run-export-jobs cron-context", () => {
+  test("Cron-Job-Kontext (configResolver, KEIN config) → Export läuft durch, bytesWritten > 0", async () => {
+    const jobId = await seedPendingJob();
+    const job = stack.registry.getJob(JOB_QN);
+    expect(job).toBeDefined();
+
+    // EXAKT der prod-Job-Kontext: configResolver gesetzt, config undefined.
+    const jobCtx = {
+      db: stack.db,
+      registry: stack.registry,
+      configResolver,
+      _userId: SYSTEM_USER_ID,
+      now: getTemporal().Now.instant(),
+    };
+    // Vor dem Fix wirft der Wrapper hier "ctx.config is missing".
+    await job?.handler({}, jobCtx as never);
+
+    const [row] = (await selectMany(stack.db, exportJobsTable, { id: jobId })) as Array<{
+      status: string;
+      bytesWritten: number | null;
+      errorMessage: string | null;
+    }>;
+    expect(row?.errorMessage).toBeNull();
+    expect(row?.status).toBe(EXPORT_JOB_STATUS.Done);
+    expect(row?.bytesWritten ?? 0).toBeGreaterThan(0);
+  });
+});

package/src/user-data-rights/feature.ts

@@ -4,6 +4,7 @@ import {
   type FeatureDefinition,
   SYSTEM_USER_ID,
 } from "@cosmicdrift/kumiko-framework/engine";
+import { createConfigAccessor } from "../config";
 import { createFileProviderForTenant } from "../file-foundation";
 import { PRIVACY_CENTER_SCREEN_ID } from "./constants";
 import { cancelDeletionWrite } from "./handlers/cancel-deletion.write";
@@ -295,17 +296,35 @@ export function createUserDataRightsFeature(opts: UserDataRightsOptions = {}): F
         // SYSTEM_USER_ID ist die framework-weite Konvention. Der job-
         // Discriminator wird via handlerName="user-data-rights:run-export-
         // jobs" im Secret-Read-Audit erfasst.
-        const providerCtx = {
-          config: ctx.config,
-          registry: ctx.registry,
-          secrets: ctx.secrets,
-          _userId: ctx._userId ?? SYSTEM_USER_ID,
-        };
+        const exportUserId = ctx._userId ?? SYSTEM_USER_ID;
+        const exportDb = ctx.db as import("@cosmicdrift/kumiko-framework/db").DbConnection; // @cast-boundary db-operator
+        const exportRegistry = ctx.registry;
         await runExportJobs({
-          db: ctx.db as import("@cosmicdrift/kumiko-framework/db").DbConnection, // @cast-boundary db-operator
-          registry: ctx.registry,
-          buildStorageProvider: async (tenantId) =>
-            createFileProviderForTenant(providerCtx, tenantId, "user-data-rights:run-export-jobs"), // @wrapper-known semantic-alias
+          db: exportDb,
+          registry: exportRegistry,
+          buildStorageProvider: async (tenantId) => {
+            // ctx.config (per-request ConfigAccessor) existiert nur im HTTP-
+            // Dispatcher; der Cron-Job-Kontext trägt ctx.configResolver. Den
+            // per-Tenant-Accessor daraus bauen (wie der HTTP-Pfad via
+            // _configAccessorFactory) — sonst wirft createFileProviderForTenant
+            // "ctx.config is missing" und jeder Export landet auf failed.
+            const config =
+              ctx.config ??
+              (ctx.configResolver
+                ? createConfigAccessor(
+                    exportRegistry,
+                    ctx.configResolver,
+                    tenantId as Parameters<typeof createConfigAccessor>[2],
+                    exportUserId,
+                    exportDb,
+                  )
+                : undefined);
+            return createFileProviderForTenant(
+              { config, registry: exportRegistry, secrets: ctx.secrets, _userId: exportUserId },
+              tenantId,
+              "user-data-rights:run-export-jobs",
+            );
+          },
           now: T.Now.instant(),
           // Atom 5 — App-Author-Callbacks fuer Email-Notification.
           // Optional: wenn nicht gesetzt, kein Email; User pollt