@cosmicdrift/kumiko-bundled-features 0.45.0 → 0.46.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.45.0",
+  "version": "0.46.0",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",

package/src/__tests__/ride-along-schema-meta.test.ts

@@ -0,0 +1,33 @@
+// Regression for framework#347: the migration generator (collectTableMetas)
+// must see the ride-along columns/indexes that live only on a feature's
+// backing Drizzle table, not just the entity fields. Before the fix the
+// generated migration omitted them → prod-500 (publicstatus#116). Guards the
+// `r.entity(name, def, { table })` wiring on the two real ride-along features
+// so a future removal of the `{ table }` arg fails here.
+
+import { describe, expect, test } from "bun:test";
+import { collectTableMetas } from "@cosmicdrift/kumiko-framework/db";
+import { createDeliveryFeature } from "../delivery/feature";
+import { createSecretsFeature } from "../secrets/feature";
+
+describe("ride-along schema metas reach the generator (framework#347)", () => {
+  test("secrets read_tenant_secrets: envelope/metadata/last_rotated_at + (tenant,key) uniqueIndex", () => {
+    const meta = collectTableMetas([createSecretsFeature()]).find(
+      (m) => m.tableName === "read_tenant_secrets",
+    );
+    const cols = meta?.columns.map((c) => c.name) ?? [];
+    expect(cols).toContain("envelope");
+    expect(cols).toContain("metadata");
+    expect(cols).toContain("last_rotated_at");
+    expect(meta?.indexes.map((i) => i.name)).toContain("read_tenant_secrets_tenant_key_unique");
+  });
+
+  test("delivery read_notification_preferences: (tenant,user,type,channel) uniqueIndex", () => {
+    const meta = collectTableMetas([createDeliveryFeature()]).find(
+      (m) => m.tableName === "read_notification_preferences",
+    );
+    const unique = meta?.indexes.find((i) => i.name === "read_notification_preferences_unique");
+    expect(unique).toBeDefined();
+    expect(unique?.unique).toBe(true);
+  });
+});

package/src/delivery/feature.ts

@@ -10,6 +10,7 @@ import {
   deliveryAttemptsTable,
   deliveryAttemptsTableMeta,
   notificationPreferenceEntity,
+  notificationPreferencesTable,
 } from "./tables";
 
 export function createDeliveryFeature(): FeatureDefinition {
@@ -18,7 +19,12 @@ export function createDeliveryFeature(): FeatureDefinition {
       "The notification dispatch core: call `ctx.notify(notificationType, { to, route, data, priority, idempotencyKey })` from any handler to fan out a notification across all registered channels (email, in-app, push). It stores per-user channel preferences in the `notification-preference` entity, logs every attempt to `read_delivery_attempts`, and enforces idempotency and rate-limiting \u2014 add `channel-email`, `channel-in-app`, or `channel-push` on top to actually send anything.",
     );
     r.systemScope();
-    r.entity("notification-preference", notificationPreferenceEntity);
+    // Backing table: the (tenant,user,type,channel) uniqueIndex lives only on
+    // the physical table, not on the entity fields, so the generator would
+    // otherwise omit it → duplicate preference rows on concurrent upserts.
+    r.entity("notification-preference", notificationPreferenceEntity, {
+      table: notificationPreferencesTable,
+    });
     r.unmanagedTable(deliveryAttemptsTableMeta, {
       reason: "read_side.delivery_attempt_log",
     });

package/src/secrets/feature.ts

@@ -7,7 +7,7 @@ import { listQuery } from "./handlers/list.query";
 import { rotateJob } from "./handlers/rotate.job";
 import { setWrite } from "./handlers/set.write";
 import { secretReadSchema } from "./secrets-context";
-import { tenantSecretEntity } from "./table";
+import { tenantSecretEntity, tenantSecretsTable } from "./table";
 
 /**
  * Env-vars contract for the `secrets` feature. Apps merge this via
@@ -93,7 +93,11 @@ export function createSecretsFeature(): FeatureDefinition {
     // .updated/.deleted` events land on the aggregate stream. Reads fire a
     // separate `tenantSecretRead` event per call (see secrets-context.get
     // for the one-event-per-read rationale).
-    r.entity("tenant-secret", tenantSecretEntity);
+    // Backing table: envelope/metadata/last_rotated_at + the (tenant,key)
+    // uniqueIndex are not expressible via the field-DSL (jsonb-without-default,
+    // now()-default), so the physical table is the DDL truth. Without this the
+    // generated migration omitted those columns → prod-500 (publicstatus#116).
+    r.entity("tenant-secret", tenantSecretEntity, { table: tenantSecretsTable });
 
     // Read-audit domain-event. Registered here so ops tools + MSPs can
     // discover the type; secrets-context.get parses payloads against