@cosmicdrift/kumiko-bundled-features 0.34.1 → 0.35.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.34.1",
+  "version": "0.35.0",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",

package/src/custom-fields/web/__tests__/custom-fields-form-section.test.tsx

@@ -110,6 +110,63 @@ describe("CustomFieldsFormSection", () => {
     });
   });
 
+  test("pre-fills inputs from initialValues (Edit zeigt den Bestand, nicht write-only)", async () => {
+    mockedQueryRows = [
+      {
+        id: "f1",
+        entityName: "component",
+        fieldKey: "vendor",
+        type: "text",
+        required: false,
+        displayOrder: 1,
+      },
+      {
+        id: "f2",
+        entityName: "component",
+        fieldKey: "tier",
+        type: "number",
+        required: false,
+        displayOrder: 2,
+      },
+    ];
+    dispatchSpy.mockClear();
+
+    render(
+      <Wrapper>
+        <CustomFieldsFormSection
+          entityName="component"
+          entityId="row-42"
+          initialValues={{ vendor: "Hetzner", tier: 3 }}
+        />
+      </Wrapper>,
+    );
+
+    // Gespeicherte Werte sind in den Inputs sichtbar (kein write-only mehr).
+    const vendorInput = document.getElementById("custom-field-vendor") as HTMLInputElement;
+    const tierInput = document.getElementById("custom-field-tier") as HTMLInputElement;
+    expect(vendorInput.value).toBe("Hetzner");
+    expect(tierInput.value).toBe("3");
+
+    // Save bleibt disabled bis zur ersten Änderung (pending trackt nur Edits) —
+    // sonst würde jeder Mount alle Werte sinnlos neu schreiben.
+    const saveBtn = screen.getByTestId("custom-fields-form-save") as HTMLButtonElement;
+    expect(saveBtn.disabled).toBe(true);
+
+    // Nur das geänderte Feld wird geschrieben, nicht der unveränderte Bestand.
+    fireEvent.change(vendorInput, { target: { value: "Netcup" } });
+    expect(saveBtn.disabled).toBe(false);
+    fireEvent.click(saveBtn);
+    await Promise.resolve();
+    await Promise.resolve();
+    expect(dispatchSpy).toHaveBeenCalledTimes(1);
+    expect(dispatchSpy).toHaveBeenCalledWith("custom-fields:write:set-custom-field", {
+      entityName: "component",
+      entityId: "row-42",
+      fieldKey: "vendor",
+      value: "Netcup",
+    });
+  });
+
   test("shows create-mode banner when entityId is null and skips the fieldDefinition query", () => {
     mockedQueryRows = [];
     useQuerySpy.mockClear();

package/src/custom-fields/web/custom-fields-form-section.tsx

@@ -35,9 +35,15 @@ type FieldDefinitionListResponse = {
 export function CustomFieldsFormSection({
   entityName,
   entityId,
+  initialValues,
 }: {
   readonly entityName: string;
   readonly entityId: string | null;
+  /** Bereits gespeicherte customField-Werte der Entity (aus der detail-
+   *  row durchgereicht). Ohne sie wäre die Section write-only — die Inputs
+   *  zeigen den Bestand beim Edit. `pending` trackt nur Änderungen, also
+   *  bleibt der Save-Button bis zur ersten Eingabe disabled. */
+  readonly initialValues?: Readonly<Record<string, unknown>>;
 }): ReactNode {
   const { Banner, Button, Field, Input, Text } = usePrimitives();
   const t = useTranslation();
@@ -122,8 +128,10 @@ export function CustomFieldsFormSection({
           label={field.fieldKey}
           required={field.required}
         >
-          {renderInputFor(field, pending[field.fieldKey] ?? "", (v) =>
-            setPending((p) => ({ ...p, [field.fieldKey]: v })),
+          {renderInputFor(
+            field,
+            pending[field.fieldKey] ?? displayValue(field.type, initialValues?.[field.fieldKey]),
+            (v) => setPending((p) => ({ ...p, [field.fieldKey]: v })),
           )}
         </Field>
       ))}
@@ -189,3 +197,13 @@ function coerceValue(type: string, raw: string): unknown {
   if (type === "boolean") return raw === "true";
   return raw;
 }
+
+// Umkehrung von coerceValue: gespeicherter jsonb-Wert → string-Form für den
+// Input. number/boolean/date/text werden so dargestellt, wie der Input sie
+// erwartet; fehlende Werte werden zu "".
+function displayValue(type: string, value: unknown): string {
+  if (value === undefined || value === null) return "";
+  if (type === "boolean") return value === true ? "true" : "false";
+  if (type === "number") return typeof value === "number" ? String(value) : String(value);
+  return String(value);
+}