@cosmicdrift/kumiko-bundled-features 0.259.0 → 0.260.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.259.0",
+  "version": "0.260.0",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -129,12 +129,12 @@
     "./workflow-runner": "./src/workflow-runner/index.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.259.0",
-    "@cosmicdrift/kumiko-framework": "0.259.0",
-    "@cosmicdrift/kumiko-headless": "0.259.0",
-    "@cosmicdrift/kumiko-renderer": "0.259.0",
-    "@cosmicdrift/kumiko-renderer-web": "0.259.0",
-    "@cosmicdrift/kumiko-types": "0.259.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.260.0",
+    "@cosmicdrift/kumiko-framework": "0.260.0",
+    "@cosmicdrift/kumiko-headless": "0.260.0",
+    "@cosmicdrift/kumiko-renderer": "0.260.0",
+    "@cosmicdrift/kumiko-renderer-web": "0.260.0",
+    "@cosmicdrift/kumiko-types": "0.260.0",
     "@mollie/api-client": "^4.5.0",
     "@node-rs/argon2": "^2.0.2",
     "@types/mailparser": "^3.4.6",
@@ -163,7 +163,7 @@
   ],
   "devDependencies": {
     "@testing-library/user-event": "^14.6.1",
-    "@cosmicdrift/kumiko-locale-de": "0.259.0",
-    "@cosmicdrift/kumiko-locale-es": "0.259.0"
+    "@cosmicdrift/kumiko-locale-de": "0.260.0",
+    "@cosmicdrift/kumiko-locale-es": "0.260.0"
   }
 }

package/src/ledger/__tests__/ledger.integration.test.ts

@@ -242,6 +242,46 @@ describe("ledger integration — reverse-transaction (Storno)", () => {
     // Original + exactly ONE Storno — a second reverse must not book again.
     expect(await listTransactions()).toHaveLength(2);
   });
+
+  test("the Storno inherits the original's subject — an eq filter on subjectId finds both", async () => {
+    const bank = await createAccount("Bank Subj", "asset");
+    const rent = await createAccount("Subj Income", "income");
+    const tx = await createTransaction(
+      [
+        { accountId: bank, amount: 40000 },
+        { accountId: rent, amount: -40000 },
+      ],
+      { description: "Miete WE1", subjectType: "lease", subjectId: "lease-1" },
+    );
+
+    await stack.http.writeOk(LedgerHandlers.reverseTransaction, { id: tx.id }, admin);
+
+    const rows = await listTransactions(admin, {
+      filter: { field: "subjectId", op: "eq", value: "lease-1" },
+    });
+    expect(rows).toHaveLength(2);
+    for (const row of rows) {
+      expect(row["subjectType"]).toBe("lease");
+      expect(row["subjectId"]).toBe("lease-1");
+    }
+  });
+
+  test("reversing a booking without a subject leaves the Storno without one", async () => {
+    const bank = await createAccount("Bank NoSubj", "asset");
+    const rent = await createAccount("NoSubj Income", "income");
+    const tx = await createTransaction([
+      { accountId: bank, amount: 15000 },
+      { accountId: rent, amount: -15000 },
+    ]);
+
+    await stack.http.writeOk(LedgerHandlers.reverseTransaction, { id: tx.id }, admin);
+
+    const rows = await listTransactions();
+    const storno = rows.find((r) => r["reference"] === tx.id);
+    expect(storno).toBeDefined();
+    expect(storno?.["subjectType"]).toBeNull();
+    expect(storno?.["subjectId"]).toBeNull();
+  });
 });
 
 describe("ledger integration — trial balance (golden invariant)", () => {

package/src/ledger/handlers/reverse-transaction.write.ts

@@ -68,6 +68,12 @@ export function createReverseTransactionHandler(
         amount: -l.amount,
       }));
 
+      // The reversal shares its subject with the original so filtering by
+      // subjectId still finds the Storno; unset on the original stays unset.
+      const subjectType =
+        typeof original["subjectType"] === "string" ? original["subjectType"] : null;
+      const subjectId = typeof original["subjectId"] === "string" ? original["subjectId"] : null;
+
       return transactionExecutor.create(
         {
           id: generateId(),
@@ -78,6 +84,8 @@ export function createReverseTransactionHandler(
           reference: payload.id,
           status: "posted",
           lines,
+          subjectType,
+          subjectId,
         },
         event.user,
         ctx.db,

package/src/notes-history/__tests__/notes-section.test.tsx

@@ -20,9 +20,9 @@ import {
   TokensProvider,
 } from "@cosmicdrift/kumiko-renderer";
 import { defaultPrimitives, defaultTokens } from "@cosmicdrift/kumiko-renderer-web";
-import { render, waitFor } from "@testing-library/react";
+import { fireEvent, render, waitFor } from "@testing-library/react";
 import type { ReactNode } from "react";
-import { NotesHistoryQueries } from "../constants";
+import { NotesHistoryHandlers, NotesHistoryQueries } from "../constants";
 import { defaultTranslations } from "../web/i18n";
 import { NotesSection } from "../web/notes-section";
 
@@ -203,3 +203,106 @@ describe("NotesSection — entry display", () => {
     expect(metaEl.textContent).toContain(formatWhen(INSERTED_AT));
   });
 });
+
+function makeWriteCapturingDispatcher(): {
+  readonly dispatcher: Dispatcher;
+  readonly writes: { readonly type: string; readonly payload: unknown }[];
+} {
+  const writes: { type: string; payload: unknown }[] = [];
+  const statusStore = createStore<DispatcherStatus>("online");
+  const query = (async (type: string) => {
+    if (type === NotesHistoryQueries.noteList) {
+      return { isSuccess: true, data: { rows: [] } };
+    }
+    return { isSuccess: true, data: null };
+  }) as unknown as Dispatcher["query"];
+  const write = (async (type: string, payload: unknown) => {
+    writes.push({ type, payload });
+    return { isSuccess: true, data: null };
+  }) as unknown as Dispatcher["write"];
+  return {
+    dispatcher: {
+      write,
+      query,
+      batch: (async () => ({ isSuccess: true, results: [] })) as unknown as Dispatcher["batch"],
+      statusStore,
+      async *stream() {},
+      pendingWrites: () => [],
+      pendingFiles: () => [],
+    } as unknown as Dispatcher, // @cast-boundary test-stub
+    writes,
+  };
+}
+
+function renderSectionWith(dispatcher: Dispatcher): ReturnType<typeof render> {
+  const wrapper = ({ children }: { readonly children: ReactNode }): ReactNode => (
+    <TokensProvider value={stubTokens}>
+      <LocaleProvider
+        resolver={stubResolver}
+        fallbackBundles={[defaultTranslations, kumikoDefaultTranslations]}
+      >
+        <PrimitivesProvider value={defaultPrimitives}>
+          <LiveEventsProvider value={stubLiveEvents}>
+            <DispatcherProvider dispatcher={dispatcher}>{children}</DispatcherProvider>
+          </LiveEventsProvider>
+        </PrimitivesProvider>
+      </LocaleProvider>
+    </TokensProvider>
+  );
+  return render(<NotesSection entityName="contact" entityId="contact-1" />, { wrapper });
+}
+
+function requireTextarea(container: HTMLElement): HTMLTextAreaElement {
+  const textarea = container.querySelector("textarea");
+  if (textarea === null) throw new Error("no textarea rendered");
+  return textarea;
+}
+
+describe("NotesSection — Ctrl/Cmd+Enter submit shortcut", () => {
+  test("Ctrl+Enter with a non-empty draft dispatches addNote, same as the button", async () => {
+    const { dispatcher, writes } = makeWriteCapturingDispatcher();
+    const view = renderSectionWith(dispatcher);
+    await waitFor(() => expect(view.getByTestId("notes-section-add")).toBeTruthy());
+
+    const textarea = requireTextarea(view.container);
+    fireEvent.change(textarea, { target: { value: "Ctrl+Enter note" } });
+    fireEvent.keyDown(textarea, { key: "Enter", ctrlKey: true });
+
+    await waitFor(() => expect(writes).toHaveLength(1));
+    expect(writes[0]).toEqual({
+      type: NotesHistoryHandlers.addNote,
+      payload: { entityType: "contact", entityId: "contact-1", body: "Ctrl+Enter note" },
+    });
+  });
+
+  test("Cmd+Enter (metaKey) also dispatches addNote", async () => {
+    const { dispatcher, writes } = makeWriteCapturingDispatcher();
+    const view = renderSectionWith(dispatcher);
+    await waitFor(() => expect(view.getByTestId("notes-section-add")).toBeTruthy());
+
+    const textarea = requireTextarea(view.container);
+    fireEvent.change(textarea, { target: { value: "Cmd+Enter note" } });
+    fireEvent.keyDown(textarea, { key: "Enter", metaKey: true });
+
+    await waitFor(() => expect(writes).toHaveLength(1));
+    expect(writes[0]?.payload).toEqual({
+      entityType: "contact",
+      entityId: "contact-1",
+      body: "Cmd+Enter note",
+    });
+  });
+
+  test("Ctrl+Enter with an empty draft does nothing", async () => {
+    const { dispatcher, writes } = makeWriteCapturingDispatcher();
+    const view = renderSectionWith(dispatcher);
+    await waitFor(() => expect(view.getByTestId("notes-section-add")).toBeTruthy());
+
+    const textarea = requireTextarea(view.container);
+    fireEvent.keyDown(textarea, { key: "Enter", ctrlKey: true });
+
+    // No affirmative signal to await on a no-op — give pending microtasks a
+    // tick, then assert nothing landed.
+    await new Promise((resolve) => setTimeout(resolve, 0));
+    expect(writes).toHaveLength(0);
+  });
+});

package/src/notes-history/web/notes-section.tsx

@@ -126,6 +126,9 @@ export function NotesSection({
           name="draft"
           value={draft}
           onChange={setDraft}
+          onSubmitShortcut={() => {
+            if (!busy && draft.trim() !== "") addNote();
+          }}
         />
         <div>
           <Button