@cosmicdrift/kumiko-bundled-features 0.153.0 → 0.154.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cosmicdrift/kumiko-bundled-features",
-  "version": "0.153.0",
+  "version": "0.154.0",
   "description": "Built-in features — tenant, user, auth, delivery. The stuff you'd rewrite anyway, already typed.",
   "license": "BUSL-1.1",
   "author": "Marc Frost <marc@cosmicdriftgamestudio.com>",
@@ -115,11 +115,11 @@
     "./step-dispatcher": "./src/step-dispatcher/index.ts"
   },
   "dependencies": {
-    "@cosmicdrift/kumiko-dispatcher-live": "0.153.0",
-    "@cosmicdrift/kumiko-framework": "0.153.0",
-    "@cosmicdrift/kumiko-headless": "0.153.0",
-    "@cosmicdrift/kumiko-renderer": "0.153.0",
-    "@cosmicdrift/kumiko-renderer-web": "0.153.0",
+    "@cosmicdrift/kumiko-dispatcher-live": "0.154.0",
+    "@cosmicdrift/kumiko-framework": "0.154.0",
+    "@cosmicdrift/kumiko-headless": "0.154.0",
+    "@cosmicdrift/kumiko-renderer": "0.154.0",
+    "@cosmicdrift/kumiko-renderer-web": "0.154.0",
     "@mollie/api-client": "^4.5.0",
     "imapflow": "^1.3.3",
     "mailparser": "^3.9.8",

package/src/auth-mfa/__tests__/disable-and-regenerate.integration.test.ts

@@ -4,6 +4,7 @@ import {
   createTestUser,
   setupTestStack,
   type TestStack,
+  testTenantId,
   unsafeCreateEntityTable,
   unsafePushTables,
 } from "@cosmicdrift/kumiko-framework/stack";
@@ -18,7 +19,7 @@ import { createTenantFeature } from "../../tenant";
 import { createUserFeature } from "../../user/feature";
 import { userEntity } from "../../user/schema/user";
 import { base32Decode } from "../base32";
-import { AuthMfaHandlers } from "../constants";
+import { AuthMfaHandlers, AuthMfaQueries } from "../constants";
 import { createAuthMfaFeature } from "../feature";
 import { userMfaEntity } from "../schema/user-mfa";
 import { currentTotpCode } from "../totp";
@@ -216,3 +217,49 @@ describe("regenerate-recovery", () => {
     expectErrorIncludes(err, "mfa_not_enabled");
   });
 });
+
+// pr-review kumiko-framework #1062/4 — the only prior coverage of
+// user-mfa:status was the false → true transition (implicit in
+// enableMfaFor's own setup); the more interesting true → false after
+// disable, and tenant isolation, had no assertion anywhere.
+describe("status query", () => {
+  test("true → false after disable", async () => {
+    const { user, secret } = await enableMfaFor("status-disable-1");
+
+    const before = await stack.http.queryOk<{ enabled: boolean }>(AuthMfaQueries.status, {}, user);
+    expect(before.enabled).toBe(true);
+
+    await stack.http.writeOk(AuthMfaHandlers.disable, { code: currentTotpCode(secret) }, user);
+
+    const after = await stack.http.queryOk<{ enabled: boolean }>(AuthMfaQueries.status, {}, user);
+    expect(after.enabled).toBe(false);
+  });
+
+  test("tenant isolation: same userId enrolled in tenant A stays invisible to the same id in tenant B", async () => {
+    // The entity's uniqueness is [userId, tenantId] — a second tenant CAN
+    // have a distinct (non-enrolled) row for the identical userId. The
+    // query filters only by userId (see status.query.ts's own comment) and
+    // relies on ctx.db's tenant scoping to keep them apart; assert that
+    // scoping actually holds instead of just trusting it.
+    const { user: tenantAUser } = await enableMfaFor("status-tenant-iso-1");
+    const tenantBUser = createTestUser({
+      id: tenantAUser.id,
+      tenantId: testTenantId(2),
+      roles: ["User"],
+    });
+
+    const tenantAStatus = await stack.http.queryOk<{ enabled: boolean }>(
+      AuthMfaQueries.status,
+      {},
+      tenantAUser,
+    );
+    expect(tenantAStatus.enabled).toBe(true);
+
+    const tenantBStatus = await stack.http.queryOk<{ enabled: boolean }>(
+      AuthMfaQueries.status,
+      {},
+      tenantBUser,
+    );
+    expect(tenantBStatus.enabled).toBe(false);
+  });
+});