@corva/ui 3.78.0-16 → 3.78.0-17

package/MCP_README.md

@@ -711,9 +711,17 @@ To check whether telemetry is currently active for your install, run `/mcp__corv
 
 To opt out entirely, set `CORVA_UI_MCP_TELEMETRY_DISABLED=1` in the server's environment (e.g. in the `env` block of
 your MCP config file) — any non-empty value other than `0` or `false` works. The switch is honored at runtime before
-any telemetry configuration is read. Feedback travels over the same channel and is subject to the same sampling rate:
-`submit_feedback` and the `feedback` prompt always confirm the message, but with telemetry off nothing reaches the
-maintainers, and with a sampling rate below 1 some messages are dropped.
+any telemetry configuration is read.
+
+Feedback travels over the same channel, so `submit_feedback` reports one of 2 delivery states:
+
+- **queued** — telemetry is enabled and the message was handed to it for export. Delivery is not confirmed. Feedback is
+  exempt from the sampling rate, so it is never sampled out.
+- **not sent** — nothing reaches the maintainers, and the response names the cause: the opt-out is set
+  (`CORVA_UI_MCP_TELEMETRY_DISABLED`, or `"enabled": false` in the local config), or telemetry has no valid
+  configuration in this session (or failed to start).
+
+The `feedback` prompt relays that state to you, and `get_diagnostics` shows it as the feedback channel.
 
 ## FAQ
 

package/mcp-server/server.mjs

@@ -5,7 +5,7 @@ import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js'
 import { OTLPMetricExporter, AggregationTemporalityPreference } from '@opentelemetry/exporter-metrics-otlp-http';
 import { MeterProvider, PeriodicExportingMetricReader } from '@opentelemetry/sdk-metrics';
 import { SpanKind, SpanStatusCode, propagation, context } from '@opentelemetry/api';
-import { NodeTracerProvider, TraceIdRatioBasedSampler, SimpleSpanProcessor } from '@opentelemetry/sdk-trace-node';
+import { TraceIdRatioBasedSampler, SamplingDecision, NodeTracerProvider, SimpleSpanProcessor } from '@opentelemetry/sdk-trace-node';
 import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-http';
 import { randomUUID } from 'crypto';
 import { defaultResource, resourceFromAttributes } from '@opentelemetry/resources';
@@ -246,9 +246,9 @@ const validateDsn = dsn => {
   return url.href;
 };
 
-const MCP_SERVER_VERSION = '1.8.0';
+const MCP_SERVER_VERSION = '1.9.0';
 
-var version = "3.78.0-16";
+var version = "3.78.0-17";
 
 const CORVA_UI_VERSION = version;
 
@@ -535,11 +535,24 @@ const recordInitSpan = (tracer, attrs) => {
   }
 };
 
+// Feedback leaves the process only as this span, so a ratio below 1 would silently lose messages.
+// Matched by name: recordToolSpan sets gen_ai.tool.name after startSpan, too late for a sampler.
+const FEEDBACK_SPAN_NAME = 'tools/call submit_feedback';
+const createSampler = samplingRate => {
+  const ratioSampler = new TraceIdRatioBasedSampler(samplingRate);
+  return {
+    shouldSample: (context, traceId, spanName) => spanName === FEEDBACK_SPAN_NAME ? {
+      decision: SamplingDecision.RECORD_AND_SAMPLED
+    } : ratioSampler.shouldSample(context, traceId),
+    toString: () => `FeedbackAlwaysOn{${ratioSampler.toString()}}`
+  };
+};
+
 const createTracerProvider = config => {
   const dsn = validateDsn(config.dsn);
   return new NodeTracerProvider({
     resource: config.resource,
-    sampler: new TraceIdRatioBasedSampler(config.samplingRate),
+    sampler: createSampler(config.samplingRate),
     spanProcessors: [
     // Export spans immediately at end for short-lived local MCP sessions.
     new SimpleSpanProcessor(new OTLPTraceExporter({
@@ -659,7 +672,7 @@ const readLocalConfig = async logger => {
     // Fail closed: the file's presence signals the user wants local control over telemetry,
     // so a broken file must never silently fall back to the remote config that re-enables it.
     logger.warn(`Local telemetry config file exists but is invalid: ${configPath}. Telemetry disabled (fix or delete the file to re-enable).`);
-    return 'disabled';
+    return 'invalid';
   } catch (error) {
     if (error instanceof Error && 'code' in error && error.code === 'ENOENT') {
       // File doesn't exist, which is normal. Silently skip.
@@ -668,10 +681,13 @@ const readLocalConfig = async logger => {
 
     // Other errors (JSON parse errors, permissions, etc.) — same fail-closed rule as above.
     logger.warn(`Failed to read local telemetry config from ${configPath}: ${error instanceof Error ? error.message : String(error)}. Telemetry disabled (fix or delete the file to re-enable).`);
-    return 'disabled';
+    return 'invalid';
   }
 };
 
+/** The user turned telemetry off, as opposed to it being unavailable. */
+const TELEMETRY_OPT_OUT = 'opt-out';
+
 // Read at call time, not module scope: in production bundles the rollup replace plugin bakes
 // the URL in as a string literal either way, while in dev/tsx mode (and tests) this honors the
 // process env at the moment of the call.
@@ -688,13 +704,18 @@ const isKillSwitchEnabled = () => {
 const fetchTelemetryConfig = async logger => {
   if (isKillSwitchEnabled()) {
     logger.info('Telemetry disabled via CORVA_UI_MCP_TELEMETRY_DISABLED');
-    return null;
+    return TELEMETRY_OPT_OUT;
   }
   const localConfig = await readLocalConfig(logger);
 
   // Explicit user opt-out ("enabled": false in the local file) — must stop here, not
   // fall through to the remote config, which would override the user's choice.
   if (localConfig === 'disabled') {
+    return TELEMETRY_OPT_OUT;
+  }
+
+  // A broken file fails closed too, but it is not the user's choice, so it is not opt-out.
+  if (localConfig === 'invalid') {
     return null;
   }
   if (localConfig) {
@@ -743,10 +764,18 @@ const fetchTelemetryConfig = async logger => {
 const initTelemetry = async logger => {
   try {
     const configResult = await fetchTelemetryConfig(logger);
+    if (configResult === TELEMETRY_OPT_OUT) {
+      return {
+        client: createNoopTelemetryClient(),
+        info: null,
+        disabledReason: 'opt-out'
+      };
+    }
     if (!configResult) {
       return {
         client: createNoopTelemetryClient(),
-        info: null
+        info: null,
+        disabledReason: 'no-config'
       };
     }
     const {
@@ -777,13 +806,15 @@ const initTelemetry = async logger => {
       info: {
         configSource: source,
         samplingRate: config.samplingRate
-      }
+      },
+      disabledReason: null
     };
   } catch (error) {
     logger.warn(`Telemetry init failed, continuing without telemetry: ${error}`);
     return {
       client: createNoopTelemetryClient(),
-      info: null
+      info: null,
+      disabledReason: 'no-config'
     };
   }
 };
@@ -1037,7 +1068,7 @@ Do the following:
 2. Infer a sentiment ('positive', 'negative', or 'neutral') from the feedback. If it is ambiguous, ask the user briefly or default to 'neutral'.
 3. If the feedback is about a specific item, set category (component, hook, util, constant, client, theme, tool, docs, or other) and target (e.g. the component or hook name).
 4. Call \`mcp__corva-ui__submit_feedback\` with the message and the fields above, and set \`source: "user"\` (this feedback is relayed from the user).
-5. Confirm to the user that the feedback was sent.`;
+5. Tell the user the delivery state the tool reported: queued, or not sent with its cause. Do not claim more than the tool reported.`;
   return {
     description: feedbackPromptDescription,
     messages: [{
@@ -22471,11 +22502,54 @@ ${formatMethods(client.methods)}`;
   };
 };
 
+const FEEDBACK_CATEGORIES = [...ENTITY_TYPES, 'theme', 'tool', 'docs', 'other'];
+const submitFeedbackToolName = 'submit_feedback';
+const submitFeedbackToolTitle = 'Submit Feedback';
+const submitFeedbackToolDescription = `Send feedback about @corva/ui or this MCP server so the maintainers can improve docs and coverage.
+Use this when the user says something like "send feedback that…", or proactively when you hit a docs/coverage gap (a missing component, a wrong or incomplete prop, a hook that lacks an example, a search that should have matched but didn't).
+
+Always infer sentiment and category from the feedback itself — do not leave them at the defaults. Reserve sentiment 'neutral' for genuinely factual/mixed feedback and category 'other' only when none of the specific categories fit.
+Set source to 'agent' when you are reporting a gap on your own initiative, or 'user' when relaying something the user said.
+Keep message specific and actionable; name the component/hook/util in target when the feedback is about a particular item.
+The response states whether the message was queued or not sent, and why; relay that state to the user as is.`;
+const submitFeedbackToolSchema = {
+  message: z.string().min(1).describe('The feedback text (required). Be specific and actionable.'),
+  sentiment: z.enum(['positive', 'negative', 'neutral']).optional().describe("Tone of the feedback — classify it from the message; don't default to neutral unless the feedback is genuinely neutral/factual (default: neutral)"),
+  category: z.enum(FEEDBACK_CATEGORIES).optional().describe("What the feedback is about — pick the most specific category; use 'other' only when none apply"),
+  target: z.string().optional().describe('The specific component/hook/util/tool the feedback is about (e.g. "Button")'),
+  source: z.enum(['user', 'agent']).optional().describe("Who originated the feedback: 'user' (relayed) or 'agent' (default: user)")
+};
+const NOT_SENT_CAUSES = {
+  'opt-out': 'telemetry is turned off by opt-out (CORVA_UI_MCP_TELEMETRY_DISABLED, or "enabled": false in the local telemetry config)',
+  'no-config': 'telemetry has no valid configuration in this session, or it failed to start'
+};
+const describeFeedbackDelivery = delivery => delivery.state === 'queued' ? 'queued — handed to telemetry for export; delivery is not confirmed' : `not sent — ${NOT_SENT_CAUSES[delivery.cause]}`;
+const formatResponse = (delivery, sentiment) => delivery.state === 'queued' ? `Feedback ${describeFeedbackDelivery(delivery)}. (${sentiment})\nThe @corva/ui team uses this to improve the library and its docs.` : `Feedback ${describeFeedbackDelivery(delivery)}. Feedback travels only through telemetry, so the @corva/ui team will not receive this message. Tell the user, so they can share it with the team another way.`;
+const handleSubmitFeedback = (args, delivery) => {
+  const message = args.message?.trim() ?? '';
+  if (!message) {
+    throw new Error('Feedback message cannot be empty.');
+  }
+  const sentiment = args.sentiment ?? 'neutral';
+  const source = args.source ?? 'user';
+  const category = args.category?.trim() || undefined;
+  const target = args.target?.trim() || undefined;
+  return {
+    response: createToolResponse(formatResponse(delivery, sentiment)),
+    delivery,
+    message,
+    sentiment,
+    category,
+    target,
+    source
+  };
+};
+
 const diagnosticsToolName = 'get_diagnostics';
 const diagnosticsToolTitle = 'Get Server Diagnostics';
 const diagnosticsToolDescription = `Get MCP server health metrics.
 Returns server version, uptime, memory usage, request statistics, telemetry status,
-project identity (app key and package name), and the prompts this server registers.`;
+whether feedback can reach the maintainers, project identity (app key and package name), and the prompts this server registers.`;
 const diagnosticsToolSchema = {};
 const formatUptime = ms => {
   const seconds = Math.floor(ms / 1000);
@@ -22534,6 +22608,9 @@ const handleGetDiagnostics = (stats, telemetry, identity, registeredPromptNames)
         text += `${bold('Telemetry sampling rate')}: ${telemetry.samplingRate}\n`;
       }
     }
+    if (telemetry.feedbackDelivery) {
+      text += `${bold('Feedback channel')}: ${describeFeedbackDelivery(telemetry.feedbackDelivery)}\n`;
+    }
   } else {
     text += `${bold('Status')}: Disabled\n`;
   }
@@ -22550,41 +22627,6 @@ const handleGetDiagnostics = (stats, telemetry, identity, registeredPromptNames)
   };
 };
 
-const FEEDBACK_CATEGORIES = [...ENTITY_TYPES, 'theme', 'tool', 'docs', 'other'];
-const submitFeedbackToolName = 'submit_feedback';
-const submitFeedbackToolTitle = 'Submit Feedback';
-const submitFeedbackToolDescription = `Send feedback about @corva/ui or this MCP server so the maintainers can improve docs and coverage.
-Use this when the user says something like "send feedback that…", or proactively when you hit a docs/coverage gap (a missing component, a wrong or incomplete prop, a hook that lacks an example, a search that should have matched but didn't).
-
-Always infer sentiment and category from the feedback itself — do not leave them at the defaults. Reserve sentiment 'neutral' for genuinely factual/mixed feedback and category 'other' only when none of the specific categories fit.
-Set source to 'agent' when you are reporting a gap on your own initiative, or 'user' when relaying something the user said.
-Keep message specific and actionable; name the component/hook/util in target when the feedback is about a particular item.`;
-const submitFeedbackToolSchema = {
-  message: z.string().min(1).describe('The feedback text (required). Be specific and actionable.'),
-  sentiment: z.enum(['positive', 'negative', 'neutral']).optional().describe("Tone of the feedback — classify it from the message; don't default to neutral unless the feedback is genuinely neutral/factual (default: neutral)"),
-  category: z.enum(FEEDBACK_CATEGORIES).optional().describe("What the feedback is about — pick the most specific category; use 'other' only when none apply"),
-  target: z.string().optional().describe('The specific component/hook/util/tool the feedback is about (e.g. "Button")'),
-  source: z.enum(['user', 'agent']).optional().describe("Who originated the feedback: 'user' (relayed) or 'agent' (default: user)")
-};
-const handleSubmitFeedback = args => {
-  const message = args.message?.trim() ?? '';
-  if (!message) {
-    throw new Error('Feedback message cannot be empty.');
-  }
-  const sentiment = args.sentiment ?? 'neutral';
-  const source = args.source ?? 'user';
-  const category = args.category?.trim() || undefined;
-  const target = args.target?.trim() || undefined;
-  return {
-    response: createToolResponse(`Thanks — your feedback was recorded. (${sentiment})\nThe @corva/ui team uses this to improve the library and its docs.`),
-    message,
-    sentiment,
-    category,
-    target,
-    source
-  };
-};
-
 /**
  * Authoring types for inline component migrations.
  *
@@ -23038,7 +23080,8 @@ const registerTools = deps => {
     getStats,
     getTelemetryStatus,
     getProjectIdentity,
-    getTelemetry
+    getTelemetry,
+    getFeedbackDelivery
   } = deps;
 
   // TODO: every `inputSchema: …ToolSchema as any` below is unexplained — the cast predates any
@@ -23215,7 +23258,7 @@ const registerTools = deps => {
     const parentContext = extractContextFromMeta(extra?._meta);
     try {
       return executeToolWithObservability(submitFeedbackToolName, args, () => {
-        const result = handleSubmitFeedback(args);
+        const result = handleSubmitFeedback(args, getFeedbackDelivery());
         // Supplemental low-cardinality counter, in addition to the standard
         // tool-call span/metrics recorded by the wrapper. No-op when disabled.
         const telemetry = getTelemetry();
@@ -23226,7 +23269,7 @@ const registerTools = deps => {
           ...result,
           isEmpty: false
         };
-      }, r => `feedback recorded (${r.sentiment})`, {
+      }, r => `feedback ${r.delivery.state} (${r.sentiment})`, {
         parentContext,
         getSpanAttributes: r => ({
           // Indexed copy of the message so it is searchable/groupable in
@@ -23339,6 +23382,7 @@ class CorvaUiMcpServer {
 
   telemetry = createNoopTelemetryClient();
   telemetryInfo = null;
+  telemetryDisabledReason = null;
   telemetryInitPromise = null;
   shutdownRequested = false;
   pendingInitData = null;
@@ -23562,7 +23606,8 @@ class CorvaUiMcpServer {
       getStats: () => this.getStats(),
       getTelemetryStatus: () => this.getTelemetryStatus(),
       getProjectIdentity: () => this.projectIdentity,
-      getTelemetry: () => this.telemetry
+      getTelemetry: () => this.telemetry,
+      getFeedbackDelivery: () => this.getFeedbackDelivery()
     });
   }
   setupPrompts() {
@@ -23580,10 +23625,12 @@ class CorvaUiMcpServer {
     const telemetryTimer = this.mcpLogger.time('telemetry-init');
     this.telemetryInitPromise = initTelemetry(this.mcpLogger).then(({
       client,
-      info
+      info,
+      disabledReason
     }) => {
       this.telemetry = client;
       this.telemetryInfo = info;
+      this.telemetryDisabledReason = disabledReason;
     }).catch(() => {
       /* telemetry is best-effort — it must never take the server down */
     });
@@ -23635,7 +23682,16 @@ class CorvaUiMcpServer {
       enabled: this.telemetry.isEnabled(),
       sessionId: this.telemetry.isEnabled() ? this.telemetry.sessionId : undefined,
       configSource: this.telemetryInfo?.configSource,
-      samplingRate: this.telemetryInfo?.samplingRate
+      samplingRate: this.telemetryInfo?.samplingRate,
+      feedbackDelivery: this.getFeedbackDelivery()
+    };
+  }
+  getFeedbackDelivery() {
+    return this.telemetry.isEnabled() ? {
+      state: 'queued'
+    } : {
+      state: 'not-sent',
+      cause: this.telemetryDisabledReason ?? 'no-config'
     };
   }
   getStats() {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@corva/ui",
-  "version": "3.78.0-16",
+  "version": "3.78.0-17",
   "license": "UNLICENSED",
   "description": "Shared components/utils for Corva ui projects",
   "repository": {