@corva/create-app 0.43.0-1 → 0.43.0-3

package/bin/create-corva-app.cjs

@@ -1,14 +1,25 @@
 #!/usr/bin/env node
 
-const { spawnSync } = require('child_process');
+const { sync: spawnSync } = require('cross-spawn');
 const { resolve } = require('path');
 
-const cmd = [
-  'node',
+const cmd = 'node';
+const args = [
   '--no-warnings',
   '--experimental-json-modules',
   resolve(__dirname, 'cca.js'),
   ...process.argv.slice(2),
 ];
 
-spawnSync(cmd.map((a) => `"${a}"`).join(' '), { stdio: 'inherit', shell: true });
+const { signal, status, error } = spawnSync(cmd, args, {
+  stdio: 'inherit',
+  shell: true,
+});
+
+if (signal) {
+  process.exit(signal);
+}
+
+if (status || error) {
+  process.exit(1);
+}

package/lib/helpers/resolve-app-runtime.js

@@ -2,7 +2,7 @@ import { APP_TYPES } from '../constants/cli.js';
 import Debug from 'debug';
 
 const debug = Debug('cca:resolve-app-runtime');
-import { spawn } from 'child_process';
+import spawn from 'cross-spawn';
 import { promises as fs } from 'fs';
 import semver from 'semver';
 import os from 'os';
@@ -11,22 +11,22 @@ const checkCliVersion = async (command, version, stdErr = false) =>
   new Promise((resolve, reject) => {
     const child = spawn(command, ['--version']);
 
-    let data;
+    let data = '';
 
-    child.stderr.once('data', (buffer) => {
-      data = buffer;
+    child.stderr.on('data', (buffer) => {
+      data += buffer;
     });
 
-    child.stdout.once('data', (buffer) => {
-      data = buffer;
+    child.stdout.on('data', (buffer) => {
+      data += buffer;
     });
 
     child.once('close', (code) => {
       if (code !== 0) {
         debug(`Command ${command} exited with code ${code}`);
-        debug(data.toString());
+        debug('Output:', data.toString());
 
-        return reject(false);
+        return resolve(false);
       }
 
       debug(`%s version output: %s`, command, data.toString());
@@ -77,8 +77,7 @@ export const resolveAppRuntime = (opts) => {
 
   return {
     language: 'python',
-    isRuntimeAvailable: async () =>
-      (await checkCliVersion('python3', version)) || (await checkCliVersion('python', version)),
+    isRuntimeAvailable: () => checkCliVersion('python3', version),
     packageManager: 'pip',
     version,
   };

package/lib/main.js

@@ -302,12 +302,38 @@ const handleCommanderError = (e) => {
   }
 };
 
+/**
+ *
+ * @param {import('./flows/lib/manifest').Manifest} manifest
+ */
+const getEnvManagementLink = (manifest) => {
+  const isWindows = process.platform === 'win32';
+
+  if (manifest.isJs()) {
+    if (isWindows) {
+      return 'https://github.com/coreybutler/nvm-windows';
+    }
+
+    return 'https://github.com/nvm-sh/nvm';
+  }
+
+  if (isWindows) {
+    return 'https://github.com/pyenv-win/pyenv-win';
+  }
+
+  return 'https://github.com/pyenv/pyenv';
+};
+
 async function initPackage(projectName, opts) {
   const manifest = new Manifest(manifestHelpers.fillManifest(opts));
   const runtime = resolveAppRuntime(opts);
 
   if (!(await runtime.isRuntimeAvailable())) {
-    throw new Error(`Runtime "${opts.runtime}" is not available locally`);
+    throw new Error(
+      `Runtime "${opts.runtime}" is not available locally. Please proceed to ${chalk.green(
+        getEnvManagementLink(manifest)
+      )} to install it locally.`
+    );
   }
 
   if (manifest.isUi()) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@corva/create-app",
-    "version": "0.43.0-1",
+    "version": "0.43.0-3",
     "private": false,
     "description": "Create an app to use it in CORVA.AI",
     "keywords": [
@@ -37,7 +37,7 @@
         "archiver": "^5.3.0",
         "chalk": "4.1.0",
         "commander": "^9.1.0",
-        "cross-spawn": "7.0.3",
+        "cross-spawn": "^7.0.3",
         "debug": "^4.3.4",
         "dotenv": "^16.0.0",
         "figlet": "^1.5.0",
@@ -55,6 +55,7 @@
     "devDependencies": {
         "@corva/eslint-config-browser": "^0.0.4",
         "@corva/eslint-config-node": "^4.2.0",
+        "@types/cross-spawn": "^6.0.2",
         "conventional-changelog-cli": "^2.1.0",
         "prettier": "^2.4.1",
         "standard-version": "^9.0.0"