@corva/create-app 0.17.0-1 → 0.18.0-1

package/CHANGELOG.md

@@ -2,6 +2,30 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [0.18.0-1](https://github.com/corva-ai/create-corva-app/compare/v0.18.0-0...v0.18.0-1) (2021-12-20)
+
+
+### Features
+
+* **CQA-445:** DC local development test to CI config ([6a63221](https://github.com/corva-ai/create-corva-app/commit/6a6322182d02dbe56f8f50d3e406e04890c4a6fd))
+
+
+### Bug Fixes
+
+* **dc-2707:** check file existence before zipping it ([064add5](https://github.com/corva-ai/create-corva-app/commit/064add5b86dfb32073eb9f7b4d16f7d4f71d32c1))
+
+## [0.17.0-2](https://github.com/corva-ai/create-corva-app/compare/v0.17.0-0...v0.17.0-2) (2021-12-07)
+
+
+### Features
+
+* add scheduler type option ([e2d3d3d](https://github.com/corva-ai/create-corva-app/commit/e2d3d3dcc7154d841b3da342a36a7edfbc8488e4))
+
+
+### Bug Fixes
+
+* diff app types, runtimes and templates ([7c52817](https://github.com/corva-ai/create-corva-app/commit/7c528173535b9a915372ec469df8043b3830e387))
+
 ## [0.17.0-1](https://github.com/corva-ai/create-corva-app/compare/v0.17.0-0...v0.17.0-1) (2021-12-03)
 
 

package/constants/manifest.js

@@ -95,6 +95,7 @@ const getManifestMandatoryKeys = (opts) => {
 
     if (appType === APP_TYPES.SCHEDULER) {
       keys.push('schedulerType');
+      keys.push('cronString');
     }
   }
 
@@ -120,7 +121,7 @@ const manifestOptions = (projectName) => [
     type: 'rawlist',
     name: 'schedulerType',
     message: 'Choose the scheduler type',
-    default: SCHEDULER_TYPE_NATURAL_TIME.name,
+    default: SCHEDULER_TYPE_NATURAL_TIME.value,
     choices: [SCHEDULER_TYPE_NATURAL_TIME, SCHEDULER_TYPE_DATA_TIME, SCHEDULER_TYPE_DEPTH],
     when: (answers) => answers.appType === APP_TYPES.SCHEDULER,
   },

package/index.js

@@ -88,15 +88,15 @@ async function initialChecks() {
       projectName = name;
     })
     .option('-z, --zip <type>', 'zip app source')
-    .option('-t, --useTypescript', 'use typescript or javascript', false)
     .addOption(
-      new commander.Option(`-p, --packageManager <value>`, 'package manager to use')
+      new commander.Option(`-p, --packageManager [string]`, 'package manager to use')
         .default(YARN_EXECUTABLE)
         .choices(['npm', YARN_EXECUTABLE])
     );
 
   manifestConstants.manifestOptions(projectName).forEach((value) => {
-    const option = new commander.Option(`--${value.name} [value]`, value.message);
+    const type = typeof value.default;
+    const option = new commander.Option(`--${value.name} [${type !== 'undefined' && type || 'string'}]`, value.message);
 
     if (value.choices) {
       if (typeof value.choices === 'function') {
@@ -108,6 +108,10 @@ async function initialChecks() {
       }
     }
 
+    if (type === 'number') {
+      option.argParser(Number)
+    }
+
     program.addOption(option);
   });
 
@@ -117,10 +121,6 @@ async function initialChecks() {
 
   const opts = program.opts();
 
-  if (opts.schedulerType) {
-    opts.schedulerType = Number(opts.schedulerType);
-  }
-
   packageManager = opts.packageManager || packageManager;
   useTypescript = opts.useTypescript || useTypescript;
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@corva/create-app",
-    "version": "0.17.0-1",
+    "version": "0.18.0-1",
     "private": false,
     "description": "Create app to use it in CORVA.AI",
     "keywords": [

package/scripts/ui/zipAppSource.js

@@ -36,9 +36,7 @@ async function compressAppToZip(useYarn) {
   archive.pipe(output);
 
   output.on('close', function () {
-    console.log(archive.pointer() + ' total bytes');
-
-    console.log('archiver has been finalized and the output file descriptor has closed.');
+    console.log(`Created ${zipPath.replace(dirname + '/', '')}, ${archive.pointer()} bytes written\n`);
 
     // clean up temp package.json file
     try {
@@ -90,7 +88,16 @@ async function compressAppToZip(useYarn) {
     'config-overrides.js',
     'tsconfig.json',
     useYarn ? 'yarn.lock' : 'package-lock.json',
-  ].forEach((name) => archive.file(path.resolve(dirname, name), { name }));
+  ].forEach((name) => {
+    const file = path.resolve(dirname, name);
+
+    // not all app templates have the tsconfig, archive will raise an error with missing files, have to filter-out that
+    if (!fs.existsSync(file)) {
+      return;
+    }
+
+    archive.file(file, { name })
+  });
 
   archive.directory(path.resolve(dirname, 'src'), 'src');