@corva/create-app 0.126.1 → 0.127.0

package/lib/commands/create.js

@@ -358,7 +358,12 @@ function addPackageJSON(root, manifest, runtime, opts) {
     },
     scripts,
     dependencies,
-    devDependencies,
+    // the app's scripts run the CLI that generated it, from its own node_modules, so a global
+    // install of another version cannot change what `yarn zip` or `yarn release` do
+    devDependencies: {
+      '@corva/create-app': fs.readJSONSync(join(__dirname, '../../package.json')).version,
+      ...devDependencies,
+    },
     ...rest,
   };
 

package/lib/flows/steps/zip-file-list-resolve.js

@@ -1,17 +1,14 @@
 import chalk from 'chalk';
-import Glob from 'glob';
+import { glob } from 'glob';
 import isGlob from 'is-glob';
 import _ from 'lodash/fp.js';
 import { promises as fs } from 'node:fs';
 import { resolve } from 'node:path';
-import { promisify } from 'node:util';
 import { getIncreasedVersion } from '../../helpers/cli-version.js';
 import { generateRandomString } from '../../helpers/utils.js';
 import { loadJson } from '../lib/json.js';
 import { StepError } from '../lib/step-error.js';
 
-const glob = promisify(Glob);
-
 import debugFn from 'debug';
 
 const debug = debugFn('cca:flow:zip:resolve');

package/lib/helpers/cli-version.js

@@ -1,4 +1,3 @@
-import NpmApi from 'npm-api';
 import chalk from 'chalk';
 import semver from 'semver';
 import inquirer from 'inquirer';
@@ -9,8 +8,6 @@ import fs from 'fs-extra';
 import { logger } from './logger.js';
 import { StepError } from '../flows/lib/step-error.js';
 
-const npm = new NpmApi();
-
 const error = chalk.bold.red;
 const warning = chalk.hex('#FFA500'); // Orange
 const code = chalk.cyan;
@@ -19,20 +16,32 @@ const asterisks = '*************************************************************
 const getCurrentVersion = async () =>
   (await fs.readJSON(join(url.fileURLToPath(new URL('.', import.meta.url)), '../../package.json'))).version;
 
+// An app that lists @corva/create-app owns the version its scripts run, so there is nothing for the
+// user to update globally; the nag belongs to a global install only.
+const isCliPinnedByApp = async (appDirectory) => {
+  const packageJsonPath = join(appDirectory, 'package.json');
+
+  if (!(await fs.pathExists(packageJsonPath))) {
+    return false;
+  }
+
+  const { dependencies = {}, devDependencies = {} } = await fs.readJSON(packageJsonPath);
+
+  return Boolean(dependencies['@corva/create-app'] || devDependencies['@corva/create-app']);
+};
+
 const getLatestVersion = async () => {
   try {
-    return await npm.repo('@corva/create-app').prop('version');
+    const response = await fetch('https://registry.npmjs.org/@corva/create-app/latest');
+
+    return (await response.json()).version;
   } catch (caughtError) {
-    if (caughtError.name === 'FetchError') {
-      throw new StepError(`The request to check the latest available version has failed due to the network error. Details:
+    throw new StepError(`The request to check the latest available version has failed due to the network error. Details:
 
 ${caughtError}
 
 Please check your internet connection and that the above request is not blocked in your network 
   `);
-    }
-
-    throw caughtError;
   }
 };
 
@@ -71,7 +80,11 @@ export async function ensureLatestVersion() {
 }
 
 // NOTE: Show user-friendly warning if version is outdated
-export async function warnIfOutdated() {
+export async function warnIfOutdated(appDirectory = process.cwd()) {
+  if (await isCliPinnedByApp(appDirectory)) {
+    return;
+  }
+
   logger.write('Checking for updates...\n');
 
   const currentVersion = await getCurrentVersion();

package/lib/main.js

@@ -1,3 +1,5 @@
+import { resolve } from 'node:path';
+
 import chalk from 'chalk';
 import { Command } from 'commander';
 import semver from 'semver';
@@ -35,10 +37,13 @@ function checkNodeVersion() {
 
 export async function run() {
   const program = new Command('create-corva-app')
-    .hook('preAction', async () => {
+    .hook('preAction', async (_, actionCommand) => {
       checkNodeVersion();
 
-      await warnIfOutdated();
+      const [projectDirectory = '.'] = actionCommand.args;
+      const { originalCwd = process.cwd() } = actionCommand.opts();
+
+      await warnIfOutdated(resolve(originalCwd, projectDirectory));
     })
     .addCommand(createCommand, { isDefault: true })
     .addCommand(zipCommand)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@corva/create-app",
-  "version": "0.126.1",
+  "version": "0.127.0",
   "private": false,
   "description": "Create an app to use it in CORVA.AI",
   "keywords": [
@@ -45,7 +45,7 @@
     "lodash": "4.18.1"
   },
   "dependencies": {
-    "archiver": "^5.3.0",
+    "archiver": "^7.0.1",
     "chalk": "^4.1.0",
     "commander": "^9.1.0",
     "cross-spawn": "^7.0.3",
@@ -54,12 +54,11 @@
     "figlet": "^1.5.0",
     "form-data": "^4.0.4",
     "fs-extra": "^9.0.1",
-    "glob": "^8.0.1",
+    "glob": "^13.0.6",
     "got": "^12.5.1",
     "inquirer": "^8.2.3",
     "is-glob": "^4.0.3",
     "lodash": "^4.18.1",
-    "npm-api": "^1.0.0",
     "semver": "^7.3.2",
     "terminal-link": "^3.0.0"
   },