@cortexkit/opencode-magic-context 0.44.1 → 0.44.3

package/src/shared/sqlite-acquisition-fence.test.ts

@@ -0,0 +1,132 @@
+import { expect, test } from "bun:test";
+import { readdirSync, readFileSync } from "node:fs";
+import { join, relative, resolve } from "node:path";
+import ts from "typescript";
+
+const root = resolve(import.meta.dir, "../../../..");
+const shared = "packages/plugin/src/shared/sqlite.ts";
+function files(dir: string): string[] {
+    return readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
+        const path = join(dir, entry.name);
+        if (entry.isDirectory()) return files(path);
+        return /\.tsx?$/.test(path) && !/\.test\.|test-support|\.d\.ts$/.test(path) ? [path] : [];
+    });
+}
+
+function scan(
+    path: string,
+    text: string,
+): { violations: string[]; transactions: number; literals: number } {
+    const violations: string[] = [];
+    let transactions = 0;
+    let literals = 0;
+    const source = ts.createSourceFile(path, text, ts.ScriptTarget.Latest, true);
+    const visit = (node: ts.Node) => {
+        if (
+            ts.isCallExpression(node) &&
+            ts.isPropertyAccessExpression(node.expression) &&
+            node.expression.name.text === "transaction"
+        )
+            transactions++;
+        if (
+            path !== shared &&
+            ts.isImportDeclaration(node) &&
+            ts.isStringLiteral(node.moduleSpecifier) &&
+            !node.importClause?.isTypeOnly &&
+            /^(bun:sqlite|node:sqlite|better-sqlite3)$/.test(node.moduleSpecifier.text)
+        ) {
+            violations.push(`${path}: native SQLite import bypasses shared acquisition`);
+        }
+        if (
+            path !== shared &&
+            ts.isExportDeclaration(node) &&
+            !node.isTypeOnly &&
+            node.moduleSpecifier &&
+            ts.isStringLiteral(node.moduleSpecifier) &&
+            /^(bun:sqlite|node:sqlite|better-sqlite3)$/.test(node.moduleSpecifier.text)
+        ) {
+            violations.push(`${path}: native SQLite re-export bypasses shared acquisition`);
+        }
+        if (
+            path !== shared &&
+            ts.isCallExpression(node) &&
+            (node.expression.kind === ts.SyntaxKind.ImportKeyword ||
+                (ts.isIdentifier(node.expression) && node.expression.text === "require")) &&
+            /(?:bun:sqlite|node:sqlite|better-sqlite3)/.test(
+                node.arguments.map((arg) => arg.getText(source)).join(""),
+            )
+        ) {
+            violations.push(`${path}: dynamic native SQLite import bypasses shared acquisition`);
+        }
+        const sqlText = ts.isStringLiteralLike(node)
+            ? node.text
+            : ts.isTemplateExpression(node)
+              ? node.head.text + node.templateSpans.map((span) => span.literal.text).join("")
+              : undefined;
+        if (
+            sqlText !== undefined &&
+            /\bBEGIN\s+(?:IMMEDIATE|EXCLUSIVE)(?:\s+TRANSACTION)?\s*(?:;|$)/i.test(sqlText)
+        ) {
+            literals++;
+            if (path !== shared) {
+                const call = node.parent;
+                const routed =
+                    !ts.isTemplateExpression(node) &&
+                    ts.isCallExpression(call) &&
+                    ts.isPropertyAccessExpression(call.expression) &&
+                    call.expression.name.text === "exec" &&
+                    /^\s*BEGIN\s+(IMMEDIATE|EXCLUSIVE)(?:\s+TRANSACTION)?\s*;?\s*$/i.test(sqlText);
+                if (!routed)
+                    violations.push(
+                        `${path}:${source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1}: BEGIN acquisition must be a standalone shared Database.exec call`,
+                    );
+            }
+        }
+        ts.forEachChild(node, visit);
+    };
+    visit(source);
+    return { violations, transactions, literals };
+}
+
+test("all production transaction acquisition routes through the shared SQLite runtime", () => {
+    const scans = ["packages/plugin/src", "packages/pi-plugin/src", "packages/cli/src"]
+        .flatMap((directory) => files(join(root, directory)))
+        .map((path) => scan(relative(root, path), readFileSync(path, "utf8")));
+    expect(scans.reduce((sum, scan) => sum + scan.transactions, 0)).toBeGreaterThan(50);
+    expect(scans.reduce((sum, scan) => sum + scan.literals, 0)).toBeGreaterThan(20);
+    expect(scans.flatMap((scan) => scan.violations)).toEqual([]);
+});
+
+test("acquisition fence rejects raw native transactions and unrouted BEGIN shapes", () => {
+    expect(
+        scan(
+            "new-writer.ts",
+            'import { Database } from "bun:sqlite"; new Database(":memory:").transaction(() => write())();',
+        ).violations,
+    ).toHaveLength(1);
+    expect(
+        scan(
+            "new-writer.ts",
+            'const { DatabaseSync } = require("node:sqlite"); new DatabaseSync(":memory:").transaction(() => write())();',
+        ).violations,
+    ).toHaveLength(1);
+    expect(scan("new-writer.ts", 'export { Database } from "bun:sqlite";').violations).toHaveLength(
+        1,
+    );
+    expect(scan("new-writer.ts", 'db.prepare("BEGIN IMMEDIATE").run();').violations).toHaveLength(
+        1,
+    );
+    expect(
+        scan("new-writer.ts", 'db.exec("BEGIN IMMEDIATE; INSERT INTO result VALUES (1)");')
+            .violations,
+    ).toHaveLength(1);
+    expect(scan("new-writer.ts", "db.exec(`BEGIN IMMEDIATE; ${extra}`);").violations).toHaveLength(
+        1,
+    );
+    expect(
+        scan(
+            "new-writer.ts",
+            'import { Database } from "./shared/sqlite"; db.exec("BEGIN IMMEDIATE"); db.transaction(() => write()).immediate();',
+        ).violations,
+    ).toEqual([]);
+});

package/src/shared/sqlite-acquisition-routing.test.ts

@@ -0,0 +1,102 @@
+import { expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import {
+    Database,
+    withAsyncPrivilegedWriter,
+    withPrivilegedWriter,
+    withSqliteTransformPass,
+} from "./sqlite";
+import { startSqliteWriteLocker } from "./sqlite-write-locker-test-support";
+
+for (const mode of ["default", "immediate", "exclusive", "literal"] as const) {
+    test(`shared SQLite retries ${mode} acquisition before running any writes`, async () => {
+        const dir = mkdtempSync(join(tmpdir(), "mc-routed-acquisition-"));
+        const path = join(dir, "context.db");
+        const db = new Database(path);
+        db.exec(
+            "PRAGMA journal_mode=WAL; PRAGMA busy_timeout=50; CREATE TABLE result(value TEXT); CREATE TABLE context_privilege_state(id INTEGER PRIMARY KEY, enabled INTEGER)",
+        );
+        const locker = await startSqliteWriteLocker(path, 650);
+        let calls = 0;
+        const write = () => {
+            calls++;
+            db.prepare("INSERT INTO result VALUES (?)").run("once");
+            return "managed";
+        };
+        try {
+            await withSqliteTransformPass(async () => {
+                await withAsyncPrivilegedWriter(db, () => undefined);
+                if (mode === "literal") {
+                    db.exec("BEGIN IMMEDIATE");
+                    write();
+                    db.exec("COMMIT");
+                } else {
+                    const transaction = db.transaction(write);
+                    expect(mode === "default" ? transaction() : transaction[mode]()).toBe(
+                        "managed",
+                    );
+                }
+            });
+            expect(calls).toBe(1);
+            expect(db.prepare("SELECT * FROM result").all()).toEqual([{ value: "once" }]);
+        } finally {
+            await locker.exited;
+            db.close();
+            rmSync(dir, { recursive: true, force: true });
+        }
+    }, 30000);
+}
+
+test("routed transactions preserve nesting, receiver, arguments and rollback without callback retries", () => {
+    const db = new Database(":memory:");
+    db.exec(
+        "CREATE TABLE result(value TEXT); CREATE TABLE context_privilege_state(id INTEGER PRIMARY KEY, enabled INTEGER)",
+    );
+    let calls = 0;
+    const transaction = db.transaction(function (this: { prefix: string }, value: string) {
+        calls++;
+        db.prepare("INSERT INTO result VALUES (?)").run(this.prefix + value);
+        db.transaction(() => {
+            db.exec("INSERT INTO result VALUES ('inner')");
+        }).immediate();
+        throw Object.assign(new Error("busy after writes"), { code: "SQLITE_BUSY" });
+    });
+    try {
+        expect(() =>
+            withSqliteTransformPass(() => transaction.call({ prefix: "outer-" }, "value")),
+        ).toThrow("busy after writes");
+        expect(calls).toBe(1);
+        expect(db.prepare("SELECT * FROM result").all()).toEqual([]);
+    } finally {
+        db.close();
+    }
+});
+
+test("exhausted routed acquisition never enters the callback or multiplies privileged retries", () => {
+    const dir = mkdtempSync(join(tmpdir(), "mc-routed-exhaustion-"));
+    const path = join(dir, "context.db");
+    const blocker = new Database(path);
+    const db = new Database(path);
+    blocker.exec(
+        "PRAGMA journal_mode=WAL; CREATE TABLE result(value TEXT); CREATE TABLE context_privilege_state(id INTEGER PRIMARY KEY, enabled INTEGER)",
+    );
+    db.exec("PRAGMA busy_timeout=0");
+    blocker.exec("BEGIN IMMEDIATE");
+    let callbacks = 0;
+    try {
+        for (const run of [
+            () => db.transaction(() => callbacks++)(),
+            () => withPrivilegedWriter(db, () => callbacks++),
+        ]) {
+            expect(() => withSqliteTransformPass(run)).toThrow("acquisition remained busy");
+            expect(callbacks).toBe(0);
+        }
+    } finally {
+        blocker.exec("ROLLBACK");
+        blocker.close();
+        db.close();
+        rmSync(dir, { recursive: true, force: true });
+    }
+});

package/src/shared/sqlite-pass-scope.test.ts

@@ -0,0 +1,153 @@
+import { expect, test } from "bun:test";
+import { mkdtempSync, rmSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import {
+    beginSqliteWriterAsync,
+    Database,
+    isTransientSqliteError,
+    SqliteAcquisitionBusyError,
+    withAsyncPrivilegedWriter,
+    withPrivilegedWriter,
+    withSqliteBackgroundWriter,
+    withSqliteTransformPass,
+} from "./sqlite";
+import { startSqliteWriteLocker } from "./sqlite-write-locker-test-support";
+
+function fixture() {
+    const dir = mkdtempSync(join(tmpdir(), "mc-busy-yield-"));
+    const path = join(dir, "context.db");
+    const db = new Database(path);
+    db.exec(
+        "PRAGMA journal_mode=WAL; CREATE TABLE context_privilege_state(id INTEGER PRIMARY KEY, enabled INTEGER)",
+    );
+    db.exec("PRAGMA busy_timeout=5000");
+    return {
+        db,
+        path,
+        close: () => {
+            db.close();
+            rmSync(dir, { recursive: true, force: true });
+        },
+    };
+}
+
+test("tool-style transaction outside a pass waits for a brief lock", async () => {
+    const { db, path, close } = fixture();
+    const locker = await startSqliteWriteLocker(path, 300);
+    try {
+        const start = performance.now();
+        db.transaction(() =>
+            db.prepare("INSERT INTO context_privilege_state(id, enabled) VALUES (1, 0)").run(),
+        ).immediate();
+        expect(performance.now() - start).toBeGreaterThanOrEqual(250);
+        expect(db.prepare("SELECT COUNT(*) AS count FROM context_privilege_state").get()).toEqual({
+            count: 1,
+        });
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        await locker.exited;
+        close();
+    }
+}, 30000);
+
+test("named background acquisition gives up quickly and leaves work for retry", () => {
+    const { db, path, close } = fixture();
+    const blocker = new Database(path);
+    blocker.exec("BEGIN IMMEDIATE");
+    let calls = 0;
+    let retryQueued = false;
+    try {
+        const start = performance.now();
+        try {
+            withSqliteBackgroundWriter(() => db.transaction(() => calls++)());
+        } catch (error) {
+            if (!isTransientSqliteError(error)) throw error;
+            retryQueued = true;
+        }
+        expect(performance.now() - start).toBeLessThan(250);
+        expect(retryQueued).toBe(true);
+        expect(calls).toBe(0);
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        blocker.exec("ROLLBACK");
+        blocker.close();
+        close();
+    }
+});
+
+test("foreground admission keeps the loop ticking while a separate writer holds the lock", async () => {
+    const { db, path, close } = fixture();
+    const locker = await startSqliteWriteLocker(path, 650);
+    let timerFired = false;
+    let calls = 0;
+    try {
+        setTimeout(() => {
+            timerFired = true;
+        }, 100);
+        await withSqliteTransformPass(() =>
+            withAsyncPrivilegedWriter(db, () => {
+                calls++;
+            }),
+        );
+        expect(timerFired).toBe(true);
+        expect(calls).toBe(1);
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        await locker.exited;
+        close();
+    }
+}, 30000);
+
+test("a foreground in-pass writer has bounded 250ms tolerance and restores its timeout", () => {
+    const { db, path, close } = fixture();
+    const blocker = new Database(path);
+    blocker.exec("BEGIN IMMEDIATE");
+    try {
+        const start = performance.now();
+        expect(() =>
+            withSqliteTransformPass(() => withPrivilegedWriter(db, () => undefined)),
+        ).toThrow(SqliteAcquisitionBusyError);
+        expect(performance.now() - start).toBeGreaterThanOrEqual(200);
+        expect(performance.now() - start).toBeLessThan(400);
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        blocker.exec("ROLLBACK");
+        blocker.close();
+        close();
+    }
+});
+
+test("ready background publication retries on a timer and retains its write", async () => {
+    const { db, path, close } = fixture();
+    const locker = await startSqliteWriteLocker(path, 650);
+    let ticked = false;
+    try {
+        setTimeout(() => {
+            ticked = true;
+        }, 100);
+        await beginSqliteWriterAsync(db, "historian-publish");
+        db.prepare("INSERT INTO context_privilege_state(id, enabled) VALUES (1, 0)").run();
+        db.exec("COMMIT");
+        expect(ticked).toBe(true);
+        expect(db.prepare("SELECT COUNT(*) AS count FROM context_privilege_state").get()).toEqual({
+            count: 1,
+        });
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        await locker.exited;
+        close();
+    }
+}, 30000);
+
+test("an in-pass BEGIN tolerates a sibling writer that releases within 250ms", async () => {
+    const { db, path, close } = fixture();
+    const locker = await startSqliteWriteLocker(path, 150);
+    try {
+        withSqliteTransformPass(() => withPrivilegedWriter(db, () => undefined));
+        expect(db.prepare("PRAGMA busy_timeout").get()).toEqual({ timeout: 5000 });
+    } finally {
+        await locker.exited;
+        close();
+    }
+}, 30000);

package/src/shared/sqlite-transaction-mode-guard.test.ts

@@ -4,14 +4,14 @@ import { join, relative, resolve } from "node:path";
 import ts from "typescript";
 
 /**
- * A deferred transaction (`db.transaction(fn)()`, `.deferred()`, `.default()`)
- * starts with no lock. If it reads before it writes, the write must upgrade a read
+ * An explicitly deferred transaction starts with no writer lock. If it reads before it writes, the write must upgrade a read
  * snapshot to a write lock, and SQLite never runs the busy handler for that
  * upgrade: under another process's write it fails at once with SQLITE_BUSY, or
  * with SQLITE_BUSY_SNAPSHOT when another commit landed after the read, and
  * busy_timeout never applies. Many OpenCode and Pi processes share one context.db,
- * so every transaction that writes must start with `.immediate()` (or
- * `.exclusive()`), which takes the write lock at BEGIN where busy_timeout covers it.
+ * so writing transactions must acquire at BEGIN. The shared runtime defaults
+ * writable handles to IMMEDIATE; plugin/Pi call sites keep their explicit
+ * `.immediate()` / `.exclusive()` declarations as an additional intent fence.
  *
  * Only read-only transactions may stay deferred. Each one is listed here, keyed
  * by file and the nearest named enclosing function, with the reason it never
@@ -26,7 +26,7 @@ const READ_ONLY_DEFERRED_TRANSACTIONS: Record<string, string> = {
 };
 
 const REPOSITORY_ROOT = resolve(import.meta.dir, "../../../..");
-const SOURCE_ROOTS = ["packages/plugin/src", "packages/pi-plugin/src"];
+const SOURCE_ROOTS = ["packages/plugin/src", "packages/pi-plugin/src", "packages/cli/src"];
 const LOCKING_MODES = new Set(["immediate", "exclusive"]);
 
 function sourceFiles(directory: string): string[] {
@@ -56,13 +56,16 @@ function isTransactionCall(node: ts.Node): node is ts.CallExpression {
 }
 
 /** True when `node` is the receiver of a called `.immediate()` / `.exclusive()`. */
-function isCalledWithLockingMode(node: ts.Node): boolean {
+function isCalledWithLockingMode(
+    node: ts.Node,
+    modes: ReadonlySet<string> = LOCKING_MODES,
+): boolean {
     const access = node.parent;
     return (
         access !== undefined &&
         ts.isPropertyAccessExpression(access) &&
         access.expression === node &&
-        LOCKING_MODES.has(access.name.text) &&
+        modes.has(access.name.text) &&
         access.parent !== undefined &&
         ts.isCallExpression(access.parent) &&
         access.parent.expression === access
@@ -92,7 +95,11 @@ function enclosingFunctionName(node: ts.Node): string {
  * A transaction stored in a variable is locking only when every use of that
  * variable calls `.immediate()` or `.exclusive()` on it.
  */
-function storedTransactionLocks(call: ts.CallExpression, source: ts.SourceFile): boolean {
+function storedTransactionLocks(
+    call: ts.CallExpression,
+    source: ts.SourceFile,
+    modes: ReadonlySet<string> = LOCKING_MODES,
+): boolean {
     const declaration = call.parent;
     if (!ts.isVariableDeclaration(declaration) || !ts.isIdentifier(declaration.name)) return false;
     const name = declaration.name.text;
@@ -111,7 +118,7 @@ function storedTransactionLocks(call: ts.CallExpression, source: ts.SourceFile):
         ts.forEachChild(node, visit);
     };
     visit(scope);
-    return uses.length > 0 && uses.every(isCalledWithLockingMode);
+    return uses.length > 0 && uses.every((use) => isCalledWithLockingMode(use, modes));
 }
 
 interface TransactionScan {
@@ -154,8 +161,33 @@ function repositorySources(): Array<{ path: string; text: string }> {
 }
 
 describe("SQLite transaction lock mode", () => {
+    it("declares every audited read-only transaction explicitly deferred", () => {
+        const candidates: string[] = [];
+        for (const file of repositorySources()) {
+            const source = ts.createSourceFile(file.path, file.text, ts.ScriptTarget.Latest, true);
+            const visit = (node: ts.Node): void => {
+                if (isTransactionCall(node)) {
+                    const key = `${file.path}#${enclosingFunctionName(node)}`;
+                    if (key in READ_ONLY_DEFERRED_TRANSACTIONS) {
+                        const deferred = new Set(["deferred"]);
+                        if (
+                            !isCalledWithLockingMode(node, deferred) &&
+                            !storedTransactionLocks(node, source, deferred)
+                        )
+                            candidates.push(key);
+                    }
+                }
+                ts.forEachChild(node, visit);
+            };
+            visit(source);
+        }
+        expect(candidates.sort()).toEqual([]);
+    });
+
     it("starts every writing transaction with .immediate() or .exclusive()", () => {
-        const { deferredSites, lockingSites } = scanTransactionModes(repositorySources());
+        const { deferredSites, lockingSites } = scanTransactionModes(
+            repositorySources().filter((file) => !file.path.startsWith("packages/cli/")),
+        );
         // The scan must actually see the codebase's transactions.
         expect(lockingSites).toBeGreaterThan(50);
 

package/src/shared/sqlite-write-locker-test-support.ts

@@ -26,6 +26,7 @@ export async function startSqliteWriteLocker(
     const child = Bun.spawn(["bun", import.meta.path, dbPath, String(holdMs)], {
         stdout: "pipe",
         stderr: "pipe",
+        windowsHide: true,
     });
     const reader = child.stdout.getReader();
     const decoder = new TextDecoder();