@cortexkit/aft-opencode 0.50.3 → 0.51.0

package/src/tui/sidebar.tsx

@@ -17,6 +17,7 @@ import {
   formatSemanticRefreshing,
   type StatusBar,
   type StatusCompression,
+  worktreeCacheRoleNote,
 } from "../shared/status";
 import { resolveCortexKitStorageRoot } from "../shared/storage-paths";
 import { badgeTextColor } from "./badge-contrast";
@@ -193,7 +194,7 @@ export function collapsedCompressionValue(
   return `${formatCount(savings_tokens)} / ${pct}%`;
 }
 
-export type HealthLightTone = "ok" | "warn" | "err";
+export type HealthLightTone = "ok" | "warn" | "err" | "muted";
 
 // Degraded-mode reason → human-readable hint. Distinct strings per reason
 // because the UX direction is different: "home_root" tells the user to open a
@@ -215,26 +216,31 @@ export function degradedReasonLabel(reason: string): string {
 }
 
 export interface HealthLights {
-  // Diagnostics: red if any errors, yellow if any warnings, else green.
   diagnostics: HealthLightTone;
-  // Code cruft: yellow if there is any dead code, unused export, or duplicate,
-  // green when zero. Never red — cruft is not a build failure.
   code: HealthLightTone;
-  // TODOs: yellow if any, else green.
   todos: HealthLightTone;
 }
 
-// Three traffic lights for the collapsed view, replacing the cramped
-// `E· W· | D· U· C· | T·` string. Returns null until populated.
+// Missing categories are intentionally muted: a green light requires an
+// explicit zero for every category that feeds that light.
 export function collapsedHealthLights(statusBar: StatusBar | undefined): HealthLights | null {
   if (!statusBar) return null;
   const diagnostics: HealthLightTone =
-    statusBar.errors > 0 ? "err" : statusBar.warnings > 0 ? "warn" : "ok";
-  const code: HealthLightTone =
-    statusBar.dead_code > 0 || statusBar.unused_exports > 0 || statusBar.duplicates > 0
-      ? "warn"
-      : "ok";
-  const todos: HealthLightTone = statusBar.todos > 0 ? "warn" : "ok";
+    statusBar.errors !== undefined && statusBar.errors > 0
+      ? "err"
+      : statusBar.warnings !== undefined && statusBar.warnings > 0
+        ? "warn"
+        : statusBar.errors === 0 && statusBar.warnings === 0
+          ? "ok"
+          : "muted";
+  const codeValues = [statusBar.dead_code, statusBar.unused_exports, statusBar.duplicates];
+  const code: HealthLightTone = codeValues.some((value) => value !== undefined && value > 0)
+    ? "warn"
+    : codeValues.every((value) => value === 0)
+      ? "ok"
+      : "muted";
+  const todos: HealthLightTone =
+    statusBar.todos === undefined ? "muted" : statusBar.todos > 0 ? "warn" : "ok";
   return { diagnostics, code, todos };
 }
 
@@ -561,6 +567,10 @@ const SidebarContent = (props: {
     return reasons.map(degradedReasonLabel).join("; ");
   };
 
+  // Worktree borrow is a shared-index arrangement, not a degraded_reasons
+  // entry. Keep this muted and separate from the DEGRADED badge above.
+  const worktreeNote = () => worktreeCacheRoleNote(s()?.cache_role);
+
   return (
     <box
       width="100%"
@@ -627,6 +637,12 @@ const SidebarContent = (props: {
         </box>
       )}
 
+      {!notInitialized() && worktreeNote() && (
+        <box marginTop={1} width="100%">
+          <text fg={props.theme.textMuted}>{worktreeNote()}</text>
+        </box>
+      )}
+
       {/* Lazy-bridge placeholder. AFT skips spawning the `aft` binary at
           plugin init to keep memory/CPU low on OpenCode Desktop sessions
           that have many projects pinned in the sidebar. The RPC server
@@ -755,54 +771,62 @@ const SidebarContent = (props: {
             </>
           )}
 
-          {/* Code Health — the agent status-bar glance, surfaced for users.
-          Hidden until the Tier-2 cache is populated (status_bar undefined),
-          so it never shows fabricated zeros. Errors/warnings are live LSP
-          diagnostics; D/U/C/T come from the last background scan. A `~` on
-          the section header flags the Tier-2 counts as predating the latest
-          edit. */}
+          {/* Human health values are optional. A category stays absent until the
+          server proves it, rather than appearing as a clean zero. */}
           {prefs().sections.codeHealth && statusBar() && (
             <>
               <SectionHeader
                 theme={props.theme}
                 title={statusBar()!.tier2_stale ? "Code Health ~" : "Code Health"}
               />
-              <StatRow
-                theme={props.theme}
-                label="Errors"
-                value={formatCount(statusBar()!.errors)}
-                tone={statusBar()!.errors > 0 ? "err" : "muted"}
-              />
-              <StatRow
-                theme={props.theme}
-                label="Warnings"
-                value={formatCount(statusBar()!.warnings)}
-                tone={statusBar()!.warnings > 0 ? "warn" : "muted"}
-              />
-              <StatRow
-                theme={props.theme}
-                label="Dead Code"
-                value={formatCount(statusBar()!.dead_code)}
-                tone="muted"
-              />
-              <StatRow
-                theme={props.theme}
-                label="Unused Exports"
-                value={formatCount(statusBar()!.unused_exports)}
-                tone="muted"
-              />
-              <StatRow
-                theme={props.theme}
-                label="Duplicates"
-                value={formatCount(statusBar()!.duplicates)}
-                tone="muted"
-              />
-              <StatRow
-                theme={props.theme}
-                label="TODOs"
-                value={formatCount(statusBar()!.todos)}
-                tone="muted"
-              />
+              {statusBar()!.errors !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="Errors"
+                  value={formatCount(statusBar()!.errors)}
+                  tone={statusBar()!.errors! > 0 ? "err" : "muted"}
+                />
+              )}
+              {statusBar()!.warnings !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="Warnings"
+                  value={formatCount(statusBar()!.warnings)}
+                  tone={statusBar()!.warnings! > 0 ? "warn" : "muted"}
+                />
+              )}
+              {statusBar()!.dead_code !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="Dead Code"
+                  value={formatCount(statusBar()!.dead_code)}
+                  tone="muted"
+                />
+              )}
+              {statusBar()!.unused_exports !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="Unused Exports"
+                  value={formatCount(statusBar()!.unused_exports)}
+                  tone="muted"
+                />
+              )}
+              {statusBar()!.duplicates !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="Duplicates"
+                  value={formatCount(statusBar()!.duplicates)}
+                  tone="muted"
+                />
+              )}
+              {statusBar()!.todos !== undefined && (
+                <StatRow
+                  theme={props.theme}
+                  label="TODOs"
+                  value={formatCount(statusBar()!.todos)}
+                  tone="muted"
+                />
+              )}
             </>
           )}
 

package/src/tui-compiled/index.tsx

@@ -12,7 +12,7 @@ import { createElement as _$createElement } from "opentui:runtime-module:%40open
 import { createMemo, createSignal, onCleanup } from "opentui:runtime-module:solid-js";
 import { version as packageVersion } from "../../package.json";
 import { AftRpcClient } from "../shared/rpc-client";
-import { coerceAftStatus, formatBytes, formatSemanticIndexStatus, formatSemanticRefreshing } from "../shared/status";
+import { coerceAftStatus, formatBytes, formatCacheRoleLabel, formatSemanticIndexStatus, formatSemanticRefreshing } from "../shared/status";
 import { createDebouncedStatusRefresh, refreshAftTuiSocketScope, startAftTuiSocket, stopAftTuiSocket, subscribeStatusInvalidations } from "./notification-socket";
 import { createAftSidebarSlot, formatCompressionSidebarRows, isSnapshotForContext, resolveTuiStorageDir, shouldSuppressUninitializedDowngrade } from "./sidebar";
 
@@ -188,9 +188,9 @@ const StatusDialog = props => {
     }
   });
 
-  // Visual cache-role badge: main is accent, worktree is warning,
-  // not_initialized is muted. Matches the sidebar convention.
-  const cacheRoleTone = role => role === "main" ? "accent" : role === "worktree" ? "warn" : "muted";
+  // Visual cache-role badge: main is accent. Worktree/read_only borrow the
+  // shared repo index — muted, not warning, so it is not read as a failure.
+  const cacheRoleTone = role => role === "main" ? "accent" : "muted";
   // Reuse the sidebar's label/value formatter so the dialog and sidebar
   // render identical text (e.g. "Session" / "-174,489 tokens, 59% reduction").
   // The earlier `formatCompressionDialogRows` returned padded strings that
@@ -288,7 +288,7 @@ const StatusDialog = props => {
           },
           label: "Cache role",
           get value() {
-            return status().cache_role;
+            return formatCacheRoleLabel(status().cache_role);
           },
           get tone() {
             return cacheRoleTone(status().cache_role);
@@ -696,70 +696,88 @@ const StatusDialog = props => {
         _$setProp(_el$53, "marginTop", 1);
         _$insertNode(_el$54, _el$55);
         _$insert(_el$55, () => status().status_bar.tier2_stale ? "Code Health ~" : "Code Health");
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "Errors",
-          get value() {
-            return formatCountShort(status().status_bar.errors);
-          },
-          get tone() {
-            return status().status_bar.errors > 0 ? "err" : "muted";
-          }
-        }), null);
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "Warnings",
-          get value() {
-            return formatCountShort(status().status_bar.warnings);
-          },
-          get tone() {
-            return status().status_bar.warnings > 0 ? "warn" : "muted";
-          }
-        }), null);
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "Dead Code",
-          get value() {
-            return formatCountShort(status().status_bar.dead_code);
-          },
-          tone: "muted"
-        }), null);
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "Unused Exports",
-          get value() {
-            return formatCountShort(status().status_bar.unused_exports);
-          },
-          tone: "muted"
-        }), null);
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "Duplicates",
-          get value() {
-            return formatCountShort(status().status_bar.duplicates);
-          },
-          tone: "muted"
-        }), null);
-        _$insert(_el$53, _$createComponent(R, {
-          get theme() {
-            return t();
-          },
-          label: "TODOs",
-          get value() {
-            return formatCountShort(status().status_bar.todos);
-          },
-          tone: "muted"
-        }), null);
+        _$insert(_el$53, (() => {
+          var _c$14 = _$memo(() => status().status_bar.errors !== undefined);
+          return () => _c$14() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "Errors",
+            get value() {
+              return formatCountShort(status().status_bar.errors);
+            },
+            get tone() {
+              return status().status_bar.errors > 0 ? "err" : "muted";
+            }
+          }) : null;
+        })(), null);
+        _$insert(_el$53, (() => {
+          var _c$15 = _$memo(() => status().status_bar.warnings !== undefined);
+          return () => _c$15() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "Warnings",
+            get value() {
+              return formatCountShort(status().status_bar.warnings);
+            },
+            get tone() {
+              return status().status_bar.warnings > 0 ? "warn" : "muted";
+            }
+          }) : null;
+        })(), null);
+        _$insert(_el$53, (() => {
+          var _c$16 = _$memo(() => status().status_bar.dead_code !== undefined);
+          return () => _c$16() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "Dead Code",
+            get value() {
+              return formatCountShort(status().status_bar.dead_code);
+            },
+            tone: "muted"
+          }) : null;
+        })(), null);
+        _$insert(_el$53, (() => {
+          var _c$17 = _$memo(() => status().status_bar.unused_exports !== undefined);
+          return () => _c$17() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "Unused Exports",
+            get value() {
+              return formatCountShort(status().status_bar.unused_exports);
+            },
+            tone: "muted"
+          }) : null;
+        })(), null);
+        _$insert(_el$53, (() => {
+          var _c$18 = _$memo(() => status().status_bar.duplicates !== undefined);
+          return () => _c$18() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "Duplicates",
+            get value() {
+              return formatCountShort(status().status_bar.duplicates);
+            },
+            tone: "muted"
+          }) : null;
+        })(), null);
+        _$insert(_el$53, (() => {
+          var _c$19 = _$memo(() => status().status_bar.todos !== undefined);
+          return () => _c$19() ? _$createComponent(R, {
+            get theme() {
+              return t();
+            },
+            label: "TODOs",
+            get value() {
+              return formatCountShort(status().status_bar.todos);
+            },
+            tone: "muted"
+          }) : null;
+        })(), null);
         _$effect(_$p => _$setProp(_el$54, "fg", t().text, _$p));
         return _el$53;
       })() : null;