@cornerstonejs/tools 1.14.2 → 1.14.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/tools",
-  "version": "1.14.2",
+  "version": "1.14.4",
   "description": "Cornerstone3D Tools",
   "main": "dist/umd/index.js",
   "types": "dist/esm/index.d.ts",
@@ -29,7 +29,7 @@
     "webpack:watch": "webpack --mode development --progress --watch  --config ./.webpack/webpack.dev.js"
   },
   "dependencies": {
-    "@cornerstonejs/core": "^1.14.2",
+    "@cornerstonejs/core": "^1.14.4",
     "lodash.clonedeep": "4.5.0",
     "lodash.get": "^4.4.2"
   },
@@ -52,5 +52,5 @@
     "type": "individual",
     "url": "https://ohif.org/donate"
   },
-  "gitHead": "7fb460c47629f6694a78c6bed836b432e1af13a3"
+  "gitHead": "96dc1772a2f77a7626c07e19434b42753e9d4188"
 }

package/src/store/SynchronizerManager/Synchronizer.ts

@@ -205,6 +205,7 @@ class Synchronizer {
     }
 
     this._ignoreFiredEvents = true;
+    const promises = [];
     try {
       for (let i = 0; i < this._targetViewports.length; i++) {
         const targetViewport = this._targetViewports[i];
@@ -214,19 +215,26 @@ class Synchronizer {
         if (targetIsSource) {
           continue;
         }
-
-        this._eventHandler(
-          this,
-          sourceViewport,
-          targetViewport,
-          sourceEvent,
-          this._options
+        promises.push(
+          this._eventHandler(
+            this,
+            sourceViewport,
+            targetViewport,
+            sourceEvent,
+            this._options
+          )
         );
       }
     } catch (ex) {
       console.warn(`Synchronizer, for: ${this._eventName}`, ex);
     } finally {
-      this._ignoreFiredEvents = false;
+      if (promises.length) {
+        Promise.allSettled(promises).then(() => {
+          this._ignoreFiredEvents = false;
+        });
+      } else {
+        this._ignoreFiredEvents = false;
+      }
     }
   }
 

package/src/synchronizers/callbacks/stackImageSyncCallback.ts

@@ -1,4 +1,4 @@
-import { vec3 } from 'gl-matrix';
+import { vec3, mat4 } from 'gl-matrix';
 import {
   getRenderingEngine,
   Types,
@@ -8,28 +8,27 @@ import {
 import { Synchronizer } from '../../store';
 import { jumpToSlice } from '../../utilities';
 import areViewportsCoplanar from './areViewportsCoplanar ';
+
+const getSpatialRegistration = (targetId, sourceId) =>
+  utilities.spatialRegistrationMetadataProvider.get(
+    'spatialRegistrationModule',
+    [targetId, sourceId]
+  );
+
 /**
  * Synchronizer callback to synchronize the source viewport image to the
- * target viewports closest image in its stack. There are two scenarios
+ * target viewports closest image in its stack.
  *
- * 1) viewports are in the same frameOfReferenceUID then we can use the
- * absolute imagePositionPatient for the source viewport's current image
- * and set the target viewport's image to the closest image in its stack
- * (which might have different slice thickness so cannot use slice number)
+ * This synchronizer does a setup (which can already be predefined as required)
+ * to register the target and soruce viewports.  The registration will default
+ * to the identity registration if the same FOR is present in both viewports,
+ * unless the option `useInitialPosition` is set in the target viewport.
  *
- * 2) viewports have different frameOfReferenceUIDs then we look inside the
- * registrationMetadataProvider to check if there is a corresponding matrix
- * for mapping between the source and target viewport if so it is used to
- * and is applied to the imagePositionPatient of the source viewport's to
- * get the imagePositionPatient of the target viewport's closest image in
- * its stack.
- * Note for 2) The consuming apps using Cornerstone3D (OHIF, etc) are responsible
- * to provide such data in the registrationMetadataProvider. This can be done
+ * The consuming apps using Cornerstone3D (OHIF, etc) MAY provide such data in
+ * the registrationMetadataProvider to override the data here. This can be done
  * by various methods 1) Using spatialRegistrationModule inside dicom 2) assuming
  * the user has actually manually scrolled the target viewport to the correct
  * slice before initiating the synchronization 3) using some other method
- * But overall, the consuming app is responsible for providing the data.
- *
  *
  * @param synchronizerInstance - The Instance of the Synchronizer
  * @param sourceViewport - The list of IDs defining the source viewport.
@@ -53,13 +52,16 @@ export default async function stackImageSyncCallback(
     sourceViewport.viewportId
   ) as Types.IStackViewport;
 
+  const options = synchronizerInstance.getOptions(targetViewport.viewportId);
+
+  if (options?.disabled) {
+    return;
+  }
+
   const tViewport = renderingEngine.getViewport(
     targetViewport.viewportId
   ) as Types.IStackViewport;
 
-  const frameOfReferenceUID1 = sViewport.getFrameOfReferenceUID();
-  const frameOfReferenceUID2 = tViewport.getFrameOfReferenceUID();
-
   const imageId1 = sViewport.getCurrentImageId();
   const imagePlaneModule1 = metaData.get('imagePlaneModule', imageId1);
   const sourceImagePositionPatient = imagePlaneModule1.imagePositionPatient;
@@ -70,69 +72,62 @@ export default async function stackImageSyncCallback(
     return;
   }
 
-  if (frameOfReferenceUID1 === frameOfReferenceUID2) {
-    // if frames of references are the same we can use the absolute
-    // imagePositionPatient to find the closest image in the target viewport's stack
-    const closestImageIdIndex = _getClosestImageIdIndex(
-      sourceImagePositionPatient,
-      targetImageIds
-    );
+  // if the frame of reference is different we need to use the registrationMetadataProvider
+  // and add that to the imagePositionPatient of the source viewport to get the
+  // imagePositionPatient of the target viewport's closest image in its stack
+  let registrationMatrixMat4 = getSpatialRegistration(
+    targetViewport.viewportId,
+    sourceViewport.viewportId
+  );
 
+  if (!registrationMatrixMat4) {
+    const frameOfReferenceUID1 = sViewport.getFrameOfReferenceUID();
+    const frameOfReferenceUID2 = tViewport.getFrameOfReferenceUID();
     if (
-      closestImageIdIndex.index !== -1 &&
-      tViewport.getCurrentImageIdIndex() !== closestImageIdIndex.index
+      frameOfReferenceUID1 === frameOfReferenceUID2 &&
+      options.useInitialPosition !== false
     ) {
-      // await tViewport.setImageIdIndex(closestImageIdIndex.index);
-      await jumpToSlice(tViewport.element, {
-        imageIndex: closestImageIdIndex.index,
-      });
-
-      return;
-    }
-  } else {
-    // if the frame of reference is different we need to use the registrationMetadataProvider
-    // and add that to the imagePositionPatient of the source viewport to get the
-    // imagePositionPatient of the target viewport's closest image in its stack
-    const registrationMatrixMat4 =
-      utilities.spatialRegistrationMetadataProvider.get(
-        'spatialRegistrationModule',
-        [targetViewport.viewportId, sourceViewport.viewportId]
+      registrationMatrixMat4 = mat4.identity(mat4.create());
+    } else {
+      utilities.calculateViewportsSpatialRegistration(sViewport, tViewport);
+      registrationMatrixMat4 = getSpatialRegistration(
+        targetViewport.viewportId,
+        sourceViewport.viewportId
       );
-
+    }
     if (!registrationMatrixMat4) {
-      throw new Error(
-        `No registration matrix found for sourceViewport: ${sourceViewport.viewportId} and targetViewport: ${targetViewport.viewportId}, viewports with different frameOfReferenceUIDs must have a registration matrix in the registrationMetadataProvider. Use calculateViewportsRegistrationMatrix to calculate the matrix.`
-      );
+      return;
     }
+  }
 
-    // apply the registration matrix to the source viewport's imagePositionPatient
-    // to get the target viewport's imagePositionPatient
-    const targetImagePositionPatientWithRegistrationMatrix = vec3.transformMat4(
-      vec3.create(),
-      sourceImagePositionPatient,
-      registrationMatrixMat4
-    );
+  // apply the registration matrix to the source viewport's imagePositionPatient
+  // to get the target viewport's imagePositionPatient
+  const targetImagePositionPatientWithRegistrationMatrix = vec3.transformMat4(
+    vec3.create(),
+    sourceImagePositionPatient,
+    registrationMatrixMat4
+  );
 
-    // find the closest image in the target viewport's stack to the
-    // targetImagePositionPatientWithRegistrationMatrix
-    const closestImageIdIndex2 = _getClosestImageIdIndex(
-      targetImagePositionPatientWithRegistrationMatrix,
-      targetImageIds
-    );
+  // find the closest image in the target viewport's stack to the
+  // targetImagePositionPatientWithRegistrationMatrix
+  const closestImageIdIndex2 = _getClosestImageIdIndex(
+    targetImagePositionPatientWithRegistrationMatrix,
+    targetImageIds
+  );
 
-    if (
-      closestImageIdIndex2.index !== -1 &&
-      tViewport.getCurrentImageIdIndex() !== closestImageIdIndex2.index
-    ) {
-      await jumpToSlice(tViewport.element, {
-        imageIndex: closestImageIdIndex2.index,
-      });
-    }
+  if (
+    closestImageIdIndex2.index !== -1 &&
+    tViewport.getCurrentImageIdIndex() !== closestImageIdIndex2.index
+  ) {
+    await jumpToSlice(tViewport.element, {
+      imageIndex: closestImageIdIndex2.index,
+    });
   }
 }
 
 function _getClosestImageIdIndex(targetPoint, imageIds) {
   // todo: this does not assume orientation yet, but that can be added later
+  // todo: handle multiframe images
   return imageIds.reduce(
     (closestImageIdIndex, imageId, index) => {
       const { imagePositionPatient } = metaData.get(

package/src/synchronizers/callbacks/voiSyncCallback.ts

@@ -39,7 +39,7 @@ export default function voiSyncCallback(
     voiRange: range,
   };
 
-  if (options.syncInvertState && invertStateChanged) {
+  if (options?.syncInvertState && invertStateChanged) {
     tProperties.invert = invert;
   }
 

package/src/tools/annotation/AngleTool.ts

@@ -808,7 +808,7 @@ class AngleTool extends AnnotationTool {
       );
 
       cachedStats[targetId] = {
-        angle,
+        angle: isNaN(angle) ? 'Incomplete Angle' : angle,
       };
     }