@cornerstonejs/core 1.66.5 → 1.66.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/core",
-  "version": "1.66.5",
+  "version": "1.66.7",
   "description": "",
   "main": "src/index.ts",
   "types": "dist/types/index.d.ts",
@@ -47,5 +47,5 @@
     "type": "individual",
     "url": "https://ohif.org/donate"
   },
-  "gitHead": "23c01d5231da3a5283a0d042e4eb5abac3aed44e"
+  "gitHead": "7e318e04ab84565f2365252b6dc5a78ca1f0bb52"
 }

package/src/RenderingEngine/Viewport.ts

@@ -1424,6 +1424,7 @@ class Viewport implements IViewport {
     const { viewPlaneNormal } = viewRef;
     const camera = this.getCamera();
     if (
+      viewPlaneNormal &&
       !isEqual(viewPlaneNormal, camera.viewPlaneNormal) &&
       !isEqual(
         vec3.negate(camera.viewPlaneNormal, camera.viewPlaneNormal),

package/src/utilities/getTargetVolumeAndSpacingInNormalDir.ts

@@ -3,6 +3,7 @@ import { EPSILON } from '../constants';
 import { ICamera, IImageVolume, IVolumeViewport, Point3 } from '../types';
 import getSpacingInNormalDirection from './getSpacingInNormalDirection';
 import { getVolumeLoaderSchemes } from '../loaders/volumeLoader';
+import { getVolumeId } from './getVolumeId';
 
 // One EPSILON part larger multiplier
 const EPSILON_PART = 1 + EPSILON;
@@ -20,15 +21,14 @@ const isPrimaryVolume = (volume): boolean =>
 
 /**
  * Given a volume viewport and camera, find the target volume.
- * The imageVolume is retrieved from cache for the specified targetVolumeId or
+ * The imageVolume is retrieved from cache for the specified targetId or
  * in case it is not provided, it chooses the volumeId on the viewport (there
  * might be more than one in case of fusion) that has the finest resolution in the
  * direction of view (normal).
  *
  * @param viewport - volume viewport
  * @param camera - current camera
- * @param targetVolumeId - If a target volumeId is given that volume
- * is forced to be used.
+ * @param targetId - If a targetId is forced to be used.
  * @param useSlabThickness - If true, the number of steps will be calculated
  * based on the slab thickness instead of the spacing in the normal direction
  * @returns An object containing the imageVolume and spacingInNormalDirection.
@@ -37,7 +37,7 @@ const isPrimaryVolume = (volume): boolean =>
 export default function getTargetVolumeAndSpacingInNormalDir(
   viewport: IVolumeViewport,
   camera: ICamera,
-  targetVolumeId?: string,
+  targetId?: string,
   useSlabThickness = false
 ): {
   imageVolume: IImageVolume;
@@ -65,9 +65,10 @@ export default function getTargetVolumeAndSpacingInNormalDir(
     .filter((iv) => !!iv);
 
   // If a volumeId is defined, set that volume as the target
-  if (targetVolumeId) {
+  if (targetId) {
+    const targetVolumeId = getVolumeId(targetId);
     const imageVolumeIndex = imageVolumes.findIndex((iv) =>
-      iv.volumeId.includes(targetVolumeId)
+      targetVolumeId.includes(iv.volumeId)
     );
 
     const imageVolume = imageVolumes[imageVolumeIndex];

package/src/utilities/getVolumeId.ts

@@ -0,0 +1,16 @@
+/**
+ * Retrieves the volume ID from a target ID. Target Id is not only
+ * volumeId but might include other information, but it starts with volumeId.
+ *
+ * @param targetId - The target ID from which to extract the volume ID.
+ * @returns The volume ID extracted from the target ID.
+ */
+export const getVolumeId = (targetId: string) => {
+  const prefix = 'volumeId:';
+  const str = targetId.includes(prefix)
+    ? targetId.substring(prefix.length)
+    : targetId;
+
+  const index = str.indexOf('?');
+  return index === -1 ? str : str.substring(0, index);
+};

package/src/utilities/index.ts

@@ -70,6 +70,7 @@ import roundNumber, { roundToPrecision } from './roundNumber';
 import convertToGrayscale from './convertToGrayscale';
 import getViewportImageIds from './getViewportImageIds';
 import { getRandomSampleFromArray } from './getRandomSampleFromArray';
+import { getVolumeId } from './getVolumeId';
 
 // name spaces
 import * as planar from './planar';
@@ -158,4 +159,5 @@ export {
   roundToPrecision,
   getViewportImageIds,
   getRandomSampleFromArray,
+  getVolumeId,
 };