@cornerstonejs/core 1.63.1 → 1.63.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/core",
-  "version": "1.63.1",
+  "version": "1.63.3",
   "description": "",
   "main": "src/index.ts",
   "types": "dist/types/index.d.ts",
@@ -47,5 +47,5 @@
     "type": "individual",
     "url": "https://ohif.org/donate"
   },
-  "gitHead": "e4fcacba07b254d69218c70e5e549a696115f008"
+  "gitHead": "027b911678b62776ca4407fe900a47e1f5045e14"
 }

package/src/RenderingEngine/CanvasActor/index.ts

@@ -54,7 +54,7 @@ export default class CanvasActor implements ICanvasActor {
       const baseOffset = (y * width) << 2;
       let indicesToDelete;
       for (const run of row) {
-        const { start: start, end, value: segmentIndex } = run;
+        const { start, end, value: segmentIndex } = run;
         if (segmentIndex === 0) {
           indicesToDelete ||= [];
           indicesToDelete.push(row.indexOf(run));
@@ -85,10 +85,10 @@ export default class CanvasActor implements ICanvasActor {
       imageData,
       0,
       0,
-      dirtyX,
-      dirtyY,
-      dirtyWidth,
-      dirtyHeight
+      dirtyX - 1,
+      dirtyY - 1,
+      dirtyWidth + 2,
+      dirtyHeight + 2
     );
     context.drawImage(
       canvas,

package/src/RenderingEngine/VideoViewport.ts

@@ -59,6 +59,13 @@ class VideoViewport extends Viewport implements IVideoViewport {
   private playbackRate = 1;
   private scalarData: CanvasScalarData;
 
+  /**
+   * This is used to pause initially so that we get at least one render to allow
+   * navigating frames.  Otherwise the viewport is blank initially until the user
+   * hits play manually.
+   */
+  private initialRender: () => void;
+
   /**
    * The range is the set of frames to play
    */
@@ -119,6 +126,7 @@ class VideoViewport extends Viewport implements IVideoViewport {
     this.videoElement = document.createElement('video');
     this.videoElement.muted = this.mute;
     this.videoElement.loop = this.loop;
+    this.videoElement.autoplay = true;
     this.videoElement.crossOrigin = 'anonymous';
 
     this.addEventListeners();
@@ -235,16 +243,22 @@ class VideoViewport extends Viewport implements IVideoViewport {
       this.numberOfFrames = numberOfFrames;
       // 1 based range setting
       this.setFrameRange([1, numberOfFrames]);
-      this.play();
+      // The initial render allows us to set the frame position - rendering needs
+      // to start already playing
+      this.initialRender = () => {
+        this.initialRender = null;
+        this.pause();
+        this.setFrameNumber(frameNumber || 1);
+      };
+
       // This is ugly, but without it, the video often fails to render initially
       // so having a play, followed by a pause fixes things.
-      // 100 ms is a tested value that seems to work to prevent exceptions
+      // 25 ms is a tested value that seems to work to prevent exceptions
       return new Promise((resolve) => {
         window.setTimeout(() => {
-          this.pause();
           this.setFrameNumber(frameNumber || 1);
           resolve(this);
-        }, 100);
+        }, 25);
       });
     });
   }
@@ -646,6 +660,7 @@ class VideoViewport extends Viewport implements IVideoViewport {
       ];
     }
 
+    this.canvasContext.fillStyle = 'rgba(0,0,0,1)';
     this.canvasContext.fillRect(0, 0, this.canvas.width, this.canvas.height);
 
     if (this.isPlaying === false) {
@@ -1045,6 +1060,8 @@ class VideoViewport extends Viewport implements IVideoViewport {
       duration: this.videoElement.duration,
     });
 
+    this.initialRender?.();
+
     const frame = this.getFrameNumber();
     if (this.isPlaying) {
       if (frame < this.frameRange[0]) {