@cornerstonejs/core 1.35.2 → 1.36.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/core",
-  "version": "1.35.2",
+  "version": "1.36.0",
   "description": "",
   "main": "src/index.ts",
   "types": "dist/types/index.d.ts",
@@ -47,5 +47,5 @@
     "type": "individual",
     "url": "https://ohif.org/donate"
   },
-  "gitHead": "323d50dd5e96fd476514db0cd2b62d526d480de0"
+  "gitHead": "616ef6915f122cab6d1e27e2d02ebc95484a4e37"
 }

package/src/requestPool/requestPoolManager.ts

@@ -239,7 +239,7 @@ class RequestPoolManager {
         this.numRequests[type]++;
         this.awake = true;
 
-        requestDetails.requestFn().finally(() => {
+        requestDetails.requestFn()?.finally(() => {
           this.numRequests[type]--;
           this.startAgain();
         });

package/src/types/Color.ts

@@ -0,0 +1,10 @@
+/**
+ * Four elements RGBA as 0-255
+ */
+export type Color = [number, number, number, number];
+
+/**
+ * Color LUT Array - Array of colors
+ * [[0,0,0,0], [200,200,200,200], ....]
+ */
+export type ColorLUT = Array<Color>;

package/src/types/index.ts

@@ -98,6 +98,7 @@ export type {
   IImagesLoader,
 } from './IRetrieveConfiguration';
 import type { ImageLoadListener } from './ImageLoadListener';
+import type { Color, ColorLUT } from './Color';
 import type VideoViewportProperties from './VideoViewportProperties';
 import type IVideoViewport from './IVideoViewport';
 import type {
@@ -211,4 +212,6 @@ export type {
   // video
   InternalVideoCamera,
   VideoViewportInput,
+  Color,
+  ColorLUT,
 };

package/src/utilities/deepMerge.ts

@@ -31,7 +31,12 @@ const defaultArrayMerge = (target, source, optionsArgument) => {
     } else if (isMergeableObject(e)) {
       destination[i] = deepMerge(target[i], e, optionsArgument);
     } else if (target.indexOf(e) === -1) {
-      destination.push(cloneIfNecessary(e, optionsArgument));
+      // IMPORTANT: WE SHOULD NOT PUSH NEW ELEMENTS TO THE ARRAY
+      // INSTEAD WE SHOULD REPLACE THE ELEMENT, this will result
+      // in unexpected behaviors if the initial tool parameters
+      // are desired to override the default tool parameters that are
+      // arrays
+      destination[i] = cloneIfNecessary(e, optionsArgument);
     }
   });