@cornerstonejs/core 1.27.2 → 1.27.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@cornerstonejs/core",
-  "version": "1.27.2",
+  "version": "1.27.3",
   "description": "",
   "main": "src/index.ts",
   "types": "dist/esm/index.d.ts",
@@ -46,5 +46,5 @@
     "type": "individual",
     "url": "https://ohif.org/donate"
   },
-  "gitHead": "19d7d73eca5190a6bd81429a5a1858c500946d61"
+  "gitHead": "217b37f8e2933ee9368d07130152c82ff6e9add2"
 }

package/src/RenderingEngine/BaseVolumeViewport.ts

@@ -67,7 +67,7 @@ import { getTransferFunctionNodes } from '../utilities/transferFunctionUtils';
  */
 abstract class BaseVolumeViewport extends Viewport implements IVolumeViewport {
   useCPURendering = false;
-  use16BitTexture = false;
+  useNativeDataType = false;
   private _FrameOfReferenceUID: string;
 
   protected initialTransferFunctionNodes: any;
@@ -84,7 +84,7 @@ abstract class BaseVolumeViewport extends Viewport implements IVolumeViewport {
     super(props);
 
     this.useCPURendering = getShouldUseCPURendering();
-    this.use16BitTexture = this._shouldUseNativeDataType();
+    this.useNativeDataType = this._shouldUseNativeDataType();
 
     if (this.useCPURendering) {
       throw new Error(
@@ -753,7 +753,7 @@ abstract class BaseVolumeViewport extends Viewport implements IVolumeViewport {
         this.element,
         this.id,
         suppressEvents,
-        this.use16BitTexture
+        this.useNativeDataType
       );
 
       // We cannot use only volumeId since then we cannot have for instance more
@@ -819,7 +819,7 @@ abstract class BaseVolumeViewport extends Viewport implements IVolumeViewport {
         this.element,
         this.id,
         suppressEvents,
-        this.use16BitTexture
+        this.useNativeDataType
       );
 
       if (visibility === false) {

package/src/RenderingEngine/Viewport.ts

@@ -1091,22 +1091,33 @@ class Viewport implements IViewport {
 
     // update clipping range only if focal point changed of a new actor is added
     const prevFocalPoint = previousCamera.focalPoint;
+    const prevViewUp = previousCamera.viewUp;
 
-    if (prevFocalPoint && focalPoint) {
+    if ((prevFocalPoint && focalPoint) || (prevViewUp && viewUp)) {
       const currentViewPlaneNormal = <Point3>vtkCamera.getViewPlaneNormal();
+      const currentViewUp = <Point3>vtkCamera.getViewUp();
 
-      const deltaCamera = <Point3>[
-        focalPoint[0] - prevFocalPoint[0],
-        focalPoint[1] - prevFocalPoint[1],
-        focalPoint[2] - prevFocalPoint[2],
-      ];
+      let cameraModifiedOutOfPlane = false;
+      let viewUpHasChanged = false;
+
+      if (focalPoint) {
+        const deltaCamera = <Point3>[
+          focalPoint[0] - prevFocalPoint[0],
+          focalPoint[1] - prevFocalPoint[1],
+          focalPoint[2] - prevFocalPoint[2],
+        ];
 
-      const cameraModifiedOutOfPlane =
-        Math.abs(vtkMath.dot(deltaCamera, currentViewPlaneNormal)) > 0;
+        cameraModifiedOutOfPlane =
+          Math.abs(vtkMath.dot(deltaCamera, currentViewPlaneNormal)) > 0;
+      }
+
+      if (viewUp) {
+        viewUpHasChanged = isEqual(currentViewUp, prevViewUp);
+      }
 
       // only modify the clipping planes if the camera is modified out of plane
       // or a new actor is added and we need to update the clipping planes
-      if (cameraModifiedOutOfPlane || this.newActorAdded) {
+      if (cameraModifiedOutOfPlane || viewUpHasChanged || this.newActorAdded) {
         const actorEntry = this.getDefaultActor();
         if (!actorEntry?.actor) {
           return;

package/src/RenderingEngine/helpers/createVolumeActor.ts

@@ -34,7 +34,7 @@ async function createVolumeActor(
   element: HTMLDivElement,
   viewportId: string,
   suppressEvents = false,
-  use16BitTexture = false
+  useNativeDataType = false
 ): Promise<VolumeActor> {
   const { volumeId, callback, blendMode } = props;
 
@@ -71,7 +71,7 @@ async function createVolumeActor(
   // types of volumes which might not be composed of imageIds would be e.g., nrrd, nifti
   // format volumes
   if (imageVolume.imageIds) {
-    await setDefaultVolumeVOI(volumeActor, imageVolume, use16BitTexture);
+    await setDefaultVolumeVOI(volumeActor, imageVolume, useNativeDataType);
   }
 
   if (callback) {

package/src/RenderingEngine/helpers/setDefaultVolumeVOI.ts

@@ -24,12 +24,12 @@ const REQUEST_TYPE = RequestType.Prefetch;
 async function setDefaultVolumeVOI(
   volumeActor: VolumeActor,
   imageVolume: IImageVolume,
-  use16BitTexture: boolean
+  useNativeDataType: boolean
 ): Promise<void> {
   let voi = getVOIFromMetadata(imageVolume);
 
   if (!voi) {
-    voi = await getVOIFromMinMax(imageVolume, use16BitTexture);
+    voi = await getVOIFromMinMax(imageVolume, useNativeDataType);
   }
 
   if (!voi || voi.lower === undefined || voi.upper === undefined) {
@@ -117,7 +117,7 @@ function getVOIFromMetadata(imageVolume: IImageVolume): VOIRange {
  */
 async function getVOIFromMinMax(
   imageVolume: IImageVolume,
-  use16BitTexture: boolean
+  useNativeDataType: boolean
 ): Promise<VOIRange> {
   const { imageIds } = imageVolume;
   const scalarData = imageVolume.getScalarData();
@@ -157,7 +157,7 @@ async function getVOIFromMinMax(
 
   const options = {
     targetBuffer: {
-      type: use16BitTexture ? undefined : 'Float32Array',
+      type: useNativeDataType ? undefined : 'Float32Array',
     },
     priority: PRIORITY,
     requestType: REQUEST_TYPE,